summaryrefslogtreecommitdiffstats
path: root/fpicker
Commit message (Collapse)AuthorAgeFilesLines
* new loplugin:shouldreturnboolNoel Grandin2018-06-112-6/+6
| | | | | | | | | | | | look for methods returning only 1 and/or 0, which (most of the time) should be returning bool. Off by default, because some of this is a matter of taste Change-Id: Ib17782e629888255196e89d4a178618a9612a0de Reviewed-on: https://gerrit.libreoffice.org/54379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#42949 remove unused compheler includes ..Jochen Nitschke2018-06-052-3/+0
| | | | | | | | | and fix the fallout Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e Reviewed-on: https://gerrit.libreoffice.org/54882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* A few assorted improvements to translatable strings before freezeAdolfo Jayme Barrientos2018-06-021-2/+2
| | | | Change-Id: I30d315e0c82afc112cdb4fef17339c1b78b5643a
* Bitmap->BitmapEx in FixedBitmapNoel Grandin2018-05-301-3/+3
| | | | | | | Change-Id: I0e409beb0d046d927b6a0c1987abec42df76727d Reviewed-on: https://gerrit.libreoffice.org/55032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedfields in formula..registryNoel Grandin2018-05-172-3/+2
| | | | | | | Change-Id: I031654d8bb4f1788d364ef4f8d3bf7a05fadb148 Reviewed-on: https://gerrit.libreoffice.org/54454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* weld QueryFolderNameDialogCaolán McNamara2018-05-174-60/+41
| | | | | | | | Change-Id: I73ff0a15010d00a353e498755755177c8e7df607 Reviewed-on: https://gerrit.libreoffice.org/54442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Fix typosAndrea Gelmini2018-05-051-1/+1
| | | | | | | Change-Id: I92078fdece135754744d85424956dbb071f3899e Reviewed-on: https://gerrit.libreoffice.org/53638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* fix -Werror=shadowNoel Grandin2018-04-251-2/+2
| | | | | | | | | after commit bbf134a2b77909706492cbc41952210f89c0df71 Date: Tue Apr 24 13:36:34 2018 +0200 SvTabListBox::SetTabs, pass count explicit Change-Id: Iea41aa1c4708b6486ba9a306d3b9d02846e23d7a
* SvTabListBox::SetTabs, pass count explicitNoel Grandin2018-04-251-2/+2
| | | | | | passing count as first element in array, dodgy. Change-Id: I49905b554b3b4d6cc3fa419a36389cd2e5ded463
* tdf#42949 Remove unnecessary localization headers of svtoolsGabor Kelemen2018-04-202-2/+0
| | | | | | | | | | Found by searching for the header names and the localization function: git grep -l -e \<svtools/svtresid.hxx\> -e \<svtools/strings.hrc\> | xargs grep -c SvtResId | grep :0$ | grep -v /pch Change-Id: I861fed778660412dc73616da29503538b3fe9ccb Reviewed-on: https://gerrit.libreoffice.org/53136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typosAndrea Gelmini2018-04-161-1/+1
| | | | | | | Change-Id: Ife28cd9399cfcb375bad764dac7424eda50d430d Reviewed-on: https://gerrit.libreoffice.org/52198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* remove some unused comphelper includesJochen Nitschke2018-04-153-3/+1
| | | | | | | | | and fix the fallout Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359 Reviewed-on: https://gerrit.libreoffice.org/52894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* look for check buttons without underlinesCaolán McNamara2018-04-141-0/+5
| | | | | | | | Change-Id: Ia9963190cf3dccbfa82951a3f2c0e29e00171429 Reviewed-on: https://gerrit.libreoffice.org/52847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#42949 Remove unnecessary localization headers from fpickerGabor Kelemen2018-04-124-4/+2
| | | | | | | | | | Found by searching for the header names and the localization function: git grep -l -e \<fpsofficeResMgr.hxx\> -e \<strings.hrc\> fpicker/ | xargs grep -c FpsResId | grep :0$ | grep -v /pch Change-Id: I77361692343a731ca344744ae2ab440caf1d66e9 Reviewed-on: https://gerrit.libreoffice.org/52596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* weld PlaceEditDialogCaolán McNamara2018-04-113-17/+17
| | | | | | | | Change-Id: I971784afc8c2ba6ebd7809c20ef8d730aafbfe31 Reviewed-on: https://gerrit.libreoffice.org/52727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* drop the spurious invisible_char[_set] propertiesCaolán McNamara2018-04-021-1/+0
| | | | | | | | Change-Id: I8264a4f6035fd19c7a892902c41127615eaf6dd3 Reviewed-on: https://gerrit.libreoffice.org/52265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* fix some openoffice bugzilla linksdennisroczek2018-04-011-1/+1
| | | | | | | | | | | * remove redirects * use https links * replace old attchment links with working ones Change-Id: Ic9a154f46e142138f0adea7d7b8be3b6cfe8af18 Reviewed-on: https://gerrit.libreoffice.org/52224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove unused processfactory.hxx includesJochen Nitschke2018-04-012-2/+0
| | | | | | | | | and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* tdf#116615 WIN process messages using RescheduleJan-Marek Glogowski2018-03-281-78/+44
| | | | | | | | | | | | | | | | | | | | | Since LO message processing loop is a little more complex then PeekMessageW and DispatchMessageW, use Reschedule( true ) to process all pending events. Processing all event is important, because MsgWaitForMultipleObjects will just trigger for new messages since its call and will ignore already pending messages. Which leaves the IsMTA() call. I know of the COM STA / MTA stuff, but I don't understand how this might be related here. The call to SHBrowseForFolderW definitly block, but we already use multiple threads, so I don't understand, how this has worked before... Change-Id: Id348f26155571b3ddb31233d0bcd2c4fd2003819 Reviewed-on: https://gerrit.libreoffice.org/51940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
* drop unnecessary includesCaolán McNamara2018-03-204-4/+0
| | | | | | | | Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Use for-range loops in fpickerJulien Nabet2018-03-174-98/+80
| | | | | | | Change-Id: I9bca308889c6e15ce9fcbc82f5c6c5e126b29022 Reviewed-on: https://gerrit.libreoffice.org/51460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* tdf#116147 guard triggerRequestThreadAwareJan-Marek Glogowski2018-03-061-0/+1
| | | | | | | | | | | | | | | | | It didn't help putting a SolarMutexGuard into VCLXButton::ProcessWindowEvent, which was my first suspect in my own backtrace, as VCLXWindowImpl::OnProcessCallbacks releases it to process the callbacks. Since the gtk backend also guards all calls into the file picker code, I think it's save to do the same for the Windows picker. I have no idea where it is actually released again... Change-Id: I3ab3b47904dc3d0033739a82f7afd91e6e80403d Reviewed-on: https://gerrit.libreoffice.org/50783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
* Resolves: tdf#116188 set min version on all .ui files to 3.18Caolán McNamara2018-03-052-2/+2
| | | | | | | | | | which is already the min for the runtime Change-Id: Ifebe099f1f94a36f65a31989689400327a823dcd Reviewed-on: https://gerrit.libreoffice.org/50776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Translate German comments and debug stringsJohnny_M2018-02-281-1/+1
| | | | | | | Change-Id: Ie2da785cb674e21f042caa5e6d461e3489036003 Reviewed-on: https://gerrit.libreoffice.org/50467 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* remove unused vclunohelper.hxx includesJochen Nitschke2018-02-271-1/+0
| | | | | | | Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22 Reviewed-on: https://gerrit.libreoffice.org/50393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* replace Color(COL_*) with COL_*Noel Grandin2018-02-271-1/+1
| | | | | | | | | | | | | | | using git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)" | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g" and then some manual fixup where the resulting expression no longer compiled Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4 Reviewed-on: https://gerrit.libreoffice.org/50372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert all help responses to gtk's -11Caolán McNamara2018-02-251-2/+2
| | | | | | | | | | | | | | and ok responses to gtk's -5 and cancel responses to gtk's -6 and close responses to gtk's -7 and yes responses to gtk's -8 and no responses to gtk's -9 Change-Id: Ia1a261a3a711ed9f5d8c0b0c639897c3064bb08c Reviewed-on: https://gerrit.libreoffice.org/50206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* weld native message dialogsCaolán McNamara2018-02-222-11/+16
| | | | | | | | | | | | | | | | just the straight-forward MessageDialog cases first a) remove border_width from message dialog .ui so as to take the default border width b) retain 12 as default message dialog border for vcl widget case c) remove layour_style from message dialog button boxes so as to take the default mode (a no-op for vcl widget case) d) use gtk response ids (vcl builder will converts to vcl ones) Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154 Reviewed-on: https://gerrit.libreoffice.org/50143 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:useuniqueptr in filepickerNoel Grandin2018-02-195-23/+15
| | | | | | | Change-Id: I367bea33bdb9ea3132d3ed079a16b516498b4fcc Reviewed-on: https://gerrit.libreoffice.org/49947 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Revert "loplugin:changetoolsgen in filter..framework" and reapply pluginNoel Grandin2018-02-163-3/+3
| | | | | | | | | | | | | because I (a) forgot to insert parentheses which changes the meaning of some expressions and (b) I now use the AdjustFoo calls when changing unary operations, which reads much better This reverts commit bf8a6cacd06d7c1961b5db8cc79ee4bbdb342e43. Change-Id: I4b5a9bf0c38ee1b57af91e6b7f184f1e8807f6f7 Reviewed-on: https://gerrit.libreoffice.org/49843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:changetoolsgen in filter..frameworkNoel Grandin2018-02-143-11/+11
| | | | | | | Change-Id: I622da8a0c096c74efd97326451c4576b230f0483 Reviewed-on: https://gerrit.libreoffice.org/49701 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#86739 Option to set image anchor type in image insert dialogSamuel Mehrbrodt2018-02-0814-1/+76
| | | | | | | | | | | | | | | This adds the selectbox to (hopefully) all filepickers: - LO native - GTK/GTK3 - KDE4 - KDE5 - Windows - macOS Change-Id: I01bd42b1ca18e0f691b879647a6cb1b62177d3ce Reviewed-on: https://gerrit.libreoffice.org/49311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* fpicker: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski2018-02-018-50/+1
| | | | | | | Change-Id: Ifb05da6cf6d2084e80372440118883278738ea87 Reviewed-on: https://gerrit.libreoffice.org/48979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* fpicker: Respect the PrepareExecute() resultPranav Kant2018-01-251-1/+2
| | | | Change-Id: I351eaa76da01656638de5f04eb376e5b16102b4a
* lokdialog: Disable filepicker for LOKPranav Kant2018-01-251-0/+4
| | | | | | We don't want people to browser their jails in the filepicker dialog. Change-Id: I2fdd3d948cc1f193098492d1a310424ac2d49317
* More loplugin:cstylecast on WindowsStephan Bergmann2018-01-233-6/+6
| | | | | | | | | | | | Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* More loplugin:cstylecast on macOSStephan Bergmann2018-01-207-22/+22
| | | | | | | | | | | | Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Iff4877e8a42804c952c48c13332caf0a83c92870 Reviewed-on: https://gerrit.libreoffice.org/48216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:redundantcast (after loplugin:cstylecast, macOS)Stephan Bergmann2018-01-191-1/+1
| | | | Change-Id: I349eb6c3c2408729799d35316ab75bb05920021f
* Handle focus_on_click glade property for buttonsMaxim Monastirsky2018-01-172-1/+1
| | | | | | | | | It maps to our WB_NOPOINTERFOCUS. Change-Id: Ib00e696801b72de2c931e282ed8d50c972fa59fb Reviewed-on: https://gerrit.libreoffice.org/47990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
* Fix typosAndrea Gelmini2018-01-161-1/+1
| | | | | | | Change-Id: I078626eaa3155cc429320cc8c1532003b382b22a Reviewed-on: https://gerrit.libreoffice.org/47855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:unoany (clang-cl)Stephan Bergmann2018-01-161-1/+1
| | | | | | | Change-Id: If7674b8a75668a5774abe43d28b48b63da2c9296 Reviewed-on: https://gerrit.libreoffice.org/47928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix typosAndrea Gelmini2018-01-141-1/+1
| | | | | | | Change-Id: I2b4988e1d81fe60f7699362480cd739d2620c053 Reviewed-on: https://gerrit.libreoffice.org/47856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* More loplugin:cstylecast: fpickerStephan Bergmann2018-01-124-8/+8
| | | | | | | | auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I41dc5653f0da71b0efadc9ce09b22231d3321827
* loplugin:unnecessaryparen (clang-cl)Stephan Bergmann2018-01-091-1/+1
| | | | | | | Change-Id: I867dd6f70d83f9e57ff3b9b5c73e18b6860e9026 Reviewed-on: https://gerrit.libreoffice.org/47671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#113070: Fix master document issueAhmed GHANMI2018-01-072-5/+18
| | | | | | | | | | | | | | | In fpicker module we don't treat template listbox "LISTBOX_TEMPLATE" element selected in "impl_sta_GetControlValue" function. In order to fix this issue we added a sequence "gitems" which save items added in template listbox while creating the ODM creation graphic interface. Also we added a section in impl_sta_GetControlValue function to get user selection from template listbox and the get the item from gitems and we return the value. Change-Id: Ibbf0a134ade8c59d8e6f333236070954da067305 Reviewed-on: https://gerrit.libreoffice.org/45589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:passstuffbyref improved return in lotuswordproNoel Grandin2017-12-311-1/+1
| | | | | | | Change-Id: I2e4103bb496ed3d0677d036e2f8cec76d001d682 Reviewed-on: https://gerrit.libreoffice.org/47222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* lokdialog: Allow switching language of some of the ResMgr's.Jan Holesovsky2017-12-221-2/+1
| | | | | | | | | | | | | | This way, it is possible to have all the strings translated in dialogs even when different users use different languages. [It was already possible to have different languages previously, but not everything in the dialog has switched - like the buttons at the bottom of the dialogs etc.] Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9 Reviewed-on: https://gerrit.libreoffice.org/46417 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46979 Tested-by: Jenkins <ci@libreoffice.org>
* loplugin:unusedindexMike Kaganski2017-12-201-14/+6
| | | | | | | Change-Id: I30a49d9d9f9badadab3afcbaa6cee011b7af4bd0 Reviewed-on: https://gerrit.libreoffice.org/46830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* inline use-once typedefsNoel Grandin2017-12-191-2/+1
| | | | | | | Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:salcall (clang-cl)Stephan Bergmann2017-12-155-7/+7
| | | | | | | Change-Id: Idda630320bb5e02e1ea675b3b3786c9ec6ac166b Reviewed-on: https://gerrit.libreoffice.org/46504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-09-04 15:46:12 +0000