summaryrefslogtreecommitdiffstats
path: root/fpicker
Commit message (Collapse)AuthorAgeFilesLines
* The macOS SDK 10.15 has a tighter declaration of objc_msgSend()Tor Lillqvist2019-10-301-1/+1
| | | | | | | | | Change-Id: I51734b92965a9fa1f06aa18017d39b4b0d532456 (cherry picked from commit 4d3628ca769ce07c93e8c4629075eeb7c8dc317e) Reviewed-on: https://gerrit.libreoffice.org/81740 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
* Use hasElements to check Sequence emptiness in [e-i]*Arkadiy Illarionov2019-05-313-7/+7
| | | | | | | | | Similar to clang-tidy readability-container-size-empty Change-Id: I79e31919db8f4132216f09a7868d18835eeb154b Reviewed-on: https://gerrit.libreoffice.org/71795 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* an uno -> a unoCaolán McNamara2019-05-101-1/+1
| | | | | | | | Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* an is used before a vowel soundCaolán McNamara2019-05-102-3/+3
| | | | | | | | | | not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Replace lists by vectors in fpicker/officeJulien Nabet2019-05-103-5/+5
| | | | | | | Change-Id: Id8d84ddebdb909583bfb136747374c0500c080e5 Reviewed-on: https://gerrit.libreoffice.org/72067 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:sequentialassign in filter..fpickerNoel Grandin2019-04-131-4/+2
| | | | | | | Change-Id: I4ba0e1e982897bd570612f6cda8ba1e6a9fa5dbd Reviewed-on: https://gerrit.libreoffice.org/70700 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more std::make_uniqueNoel Grandin2019-04-131-1/+1
| | | | | | | Change-Id: I7d85cbc9105c5e0c4a8d9a69c4ac9d6dfc07eabd Reviewed-on: https://gerrit.libreoffice.org/70663 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typoAndrea Gelmini2019-04-091-1/+1
| | | | | | | Change-Id: Ibae0cf4ef91c8b830447c999306a60dea3334ad6 Reviewed-on: https://gerrit.libreoffice.org/70440 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
* Don't use resettable/clearable guard where plain guard is enoughMike Kaganski2019-04-072-32/+34
| | | | | | | | | | | Also use scope where possible. This allows to limit guard scope at language level; visualises the scope clearly; and helps avoiding errors like fixed in commit 61e4437c857854b331fa01da6f39b2b3b58a800b. Change-Id: Ifeca96e2df8e8a0897770d9546b2536806275f41 Reviewed-on: https://gerrit.libreoffice.org/70376 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#124579: ensure to provide an event to wake up main loop when notifyingMike Kaganski2019-04-061-0/+5
| | | | | | | | | | | | | | Without that, Request::waitProcessMessages might wait indefinitely for Application::Yield() to return; while the latter would wait for a message in GetMessage. If there's no visible LO window, the message might never arrive by itself. Co-authored-by: Jan-Marek Glogowski <glogow@fbihome.de> Change-Id: Ie2622053a8d4467eb1cbd579d8496cb5ddef08aa Reviewed-on: https://gerrit.libreoffice.org/70346 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#123502: Make sure to hold the mutex before releasing itMike Kaganski2019-04-051-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes a regression after commit 5b2f1243bd44b450da26c8344b3ee459f8e88f6c The destruction of the dialog is initiated by a callback executed from VCLXButton::ProcessWindowEvent, which notifies listeners, using a call to VCLXWindow::ImplExecuteAsyncWithoutSolarLock. The stack looks like this: ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28) ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(154) ucrtbased.dll!abort() Line 51 at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(51) comphelper.dll!comphelper::SolarMutex::doRelease(bool bUnlockAll) Line 65 at c:\lo\src\core2\comphelper\source\misc\solarmutex.cxx(65) vclplug_winlo.dll!SalYieldMutex::doRelease(bool bUnlockAll) Line 169 at c:\lo\src\core2\vcl\win\app\salinst.cxx(169) comphelper.dll!comphelper::SolarMutex::release(bool bUnlockAll) Line 89 at c:\lo\src\core2\include\comphelper\solarmutex.hxx(89) vcllo.dll!SalInstance::ReleaseYieldMutexAll() Line 114 at c:\lo\src\core2\vcl\source\app\salvtables.cxx(114) vcllo.dll!Application::ReleaseSolarMutex() Line 548 at c:\lo\src\core2\vcl\source\app\svapp.cxx(548) fps.dll!SolarMutexReleaser::SolarMutexReleaser() Line 1479 at c:\lo\src\core2\include\vcl\svapp.hxx(1479) fps.dll!fpicker::win32::vista::AsyncRequests::~AsyncRequests() Line 84 at c:\lo\src\core2\fpicker\source\win32\asyncrequests.cxx(84) fps.dll!fpicker::win32::vista::VistaFilePicker::~VistaFilePicker() Line 72 at c:\lo\src\core2\fpicker\source\win32\vistafilepicker.cxx(72) fps.dll!fpicker::win32::vista::VistaFilePicker::`scalar deleting destructor'(unsigned int) cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 233 at c:\lo\src\core2\cppuhelper\source\weak.cxx(233) cppuhelper3MSC.dll!cppu::WeakComponentImplHelperBase::release() Line 84 at c:\lo\src\core2\cppuhelper\source\implbase.cxx(84) fps.dll!cppu::PartialWeakComponentImplHelper<com::sun::star::ui::dialogs::XFilePicker3,com::sun::star::ui::dialogs::XFilePickerControlAccess,com::sun::star::ui::dialogs::XFilePreview,com::sun::star::ui::dialogs::XFolderPicker2,com::sun::star::lang::XInitialization,com::sun::star::lang::XServiceInfo>::release() Line 86 at c:\lo\src\core2\include\cppuhelper\compbase.hxx(86) invocationlo.dll!com::sun::star::uno::cpp_release(void * pCppI) Line 48 at c:\lo\src\core2\include\com\sun\star\uno\genfunc.hxx(48) cppu3.dll!cppu::_release(void * p, void(*)(void *) release) Line 86 at c:\lo\src\core2\cppu\source\uno\prim.hxx(86) cppu3.dll!cppu::_destructAny(_uno_Any * pAny, void(*)(void *) release) Line 130 at c:\lo\src\core2\cppu\source\uno\destr.hxx(130) cppu3.dll!uno_any_destruct(_uno_Any * pValue, void(*)(void *) release) Line 131 at c:\lo\src\core2\cppu\source\uno\any.cxx(131) invocationlo.dll!com::sun::star::uno::Any::~Any() Line 111 at c:\lo\src\core2\include\com\sun\star\uno\any.hxx(111) invocationlo.dll!stoc_inv::Invocation_Impl::~Invocation_Impl() invocationlo.dll!stoc_inv::Invocation_Impl::`scalar deleting destructor'(unsigned int) cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 233 at c:\lo\src\core2\cppuhelper\source\weak.cxx(233) invocationlo.dll!stoc_inv::Invocation_Impl::release() Line 110 at c:\lo\src\core2\stoc\source\invocation\invocation.cxx(110) pyuno_d.pyd!com::sun::star::uno::Reference<com::sun::star::script::XInvocation2>::~Reference<com::sun::star::script::XInvocation2>() Line 110 at c:\lo\src\core2\include\com\sun\star\uno\reference.hxx(110) pyuno_d.pyd!pyuno::PyUNOInternals::~PyUNOInternals() pyuno_d.pyd!pyuno::PyUNOInternals::`scalar deleting destructor'(unsigned int) pyuno_d.pyd!pyuno::PyUNO_del(_object * self) Line 81 at c:\lo\src\core2\pyuno\source\module\pyuno.cxx(81) python35_d.dll!_Py_Dealloc(_object * op) Line 1795 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\object.c(1795) python35_d.dll!dict_dealloc(PyDictObject * mp) Line 1646 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\dictobject.c(1646) python35_d.dll!_Py_Dealloc(_object * op) Line 1795 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\object.c(1795) python35_d.dll!subtype_dealloc(_object * self) Line 1194 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\typeobject.c(1194) python35_d.dll!_Py_Dealloc(_object * op) Line 1795 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\object.c(1795) python35_d.dll!frame_dealloc(_frame * f) Line 431 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\frameobject.c(431) python35_d.dll!_Py_Dealloc(_object * op) Line 1795 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\object.c(1795) python35_d.dll!fast_function(_object * func, _object * * * pp_stack, int n, int na, int nk) Line 4858 at c:\lo\src\core2\workdir\unpackedtarball\python3\python\ceval.c(4858) python35_d.dll!call_function(_object * * * pp_stack, int oparg) Line 4783 at c:\lo\src\core2\workdir\unpackedtarball\python3\python\ceval.c(4783) python35_d.dll!PyEval_EvalFrameEx(_frame * f, int throwflag) Line 3291 at c:\lo\src\core2\workdir\unpackedtarball\python3\python\ceval.c(3291) python35_d.dll!_PyEval_EvalCodeWithName(_object * _co, _object * globals, _object * locals, _object * * args, int argcount, _object * * kws, int kwcount, _object * * defs, int defcount, _object * kwdefs, _object * closure, _object * name, _object * qualname) Line 4080 at c:\lo\src\core2\workdir\unpackedtarball\python3\python\ceval.c(4080) python35_d.dll!PyEval_EvalCodeEx(_object * _co, _object * globals, _object * locals, _object * * args, int argcount, _object * * kws, int kwcount, _object * * defs, int defcount, _object * kwdefs, _object * closure) Line 4092 at c:\lo\src\core2\workdir\unpackedtarball\python3\python\ceval.c(4092) python35_d.dll!function_call(_object * func, _object * arg, _object * kw) Line 627 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\funcobject.c(627) python35_d.dll!PyObject_Call(_object * func, _object * arg, _object * kw) Line 2166 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\abstract.c(2166) python35_d.dll!method_call(_object * func, _object * arg, _object * kw) Line 330 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\classobject.c(330) python35_d.dll!PyObject_Call(_object * func, _object * arg, _object * kw) Line 2166 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\abstract.c(2166) python35_d.dll!PyEval_CallObjectWithKeywords(_object * func, _object * arg, _object * kw) Line 4634 at c:\lo\src\core2\workdir\unpackedtarball\python3\python\ceval.c(4634) python35_d.dll!PyObject_CallObject(_object * o, _object * a) Line 2092 at c:\lo\src\core2\workdir\unpackedtarball\python3\objects\abstract.c(2092) pyuno_d.pyd!pyuno::Adapter::invoke(const rtl::OUString & aFunctionName, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & aParams, com::sun::star::uno::Sequence<short> & aOutParamIndex, com::sun::star::uno::Sequence<com::sun::star::uno::Any> & aOutParam) Line 251 at c:\lo\src\core2\pyuno\source\module\pyuno_adapter.cxx(251) msci_uno.dll!`anonymous namespace'::callVirtualMethod(void * pAdjustedThisPtr, long nVtableIndex, void * pRegisterReturn, _typelib_TypeClass eReturnTypeClass, long * pStackLongs, long nStackLongs) Line 74 at c:\lo\src\core2\bridges\source\cpp_uno\msvc_win32_intel\uno2cpp.cxx(74) msci_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 249 at c:\lo\src\core2\bridges\source\cpp_uno\msvc_win32_intel\uno2cpp.cxx(249) msci_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberDescr, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430 at c:\lo\src\core2\bridges\source\cpp_uno\msvc_win32_intel\uno2cpp.cxx(430) invocadaptlo.dll!stoc_invadp::AdapterImpl::invoke(const _typelib_TypeDescription * pMemberType, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 467 at c:\lo\src\core2\stoc\source\invocation_adapterfactory\iafactory.cxx(467) invocadaptlo.dll!adapter_dispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberType, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 617 at c:\lo\src\core2\stoc\source\invocation_adapterfactory\iafactory.cxx(617) msci_uno.dll!`anonymous namespace'::cpp2uno_call(bridges::cpp_uno::shared::CppInterfaceProxy * pThis, const _typelib_TypeDescription * pMemberTypeDescr, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * * pCallStack, __int64 * pRegisterReturn) Line 155 at c:\lo\src\core2\bridges\source\cpp_uno\msvc_win32_intel\cpp2uno.cxx(155) msci_uno.dll!`anonymous namespace'::cpp_mediate(void * * pCallStack, long nFunctionIndex, long nVtableOffset, __int64 * pRegisterReturn) Line 345 at c:\lo\src\core2\bridges\source\cpp_uno\msvc_win32_intel\cpp2uno.cxx(345) msci_uno.dll!`anonymous namespace'::cpp_vtable_call() Line 380 at c:\lo\src\core2\bridges\source\cpp_uno\msvc_win32_intel\cpp2uno.cxx(380) tklo.dll!ActionListenerMultiplexer::actionPerformed(const com::sun::star::awt::ActionEvent & evt) Line 146 at c:\lo\src\core2\toolkit\source\helper\listenermultiplexer.cxx(146) tklo.dll!ActionListenerMultiplexer::actionPerformed(const com::sun::star::awt::ActionEvent & evt) Line 146 at c:\lo\src\core2\toolkit\source\helper\listenermultiplexer.cxx(146) tklo.dll!VCLXButton::ProcessWindowEvent::__l8::<lambda>() Line 593 at c:\lo\src\core2\toolkit\source\awt\vclxwindows.cxx(593) tklo.dll!std::_Invoker_functor::_Call<void <lambda>(void) &>(VCLXButton::ProcessWindowEvent::__l8::void <lambda>(void) & _Obj) tklo.dll!std::invoke<void <lambda>(void) &>(VCLXButton::ProcessWindowEvent::__l8::void <lambda>(void) & _Obj) tklo.dll!std::_Invoker_ret<void,1>::_Call<void <lambda>(void) &>(VCLXButton::ProcessWindowEvent::__l8::void <lambda>(void) & <_Vals_0>) tklo.dll!std::_Func_impl_no_alloc<void <lambda>(void),void>::_Do_call() tklo.dll!std::_Func_class<void>::operator()() tklo.dll!VCLXWindowImpl::OnProcessCallbacks(void * __formal) Line 300 at c:\lo\src\core2\toolkit\source\awt\vclxwindow.cxx(300) ... So it seems like the only place where we could guarantee the invariant to hold solar mutex for GUI protection before releasing it is right before the releaser itself. Co-authored-by: Jan-Marek Glogowski <glogow@fbihome.de> Change-Id: Ie95bd3423a25f210f0bbb2a88288c7c60a528ea0 Reviewed-on: https://gerrit.libreoffice.org/70301 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
* Drop UNICODE/_UNICODE definesMike Kaganski2019-04-041-5/+0
| | | | | | | | | | | | The code is using expicit (mostly W) Windows API, and is independent from the macro. Removing it here allows to catch places where some UNICODE-dependent macro is used unintentionally. Change-Id: I5dff40aecfc3c3dc7fc4cf7271a995a675943a45 Reviewed-on: https://gerrit.libreoffice.org/70237 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
* Clarify flow, reduce scopeMatteo Casalin2019-03-201-13/+13
| | | | | | | Change-Id: I99dbde5d2b25a8cbffc027e136d29cf911d5337b Reviewed-on: https://gerrit.libreoffice.org/69243 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
* getToken() ==> copy() since separator positions are knownMatteo Casalin2019-03-141-13/+9
| | | | | | | Change-Id: Ib13f279fd764538deb77b3ee871e58baf8676be2 Reviewed-on: https://gerrit.libreoffice.org/69242 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
* loplugin:indentation (clang-cl)Stephan Bergmann2019-02-264-17/+17
| | | | | | | Change-Id: I94689e4eed290b4505d2caba2d9802ef7fb6cffd Reviewed-on: https://gerrit.libreoffice.org/68378 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:unusedfields in forms..fpickerNoel Grandin2019-02-232-5/+1
| | | | | | | Change-Id: Ifd3afbf276100e3cef802bbcc0792b43a9cd84f8 Reviewed-on: https://gerrit.libreoffice.org/68228 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* o3tl::make_unique -> std::make_unique in include/ & o3tl/Gabor Kelemen2019-02-202-2/+0
| | | | | | | | | | | | Also the last few remaining occurrences of the header Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: I18f435270057f2d09e21d6ea262532cbcc974598 Reviewed-on: https://gerrit.libreoffice.org/67843 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Simplify containers iterations in [f-l]*Arkadiy Illarionov2019-02-183-23/+8
| | | | | | | | | Use range-based loop or replace with STL functions Change-Id: Ib3fab47318d1bfbb4df8f886a8cd9596525a420f Reviewed-on: https://gerrit.libreoffice.org/67914 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Pointer is pointlessNoel Grandin2019-02-131-0/+1
| | | | | | | | | since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:indentation in forms..fpickerNoel Grandin2019-02-093-5/+5
| | | | | | | Change-Id: If01379c43519cc1dbcf8dfaefde545fbe7e24fc2 Reviewed-on: https://gerrit.libreoffice.org/67556 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#42949 Fix IWYU warnings in include/svtools/*Gabor Kelemen2019-02-052-0/+6
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I937ed12f2a96943664087ddcdd035f1347e84a57 Reviewed-on: https://gerrit.libreoffice.org/67102 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* loplugin:unnecessaryparen (clang-cl)Stephan Bergmann2019-01-311-2/+2
| | | | | | | Change-Id: I0cd14e0ace9c9d2fcd880477b0485295e3010b71 Reviewed-on: https://gerrit.libreoffice.org/67138 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:redundantinline (clang-cl)Stephan Bergmann2019-01-302-2/+2
| | | | | | | Change-Id: Ib6320ddc049e93cca4c5931ad28d1873d34bd8b4 Reviewed-on: https://gerrit.libreoffice.org/67137 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#122927 prevent SolarMutex deadlock on join()Jan-Marek Glogowski2019-01-252-1/+9
| | | | | | | | | | | | | | | | | | The AsyncRequests thread can be blocked in a SolarMutexGuard, so we have to release the mutex before calling join(). But there is also a static AsyncRequests object inside the VistaFilePickerEventHandler::impl_sendEvent function, which will just be cleaned up at DLL atexit. "Luckily" it won't ever run, so it doesn't need to be joined and we can use isRunning to detect it, prevent releasing a non- existing SolarMutex at this point and so won't crash LO on exit. Change-Id: I0c56b89a11f96be54e82b756c5e18a058b04a41d Reviewed-on: https://gerrit.libreoffice.org/66901 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
* tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen2019-01-072-0/+2
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Resolve deprecated implicit capture of *this by reference in C++20Stephan Bergmann2018-12-172-2/+2
| | | | | | | | | | | ...as flagged with -Werror=deprecated by trunk GCC in -std=c++2a mode. But C++17 forbids "this" in combination with a capture-default of "=", so in such cases list any entities explicitly that shall be captured by value. Change-Id: Ic228cd20682277a0f93e3e75798356d0fbbb80d4 Reviewed-on: https://gerrit.libreoffice.org/65241 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin2018-12-082-2/+2
| | | | | | | | | | | | | | | | | | | | | which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Achieved by perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" ) followed by git grep -nP '\bImage\s*\(\s*BitmapEx\s*\(' followed by commenting out the BitmapEx(OUString) constructor and seeing what needed adjusting. Change-Id: I3224e11937d720fa484b0d659d25673a9e809267 Reviewed-on: https://gerrit.libreoffice.org/64760 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* Optimize getting filter mask by index from CFilterContainerMike Kaganski2018-12-063-25/+25
| | | | | | | Change-Id: Id4ea2c3dd7420954b1852021f136bc98f20a9846 Reviewed-on: https://gerrit.libreoffice.org/64663 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#119747 FileSaveDialog: remove duplicate extension on WindowsMike Kaganski2018-12-061-4/+18
| | | | | | | | | | | | | This properly reimplements the fix, only changing the display strings sent to native dialog, and never modifying the filter names as seen by LibreOffice code. Change-Id: Iee5f09acd6b12c0ba8b7568b16f8ab07821006ee Reviewed-on: https://gerrit.libreoffice.org/64656 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Revert "tdf#119747 FileSaveDialog: Windows dialog shows only one extension."Mike Kaganski2018-12-063-37/+6
| | | | | | | | | This reverts commit 1b50fa88b148739a7b192ba70f08af2c6e326fd2. Change-Id: Ide94c1be6a265cee2e70c319578d816efa1d2eb9 Reviewed-on: https://gerrit.libreoffice.org/64655 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
* Revert "tdf#121497 "Save As": File Format Type unchanged in Windows"Mike Kaganski2018-12-061-17/+2
| | | | | | | | | This reverts commit c444eb7934d4a3c190e1d060805d9d175c1a9127. Change-Id: I19b969572afbd0a017b8086b390611cfc04c7386 Reviewed-on: https://gerrit.libreoffice.org/64654 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* remove unused HeaderBarItemBits enum valuesNoel Grandin2018-11-301-1/+1
| | | | | | | Change-Id: I84752cb9d683cb22c96d91cc54d7c4dc474603fc Reviewed-on: https://gerrit.libreoffice.org/64269 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Rename Mac OS X to official name macOS in comments and documentationBartosz Kosiorek2018-11-293-3/+3
| | | | | | | Change-Id: I651b7f202fa52ff5f5357a11aa72c43eb7dc7f95 Reviewed-on: https://gerrit.libreoffice.org/64102 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
* tdf#42949 Fix IWYU warnings in include/vcl/[i-m]*Gabor Kelemen2018-11-291-0/+1
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If1b2e04872eb0dd6725802c1709a9085f4cd8c91 Reviewed-on: https://gerrit.libreoffice.org/64141 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* remove unnecessary "if (!empty()" checks before loopsNoel Grandin2018-11-291-3/+3
| | | | | | | | | | | found with git grep -n -A4 'if.*!.*empty' | grep -B3 -P '(\bfor)|(\bwhile)|(\bdo)' Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334 Reviewed-on: https://gerrit.libreoffice.org/64169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* drop some unnecessary includesCaolán McNamara2018-11-281-1/+0
| | | | | | | | Change-Id: I474b5762e6a07982fddc0315a67181399ea4c30e Reviewed-on: https://gerrit.libreoffice.org/64156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* weld SwCondCollPageCaolán McNamara2018-11-214-4/+4
| | | | | | | | | | and put back original SvTreeListBox a11y factory use Change-Id: I4ad8ce29d8fed6ec5d44e9a1d641919a89226b79 Reviewed-on: https://gerrit.libreoffice.org/63501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:redundantfcast improvementsNoel Grandin2018-11-211-1/+1
| | | | | | | | | | check for calls to constructors, and extend the list of types we check for unnecessary temporary creation Change-Id: Ia2c1f202b41ed6866779fff5343c821128033eec Reviewed-on: https://gerrit.libreoffice.org/63472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#121497 "Save As": File Format Type unchanged in WindowsIlhan Yesil2018-11-201-2/+17
| | | | | | | | | | Added checks for filter title, so filter titles are Windows conform. Change-Id: I42485c465ea58540a99b8300c5205b902cb86a92 Reviewed-on: https://gerrit.libreoffice.org/63573 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* tdf#42949 Fix IWYU warnings in include/vcl/[ab]*Gabor Kelemen2018-11-192-0/+2
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If18c80fc64e55d797953e24e40e5d5e62bd9c625 Reviewed-on: https://gerrit.libreoffice.org/63453 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Adapt to C++2a char_tStephan Bergmann2018-11-171-1/+1
| | | | | | | | | | u8 literals incompatibly change their type (as implemented by recent Clang trunk) Change-Id: Ia4f7b91f5d86656a056303d2754981ab2093a739 Reviewed-on: https://gerrit.libreoffice.org/63494 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix typosAndrea Gelmini2018-11-161-1/+1
| | | | | | | Change-Id: I25660634dcb9ebb31292275e31ed7a047e4ddd25 Reviewed-on: https://gerrit.libreoffice.org/63474 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* tdf#119747 FileSaveDialog: Windows dialog shows only one extension.Ilhan Yesil2018-11-133-6/+37
| | | | | | | | | | | A temporary composed list of file types and extension types is build from the original list and provided to the IFileSaveDialog object, so that this dialog shows only one extension. Change-Id: Iae01c3e889ea38034332fc29e4cc397941930ac0 Reviewed-on: https://gerrit.libreoffice.org/60268 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* move SvTreeListBox to vclCaolán McNamara2018-11-071-1/+1
| | | | | | | | Change-Id: I04a146d3d8a428ac1678827dc883525c40240a44 Reviewed-on: https://gerrit.libreoffice.org/62787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* replace StartExecuteModal with StartExecuteAsyncCaolán McNamara2018-10-316-22/+21
| | | | | | | | Change-Id: I2c0e0266f6bb468ebb5285f95d1824cf12100812 Reviewed-on: https://gerrit.libreoffice.org/62690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#120703 PVS: V519 variable is assigned values twice successivelyMike Kaganski2018-10-271-5/+3
| | | | | | | | | | V519 The 'hResult' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1097, 1098. Change-Id: Ib6f9c3467578ebc68b3a15f8dbea4054af45707d Reviewed-on: https://gerrit.libreoffice.org/62411 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
* remove more rtl::OUString and OString prefixesNoel Grandin2018-10-249-79/+78
| | | | | | | | | which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove all use_action_appearance linesCaolán McNamara2018-10-232-14/+0
| | | | | | | | Change-Id: I031676e939f53a28b1a62654ffe0a91b95dea029 Reviewed-on: https://gerrit.libreoffice.org/62234 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* clang-tidy performance-unnecessary-copy-init in editeng..i18npoolNoel Grandin2018-10-231-1/+1
| | | | | | | Change-Id: I2ee2c8d15d8700cfaa1697363da4557c741a5f36 Reviewed-on: https://gerrit.libreoffice.org/62216 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy readability-container-size-emptyNoel Grandin2018-10-191-1/+1
| | | | | | | Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422 Reviewed-on: https://gerrit.libreoffice.org/61967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-04-28 02:59:24 +0000