summaryrefslogtreecommitdiffstats
path: root/forms
Commit message (Collapse)AuthorAgeFilesLines
* Remove redundant 'inline' keywordStephan Bergmann2017-03-0314-48/+48
| | | | | | | | | | ...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix typosAndrea Gelmini2017-03-032-2/+2
| | | | | | | Change-Id: I338dacd3cfe915714a9038e1dea4a60d586e9394 Reviewed-on: https://gerrit.libreoffice.org/34806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* typesafe wrappers for css::i18nutil::TransliterationModulesNoel Grandin2017-03-011-2/+2
| | | | | | | | | | | | | | | | | and related css::util::SearchOptions2 The TransliterationModules enum has it's constants spread over multiple UNO enum/constant-collections - TransliterationModules and TransliterationModulesExtra, which means that most code simply uses sal_Int32. Wrap them up into a better bundle so that only the lowest layer needs to deal directly with the UNO constants. Change-Id: I1edeab79fcc7817a4a97c933ef84ab7015bb849b Reviewed-on: https://gerrit.libreoffice.org/34582 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* new loplugin unoanyNoel Grandin2017-02-284-8/+8
| | | | | | | Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* better fix for tdf#103830Noel Grandin2017-02-241-7/+9
| | | | | | | | | | | | the first fix in commit 3a404ea870f1eed86f9765447ce0a364d39ae8f8 did not take into account that this a multimap, not a map. Thanks to Aron Budea for spotting that. Change-Id: I86d2d2a9d6cb08fd3cee3965a5b787d5691f0352 Reviewed-on: https://gerrit.libreoffice.org/34604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#103830 Form field names not update in python macroNoel Grandin2017-02-241-2/+2
| | | | | | | | | | | | regression from commit 5f15cc01b31ccaed0c6482a36556dece084ce302 "new loplugin: use more efficient find() methods" Regression found by Aron Budea. Change-Id: I0e84376dfd754738de97882979058f86c2476bd6 Reviewed-on: https://gerrit.libreoffice.org/34600 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Remove wrong and broken encoding from INetMIMEMessage::SetHeaderField_ImplStephan Bergmann2017-02-211-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | INetMIMEEncodedWordOutputSink had been intended to encode (non-ASCII) content of a "free-form text" header field as per RFC 2047. It used a heuristic trying to detect already encoded words (=?...?...?...?=) in the input, to pass them through unmodified. (Arguably, it could just as well have encoded them, assuming they were meant to be genuine input.) However, that heuristic had a bug ever since 8ab086b6cc054501bfbf7ef6fa509c393691e860 "initial import", going from STATE_FIRST_EQUALS to STATE_FIRST_EQUALS instead of STATE_FIRST_QUESTION, rendering the heuristical detection logic effectively unused. Instead of fixing the bug, 6e12729f715f142140d220dc7d3b28a4a0657016 "remove unused enumerator from EncodedWordState" and b8d8fb3f0cf4a961bbff54523eaca1a4f8179c7a "convert EncodedWordState to scoped enum" crippled the code further by removing any reputedly unused cases. But the only remaining use of INetMIMEEncodedWordOutputSink is in INetMIMEMessage::SetHeaderField_Impl, encoding MIME-Version, Content-Transfer- Encoding, Content-Type, and Content-Disposition header fields. And none of those headers have any "free-form text" content that should be encoded as per RFC 2047. The first two have fixed ASCII-only content ("1.0" and "7bit", "8bit", etc., respectively), while the latter two have structured content that may contain parameters of arbitrary content, which must be encoded according to RFC 2231 (but currently isn't). And the only place where such arbitrary-content parameters are generated is in the two calls to SetContentTransferEncoding in forms/source/component/DatabaseForm.cxx. (The calls to SetContentType there and in tools/source/inet/ itself are all known to have unproblematic ASCII-only content.) So mark those two places with TODOs about the missing encoding (which had been missing since forever) and, in INetMIMEMessage::SetHeaderField_Impl, liberally convert the content to 8-bit via OUString::toUtf8 for now. Change-Id: I4b2a219b396953b219ca66441a5227157a35951f
* Use module name when getting labelsMaxim Monastirsky2017-02-211-1/+1
| | | | Change-Id: I1d5196e1ca888dfb11d5bd6ef4676937dce49fdc
* tdf#95844 Refactor CommandInfoProviderRohan Kumar2017-02-211-1/+1
| | | | | | Instead of a singleton, CommandInfoProvider should just be a set of static methods. Change-Id: I16d4406e361a72f013d78f18d6bd0ae20c0cc5e9
* Resolves: tdf#79250 add typed list to form control listboxEike Rathke2017-02-146-8/+118
| | | | | | ... so numeric and text data can be distinguished input. Change-Id: I63280a93c272ccc6f5e7ca06a1a1fcbfb3db8455
* Revert "Resolves: tdf#79250 add typed list to form control listbox"Eike Rathke2017-02-116-126/+8
| | | | | | | | | | This reverts commit e387b69967aabc44d5da5aaad8d94191437dc57c. It breaks toolkit.subsequentcheck with propertyChangeListener wasn´t called for ´TypedItemList´ Back to the drawing board for the twisted property logic of forms and toolkit uno control models.
* Resolves: tdf#79250 add typed list to form control listboxEike Rathke2017-02-106-8/+126
| | | | | | ... so numeric and text data can be distinguished input. Change-Id: I63280a93c272ccc6f5e7ca06a1a1fcbfb3db8455
* Remove MinGW supportStephan Bergmann2017-02-101-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* space typoEike Rathke2017-02-091-1/+1
| | | | | | it's an interface name.. Change-Id: Ie758f29864761a4e0c41326dac14d233c22e5f52
* Add missing #includesStephan Bergmann2017-02-069-5/+12
| | | | | | | | | ...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
* new loplugin:unusedenumconstantsNoel Grandin2017-02-031-17/+1
| | | | | | | | | | These are the simple removals, where it is obviously safe, the more complex ones will come in separate commits Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308 Reviewed-on: https://gerrit.libreoffice.org/33828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:stringconstant handle calls to constructors with one argNoel Grandin2017-02-011-1/+1
| | | | | | | Change-Id: Ide9148a908bef46ba14640dfa6f556beaf6e3f60 Reviewed-on: https://gerrit.libreoffice.org/33772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* teach lolugin:stringconstant about calling constructorsNoel Grandin2017-01-312-4/+4
| | | | | | | | | | | so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin2017-01-281-1/+1
| | | | | | | | | ..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove dynamic exception specificationsStephan Bergmann2017-01-26123-1978/+1583
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* use rtl::Reference in OImageControlModelNoel Grandin2017-01-262-9/+6
| | | | | | | | | instead of storing both a raw pointer and an uno::Reference Change-Id: If0e1380815e93015249cc19bc66b40befbfab50e Reviewed-on: https://gerrit.libreoffice.org/33570 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use rtl::Reference in ModelNoel Grandin2017-01-263-68/+45
| | | | | | | | | instead of storing both raw pointers and an uno::Reference Change-Id: I93871eaf9807d0fa846a4e1090d7ee7b1db01c5e Reviewed-on: https://gerrit.libreoffice.org/33571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin: unnecessary destructor forms..idlcNoel Grandin2017-01-255-7/+0
| | | | | | | Change-Id: I765e0fa61f8134a60e5ea24452c6bbcb3fa8b054 Reviewed-on: https://gerrit.libreoffice.org/33492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Change all Idle* LINKs to be Timer*Jan-Marek Glogowski2017-01-233-4/+4
| | | | | | | | | | | | | | | | | | | | | Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
* use rtl::Reference in ODatabaseFormNoel Grandin2017-01-232-13/+10
| | | | | | rather than manual acquire/release Change-Id: Ic5f013b7e4cafc597c659c61fbf568adccfd806a
* don't need an intermediate ImageCaolán McNamara2017-01-201-1/+1
| | | | Change-Id: I090d94cfe433763ded70f28b5139772bca229c34
* New loplugin:dynexcspec: Add @throws documentation, formsStephan Bergmann2017-01-199-1/+17
| | | | Change-Id: Ib5e1f2ef4143ad1c75ec705624a547e47affbc79
* use rtl::Reference in OClickableImageBaseModelNoel Grandin2017-01-192-13/+7
| | | | | | instead of storing both a raw pointer and an uno::Reference Change-Id: I92dc79edef9046acc137a878d35dde935bb17674
* use rtl::Reference in OComponentEventThreadNoel Grandin2017-01-192-17/+9
| | | | | | instead of storing both a raw pointer and an uno::Reference Change-Id: I8cd4d04ffb9f40a48d48ade2b171a9a9942cf87f
* Refactor Scheduler to add Task classJan-Marek Glogowski2017-01-171-1/+1
| | | | | | | | Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
* new loplugin: useuniqueptr: forms..frameworkNoel Grandin2017-01-174-7/+7
| | | | | | | Change-Id: I4300a13f455148b7156ac3f444c7102d63ae6db3 Reviewed-on: https://gerrit.libreoffice.org/33164 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* forms,qadevOOo: dispatch of .uno:SwitchControlDesignMode is asyncMichael Stahl2017-01-161-0/+6
| | | | | | Follow-up to e19cdeaf7ddbcf39da47d9685d8e79e775dde7f4. Change-Id: Ic4f8f0373199a4237fa30a830fc89a263eb40d62
* Some loplugin:conststringvar/stringconstant improvements: formsStephan Bergmann2017-01-111-1/+1
| | | | Change-Id: Iec2be8c9ddbdf8d5d8bc1054c20a0bd40707262a
* tdf#101828 handle rtf/richtext correctlyOliver Specht2017-01-091-2/+4
| | | | | | | Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0 Reviewed-on: https://gerrit.libreoffice.org/32682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* This apparently doesn't happenStephan Bergmann2017-01-061-5/+1
| | | | | | | | | | | | The code has been like this ever since ed8c4fd992a4e2e43e65d05e6f06336bfe2fdba2 "INTEGRATION: CWS eforms2", but it doesn't make sense: It apparently wants to clear XCurrent to leave the for-loop early, but would acutally cause a null deref instead. So this branch apparently doesn't get executed routinely. Is it impossible to be reached? To play it safe, assume no. But I can't find anything substantiating the "we'll remove the slash below" claim, so just return an empty string instead. Change-Id: I18e05385bbef05e7682a2eb4d525cfee25d9a6f5
* Use OUString::booleanStephan Bergmann2017-01-061-1/+1
| | | | Change-Id: I8989fcc18cd0f0b28ef6da5c3c3d7f87429b569b
* No need for an OUStringBuffer hereStephan Bergmann2017-01-061-16/+5
| | | | Change-Id: I01697ac2b84f836ff0b3d15aa8d03042f229eacb
* Replace side-effect--only uses of makeStringAndClear() with setLength(0)Stephan Bergmann2017-01-051-1/+1
| | | | Change-Id: Iaf8011f1bd6a10b324653899b7f51458f7d0b68a
* tdf#101442 - "hyperlink" to "link"Federico Bassini2016-12-231-1/+1
| | | | | | changing other words "hyperlink" to "link!" Change-Id: I29d97bab7844183759bc34624a14c0216258ad8b
* remove newly unused SfxImageManagerCaolán McNamara2016-12-211-1/+0
| | | | Change-Id: If68637fe49b5d252ad4ec5d63d56261113be6a7c
* add dbtools for !HAVE_FEATURE_DBCONNECTIVITY anywayCaolán McNamara2016-12-173-14/+5
| | | | Change-Id: I7a769ab3c7881eae80849efc5e75eca5846d254f
* more !HAVE_FEATURE_DBCONNECTIVITY build fixingCaolán McNamara2016-12-171-2/+3
| | | | Change-Id: I1f949c29020c498200decdac487e0519f48a4142
* OSL_TRACE->SAL in chart2..ooxNoel Grandin2016-12-131-15/+2
| | | | | | | Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert SFX_HINT to scoped enumNoel Grandin2016-12-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert DecodeMechanism to scoped enumNoel Grandin2016-12-058-12/+12
| | | | Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
* convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin2016-12-051-2/+2
| | | | Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
* loplugin:unnecessaryoverride (dtors) in formsStephan Bergmann2016-12-052-10/+0
| | | | Change-Id: Ia6787aa9dc7963b1e44604f22bfc95e0333a7f79
* loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin2016-11-292-2/+2
| | | | | | | | | | | | | | Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* vcl: rename Window::Notify to EventNotifyMichael Stahl2016-11-242-3/+3
| | | | | | | | | There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
* remove use of tryPropertyValue Any specialisationJochen Nitschke2016-11-212-10/+18
| | | | | | | | | | | | | change return value of getCurrentMultiValue from Any<Sequence<Any> > to Sequence<Any>. return value of getCurrentSingleValue (Any of connectivity::ORowSetValue) can't be changed to use tryPropertyValue. inline functionality Change-Id: I3180cf5b9e63a3da9257b03ba02967a2d5402ec3 Reviewed-on: https://gerrit.libreoffice.org/30091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-22 11:35:51 +0000