summaryrefslogtreecommitdiffstats
path: root/extensions
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:expandablemethods in svtoolsNoel Grandin2016-10-271-3/+0
| | | | | | | Change-Id: I126cc87c890867c3e762f86969a20d64aef63108 Reviewed-on: https://gerrit.libreoffice.org/30314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Adapt Windows-only code to deletion of the "Any-to-Any" specializatiosStephan Bergmann2016-10-211-4/+4
| | | | | | | ...upcoming with <https://gerrit.libreoffice.org/#/c/30022/> "Delete the 'Any- to-Any' template specializations for LIBO_INTERNAL_ONLY" Change-Id: If070825d88ffa7bb49e645b3bfeae9dfa387f000
* tdf#96015 (part) link to Doc'tation in Help menuOlivier Hallot2016-10-191-0/+1
| | | | | | | | | | | | | | | | | | | | | Add the entry "Documentation" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/documentation/?&LOlang=<locale> <locale> is obtained from .getLocale() Patch2: create a member with try/catch for external URLs Patch3 Use sfx2::openUriExternally Revert to User Guides.. in UI. Change-Id: I8332253c31bd3be330cdd794f9e056b632b38037 Patch4: remove 1st '&' in URLs Reviewed-on: https://gerrit.libreoffice.org/28817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
* loplugin:expandablemethodds in editeng..extensionsNoel Grandin2016-10-1910-35/+6
| | | | | | | Change-Id: Ibe1929d74ff460955e39f2ccce3056b2051ddf08 Reviewed-on: https://gerrit.libreoffice.org/30013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* replace <<= with assign for <<= with rhs AnyJochen Nitschke2016-10-181-1/+1
| | | | | | | | | found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* so_activex_x64: Avoid warning LNK4070Mike Kaganski2016-10-181-1/+1
| | | | | | | | | | | Don't specify optional library name in DEF file that is used both for 32-bit and 64-bit library: it's explicitly specified in command line. Change-Id: I20e732f2095367ec3648741dde26cf7ec101f28f Reviewed-on: https://gerrit.libreoffice.org/30008 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
* replace <<= with assign for <<= with rhs AnyJochen Nitschke2016-10-171-17/+17
| | | | | | | | | makeAny and Any ctor return an Any Change-Id: Iaa361bc315d785f80153acf1009bf47d109728ec Reviewed-on: https://gerrit.libreoffice.org/29914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* clang-cl loplugin: extensionsStephan Bergmann2016-10-1628-717/+836
| | | | | | | Change-Id: I659d8a3b098c7417235006c86ea60e7fe1e56a44 Reviewed-on: https://gerrit.libreoffice.org/29867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* drop unused RID_RSC_BUTTON_IMAGES resourceCaolán McNamara2016-10-136-45/+1
| | | | Change-Id: If85a3491c3cb6ebb05a82e1c732083d99e91d6e8
* move this monstrosity to the last place its usedCaolán McNamara2016-10-135-5/+0
| | | | Change-Id: I4691f20143406249afc8da1a6dfa901224f4a62d
* remove (yet yet another) StringListResource implementationCaolán McNamara2016-10-133-464/+216
| | | | Change-Id: Ifaf89badfc339f8253a629c6960df8a943b8cce5
* remove StringListResource in favour of ResStringArray...Caolán McNamara2016-10-126-41/+67
| | | | | | | and turn local resources used as lists of strings into string array resources Change-Id: I9d67a790659963bca87aacba1c052d7b244b4e21
* tdf#70979 make conference proceedings strings uniqueYousuf Philips2016-10-121-2/+2
| | | | | | | Change-Id: I8386651390ba753108577ced29050585b72c5e78 Reviewed-on: https://gerrit.libreoffice.org/28813 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
* loplugin:unnecessaryoverride in extensions..filterNoel Grandin2016-10-122-8/+0
| | | | | | | Change-Id: Ifd954bf48291cdc43c66fd44b4029e47eb7589f6 Reviewed-on: https://gerrit.libreoffice.org/29690 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* safemode: Add uno command and menu entrySamuel Mehrbrodt2016-10-101-0/+2
| | | | | | | Change-Id: I1843767160b79041c42e506eff0cf39399c74f26 Reviewed-on: https://gerrit.libreoffice.org/29668 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* I can't see any evidence of any remaining magenta mask using image resourcesCaolán McNamara2016-10-062-15/+10
| | | | Change-Id: I12865d743daa3e6479edb60584d5bd01f88e818d
* ImageList just reads and discards the MaskColor, so drop itCaolán McNamara2016-10-062-5/+0
| | | | Change-Id: I243e739fea28e3f38b91534182cc54c2aa660f0e
* convert the last two lonely FixedInfos to FixedTextCaolán McNamara2016-10-051-1/+0
| | | | Change-Id: Ia6ed5f71931a6141efb3d5e5eb329149d6850342
* convert MapUnit to scoped enumNoel Grandin2016-10-0510-23/+23
| | | | | | | | | | | | I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann2016-10-0563-167/+167
| | | | | | | | | ...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
* cppcheck invalidPrintfArgTypeJochen Nitschke2016-10-021-7/+7
| | | | | | | | | signedness and long vs int corrections Change-Id: I67c6b9e05b16f5d8d4693879f1656db50dc7ec48 Reviewed-on: https://gerrit.libreoffice.org/29355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* remove unused parameterJochen Nitschke2016-09-251-1/+1
| | | | | | | | | | bTotalRanges is never used. SFX_ITEMSET_NO_DEFAULT_CTOR is no where else used. Change-Id: Ia35ea875f16a8ca04c2173b01074113f1825f565 Reviewed-on: https://gerrit.libreoffice.org/29248 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* -Werror,-Wignored-attributesStephan Bergmann2016-09-231-0/+1
| | | | | | (__declspec attribute 'allocator' in MSVC 2015 atlalloc.h; clang-cl) Change-Id: I88d2bc4667ded75a545c95f428e654be787b03f8
* loplugin:singlevalfields in basic..idlNoel Grandin2016-09-162-11/+5
| | | | | | | | | | | Also fix obvious bug in the initialisation of the connectivity::odbc::OConnection::m_bClosed field. Probably closes some kind of connection leak there. Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82 Reviewed-on: https://gerrit.libreoffice.org/28932 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Make OGenericUnoDialog::destoryDialog non-virtualStephan Bergmann2016-09-152-9/+3
| | | | | | | | | | | | ...it is only ever called: * either from dtors, where the virtual-ness doesn't acutally help (and would trigger loplugin:fragiledestructor if that were enabled) * or, in module filter, from executeDialog members of (final) classes directly derived from OGenericUnODialog without overriding destroyDialog Change-Id: If9a7370385a27952189423e5632b3f01e18ddbb5
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-1391-116/+116
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* loplugin:constantparam in extensions..lotuswordproNoel Grandin2016-09-1211-27/+27
| | | | | | | Change-Id: Ifb30d5d53536045638d872761626a1b60fa52dad Reviewed-on: https://gerrit.libreoffice.org/28831 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* coverity#1371190 Missing move assignment operatorCaolán McNamara2016-09-112-3/+8
| | | | Change-Id: I20991a31a82ff96292cdd1be4fd2c4779f9f5514
* loplugin:constantparam in svtoolsNoel Grandin2016-09-091-2/+1
| | | | | | | Change-Id: I04caae0c9ae621c55e16d3bdc014a4729617feb3 Reviewed-on: https://gerrit.libreoffice.org/28757 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* convert ScrollType to scoped enumNoel Grandin2016-09-052-3/+3
| | | | Change-Id: I6dd02d4f7df028dada6cfd5d767a6ec1b1c1efe1
* convert ExtDateFieldFormat to scoped enumNoel Grandin2016-09-051-1/+1
| | | | Change-Id: I717e5e727ee0e2b6d732ecc6a432c70926654902
* convert LineStyle to scoped enumNoel Grandin2016-09-051-1/+1
| | | | Change-Id: I30cfa5a0649b806604c443f55683d1f2a430983d
* convert RasterOp to scoped enumNoel Grandin2016-09-051-1/+1
| | | | Change-Id: I136423c105316c9b5b18e64d04a248fd7ac5590b
* tdf#101810 - Crash when selecting Bibliography from ToolsNoel Grandin2016-08-311-0/+1
| | | | | | fallout from commit aa0d0536 "tdf#97527 - vcl: reference-count Menu" Change-Id: I996a5b739f35d034b15fd5d0b4c94fd57688bf12
* remove unnecessary default constructor and operator=Markus Mohrhard2016-08-261-15/+0
| | | | | | | | | They are equal to the default generated and therefore unnecessary. Change-Id: I4c0c77c025443fc074308bfd3ce2637a7e1af8bf Reviewed-on: https://gerrit.libreoffice.org/27946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu2016-08-262-6/+5
| | | | | | | Change-Id: I3099818283a9801976288d0efa67a8711106f376 Reviewed-on: https://gerrit.libreoffice.org/28360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* -Werror,-Wnonportable-include-path (clang-cl)Stephan Bergmann2016-08-258-7/+8
| | | | Change-Id: Ia468adf0bea2f7fca9b370ef0ff8b05e34b3ac19
* tdf#89329: use unique_ptr for pImpl in datasourcehandlingArnold Dumas2016-08-192-4/+2
| | | | | | | Change-Id: Ib019d26a72d234245cc1a7322bfbfb11705f29d3 Reviewed-on: https://gerrit.libreoffice.org/28231 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* cppcheck: passedByValueCaolán McNamara2016-08-183-8/+7
| | | | Change-Id: I3ffcfe1294a1cbb06aadd3a1a79e9259876e38cc
* tdf#100782 have XPropertyList hold unique_ptrJochen Nitschke2016-08-151-1/+1
| | | | | | | Change-Id: I928f297e1be76b965898d83cb3dd2e79b23b7974 Reviewed-on: https://gerrit.libreoffice.org/28095 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#96015 (part) links to Askbot in the Help menuOlivier Hallot2016-08-111-0/+1
| | | | | | | | | | | | | | | | | | | | | | | Add the entry "~Get help online" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/forum/?&LOlang=<lang> <lang> is obtained from .getLocale() That in turn will redirect to e.g. askbot (but only few languages are using it at the moment) or other nl-specific resources. (nl-projects can request corresponding targets from infa, without the need to change the code – cf rdm#1983) The link can/should be extended to also include the version of LO and the currently used module to allow finer grained redirects. Change-Id: I56108dba4dd2684405623c4586103fc8ff9bea56 Reviewed-on: https://gerrit.libreoffice.org/27028 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* loplugin:sallogareasMichael Stahl2016-08-091-1/+1
| | | | Change-Id: I3443ed8d481d7a0ac72c03c4d0fd0bcf100a09b6
* it is possible that Sources is emptyMarkus Mohrhard2016-08-081-0/+6
| | | | | | | | | | See e.g. http://crashreport.libreoffice.org/stats/crash_details/570429b8-21e3-494e-9677-ea95fa8a5293 Change-Id: I8c05efd61fa5a91511c06c660c49a0c470a96c88 Reviewed-on: https://gerrit.libreoffice.org/27947 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* loplugin:countusersofdefaultparams in editeng..fpickerNoel Grandin2016-08-057-13/+13
| | | | | | | Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68 Reviewed-on: https://gerrit.libreoffice.org/27897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* improve passstuffbyref return analysisNoel Grandin2016-07-277-13/+13
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* masses of MessBoxes not being disposed promptlyCaolán McNamara2016-07-263-3/+3
| | | | | | | | | | | | | | | | since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
* new loplugin unnecessary overrideNoel Grandin2016-07-157-37/+1
| | | | | | | Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann2016-07-074-4/+4
| | | | Change-Id: I9bc14b4df6bdda68bae44a1972e6b412fa6adccb
* Related: tdf#92478 speculative win64 scanning fixCaolán McNamara2016-07-071-3/+5
| | | | | | | | | | | | | | | | TWAIN-2.3-Spec.pdf says... All TWAIN 2.x Sources must be prepared to work with either TWAINDSM.DLL or TWAIN_32.DLL, which may still be used by older Applications. The TWAIN DSM is a shared library named TWAINDSM.DLL. There is a 32-bit and a 64-bit version of this file. Change-Id: I047d872271573a5b2efc3ee2af4ecfc4e142a2b2 Reviewed-on: https://gerrit.libreoffice.org/26541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* merge BibTabPage with BibGeneralPageNoel Grandin2016-07-054-14/+4
| | | | | | | Change-Id: I16a80e7e98fdd2be08b5a8ce586b709a3720e694 Reviewed-on: https://gerrit.libreoffice.org/26929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>