summaryrefslogtreecommitdiffstats
path: root/extensions
Commit message (Collapse)AuthorAgeFilesLines
* overload std::hash for OUString and OStringNoel Grandin2017-10-237-13/+11
| | | | | | | | | no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#113225 - hold the solar mutex when entering from UNO.Michael Meeks2017-10-211-0/+1
| | | | | | | | | http://crashreport.libreoffice.org/stats/crash_details/dff57662-1693-47f6-8b09-88f180d2e706 Change-Id: I4322c2113c300af97fb5854aac4a741b7027e6b1 Reviewed-on: https://gerrit.libreoffice.org/43623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* no need to call acquire()Noel Grandin2017-10-181-9/+2
| | | | | | | | | when we are returning an uno::Reference Change-Id: Ifff0dba20f45f5321f398577fa7d5fb073278a94 Reviewed-on: https://gerrit.libreoffice.org/43472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use rtl::Reference in BibDataManagerNoel Grandin2017-10-172-10/+6
| | | | | | | | | instead of manual reference counting Change-Id: Ia8fd5487fb8d25d6725dd36b74aab57272aba911 Reviewed-on: https://gerrit.libreoffice.org/43447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* turn implicit container explicit in buildable notebooksCaolán McNamara2017-10-171-3/+18
| | | | | | | | | | | as in interim measure for SfxTabDialogs we throw away the TabPage if its not suitable for reuse Change-Id: Ic5776ca3d2a8cb6bf41f33df01b211f81c62a842 Reviewed-on: https://gerrit.libreoffice.org/43134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Rename and move SAL_U/W to o3tl::toU/WMike Kaganski2017-10-057-58/+63
| | | | | | | | | | | | | | | | Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* add << operator for css::uno::ExceptionNoel Grandin2017-10-045-8/+8
| | | | | | | Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* Replace more reinterpret_cast with SAL_W/SAL_UMike Kaganski2017-10-031-1/+1
| | | | | | | Change-Id: Ia632e4083222ad9e7f17c2ad0d0825f189c700cc Reviewed-on: https://gerrit.libreoffice.org/43071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#39468 Translate German comments (leftovers)Johnny_M2017-10-011-2/+2
| | | | | | | Change-Id: I9952c560547b0668d8216edba1486638fa41e553 Reviewed-on: https://gerrit.libreoffice.org/42990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:flatten (clang-cl, extensions)Stephan Bergmann2017-10-012-82/+69
| | | | | | | Change-Id: I2aceee910e8e39a7c4ebb89282447dc4b26ad3cb Reviewed-on: https://gerrit.libreoffice.org/42978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Translate German comments and debug strings (leftovers)Johnny_M2017-09-301-2/+2
| | | | | | | Change-Id: I4ab8fbae47037f6e21c51713d1c51aaa5dc61f40 Reviewed-on: https://gerrit.libreoffice.org/42967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Use SAL_W/SAL_U instead of reinterpret_cast btwn wchar_t* and sal_Unicode*Mike Kaganski2017-09-307-57/+55
| | | | | | | | | | This is type-safe, and allows to catch cases where a source type is changed for some reason, but reinterpret_cast masks that Change-Id: Ib64b6fa2e22d94a6bba890f0ccc3e20325c6f0a1 Reviewed-on: https://gerrit.libreoffice.org/42961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Use explicit function names for fooA/fooW WinAPI; prefer fooWMike Kaganski2017-09-303-16/+16
| | | | | | | | | | | | | | | | | | We should only use generic foo function name when it takes params that are also dependent on UNICODE define, like LoadCursor( nullptr, IDC_ARROW ) where IDC_ARROW is defined in MSVC headers synchronised with LoadCursor definition. We should always use Unicode API for any file paths operations, because otherwise we will get "?" for any character in path that is not in current non-unicode codepage, which will result in failed file operations. Change-Id: I3a7f453ca0f893002d8a9764318919709fd8b633 Reviewed-on: https://gerrit.libreoffice.org/42935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* readonly xBibCursor in BibDataManagerNoel Grandin2017-09-272-5/+0
| | | | | | | | | | | | since commit 95117e7fefa9ae82431dcdffd1e58495730f6f54 Date: Mon Sep 18 15:18:56 2000 +0000 initial import Change-Id: Ia7e57f1e0e2b19c6eb5b66ada9cc062f202b453a Reviewed-on: https://gerrit.libreoffice.org/42833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Rename GetSelectEntryData -> GetSelectedEntryDataSamuel Mehrbrodt2017-09-251-1/+1
| | | | | | | Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173 Reviewed-on: https://gerrit.libreoffice.org/42285 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Rename GetSelectEntryCount -> GetSelectedEntryCountSamuel Mehrbrodt2017-09-256-14/+14
| | | | | | | Change-Id: I405b347b404ed0acb3b6a0204e0b914a7698ce25 Reviewed-on: https://gerrit.libreoffice.org/42284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Windows: avoid dependence on UNICODE define; prefer W functionsMike Kaganski2017-09-229-116/+130
| | | | | | | Change-Id: I95b90128e93f0d88ed73601bcc5a7ca9279d4cf1 Reviewed-on: https://gerrit.libreoffice.org/42560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:flatten in editeng..extensionsNoel Grandin2017-09-212-15/+11
| | | | | | | Change-Id: I2b68f5640471ea827c09af1b5a319fb526a53b4b Reviewed-on: https://gerrit.libreoffice.org/42579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt2017-09-216-10/+10
| | | | | | | Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Rename GetSelectEntry -> GetSelectedEntrySamuel Mehrbrodt2017-09-217-16/+16
| | | | | | | Change-Id: Ibb7d8c59c0e61b0e87455bd78f241d8691dd9dce Reviewed-on: https://gerrit.libreoffice.org/42282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Some more WIN32_LEAN_AND_MEANMike Kaganski2017-09-183-0/+9
| | | | | | | Change-Id: Iadb0ebb66809c192fb817b8c7cf2f8cdb4d0b874 Reviewed-on: https://gerrit.libreoffice.org/42419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Use even more WIN32_LEAN_AND_MEANMike Kaganski2017-09-181-0/+3
| | | | | | | Change-Id: I538fe5b41156366e0e87b3a93e58a3947afd18f5 Reviewed-on: https://gerrit.libreoffice.org/42398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* use more default copy ctorsJochen Nitschke2017-09-171-11/+0
| | | | | | | | | | if ctor should be private or protected explicitly default them. boost::optional has copy ctors, so use them. Change-Id: If1855626b297e739afef0dc5ad57958f7ad199bc Reviewed-on: https://gerrit.libreoffice.org/42363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Make clamping of aParams.format work reliablyStephan Bergmann2017-09-111-1/+8
| | | | | | | | | | | | | ...regardless of the details of the type of aParams.format, SANE_Frame, which the SANE documentation at <http://sane.alioth.debian.org/html/doc012.html> is vague about. (It could, e.g., validly have negative values in an implementation where SANE_Frame is an enum with additional, negative enumerators besides the required SAN_FRAME_GRAY...BLUE.) Before 2687a5aca143c53c364cb44993ca601b8dd1c65e "-Werror,-Wtautological-compare with latest clang" the code had explicitly checked for aParams.format < 0. Change-Id: Ie2a19e67e942841c5a52b862cb427bac77d6ebb2
* -Werror,-Wtautological-compare with latest clangNoel Grandin2017-09-081-1/+1
| | | | | | | | | Change-Id: I073f1893b759f8d31a24187f542b031b86dc4b8a error: comparison of unsigned enum expression >= 0 is always true [-Werror,-Wtautological-compare] Reviewed-on: https://gerrit.libreoffice.org/42103 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* set parent for file dialog helperCaolán McNamara2017-09-082-7/+6
| | | | | | | | Change-Id: I3994ee48dcb5b2732cb27cb9ccb54926abf0828a Reviewed-on: https://gerrit.libreoffice.org/42048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* extensions: GCC 7 -Werror=format-truncationMichael Stahl2017-09-071-1/+13
| | | | | | | | | | | Given a valid DateTime, the "buffer" is too small by 1 because Year can be negative with 4 digits. Most of the problem is that invalid DateTimes would overflow by up to 14 bytes; throw IllegalArgumentException for obviously invalid DateTime. Change-Id: I8af109425d5681b1b28454917664401a5404f251
* new loplugin:redundantpointeropsNoel Grandin2017-09-041-1/+1
| | | | | | | Change-Id: I8428d86ea9628d69c2b40b36feee3da428a9fe1d Reviewed-on: https://gerrit.libreoffice.org/41787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparams: extensions (clang-cl)Stephan Bergmann2017-08-318-17/+17
| | | | Change-Id: I1665228a622b18757951b725467933699f9871ae
* Drop gratuitous initial :: from comphelper::ProfileZoneTor Lillqvist2017-08-251-1/+1
| | | | Change-Id: Iae7d86b857d0563d9ed9d9b4187e009554698412
* convert message box style bits to scoped enumNoel Grandin2017-08-232-2/+2
| | | | | | | | | | | | | and fix harmless bug in ImpSVGDialog::ImpSVGDialog, which there since commit 6456f1d81090dd5fe44455c09ae3ede7ec6ac38a Date: Fri Feb 4 14:52:54 2011 +0100 ka102: added/removed files for SVG import and module cleanup Change-Id: I66b2ec2b029431ab453e54e962863e4ed7d78962 Reviewed-on: https://gerrit.libreoffice.org/41412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typosAndrea Gelmini2017-08-211-1/+1
| | | | | | | Change-Id: I3f3abc3c6e12536d4bc38f0c676d5fc20532a1e3 Reviewed-on: https://gerrit.libreoffice.org/41370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#105538 Download update to Downloads folder on WindowsTakeshi Abe2017-08-182-6/+8
| | | | | | | | | instead of Desktop. Change-Id: Ib88b23afdd0b836184b7f0a3f501983137a1405d Reviewed-on: https://gerrit.libreoffice.org/40692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* loplugin:oncevar (clang-cl)Stephan Bergmann2017-08-181-1/+1
| | | | Change-Id: I36c97d99d268b0ebedfd0eebc4722cabc6e51220
* Fix typosAndrea Gelmini2017-08-181-1/+1
| | | | | | | Change-Id: I795059109e23800987cda6f04c58ab18c488ad07 Reviewed-on: https://gerrit.libreoffice.org/41242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typosAndrea Gelmini2017-08-171-1/+1
| | | | | | | Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* remove unnecessary use of OUString::getStrNoel Grandin2017-08-174-8/+4
| | | | | | | Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4 Reviewed-on: https://gerrit.libreoffice.org/38114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin2017-08-171-1/+1
| | | | | | | Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert std::map::insert to std::map::emplace IINoel Grandin2017-08-112-6/+4
| | | | | | | Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331 Reviewed-on: https://gerrit.libreoffice.org/41019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert std::map::insert to std::map::emplaceNoel Grandin2017-08-118-19/+17
| | | | | | | | | which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* desktop,extensions: updater: only allow redirects to HTTP/HTTPSMichael Stahl2017-08-091-0/+2
| | | | | | Configure curl to prevent redirects to other protocols. Change-Id: Ied73b3d9a062ea6e0a1d594f4c12162dffd6c4a7
* loplugin:unusedmethodsNoel Grandin2017-08-081-3/+0
| | | | | | | | Change-Id: Id66cf12e3a59aeed1b9a7a111b841e30b248635b Reviewed-on: https://gerrit.libreoffice.org/40876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* split out VclBuilder static methodsCaolán McNamara2017-08-021-1/+1
| | | | Change-Id: Ic94b39351c9a6131fb61883a98ae9e3ee60ad119
* move resmgr to unotoolsCaolán McNamara2017-08-0113-127/+26
| | | | | | | | | and the vast majority of translations is to the ui language so default ctor with that arg and now drop OModuleResourceClient Change-Id: I3b85a560ffdfe5f019c2271ac56a5fe4a361522b
* loplugin:constparams in extensions,scripting,sdextNoel Grandin2017-07-317-11/+11
| | | | | | | Change-Id: I3d47e144db17358bf6e2e5e3f4ad29de888c01b1 Reviewed-on: https://gerrit.libreoffice.org/40583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:oncevarNoel Grandin2017-07-313-11/+10
| | | | | | | | | extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparams handle constructorsNoel Grandin2017-07-285-6/+6
| | | | | | | | | | had to change the structure of the plugin considerably, was too messy to structure it to do the calculations on a per-function basis Change-Id: I4edee7735f726101105c607368124a08dba21086 Reviewed-on: https://gerrit.libreoffice.org/40516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* fix propcontroller extension regressionNoel Grandin2017-07-252-6/+33
| | | | | | | | | | since cmmit 00657aef09d854c74fb426a935a3e8b1fc390bb0 "migrate to boost::gettext" Change-Id: I9127203ac86a87b916980186efa6f8877868955b Reviewed-on: https://gerrit.libreoffice.org/40415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more comphelper::InitAnyPropertySequenceNoel Grandin2017-07-251-12/+7
| | | | | | | | | | | | Found with: git grep -n -A10 'Sequence.*Any' -- *.cxx | grep -B5 -w PropertyValueProvider and: git grep -n 'Sequence.*Any.*( *&' Change-Id: Icb18c98bdd3f8352817e443ff78de5df042859ad Reviewed-on: https://gerrit.libreoffice.org/40389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* coverity#1242860 Unused value + loplugin:casttovoidCaolán McNamara2017-07-241-2/+5
| | | | Change-Id: I80725fbde6fbf29d47f0b462ff22e6be4fbebaca
generated by cgit (git 2.34.1) at 2024-06-23 10:02:02 +0000