summaryrefslogtreecommitdiffstats
path: root/extensions/source
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:constparams in extensions,scripting,sdextNoel Grandin2017-07-317-11/+11
| | | | | | | Change-Id: I3d47e144db17358bf6e2e5e3f4ad29de888c01b1 Reviewed-on: https://gerrit.libreoffice.org/40583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:oncevarNoel Grandin2017-07-313-11/+10
| | | | | | | | | extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparams handle constructorsNoel Grandin2017-07-285-6/+6
| | | | | | | | | | had to change the structure of the plugin considerably, was too messy to structure it to do the calculations on a per-function basis Change-Id: I4edee7735f726101105c607368124a08dba21086 Reviewed-on: https://gerrit.libreoffice.org/40516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* fix propcontroller extension regressionNoel Grandin2017-07-251-5/+33
| | | | | | | | | | since cmmit 00657aef09d854c74fb426a935a3e8b1fc390bb0 "migrate to boost::gettext" Change-Id: I9127203ac86a87b916980186efa6f8877868955b Reviewed-on: https://gerrit.libreoffice.org/40415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more comphelper::InitAnyPropertySequenceNoel Grandin2017-07-251-12/+7
| | | | | | | | | | | | Found with: git grep -n -A10 'Sequence.*Any' -- *.cxx | grep -B5 -w PropertyValueProvider and: git grep -n 'Sequence.*Any.*( *&' Change-Id: Icb18c98bdd3f8352817e443ff78de5df042859ad Reviewed-on: https://gerrit.libreoffice.org/40389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* coverity#1242860 Unused value + loplugin:casttovoidCaolán McNamara2017-07-241-2/+5
| | | | Change-Id: I80725fbde6fbf29d47f0b462ff22e6be4fbebaca
* coverity#1242860 Unused valueCaolán McNamara2017-07-241-1/+1
| | | | Change-Id: I0749fc82ebdf45b3cb022d3989df774e73e715bd
* remove now unnecessary comphelper::OModuleClient stuffNoel Grandin2017-07-2311-18/+48
| | | | | | | | | after the great gettext migration of 2017 Change-Id: I704389b1ae1fb34dae0429c98cbfc89c2d3b8e27 Reviewed-on: https://gerrit.libreoffice.org/40322 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Removed duplicated includesAndrea Gelmini2017-07-232-2/+0
| | | | | | | | | | Mainly about "core_resource.hxx" and "strings.hrc". It passed "make check" on Linux. Change-Id: I994420d5e33d02b64929f8a51c548a7322d88a79 Reviewed-on: https://gerrit.libreoffice.org/40311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:unusedfields in extensions..frameworkNoel Grandin2017-07-226-20/+0
| | | | | | | Change-Id: I687c67c8f3c0e03c6ab2da0a93a9e62f0caf12cd Reviewed-on: https://gerrit.libreoffice.org/40292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Eliminate DateTime::operator+=() and -=() with POD typesEike Rathke2017-07-211-2/+2
| | | | | | | | | | And make some tools::Time conversion ctors explicit to catch more oddities like automatic conversion from sal_Int64 that might be unintentional. Change-Id: If275297d86d6657544c056a712b862523e310e44 Reviewed-on: https://gerrit.libreoffice.org/40275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
* de-hrc various thingsCaolán McNamara2017-07-2121-53/+26
| | | | | | | | | | | | e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
* migrate to boost::gettextCaolán McNamara2017-07-2180-3843/+248
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
* Change nonsense non-const Date* GetNullDate() to const Date&Eike Rathke2017-07-181-2/+2
| | | | | | | | | | | * first, a non-const Date* may leave the impression that one could change the NullDate through the pointer, which is only partly successful; luckily no one did that * second, there is always a NullDate so checking for nullptr is superfluous * third, the pointer was dereferenced (maybe after a check) everywhere to obtain the NullDate, luckily.. Change-Id: I3c3a788ba0336596ac6bde4c96e77a0cdb7a4a95
* loplugin:oncevar: extensions (clang-cl)Stephan Bergmann2017-07-171-2/+2
| | | | Change-Id: Id82847d72a106976339fd64685a9029900a862bd
* use more OUString::operator== in dbaccess..filterNoel Grandin2017-07-137-9/+9
| | | | | | | Change-Id: Ib7b4f2b2403ce766a7db2f6ffc118468e7677776 Reviewed-on: https://gerrit.libreoffice.org/39889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:oncevar: empty strings: extensionsStephan Bergmann2017-07-131-2/+1
| | | | Change-Id: I83fe6f3a918cef2da0085858b63ef86005a61619
* use more range-for on uno::SequenceNoel Grandin2017-07-111-8/+6
| | | | | | | Change-Id: Ifad32425d79be5a22d33d721bdc5fb993f699759 Reviewed-on: https://gerrit.libreoffice.org/39763 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* teach unnecessaryparen loplugin about identifiersNoel Grandin2017-07-104-5/+5
| | | | | | | Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove nullptr checks on STL search result iteratorsJochen Nitschke2017-07-071-1/+1
| | | | | | | | | | | | | | | | | results are in the range of first_iterator to last_iterator. If one of those is nullptr the algorithm would fail anyway. This removes some impossible checks in sw/source/core/unocore/unochart.cxx: SwChartDataProvider::detectArguments. A sorted range still holds the same values and has the same length as the original range. Replacing raw pointers eases reading this code. Change-Id: If96bd11e9167488346a57e9e08507ac42338d3cd Reviewed-on: https://gerrit.libreoffice.org/39683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* C++11 remove std::binary_function bases from functorsJochen Nitschke2017-07-075-18/+4
| | | | | | | | | | | | | | | | | | | std::binary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::binary_function base class was used by deprecated std::bind2nd, this was solved in individual commits. The members first_argument_type and second_argument_type were used in chart2/source/controller/dialogs/DataBrowserModel.cxx: DataBrowserModel::implColumnLess and are inlined in this commit. Change-Id: I60ded60a8d4afd59e15ac15a58e18d2498c9be5a Reviewed-on: https://gerrit.libreoffice.org/39659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use OString::operator== in preference to ::equalsNoel Grandin2017-07-062-3/+3
| | | | | | | Change-Id: Ib291521963a791a9c6175964571e9d9895072acf Reviewed-on: https://gerrit.libreoffice.org/39646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more begin()/end() for SequenceNoel Grandin2017-07-066-33/+19
| | | | Change-Id: I399be6b6ef7a6ce01e883569a177c0969bc29c69
* new loplugin unnecessaryparenNoel Grandin2017-07-052-2/+2
| | | | | | | Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec Reviewed-on: https://gerrit.libreoffice.org/39549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:casttovoid (clang-cl): extensionsStephan Bergmann2017-07-052-4/+2
| | | | Change-Id: I91eeddd37a745592a9aa0f0827f65db257e1dfad
* tdf#96505 Get rid of cargo cult "long" integer literalsJens Carl2017-07-044-11/+11
| | | | | | | | | Remove "long" integer literals in extensions/ Change-Id: I2eb5daa178ec9adcaddb999bad410aff0e94220c Reviewed-on: https://gerrit.libreoffice.org/39149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* loplugin:unusedfields in editengNoel Grandin2017-07-043-32/+2
| | | | | | | Change-Id: I9806d87028a11a8103c35004c87b5098ca591409 Reviewed-on: https://gerrit.libreoffice.org/39495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use begin()/end() when working with SequenceNoel Grandin2017-07-033-6/+5
| | | | | | | Change-Id: Icf9da6a24d72c073338f6fbb513d7250b3898015 Reviewed-on: https://gerrit.libreoffice.org/39469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:oncevar (clang-cl): extensionsStephan Bergmann2017-07-034-35/+17
| | | | Change-Id: I70cac146d09f015db3f7889f3cdd46c00c45c41a
* loplugin:sallogareas (clang-cl)Stephan Bergmann2017-07-031-1/+1
| | | | Change-Id: I0da74386a01c9a2db6436c9cd30aac204eb2ce73
* C++11 remove std::unary_function bases from functorsJochen Nitschke2017-07-036-15/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | std::unary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::unary_function base class was used in 3 places: * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole is used in a std::not1 function helper who uses the members return_type and argument_type. - replace deprecated std::not1 with a lambda * chart2/source/tools/ModifyListenerHelper.cxx: lcl_weakReferenceToSame used the argument_type member in the operator() parameter. - inline the parameter type. * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement used result_type and argument_type in operator(). - inline the types Also fix compile error with gcc about finding std::for_each. Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f Reviewed-on: https://gerrit.libreoffice.org/39358 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:casttovoid: extensionsStephan Bergmann2017-07-0213-29/+7
| | | | Change-Id: I5922341e0bb74da854307e6cb0a004395f3e8851
* hresult1 is unusedStephan Bergmann2017-06-301-5/+1
| | | | | | | ...since ffa37355709b95c5b8951f3a46e2b7952eee84d2 "extensions: remove code specific to oleautobridge2" Change-Id: I13042dcf071e510fc5e51627562e35f5c9f1de54
* loplugin:oncevarStephan Bergmann2017-06-301-1/+3
| | | | Change-Id: I3c292591aa178b05d8c9aae51031c7a9fd6817a4
* loplugin:oncevarStephan Bergmann2017-06-291-2/+1
| | | | Change-Id: I4efa87035436e5f2f5c2b636a2b93954d61704f3
* extensions: remove COMPMOD preprocessor definesJochen Nitschke2017-06-2618-37/+34
| | | | | | | | | | | | | | | COMPMOD_RESPREFIX=abp was unused ever since initial commit in 2001. COMPMOD_NAMESPACE was used to set the namespace name qualifier of the helper in componentmodule.hxx to the extension's namespace name. I don't see why this is necessary as the helper is always compiled in a separate extension library. Change-Id: I287607008db3dc0ebc32731536747a921c91807d Reviewed-on: https://gerrit.libreoffice.org/39184 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* s/catched/caughtNoel Grandin2017-06-262-2/+2
| | | | | | | Change-Id: I7ea6977a9749e86f8058b78cdb91cd2c62da8264 Reviewed-on: https://gerrit.libreoffice.org/39164 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* simplify some string handling in tracing callsNoel Grandin2017-06-231-4/+1
| | | | | | | Change-Id: I0fb76562429e691400a02216019c7f96791cf9b3 Reviewed-on: https://gerrit.libreoffice.org/39159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:oncevar editeng..extensionsNoel Grandin2017-06-237-34/+15
| | | | | | | Change-Id: I3a63e3e3b873ef8a2d708d39be084124a6ad1346 Reviewed-on: https://gerrit.libreoffice.org/39153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Make SfxItemSet ranges correct by construction: Fix static casesStephan Bergmann2017-06-191-3/+5
| | | | | | | | | | ...with the aid of an extended compilerplugins/clang/store/sfxitemsetrewrite.cxx (which in turn needed a small addition to compilerplugins/clang/check.hxx). Enable svl::detail::validGap check for the static case, but keep it disabled for now for the dynamic case. Change-Id: I4846ba8e99aff94a86518e2cb5044e575093386e
* remove unused osl/mutex.hxx includesJochen Nitschke2017-06-187-9/+0
| | | | | | | Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* Make SfxItemSet ranges correct by constructionStephan Bergmann2017-06-161-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow-up to 45a7f5b62d0b1b21763c1c94255ef2309ea4280b "Keep WID ranges sorted, and join adjacent ones". While SfxItemSet::MergeRange relies on the m_pWhichRanges being sorted (and, under DBG_UTIL, asserts if they are not), the various SfxItemSet constructors curiously only check (via assert or DBG_ASSERT) that each individual range has an upper bound not smaller than its lower bound. Arguably, all SfxItemSet instances should fulfill the stronger guarantees required and checked by MergeRange. And in many cases the ranges are statically known, so that the checking can happen at compile time. Therefore, replace the two SfxItemSet ctors taking explicit ranges with two other ctors that actually do proper checking. The (templated) overload taking an svl::Items struct should be used in all cases where the range values are statically known at compile time, while the overload taking a std::initializer_list<Pair> is for the remaining cases (that can only do runtime checking via assert). Most of those latter cases are simple cases with a single range covering a single item, but a few are more complex. (At least some of the uses of the existing SfxItemSet overload taking a const sal_uInt16* pWhichPairTable can probably also be strengthened, but that is left for another day.) This commit is the first in a series of two. Apart from the manual changes to compilerplugins/clang/store/sfxitemsetrewrite.cxx, include/svl/itemset.hxx, and svl/source/items/itemset.cxx, it only consists of automatic rewriting of the relevant SfxItemSet ctor calls (plus a few required manual fixes, see next). But it does not yet check that the individual ranges are properly sorted (see the TODO in svl::detail::validGap). That check will be enabled, and the ensuing manual fixes will be made in a follow-up commit, to reduce the likelyhood of accidents. There were three cases of necessary manual intervention: * sw/source/core/unocore/unostyle.cxx uses eAtr of enum type RES_FRMATR in braced-init-list syntax now, so needs explicit narrowing conversion to sal_uInt16. * In sw/source/uibase/uiview/formatclipboard.cxx, the trailiing comma in the definition of macro FORMAT_PAINTBRUSH_FRAME_IDS needed to be removed manually. * In svx/source/svdraw/svdoashp.cxx, svx/source/svdraw/svdotext.cxx, sw/source/uibase/app/docstyle.cxx, sw/source/uibase/shells/frmsh.cxx, sw/source/uibase/shells/grfsh.cxx, and sw/source/uibase/shells/textsh1.cxx, some comments had to be put back (see "TODO: the replaced range can contain relevant comments" in compilerplugins/clang/store/sfxitemsetrewrite.cxx). A few uses of the variadic form erroneously used nullptr instead of 0 for termination. But this should have been harmless even if promoted std::nullptr_t is larger than promoted sal_uInt16, assuming that the part of the nullptr value that was interpreted as sal_uInt16/promoted int was all-zero bits. Similarly, some uses made the harmless error of using 0L instead of 0. Change-Id: I2afea97282803cb311b9321a99bb627520ef5e35 Reviewed-on: https://gerrit.libreoffice.org/38861 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* Profiling API: add ProfileZonesLászló Németh2017-06-161-0/+2
| | | | | | | Change-Id: Ie5669bd75d9b4be047d98402cb69ac313ab618df Reviewed-on: https://gerrit.libreoffice.org/38787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* use ERRCODE_NONE instead of 0Noel Grandin2017-06-142-4/+4
| | | | | | | | | peeling off a small chunk of my ErrCode strong_int conversion Change-Id: Idc89e8496083beed7608cba705cd981139eb7111 Reviewed-on: https://gerrit.libreoffice.org/38777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* cleanup unused css/frame/* includesJochen Nitschke2017-06-127-11/+0
| | | | | | | Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* coverity#1405937 rework to silence Uncaught exceptionCaolán McNamara2017-06-102-15/+8
| | | | Change-Id: I89be5a53b5282130fd399a17ebe1a03ea75009e5
* add COVERITY_NOEXCEPT_FALSECaolán McNamara2017-06-061-1/+1
| | | | | | | | | | | | to markup dtors that coverity warns might throw exceptions which won't throw in practice, or where std::terminate is an acceptable response if they do Change-Id: I32b94814e8245372e1d1dc36be0d81e3564042f4 Reviewed-on: https://gerrit.libreoffice.org/38318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Fix typosAndrea Gelmini2017-06-051-1/+1
| | | | | | | Change-Id: I9eb05432732a04e816946fbb13001df100a31f73 Reviewed-on: https://gerrit.libreoffice.org/38395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* cleanup unused css/inspection/ and css/reportdesign includesJochen Nitschke2017-06-031-1/+0
| | | | | | | Change-Id: I123522dc1df439898dab13c2259e4116e330ad99 Reviewed-on: https://gerrit.libreoffice.org/38367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Improved loplugin:redundantcast static_cast handling: extensionsStephan Bergmann2017-06-023-29/+29
| | | | Change-Id: I4320d9631977ed21245fc934368600c4c91668df
generated by cgit (git 2.34.1) at 2024-08-27 09:25:37 +0000