summaryrefslogtreecommitdiffstats
path: root/extensions/source/propctrlr
Commit message (Collapse)AuthorAgeFilesLines
* Resolves: tdf#107981 SID_FM_CTL_PROPERTIES colorbox needs a 'default' entryCaolán McNamara2017-05-301-28/+8
| | | | | | | | | | | | | | | we don't need MakeHexStr either, the colorbox will do that on its own Reviewed-on: https://gerrit.libreoffice.org/37898 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7539c77fd49889015ad3a952009e33fac5324df6) Change-Id: Ifad523092c0f15cd51d0d829790c0cec1c96bb53 Reviewed-on: https://gerrit.libreoffice.org/37905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit c05f35f4f56a1e65b92f4b1bc43b0fa6138d209c)
* Resolves: tdf#106461 use a row height of max of edit and listbox heightCaolán McNamara2017-03-281-4/+5
| | | | | | | | | | | | not just take the listbox because edits can be taller and result in overlaps Change-Id: I6067b384484d933727220febda723bc9e8c5e90b (cherry picked from commit 5013abeb191cdc6f8375f107a4d30abd802547d2) Reviewed-on: https://gerrit.libreoffice.org/35596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 910582360d2a2f0455841b2cd0c3cc2c7ed08344)
* loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin2017-02-183-4/+4
| | | | | | | | | | | | | | | Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e6ffb539ee232ea0c679928ff456c1cf97429f63)
* tdf#105467 new color widget doesn't support XStringListControlCaolán McNamara2017-01-261-1/+1
| | | | | | | | | | | so this threw and mangled the dialog. New color dialog doesn't need to be told the name of colors, it figures that out itself. Change-Id: I89382b6b26312fc90c967620c654ea611cbd9616 (cherry picked from commit d92b12604b644195328b89cb9355cd4fc4bc3e2d) Reviewed-on: https://gerrit.libreoffice.org/33501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* loplugin:datamembershadowNoel Grandin2016-11-181-1/+0
| | | | | | | Change-Id: I8a737a2f22c7be9630a1f7562b4309e687bb85f9 Reviewed-on: https://gerrit.libreoffice.org/30948 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:countusersofdefaultparams in editeng..rscNoel Grandin2016-11-111-1/+1
| | | | Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
* update vclwidget loplugin to find ref-dropping assigmentNoel Grandin2016-11-111-1/+1
| | | | | | | | | | Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* make comphelper::containerToSequence a little smarterNoel Grandin2016-11-091-2/+1
| | | | | | | | | So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:expandablemethods in extensionsNoel Grandin2016-11-0810-94/+29
| | | | | | | Change-Id: I93a770933de86146de1d25db9d596615916c3e28 Reviewed-on: https://gerrit.libreoffice.org/30689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Revert "Reverts a commit series that cripple windows ci."Caolán McNamara2016-11-074-121/+36
| | | | | | | | | | | | | | | with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Reverts a commit series that cripple windows ci.Norbert Thiebaud2016-11-054-36/+121
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
* extensions leaks out details of Color Selector, patch it upCaolán McNamara2016-11-044-121/+36
| | | | | | and rebase it on SvxColorListBox Change-Id: I3afef689ab0dc3c34e465810d82bf21797907558
* loplugin:oncevar in desktop..filterNoel Grandin2016-11-041-7/+2
| | | | | | | Change-Id: I21c47cacbcd68f06eea7ccbbfa6d04fc65e2b7ee Reviewed-on: https://gerrit.libreoffice.org/30564 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu2016-11-041-8/+1
| | | | | | | | Change-Id: I619cb50c3475519921ffd318b32875ae4ff2c0b8 Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* style fixes for cppcheck noExplicitConstructorJochen Nitschke2016-11-013-5/+5
| | | | | | | Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* update vclwidgets plugin to check local variablesNoel Grandin2016-10-311-1/+1
| | | | | | | Change-Id: I91f7fc6b8419c0ed82194726eeb4c4657e998f22 Reviewed-on: https://gerrit.libreoffice.org/30428 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert std::unique_ptr<VclAbstractDialog> to VclPtrNoel Grandin2016-10-281-1/+1
| | | | Change-Id: Ifdd2a0599efd701def02b4a4d2a1c489cb1b27fa
* loplugin:expandablemethods in svtoolsNoel Grandin2016-10-271-3/+0
| | | | | | | Change-Id: I126cc87c890867c3e762f86969a20d64aef63108 Reviewed-on: https://gerrit.libreoffice.org/30314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:expandablemethodds in editeng..extensionsNoel Grandin2016-10-197-29/+4
| | | | | | | Change-Id: Ibe1929d74ff460955e39f2ccce3056b2051ddf08 Reviewed-on: https://gerrit.libreoffice.org/30013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* replace <<= with assign for <<= with rhs AnyJochen Nitschke2016-10-181-1/+1
| | | | | | | | | found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* drop unused RID_RSC_BUTTON_IMAGES resourceCaolán McNamara2016-10-136-45/+1
| | | | Change-Id: If85a3491c3cb6ebb05a82e1c732083d99e91d6e8
* move this monstrosity to the last place its usedCaolán McNamara2016-10-132-2/+0
| | | | Change-Id: I4691f20143406249afc8da1a6dfa901224f4a62d
* remove (yet yet another) StringListResource implementationCaolán McNamara2016-10-133-464/+216
| | | | Change-Id: Ifaf89badfc339f8253a629c6960df8a943b8cce5
* remove StringListResource in favour of ResStringArray...Caolán McNamara2016-10-126-41/+67
| | | | | | | and turn local resources used as lists of strings into string array resources Change-Id: I9d67a790659963bca87aacba1c052d7b244b4e21
* ImageList just reads and discards the MaskColor, so drop itCaolán McNamara2016-10-061-1/+0
| | | | Change-Id: I243e739fea28e3f38b91534182cc54c2aa660f0e
* convert MapUnit to scoped enumNoel Grandin2016-10-055-10/+10
| | | | | | | | | | | | I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann2016-10-0526-57/+57
| | | | | | | | | ...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
* remove unused parameterJochen Nitschke2016-09-251-1/+1
| | | | | | | | | | bTotalRanges is never used. SFX_ITEMSET_NO_DEFAULT_CTOR is no where else used. Change-Id: Ia35ea875f16a8ca04c2173b01074113f1825f565 Reviewed-on: https://gerrit.libreoffice.org/29248 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Make OGenericUnoDialog::destoryDialog non-virtualStephan Bergmann2016-09-152-9/+3
| | | | | | | | | | | | ...it is only ever called: * either from dtors, where the virtual-ness doesn't acutally help (and would trigger loplugin:fragiledestructor if that were enabled) * or, in module filter, from executeDialog members of (final) classes directly derived from OGenericUnODialog without overriding destroyDialog Change-Id: If9a7370385a27952189423e5632b3f01e18ddbb5
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-1343-48/+48
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* loplugin:constantparam in extensions..lotuswordproNoel Grandin2016-09-127-18/+18
| | | | | | | Change-Id: Ifb30d5d53536045638d872761626a1b60fa52dad Reviewed-on: https://gerrit.libreoffice.org/28831 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* convert ScrollType to scoped enumNoel Grandin2016-09-052-3/+3
| | | | Change-Id: I6dd02d4f7df028dada6cfd5d767a6ec1b1c1efe1
* convert ExtDateFieldFormat to scoped enumNoel Grandin2016-09-051-1/+1
| | | | Change-Id: I717e5e727ee0e2b6d732ecc6a432c70926654902
* tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu2016-08-262-6/+5
| | | | | | | Change-Id: I3099818283a9801976288d0efa67a8711106f376 Reviewed-on: https://gerrit.libreoffice.org/28360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* cppcheck: passedByValueCaolán McNamara2016-08-181-1/+1
| | | | Change-Id: I3ffcfe1294a1cbb06aadd3a1a79e9259876e38cc
* tdf#100782 have XPropertyList hold unique_ptrJochen Nitschke2016-08-151-1/+1
| | | | | | | Change-Id: I928f297e1be76b965898d83cb3dd2e79b23b7974 Reviewed-on: https://gerrit.libreoffice.org/28095 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:countusersofdefaultparams in editeng..fpickerNoel Grandin2016-08-053-7/+7
| | | | | | | Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68 Reviewed-on: https://gerrit.libreoffice.org/27897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* improve passstuffbyref return analysisNoel Grandin2016-07-272-2/+2
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* masses of MessBoxes not being disposed promptlyCaolán McNamara2016-07-261-1/+1
| | | | | | | | | | | | | | | | since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
* new loplugin unnecessary overrideNoel Grandin2016-07-151-16/+0
| | | | | | | Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann2016-07-072-2/+2
| | | | Change-Id: I9bc14b4df6bdda68bae44a1972e6b412fa6adccb
* comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin2016-07-042-4/+4
| | | | | | | | | convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* compilerplugins: add OWeakObject::release() override checkMichael Stahl2016-06-241-3/+2
| | | | | | | Change-Id: I767857545d7c91615cf162790c04f0016de9fdf6 Reviewed-on: https://gerrit.libreoffice.org/26555 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* Fix simple typo in parameter nameMuhammet Kara2016-06-181-5/+5
| | | | | | | Change-Id: I8c4a5e701c20c70c7df091a34efb38936ee59f9d Reviewed-on: https://gerrit.libreoffice.org/26420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
* remove unused constants in HRC filesNoel Grandin2016-06-061-2/+0
| | | | | | | Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1 Reviewed-on: https://gerrit.libreoffice.org/25817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Convert SelectionMode to scoped enumNoel Grandin2016-05-302-2/+2
| | | | | | | Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1 Reviewed-on: https://gerrit.libreoffice.org/25611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#34465 remove calls to SfxItemSet::Put(const SfxPoolItem&, sal_uInt16)Noel Grandin2016-05-271-11/+11
| | | | | | | | | | and put an assert in SfxPoolItem::SetWhich() so nothing new creeps in. Change-Id: I6497650fa61ffb2b6941ffff2d471c8f117be1df Reviewed-on: https://gerrit.libreoffice.org/24324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* (nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara2016-05-253-9/+3
| | | | | | | | | The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
* Fix typosAndrea Gelmini2016-05-251-1/+1
| | | | | | | Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* update unusedmethods plugin to deal with constructorsNoel Grandin2016-05-182-4/+0
| | | | | | | | | | and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-02 01:39:19 +0000