summaryrefslogtreecommitdiffstats
path: root/eventattacher
Commit message (Collapse)AuthorAgeFilesLines
* Use hasElements to check Sequence emptiness in [e-i]*Arkadiy Illarionov2019-05-311-1/+1
| | | | | | | | | Similar to clang-tidy readability-container-size-empty Change-Id: I79e31919db8f4132216f09a7868d18835eeb154b Reviewed-on: https://gerrit.libreoffice.org/71795 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#42949 Fix IWYU warnings in: animations/ eventattacher/ i18nutil/Gabor Kelemen2019-05-232-2/+4
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I23a6d485ee1ca0bc3801bcc1a6d748b8ed2b490c Reviewed-on: https://gerrit.libreoffice.org/72634 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#120703 PVS: remove redundant static castsMike Kaganski2019-02-121-6/+6
| | | | | | | | | | V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I5fee1c4bebd1972fbb5e43da37149d4e2ff6ce0d Reviewed-on: https://gerrit.libreoffice.org/67664 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:indentation in editeng..extensionsNoel Grandin2019-02-081-1/+1
| | | | | | | Change-Id: If7d7c400fb5d24e48b6cd02b364a8ac7fa23505d Reviewed-on: https://gerrit.libreoffice.org/67538 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* New loplugin:externalStephan Bergmann2018-09-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:simplifyconstruct in editeng..extensionsNoel Grandin2018-09-081-1/+1
| | | | | | | Change-Id: I646a24382554312d92a4a8746d5267767353a53f Reviewed-on: https://gerrit.libreoffice.org/60169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Improve re-throwing of UNO exceptionsNoel Grandin2018-05-251-2/+4
| | | | | | | | | | | | | | | | | (*) if we are already throwing a Wrapped*Exception, get the exception using cppu::getCaughtexception. (*) when catching and then immediately throwing UNO exceptions, use cppu::getCaughtException to prevent exception slicing (*) if we are going to catch an exception and then immediately throw a RuntimeException, rather throw a WrappedTargetRuntimeException and preserve the original exception information. Change-Id: Ia7a501a50ae0e6f4d05186333c8517fdcb17d558 Reviewed-on: https://gerrit.libreoffice.org/54692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* No need to keep these whitelisted functions decorated with SAL_CALLStephan Bergmann2017-12-141-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | The only effect SAL_CALL effectively has on LO-internal code is to change non- static member functions from __thiscall to __cdecl in MSVC (where all other functions are __cdecl by default, anyway). (For 3rd-party code, it could be argued that SAL_CALL is useful on function declarations in the URE stable interface other than non-static member functions, too, in case 3rd-party code uses a compiler switch to change the default calling convention to something other than __cdecl. But loplugin:salcall exempts the URE stable interface, anyway.) One could argue that SAL_CALL, even if today it effectively only affects non- static member functions in MSVC, could be extended in the future to affect more functions on more platforms. However, the current code would already not support that. For example, 3af500580b1c82eabd60335c9ebc458a3f68850c "loplugin:salcall fix functions" changed FrameControl_createInstance in UnoControls/source/base/registercontrols.cxx to no longer be SAL_CALL, even though its address (in ctl_component_getFacrory, in the same file) is passed to cppuhelper::createSingleFactory as an argument of type cppu::ComponentInstantiation, which is a pointer to SAL_CALL function. Change-Id: I3acbf7314a3d7868ed70e35bb5c47bc11a0b7ff6 Reviewed-on: https://gerrit.libreoffice.org/46436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:salcall fix functionsNoel Grandin2017-12-111-2/+2
| | | | | | | | | | since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:flatten in editeng..extensionsNoel Grandin2017-09-211-3/+2
| | | | | | | Change-Id: I2b68f5640471ea827c09af1b5a319fb526a53b4b Reviewed-on: https://gerrit.libreoffice.org/42579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* teach redundantcast plugin about functional castsNoel Grandin2017-05-301-1/+1
| | | | | | | Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Translate German comments and debug strings (leftovers in e... dirs)Johnny_M2017-05-201-1/+1
| | | | | | | | | | | | | Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "e". Additionally, following is translated: - A help string in /extensions/test/ole/EventListenerSample/EventListener/EventListener.idl Change-Id: Iff521ae1c4a616ed5a4ca79641a5cee6f380bee0 Reviewed-on: https://gerrit.libreoffice.org/37836 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
* cleanup osl/diagnose.h includesJochen Nitschke2017-05-091-1/+0
| | | | | | | | | | | | | | with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Fix typosAndrea Gelmini2017-05-071-1/+1
| | | | | | | | | To complete commit 076758857a98 Change-Id: I6424109e3aee8a3236e40168bdd98c725a7afafb Reviewed-on: https://gerrit.libreoffice.org/37306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2017-04-211-1/+0
| | | | | | | | | Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
* Add missing #includesStephan Bergmann2017-02-061-0/+4
| | | | | | | | | ...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
* Remove dynamic exception specificationsStephan Bergmann2017-01-261-55/+28
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* New loplugin:dynexcspec: Add @throws documentation, eventattacherStephan Bergmann2017-01-191-0/+7
| | | | Change-Id: I432f604c8b7a3b0e95f99b2982c302c2a94fd0fa
* loplugin:unnecessaryoverride (dtors) in eventattacherStephan Bergmann2016-12-051-7/+0
| | | | Change-Id: I548d90cb5aec077b78965f34b9275ef6aef315b0
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-131-1/+1
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2016-04-201-1/+1
| | | | Change-Id: I31a6e4ba81fab2843e5bc9a390fa7b0a5ec29411
* tdf#95857 Sort out German plurals ...danielt9982016-02-121-2/+2
| | | | | | | | | Made a start in removing the incorrect 'Infos' German plural Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60 Reviewed-on: https://gerrit.libreoffice.org/22301 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Remove excess newlinesChris Sherlock2016-02-091-8/+0
| | | | | | | | | | | | | | | | | | | A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* loplugin:unusedfields in eventattacherNoel Grandin2015-12-231-3/+0
| | | | Change-Id: I40c69865661cdca856118cab7c43cbb0eadfdc74
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-101-2/+2
| | | | Change-Id: Ifa481aa4bf87e7e2f93d1635864c8813f65da2f1
* yyyyyNoel Grandin2015-11-041-1/+1
| | | | Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
* use uno::Reference::set method instead of assignmentNoel Grandin2015-11-021-1/+1
| | | | | | | Change-Id: Ib297f2ab1c0c82703030f28d034d24f8a84a85ea Reviewed-on: https://gerrit.libreoffice.org/19732 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* no need to be so verbose in constructing uno::ReferenceNoel Grandin2015-11-011-1/+1
| | | | | | | Change-Id: I187a26e200e9ecaff2adaf53a2ba3f6e87346030 Reviewed-on: https://gerrit.libreoffice.org/19724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* cppcheck:noExplicitConstructorNoel Grandin2015-10-181-1/+1
| | | | | | | Change-Id: I2b68ba9e8caf7971efbba094ef060e72541bdccf Reviewed-on: https://gerrit.libreoffice.org/19426 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-121-17/+17
| | | | Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
* com::sun::star->css in extensions/Noel Grandin2015-10-011-4/+4
| | | | Change-Id: I64af9f5ae444e1f7bc6c0e8c29df383a9531dba9
* tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe2015-08-051-5/+4
| | | | | | | | | with the variadic variants in embedserv and eventattacher. Change-Id: I556ad208a7ffcf85c484e298cdbb1324b8a6a659 Reviewed-on: https://gerrit.libreoffice.org/17499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2015-06-081-7/+7
| | | | Change-Id: Ic657326fc9a73e97bf0a2ac650ce3700e0ca865b
* remove unnecessary use of void in function declarationsNoel Grandin2015-04-151-2/+2
| | | | | | | | | | | | | | | | ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
* loplugin:staticmethodsNoel Grandin2015-04-071-1/+1
| | | | Change-Id: Id3d6b50e07ea0850af18ab9bdadfffe0e4602aab
* Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann2015-03-311-1/+1
| | | | Change-Id: I4e882de3fba5998b4b3e16029b8b24c0290fb1c0
* V668 no sense in testing the result of new against nullCaolán McNamara2015-03-111-5/+1
| | | | Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
* Fix common typos. No automatic tools. Handmade…Andrea Gelmini2014-11-121-3/+3
| | | | | | | Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* coverity#983657 Uncaught exceptionCaolán McNamara2014-05-241-3/+2
| | | | Change-Id: I4feec3aeaf5f7b821a15f3b74f7b2df1f63a6681
* Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19Julien Nabet2014-05-221-4/+4
| | | | Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
* eventattacher: sal_Bool->boolNoel Grandin2014-04-221-3/+3
| | | | Change-Id: Iaf760bc747bfd8e16a52ba2047b0be8178b740cf
* Remove dead function declarationStephan Bergmann2014-04-141-1/+0
| | | | Change-Id: I638fade941d369f0b09a016cfdc23cf5c981b8f0
* Explicitly mark overriding destructors as "virtual"Stephan Bergmann2014-04-011-1/+1
| | | | | | | | It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
* First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann2014-03-261-17/+17
| | | | | | | ...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
* Introduce com.sun.star.beans.theIntrospection singletonStephan Bergmann2014-03-071-2/+2
| | | | | | ...deprecating com.sun.star.beans.Introspection (single-instance) service. Change-Id: Ica2e3a3541c7dcb1aab79222c5abf40d6988c882
* eventattacher: fix out of bounds string accessMiklos Vajna2014-02-271-1/+1
| | | | Change-Id: Ic1f7ac2b6c3f5a865b316a83d92a0f2ff7616f5c
* Remove visual noise from eventattacherAlexander Wilms2014-02-261-26/+25
| | | | | | | | | | Conflicts: eventattacher/source/eventattacher.cxx Change-Id: I7169992d453b1b2919cc8076fbd6803a95ee0565 Reviewed-on: https://gerrit.libreoffice.org/8258 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann2014-02-261-34/+34
| | | | Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
* Remove unneccessary commentsAlexander Wilms2014-02-231-4/+4
| | | | | | | Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann2013-12-171-2/+2
| | | | Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
generated by cgit (git 2.34.1) at 2024-05-03 15:53:15 +0000