summaryrefslogtreecommitdiffstats
path: root/embeddedobj
Commit message (Collapse)AuthorAgeFilesLines
* cppcheck: noExplicitConstructorCaolán McNamara2015-09-133-14/+11
| | | | Change-Id: I39194062ba68c4cb1ccc9b93c629f005ccd02497
* loplugin: defaultparamsNoel Grandin2015-08-141-1/+1
| | | | Change-Id: I455b200febc9939f3fb81597938b26c0e9eb5f74
* tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe2015-08-0315-30/+30
| | | | | | | | | with the variadic variants in embeddedobj. Change-Id: I60aad1267b664825f781c085fb33612bce3f7221 Reviewed-on: https://gerrit.libreoffice.org/17474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:unusedmethodsNoel Grandin2015-07-246-92/+12
| | | | | | | Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a Reviewed-on: https://gerrit.libreoffice.org/17312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Miscellaneous typosAdolfo Jayme Barrientos2015-07-211-8/+8
| | | | Change-Id: I5187364d420ab78c36a91632efab9c32951d867a
* for now show chart sidebarMarkus Mohrhard2015-07-161-2/+3
| | | | | | This is a hack that needs to be cleaned up later. Change-Id: I2772fe6ff8a4792d746a29653635d3eca4088e68
* fix indentationMarkus Mohrhard2015-07-161-3/+3
| | | | Change-Id: I4bceb79ed4adda085727dfcee1ba3573811e53b3
* fix indentationMarkus Mohrhard2015-07-161-2/+2
| | | | Change-Id: Ifda010d2a8f51c6981cac889bfaa1edaacd22df2
* coverity#1308586 Uncaught exceptionCaolán McNamara2015-06-292-2/+3
| | | | Change-Id: I86097e94dd47153a919bb7721376c5b98b50354e
* Fix typosAndrea Gelmini2015-06-281-1/+1
| | | | | | | Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Resolves: tdf#91683 Revert avoid activating chart objects...Caolán McNamara2015-06-232-15/+6
| | | | | | | | | | just to get their mapunit or set visual size. Will have to try something different here apparently This reverts commit 757f461ef12548af0be470f7c05ff67df3dc1314. (cherry picked from commit f2b3519c6b2aceacbe2fd9d53eb52dd36a356ecc)
* Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe2015-06-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* More helpful exception messageLionel Elie Mamane2015-06-171-1/+1
| | | | Change-Id: I63dcc98667ebfc94cc16407d283e65e1514d89fb
* Fix typosAndrea Gelmini2015-06-161-1/+1
| | | | | | | Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* remove unnecessary check for null when calling deleteNoel Grandin2015-06-151-5/+2
| | | | | | | | Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
* loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2015-06-082-22/+22
| | | | Change-Id: Ie55f464ef2eca344d3c1292713ded2710c47cc53
* tdf#67421: Prevent unloading objects due to cache fullMike Kaganski2015-05-191-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | When an object is added to OLE objects cache, when cache is full, old objects are tried to be unloaded. This triggers notifications that cause all loaded objects to become active, and to be added to cache (moved to front). As the new object already was added to front of the cache, later activity pushes it to back, until it is the last object in cache. The cache in this process is overfilled, so each next refresh tries to unload current last OLE object. So, in the end, this effectively unloads all cached OLE objects. This patch prevents this by first unloading last object, and then adding new object to front of cache. Also, removed needless creation of reference (makes at least 200 function calls for no reason). Change-Id: Ia903f4df101971df1b0b0148320fc8e45ac1e79c Reviewed-on: https://gerrit.libreoffice.org/15772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Use IMPL_LINK_NOARG[_TYPED] where applicableStephan Bergmann2015-05-101-1/+1
| | | | Change-Id: I70598072c1d492e360ef46dd7b5ef5a2fa4be495
* NOINSTANCE is implied now in IMPL_STATIC_LINK...Stephan Bergmann2015-05-101-1/+1
| | | | Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
* Replace IMPL_STATIC_LINK[_TYPED] with more useful variantsStephan Bergmann2015-05-101-1/+1
| | | | Change-Id: Ic91c8126b8e9a5a7eeed4c356b783c8bebccecf3
* embeddedobj: allow creating objects lacking a FileFormatVersion=6800 filterMiklos Vajna2015-05-043-0/+17
| | | | | | | dbaccess::ODatabaseDocument::loadFromStorage() is still not implemented, though. Change-Id: I1be11f2a2274f67dd0a11f96a718394d5f72605f
* embeddedobj: allow embedding objects lacking a FileFormatVersion=6800 filterMiklos Vajna2015-04-301-0/+4
| | | | | | The "own" filter of Base has FileFormatVersion=6200. Change-Id: I3bbd28ebcf4d517ea9cefe692b01b688358c51e8
* Remove unnecessary STATIC_LINK macroStephan Bergmann2015-04-291-1/+1
| | | | Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
* remove unnecessary use of void in function declarationsNoel Grandin2015-04-154-15/+15
| | | | | | | | | | | | | | | | ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
* loplugin:staticmethodsNoel Grandin2015-04-132-2/+2
| | | | Change-Id: I33a8ca28b0c3bf1c31758d93238e74927bebde9c
* Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann2015-04-014-12/+12
| | | | Change-Id: I1ee944679d509929e47218f88b6fe4be4905a202
* Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann2015-03-312-4/+4
| | | | Change-Id: Iad5d2858976ed789823aaac3aa7f2937233f1dfc
* avoid activating chart objects just to get their mapunit or set visual sizeCaolán McNamara2015-03-272-6/+15
| | | | | | | | | | | | | | | | | | | | | | | | the motivation is SwWrtShell::CalcAndSetScale and the assert/crash triggered by ooo58458-1.odt ooo84729-2.odt ooo75058-1.odt ooo123605-1.odt ooo102990-1.odt fdo57249-1.odt fdo50880-1.odt fdo70223-5.odt ooo30052-2.odt ooo119280-1.odt ooo79009-1.odt ooo58182-2.odt ooo59992-1.odt ooo123607-1.odt ooo89304-1.odt ooo91578-5.odt ooo89303-1.odt ooo30052-1.odt fdo65664-3.odt ooo119941-1.odt ooo55761-1.odt fdo57249-2.odt ooo83229-3.odt ooo84729-1.odt ooo102990-2.odt ooo37749-1.sxw ooo38798-1.sxw ooo27909-1.sxw getMapUnit activates the object which can cause chart object to load data from the current document and appears to attempt to stop and resume pending layout actions which can't be done if layout is underway, hence the assert from the inner SwLayAction::SwLayAction triggered by the runstate while an SwLayAction::SwLayAction is already active for counting the number of pdf output pages. getMapUnit always returns the same result regardless of anything else and the assumption is that we don't need to be in run state to setVisualSize on it Change-Id: Ie75b159b140de223a56324b39699d703c3b40bb9
* V801: Decreased performanceCaolán McNamara2015-03-091-4/+4
| | | | Change-Id: I9e9a00acf9503980f0c6c7cd0a20378e5ca7390d
* gbuild: set _WIN32_WINNT globally instead of WINVERMichael Stahl2015-03-051-4/+0
| | | | | | | | | | ... and remove the definitions in makefiles, except in fpicker, which defines a different value for the Vista file picker. The WINVER value is derived automatically from _WIN32_WINNT by SDK header sdkddkver.h. Change-Id: I73358a9bf5d070f71821654cae2a29335a754a21
* remove unnecessary parenthesis in return statementsNoel Grandin2015-02-231-1/+1
| | | | | | | found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
* tdf#88624 set DocumentBaseURL when saving reportLionel Elie Mamane2015-02-141-1/+4
| | | | | | regression from 1d38cb365543924f9c50014e6b2227e77de1d0c9 Change-Id: Ia8cfe47b9d92889b3724f394db5090a59e69dd48
* add an explicit virtual keyword here, like the other onesCaolán McNamara2015-02-021-1/+1
| | | | Change-Id: I4c5acf42d5ec33df1dd18dc3a70be7de838c9ff3
* OOoEmbeddedObjectFactory does implement optional XLinkFactoryStephan Bergmann2015-02-021-4/+6
| | | | | | | regression from 251f1b0b38be7d1267339898e44e320f05849e22 "fdo#46808, Adapt embed::*EmbeddedObjectCreator UNO services to new style" Change-Id: Id8b49c04183d3bc98f22398a8e43c80909c1ea11
* callcatcher: remove some unused methodsCaolán McNamara2015-02-022-13/+0
| | | | Change-Id: Id3ca991e9ede13512a39865496429aabb7e71088
* callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara2015-01-294-79/+0
| | | | | | | | | | | | | | | | | | i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
* new loplugin: change virtual methods to non-virtualNoel Grandin2015-01-264-5/+5
| | | | | | | | | | Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
* Some more loplugin:cstylecast: embeddedobjStephan Bergmann2015-01-202-4/+4
| | | | Change-Id: Iea3b2ca4f2598c501206ab631f86d9aa44a0407c
* override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl2015-01-091-3/+3
| | | | Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
* fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin2015-01-072-2/+2
| | | | Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
* bnc#822341: PPTX export of embedded text documentsZolnai Tamás2014-12-221-0/+11
| | | | | | | | | | | | | | -Make embedded text documents exported by analogy with spreadsheet embedded documents. -Convert MS ole objects to LO sepcific objecst to allow exporting those ole objects too. Plus use gb_CppunitTest_use_rdb instead of wasting time on finding out which missing components cause test failing. Especcially when we have platform dependent components (e.g. related to embedded object) Change-Id: Ic76d659b51274777a1669c215344a1169ebcba81
* embeddedobj: Use appropriate OUString functions on string constantsStephan Bergmann2014-12-184-9/+6
| | | | Change-Id: I149dd1abf03437bb58829a5f16a8c2aef5eec092
* fdo#39440 reduce scope of local variablesMichael Weghorn2014-12-151-3/+3
| | | | | | | | | This addresses some cppcheck warnings. Change-Id: I026999d6e995185c42df6770a1a700094540d08a Reviewed-on: https://gerrit.libreoffice.org/13454 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* typo: unknownAndras Timar2014-11-241-1/+1
| | | | Change-Id: If89443c1668ca01c826c8fc353b20097c7da7bf4
* cppuhelper: clean up public headers with include-what-you-useMichael Stahl2014-11-184-0/+4
| | | | Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
* sal: clean up public headers with include-what-you-useMichael Stahl2014-11-175-0/+6
| | | | | | | | | Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
* fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava2014-11-145-15/+15
| | | | | | | Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* Fix common typos. No automatic tools. Handmade…Andrea Gelmini2014-11-125-8/+8
| | | | | | | Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Removed duplicated includesAndrea Gelmini2014-10-311-2/+0
| | | | | | | Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* coverity#703952 Unchecked return valueCaolán McNamara2014-10-111-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | originally return was checked in commit c37f4bb94a119e4031796c097a35c1217e221e6c Date: Tue Nov 4 13:30:21 2003 +0000 #112739# add breakLink method then use of bElExists was removed in commit aec29756d7e058b47dc8dcef79bc93c3e9c61928 Date: Fri Nov 14 14:24:28 2003 +0000 #112923# ole implementation related changes at which point this line should have been removed, but it wasn't later at commit 00b1faf239dbf676178dcaa0d15a1678d1148a0d Author: Jens-Heiner Rechtien <hr@openoffice.org> INTEGRATION: CWS warnings01 (1.19.10); FILE MERGED 2005/11/03 10:31:40 cd 1.19.10.1: #i55991# Warning free code for gcc this still wasn't removed, just bElExists commented out Change-Id: I1af2635558cd4f47da06e148e45489f522e0183f
generated by cgit (git 2.34.1) at 2024-08-15 17:02:19 +0000