summaryrefslogtreecommitdiffstats
path: root/editeng
Commit message (Collapse)AuthorAgeFilesLines
* Resolves: coverity#705366 Mixing enum typesCaolán McNamara2016-08-1916-215/+215
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and coverity#705367 Mixing enum types coverity#705371 Mixing enum types coverity#982694 Mixing enum types coverity#1027717 Mixing enum types coverity#1371228 Mixing enum types coverity#1371242 Mixing enum types coverity#1371280 Mixing enum types coverity#1371310 Mixing enum types MapUnit and SfxMapUnit share the same values and are freely cast from one to the other. Now that commit d30a4298bdb5ba53cd1fe659f2b742f218a2e527 Date: Thu Aug 11 15:02:19 2016 +0200 loplugin:unusedenumconstants in package..svtools removed the SfxMapUnit entries that were directly unused, they don't match anymore and casting from one to the other is dangerous. Why there was two of these anyway escapes me, get rid of SfxMapUnit and just use MapUnit universally Change-Id: I4db5dcd04b59be2f85b62b728f96c90afe00c57e Reviewed-on: https://gerrit.libreoffice.org/28234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* coverity#1371381 Dereference before null checkCaolán McNamara2016-08-181-16/+14
| | | | | | this ones in 5-2 also Change-Id: Ia594fdc466d745df141b76ad7d8af3f362287766
* convert SvxEscapement to scoped enumNoel Grandin2016-08-171-5/+5
| | | | | | | | and fix a potential bug with footnotes and superscripts in writer in ndtxt.cxx, where it was passing bad args to the SvxEscapementItem constructor Change-Id: I0d2de34c056e7824f3b456a86d502e10ac93a1c1
* convert SvxTabAdjust to scoped enumNoel Grandin2016-08-175-37/+37
| | | | Change-Id: I29a33b8ea5daaa4b9059d024ffa4a99ca924f7ef
* convert SvxLineSpace to scoped enumNoel Grandin2016-08-175-27/+27
| | | | | | and rename to be more explicit Change-Id: Id06e6b68ef30e1d0d0daf19c37a390060e8bcb01
* convert SvxInterLineSpaceRule to scoped enumNoel Grandin2016-08-175-25/+25
| | | | | | and rename it to be more explicit Change-Id: I3f8bd7928495dba1e94b785cdda06d9819ee66bf
* convert SvxSpecialLineSpace to scoped enumNoel Grandin2016-08-171-16/+28
| | | | | | | | And move it inside editeng, since it's not really used anywhere else. And fix a bunch of places that were incorrectly calling the constructor with the enum. Change-Id: I74e8ab8bcf315eb5ad0720e74d04a450f0a3e5c9
* convert SvxBreak to scoped enumNoel Grandin2016-08-171-18/+18
| | | | Change-Id: If8b79ed617e5662550bd73bd1506d047217f2313
* convert SvxCellJustifyMethod to scoped enumNoel Grandin2016-08-173-8/+8
| | | | Change-Id: Ifdb9192f6556477a28af05a74042f216d4e9e8fd
* editeng: introduce OutlinerViewShell::NotifyOtherViews()Miklos Vajna2016-08-162-2/+8
| | | | | | | | | | This allows notifying other views about e.g. cursor position changes even if SfxLokHelper::notifyOtherViews() is not accessible from editeng. Change-Id: I921e97344ffe562109a221f241e70b3f68ee9aaf Reviewed-on: https://gerrit.libreoffice.org/28162 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* loplugin:stringstaticStephan Bergmann2016-08-161-5/+3
| | | | Change-Id: I89cbdf1b831818e7d72b5f9b6334df35a35d4f9f
* convert SvxSpellArea to scoped enumNoel Grandin2016-08-153-17/+17
| | | | Change-Id: I91d3caabb667e7d4ff23e603026e072074058712
* loplugin:unnecessaryvirtualNoel Grandin2016-08-081-17/+0
| | | | | | | Change-Id: If25d9307efda5f57b0f80a0cf5c2c5cab6a752d6 Reviewed-on: https://gerrit.libreoffice.org/27981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:countusersofdefaultparams in editeng..fpickerNoel Grandin2016-08-054-12/+12
| | | | | | | Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68 Reviewed-on: https://gerrit.libreoffice.org/27897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* use std::move in a few placesNoel Grandin2016-08-051-1/+1
| | | | | | | | | | found by git grep -n '.reset.*.release' Change-Id: I498709bd32b21d9dbbaa73603ce21d21c274f8dc Reviewed-on: https://gerrit.libreoffice.org/27863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* editeng: track view shells in SfxListUndoActionsMiklos Vajna2016-08-022-2/+16
| | | | | | | | | | This is needed for e.g. tracking deletions by backspace in Writer shape text. Change-Id: I6f873872566313096c2c57f4a13ac2f1db67e77d Reviewed-on: https://gerrit.libreoffice.org/27807 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* editeng: implement SfxUndoAction::GetViewShellId() interface in EditUndoMiklos Vajna2016-08-023-1/+16
| | | | | | | | | | With this, e.g. inserting a character in a Writer shape text remembers its view shell. Change-Id: Ic82a3f45a66cf622496e3131390d365440dffb3b Reviewed-on: https://gerrit.libreoffice.org/27796 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* editeng: make SfxUndoAction::GetViewShellId() interface availableMiklos Vajna2016-08-024-29/+21
| | | | | | | | | | Extend the existing OutlinerViewCallable interface to be able to obtain the view shell ID of a view shell, even from editeng. Change-Id: I13708b0e4f58ee86643b913c7d21de022a685223 Reviewed-on: https://gerrit.libreoffice.org/27788 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* svl: implement SfxUndoAction::GetViewShellId() interface in SfxListUndoActionMiklos Vajna2016-08-011-2/+2
| | | | | | | | | | | | | Client code in sw, sd, sc and svx is adapted, the rest is just a placeholder for now. With this, e.g. the undo item for Writer's insert comment properly tracks which window was used for the insertion. Change-Id: Idad587e6ca07ba69bf59aa7013b251af8bf95bab Reviewed-on: https://gerrit.libreoffice.org/27781 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* Resolves: tdf#101003 don't give paras in editeng accessible namesCaolán McNamara2016-07-272-14/+2
| | | | | | | | | | | | | | | change since... commit c23ab5eaed57cc3fb5860e26c591c73c5b22687b Author: Steve Yin <steve_y@apache.org> Date: Tue Nov 26 14:25:22 2013 +0000 Integrate branch of IAccessible2 keep the accessible description, but drop thea accessible name which is reportedly an undesirable change. Change-Id: I8f9c53ef967c4e566fde1829832aa035efce4f23
* improve passstuffbyref return analysisNoel Grandin2016-07-277-12/+12
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* masses of MessBoxes not being disposed promptlyCaolán McNamara2016-07-263-3/+3
| | | | | | | | | | | | | | | | since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
* new loplugin overrideparamNoel Grandin2016-07-251-2/+2
| | | | | | | | | | verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* sd lok: decouple vcl window focus from cursor visibilityMiklos Vajna2016-07-203-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The problem was the the blinking cursor was hidden when another vcl window got its focus, so it wasn't possible to edit two shape text in parallel in two windows. The code path is like this: - show cursor, cursor is created: SdrObjEditView::SdrBeginTextEdit() -> OutlinerView::ShowCursor() - show cursor, focus case: sd::FuText::Activate() -> OutlinerView::ShowCursor() - hide cursor, cursor is deleted: SdrObjEditView::SdrEndTextEdit() -> OutlinerView::HideCursor() - hide cursor, focus case: sd::FuText::Deactivate() -> OutlinerView::HideCursor() So add a new optional bool parameter that allows not emitting the LOK_CALLBACK_CURSOR_VISIBLE callback in the focus change case. Also, if we're at it, make sure that painting emits no show/cursor LOK callbacks. Change-Id: I1068a1b1f5cd76fd09b5a79066834bfb0daebc77 Reviewed-on: https://gerrit.libreoffice.org/27335 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* Resolves: tdf#97404 outline space wrong on second levelCaolán McNamara2016-07-191-24/+1
| | | | | | | | | | | | | | | | | | | | | Revert "tdf#42788: FORMATTING - Numbering/ordered list" This reverts commit 6517141b6233c5f9667031bc92f66109fddf5b76. https://gerrit.libreoffice.org/#/c/23006/ was apparently intended to revert this, but it never was Then there was https://gerrit.libreoffice.org/#/c/23427/ which was an attempt to improve it but it was abandoned Then there was https://gerrit.libreoffice.org/#/c/23542/ whichw as another attempt to improve it, but it was too abandoned. all of which leaves us worse than when we started with a pile of unhappy abandoned efforts and cruddy indent Change-Id: I8b3666a957339030d5a946a2b387f452e7fb0099
* Improve loplugin:unnecessaryoverrideStephan Bergmann2016-07-151-6/+0
| | | | | | | | | | | | | | | <sberg> thorsten, remember what that "TODO" in SvxAccessibleTextPropertySet::getSupportedServiceNames was to be about exactly, in a909acb7009acadffa53e74ea05ddb88803490f1 ? <thorsten> sberg: that's a nonsense, prolly copy'n'pasted, or a 'please review me' <sberg> thorsten, OK, thanks (that override will eventually go away with loplugin:unnecessaryoverride, and the TODO comment be lost) Change-Id: Iba964c61768459aac4067bbd4e1f7d4f78f6adac Reviewed-on: https://gerrit.libreoffice.org/27232 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* new loplugin unnecessary overrideNoel Grandin2016-07-154-17/+1
| | | | | | | Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#100880 editeng spellchecking doesn't work sometimes...Caolán McNamara2016-07-131-3/+3
| | | | | | | | | | | | | | | | | | | | | | believe to be a regression from commit 73f0b3bd5553c5d023d0a1dbfdc00836e2937961 Author: Matteo Casalin <matteo.casalin@yahoo.com> Date: Sat Dec 28 13:37:26 2013 +0100 xub_StrLen to sal_Int32 + some const and lets fix it the same way commit 9705fbc1119da91e73c00a2ec848565929eeb483 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Sun Mar 2 12:19:16 2014 -0600 Fix editeng missing spellchecking redline on load (probably) fixed some other regression caused by that Change-Id: I52775aff50dcc634fd2f08eb685cc4ad9850c82c
* Revert "bccu#1781: Impress/Comments - selection not updated on delete"Caolán McNamara2016-07-131-1/+0
| | | | | | | | | | | | | | because selection is visually mangled in the editeng. type a word in calc, hit return, double click on the word, then end, hold down the shift key and move to the left, every second letter gets highlighted. The original bug is private so I don't know what problem it wanted to fix to see if there is a better solution. This reverts commit c8a09eb373b78d9936fb00ac98b6876eb8740c4d. Change-Id: Ib1b535aca98daaae210db4e3d62900fbc389e816
* Fix typosAndrea Gelmini2016-07-111-1/+1
| | | | | | | Change-Id: I81671c9a8e7e5b878e605ac0ed6c3d8ef5c5b689 Reviewed-on: https://gerrit.libreoffice.org/27088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
* Remove redundant SvxGet* wrappers around LinguMgr functionsStephan Bergmann2016-07-107-54/+14
| | | | Change-Id: Ic431ce4880d0c1277ddb411ca59b3c8e8ca36518
* ditch the application per-language IsAutoMnemonicEnabled settingCaolán McNamara2016-07-101-5/+2
| | | | Change-Id: I9734ada09edb6544a332893a7c5d31730b0d081d
* Resolves: tdf#100452 class Date full (BCE,CE) proleptic Gregorian calendarEike Rathke2016-07-082-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... implementing signed years with year 0 gap. Date(31,12,-1) last day BCE Date(1,1,1) first day CE New class Date member functions: * AddYears(sal_Int16) to be used instead of aDate.SetYear(aDate.GetYear()+sal_Int16) to handle year 0 gap. * convenience GetNextYear() to be used insted of GetYear()+1 * convenience GetPrevYear() to be used insted of GetYear()-1 * AddMonths(sal_Int32) * operator=(const css::util::Date&) New class DateTime member functions: * operator=(const css::util::DateTime&) Made some conversion ctors explicit, specifically Date(sal_Int32) Adapted hopefully all places that used a sal_uInt16 year to use sal_Int16 where appropriate. Eliminated some quirks in date handling found on the fly. Added era handling to i18npool icu calendar setting interface, which missing was responsible for 0001-01-01 entered in Calc being set as -0001-01-01, hence subtracting one day resulted in -0002-12-31. Change-Id: I77b39fba9599ebd5067d7864f6c9ebe01f6f578f Reviewed-on: https://gerrit.libreoffice.org/27049 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* SvxGetOrCreatePosDic parameter is unusedStephan Bergmann2016-07-083-5/+3
| | | | | | | | ...ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import", so kill the equally old "TODO: remove argument or provide SvxGetIgnoreAllList with the same one" comment for good now Change-Id: Ie7b64306b8d06fc72d0bb49cc1e5fa3b00f59d6b
* loplugin:redundantcast: redundant static_casts in editengStephan Bergmann2016-07-081-1/+1
| | | | Change-Id: Ifc6d62fce28d540d07d95ec06c3a2b95030f1f0c
* loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann2016-07-0717-27/+27
| | | | Change-Id: I5bb3c63790cb153c0d6f57a681ec6dda71d482be
* tdf#100734: Update bullet of paragraph on UNDOMike Kaganski2016-07-041-0/+2
| | | | | | | Change-Id: I1afe0b4ca537eea752d3bced8bbc8944380c3514 Reviewed-on: https://gerrit.libreoffice.org/26874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
* don't autocapitalize words that follow a field markCaolán McNamara2016-07-012-6/+34
| | | | Change-Id: Ia8efa88aaf47edba9a590c858d0ea30d7bfe2977
* move #includes to top of fileNoel Grandin2016-06-291-2/+1
| | | | | | | | | | | | | instead of being randomly embedded somewhere deep inside the CXX code. Found with: git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t : Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a Reviewed-on: https://gerrit.libreoffice.org/26764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Simplify some PutProperties callsStephan Bergmann2016-06-281-156/+117
| | | | Change-Id: Idf91592e6cf34b5591f221c3c5bdc937bbe46014
* [API CHANGE] notebookbar: paragraph spacing controlsSzymon Kłos2016-06-271-1/+32
| | | | | | | Change-Id: I9d2672cd156f2dcc2ee4c544902e9d42632cab70 Reviewed-on: https://gerrit.libreoffice.org/26039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* loplugin:singlevalfields in editengNoel Grandin2016-06-243-5/+0
| | | | | | | Change-Id: I99c7ab28be7853535674cd7fab975da4252441f1 Reviewed-on: https://gerrit.libreoffice.org/26600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#99589 - tolower / toupper - dangerous to Turks ...Gökhan Gurbetoğlu2016-06-231-1/+2
| | | | | | | Change-Id: Id3b9abd557f2b8dfc942589362452cbdb0232da9 Reviewed-on: https://gerrit.libreoffice.org/26546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
* tdf#97527 - vcl: reference-count MenuNoel Grandin2016-06-231-17/+17
| | | | | | | | | | | some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Remove no longer needed ImpEditView::mpLibreOfficeKitSearchableMiklos Vajna2016-06-224-33/+1
| | | | | | | | | | All clients has been ported to use ImpEditView::mpLibreOfficeKitViewCallable instead. Change-Id: I3a2513ac5900f801a2e7aec79807f4e333dfba3d Reviewed-on: https://gerrit.libreoffice.org/26561 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* fix DBG_ASSERT condition to match messageNoel Grandin2016-06-211-1/+1
| | | | Change-Id: I7073d3063d17ade9b0d4f88013c47eabb646af58
* improve error messageNoel Grandin2016-06-211-1/+1
| | | | Change-Id: Id1408cb1d8f04b36ffab65b684a94b14db9d9c50
* loplugin:salbool: Implicit conversions from non-Boolean fundamental typesStephan Bergmann2016-06-191-1/+1
| | | | Change-Id: I67eac95686678e6f5a2d60798535b2c65a9ba5d7
* comphelper lok: remove the g_bViewCallback globalMiklos Vajna2016-06-172-28/+6
| | | | | | | | | | | | | Its purpose was to allow incrementally migrate all callers of SdrModel::libreOfficeKitCallback() to use SfxViewShell::libreOfficeKitViewCallback() (which allows notifying only the currently active or all views) instead. That is done by now, so it can go. Change-Id: I521bbbe5c638dfd844ebf025153459a37362d3c3 Reviewed-on: https://gerrit.libreoffice.org/26413 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* coverity#1362679 try and tell coverity these are non-null by restoring...Caolán McNamara2016-06-131-15/+6
| | | | | | | | | | | | | | | | | | | | to the pre vectorization code layout before... commit e5d378b1ba04c470e0c6c16b48af97ab5818e2bb Author: Kohei Yoshida <kohei.yoshida@gmail.com> Date: Tue Apr 3 18:26:29 2012 -0400 Check for empty-ness of vector before accessing the first element. I hope this will keep Stephan's tinderbox happy. If not... changed it, now that c++11 data is available to us Change-Id: I184092502d1f30fcec78f3fa807de70ddc6c2aef Reviewed-on: https://gerrit.libreoffice.org/26224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-09-05 17:16:17 +0000