summaryrefslogtreecommitdiffstats
path: root/editeng
Commit message (Collapse)AuthorAgeFilesLines
* Resolves: tdf#132288 don't merge adjacent properties for spell checkingCaolán McNamara2021-04-093-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | spell checking relies on each attribute chunk being unmerged with identical adjacent chunks squash includes... nStartPosition and nEndPosition are always the same and tdf#132288 preservation of footnote depends on reverse iteration like TextCharAttribList::FindAttrib does which spell checking used before commit 243b5b392906042ab03800e0b5765e6f3513372c Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jun 14 21:56:44 2019 +0100 weld SpellDialog converted to use an EditEngine instead of a TextEngine in order to be able to host it in a native widget Change-Id: Ia835fa054cad0dee4304f16724b9eb0c29b46102 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92772 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 994526fadb3faeb57c47cf1060a2ad7d53bd4f94)
* tdf#54409 fix AutoCorrect with Unicode quotation marksLászló Németh2019-12-301-0/+4
| | | | | | | | | | | | | | | | Now single or double typographical quotation marks don't break automatic correction of the quoted words. For example, ‘acn -> ‘can, acn’ -> can’, “acn” -> “can”. Change-Id: I7f895414be4c3bbc9a3914df83d93cf28b4311a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85812 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 0d52da4637b563c175cd21d04a639160441436ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85931 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#106164 AutoCorrect: capitalize words with apostropheLászló Németh2019-12-241-1/+2
| | | | | | | | | | | | | | | | | | | | | at sentence starting position, for example we’re -> We’re This worked only with ASCII apostrophe ('), and changing to default usage of typographical apostrophe (U+2019) broke this kind of capitalization from commit e6fade1ce133039d28369751b77ac8faff6e40cb (tdf#38395 enable smart apostrophe replacement by default). Change-Id: If582194364f77cfb9fc0f04a28ac79a08bb804ff Reviewed-on: https://gerrit.libreoffice.org/85630 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit f6cf80c81043d84606a5b5f7d93ae958307a16d3) Reviewed-on: https://gerrit.libreoffice.org/85660 (cherry picked from commit 030b7c01dcb2262e5dc73de81dd33e2e24529da2) Reviewed-on: https://gerrit.libreoffice.org/85664 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#129300 alignment enums not translated in organizerCaolán McNamara2019-12-121-6/+58
| | | | | | | | | | because they used the trick that the original ids were contiguous integers Change-Id: I4405100f26241dd84c26155529d3961d5082ee9e Reviewed-on: https://gerrit.libreoffice.org/84814 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#128659 Cannot add AutoCorrect entriesNoel Grandin2019-11-281-1/+2
| | | | | | | | | | | | | | | | | | | | | regression from commit 77dec7588c9141b03f8ec0139eb96c298b26f261 tdf#109158 improve sorting when loading large autocorrect file The insert operation in the maSortedVector case had the "check for duplicates" operation the wrong way around Change-Id: Id8a9d044c661668e74f01eb15635c35ca70da540 Reviewed-on: https://gerrit.libreoffice.org/83344 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 208ca3d33d4e6dff9e70a3efa098628b02151729) Reviewed-on: https://gerrit.libreoffice.org/83992 (cherry picked from commit d16962fb59e7326b2868f794bb6246e12e98ce0f) Reviewed-on: https://gerrit.libreoffice.org/84017 Reviewed-by: V Stuart Foote <vstuart.foote@utsa.edu> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
* Resolves: tdf#127961 Add NBSP to quotation marks for all French except fr-CHEike Rathke2019-10-171-12/+2
| | | | | | | | | | Change-Id: I71e8377bf44c2db5ef291d2990528ec16aaf3b44 Reviewed-on: https://gerrit.libreoffice.org/80909 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 8d7ec203956695475c5ce2c3e47a4aa012a48d39) Reviewed-on: https://gerrit.libreoffice.org/80932 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
* tdf#127748: crash on modify a frame style, which has writing-mode bt-lrJulien Nabet2019-09-261-1/+2
| | | | | | | | | | | | | bt here: https://bugs.documentfoundation.org/attachment.cgi?id=154474 Change-Id: I6e6e0927ea85c4f0f4f59bf327ce5468fc428328 Reviewed-on: https://gerrit.libreoffice.org/79572 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 2a38ec580b3b6ffe11276462547a41c467a51197) Reviewed-on: https://gerrit.libreoffice.org/79582 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#109158 improve load time of autocorrect XML fileNoel Grandin2019-09-231-0/+2
| | | | | | | | | | | | | | | | | | | Before, it seems to be doing a lot of unnecessary work because, by default, startFastElement will call startUnknownElement, which constructs various objects, etc. It seems to me that if the class already implements createFastChildContext, it is already using XFastParser, and so it should implement startFastElement to avoid that work. By avoiding going down the startUnknownElement path, reduces load time from 1.7s to 1.4s Change-Id: Ifd745cf2cc22a8cb988a5668332cf6e70bb996da Reviewed-on: https://gerrit.libreoffice.org/79269 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit ea4f3099d6e0cf30d80caa8b2121c7a358f80fdd) Reviewed-on: https://gerrit.libreoffice.org/79378 Tested-by: Jenkins
* tdf#109158 improve sorting when loading large autocorrect fileNoel Grandin2019-09-232-70/+81
| | | | | | | | | | | | | | | | | reduces time from 2.0s to 1.7s reduce work by (*) reserving some arrays (*) pre-sorting with a cheaper comparator (*) don't copy when returning result, just return a const& (*) flattening the data-structures to reduce pointer-chasing Change-Id: I972bd7ffdbf2121c2d38c24aca9618ca708e920c Reviewed-on: https://gerrit.libreoffice.org/79119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/79377
* Resolves: tdf#126935 a11y for hosted EditEngineCaolán McNamara2019-09-172-164/+0
| | | | | | | | | | | move it to svx so we can reuse the a11y code in svx for EditEngines hosted in shapes to provide a11y for EditEngines hosted in a native widget Change-Id: I4068c413cdb8ddb0d0ef899774fbe9f65e1bdc60 Reviewed-on: https://gerrit.libreoffice.org/78545 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* use common WeldEditViewCaolán McNamara2019-09-131-23/+39
| | | | | | | | | | | | | Reviewed-on: https://gerrit.libreoffice.org/74705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2cebba0e4042ca2cab37cf38874c2576c2ac6a6f) Change-Id: I873cb64a167027030c9eeef61344e6f6f885a924 Reviewed-on: https://gerrit.libreoffice.org/78544 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* factor out to a common WeldEditViewCaolán McNamara2019-09-132-0/+148
| | | | | | | | | | | Change-Id: Ife7b6f57c80d310bd11a8ed89e36fdc99742d158 Reviewed-on: https://gerrit.libreoffice.org/74698 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7b726e587ec7bbe8926fd00a50c0192ad32b3858) Reviewed-on: https://gerrit.libreoffice.org/78543 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* assert on selecting text from end to start in shape with a11y enabledCaolán McNamara2019-09-031-1/+1
| | | | | | | Change-Id: I0a135236cf5e5f291b6289cc76228290a6f77e98 Reviewed-on: https://gerrit.libreoffice.org/78408 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
* tdf#126316 revert Clipboard to PrimarySelectionJan-Marek Glogowski2019-07-152-3/+11
| | | | | | | | | | | | | | | | | | | | | Regression from commit ce9795954d39 ("fix crash in header/footer calc dialog"), which replaced some GetPrimarySelection() calls with GetClipboard() calls. This replaces the Window class calls for clipboard with global GetSystem* calls in vcl/transfer.hxx. Not sure if this is the best place, but the crowded Window class is definitly not. Reviewed-on: https://gerrit.libreoffice.org/75318 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit f8f43e55ec4ae7e436a5043fe6f4bae7b39cc6ad) Change-Id: Ic5f9e575c1ac5d43df234426c5616eca616dea30 Reviewed-on: https://gerrit.libreoffice.org/75370 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* InvalidateAtWindow should be preferredCaolán McNamara2019-06-201-1/+1
| | | | | | | | | | | | it already call GetWindow()->Invalidate(aClipRect) internally for the usual case, and correctly calls EditViewInvalidate when the editview is not used in a vcl::Window Change-Id: I9f985cb91bc768b410838289efc994d9a5b249d4 Reviewed-on: https://gerrit.libreoffice.org/74422 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* fix crash with non-window outputdevice betterCaolán McNamara2019-06-201-12/+17
| | | | | | | | Change-Id: I93511574f8ab7d564baf1f031d54ca0e72ca345e Reviewed-on: https://gerrit.libreoffice.org/74417 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* InvalidateWindow should be preferredCaolán McNamara2019-06-201-1/+1
| | | | | | | | | | | | it already call View::GetWindow()->Invalidate internally for the usual case, and correctly calls EditViewInvalidate when the editview is not used in a vcl::Window Change-Id: Ic83150117a8738ce5c6f34875057fd743bdb173a Reviewed-on: https://gerrit.libreoffice.org/74366 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* allow copy/paste when not hosted in vcl::WindowCaolán McNamara2019-06-191-4/+4
| | | | | | | | Change-Id: I1b30cb700461fa66192a4b86bf577d1babc76cb7 Reviewed-on: https://gerrit.libreoffice.org/74354 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* fix crash in header/footer calc dialogCaolán McNamara2019-06-182-6/+17
| | | | | | | | | | cut and paste can happen when the EditView isn't in a vcl::Window Change-Id: I9fdbfe28c5ca5dd680b821ff8ce4e0133ab203aa Reviewed-on: https://gerrit.libreoffice.org/74280 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Resolves: tdf#125866 null-derefCaolán McNamara2019-06-131-0/+3
| | | | | | | | Change-Id: I0bd597498d10130928de5d7865219fe6f4bc8bcd Reviewed-on: https://gerrit.libreoffice.org/73882 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Move isIVSSelector, isCJKIVSCharacter to i18nutil/unicode.hxxStephan Bergmann2019-06-131-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | 6a7db071c75609093fc3a9cbc297b8069726a33e "tdf#125497 allow backspace to remove CJK IVS" had moved these functions from sw/source/uibase/wrtsh/delete.cxx to rtl/character.hxx, but the latter appears to be a less than ideal home for them: For one, it is part of the stable URE interface, which makes it harder to maintain (e.g., later versions of Unicode have added CJK Extension C--F code blocks, which the current implementation of isCJKIVSCharacter does not reflect). And for another, besides details of legacy/ubiquitous ASCII, it only deals with the "hard" structure of Unicode (isUnicodeCodePoint, isSurrogate, etc.), not with any specific code blocks or character classifications (which can change over time). Internal i18nutil/unicode.hxx appears to be better suited. Reviewed-on: https://gerrit.libreoffice.org/73873 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit c1399e497191f295b9c3db95d126ff6a4fa5891d) Conflicts: include/rtl/character.hxx Change-Id: I88b3e4e2488411f988c1a20f79b8a58626d93dce Reviewed-on: https://gerrit.libreoffice.org/73889 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* weld SvxThesaurusDialogCaolán McNamara2019-06-021-1/+2
| | | | | | | Change-Id: I09a7b4dcd43af061d0e4be42a7b6a2ebf2331d0d Reviewed-on: https://gerrit.libreoffice.org/73323 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Use hasElements to check Sequence emptiness in [e-i]*Arkadiy Illarionov2019-05-313-3/+3
| | | | | | | | | Similar to clang-tidy readability-container-size-empty Change-Id: I79e31919db8f4132216f09a7868d18835eeb154b Reviewed-on: https://gerrit.libreoffice.org/71795 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#125497 allow backspace to remove CJK IVS.Mark Hung2019-05-301-1/+15
| | | | | | | | | | | Japanese users prefer to remove a CJK IVS character when pressing the backspace instead of removing the selector part of IVS. Change-Id: I4313d69ed52d82c5a7e4e4823b1da06f1d90bdad Reviewed-on: https://gerrit.libreoffice.org/72971 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
* tdf#120412 DOCX filter: fix missing superscriptJozsef Szakacs2019-05-291-1/+2
| | | | | | | | | | | | | | | | | | | | | by editeng support of large superscript raising. Maximal raising of superscript text is 1584 pt in MSO, while LibreOffice didn't import the values greater than 100% of the current font height. Using the maximal percent value of the default 11 pt font, the limit is 14400% now, fixing most of the import problems. Greater raisings will be limited to 14400% during the DOCX import. Note: the standard doesn't limit the bigger percent values, see "20.374 style:text-position" and "18.3.23 percent" in OpenDocument 1.2. Change-Id: I3d0d08f273f2067180f74fba40c47d62364fcc59 Reviewed-on: https://gerrit.libreoffice.org/69164 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
* Add comment about this "weird assignment" in editdocJulien Nabet2019-05-281-4/+6
| | | | | | | | | | | See http://document-foundation-mail-archive.969070.n3.nabble.com/Fishy-assignment-in-editdoc-editeng-td4262109.html Remove the previous comment less clear Change-Id: I06b0bc3254068d58146d9582c2b69afbadbe56ee Reviewed-on: https://gerrit.libreoffice.org/73062 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
* tdf#125297 List Format wrongly applied to text pastedNoel Grandin2019-05-231-1/+5
| | | | | | | | | | | | regression from commit f4ea84ff370d33a02a8fb1d6405b9d964491258e Date: Thu Apr 25 16:35:14 2019 +0200 tdf#119650 slow saving spreadsheet with comments, part 1 Change-Id: I91b3c009fb8b6739e98537de227ab563828b9c80 Reviewed-on: https://gerrit.libreoffice.org/72842 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* New loplugin:dataStephan Bergmann2019-05-223-6/+6
| | | | | | | | | | ...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Spell out element access explicitly in test codeStephan Bergmann2019-05-221-410/+346
| | | | | | | | | | | ...to avoid the upcoming loplugin:data asking to replace just each initial &aAttrs[0] with aAttrs.begin() and leave the remaining &aAttrs[N] alone, which would make the results look odd. Change-Id: I7d5c76e9d4fc6c7fa13cb28fca5ea65ea2d0f77e Reviewed-on: https://gerrit.libreoffice.org/72764 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix typoAndrea Gelmini2019-05-221-1/+1
| | | | | | | Change-Id: I3bb52201d523fd1c97315c99ce58e4473f971a12 Reviewed-on: https://gerrit.libreoffice.org/72699 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-221-1/+1
| | | | | | | Change-Id: I8d0eb79c1848714c637d05064b6aae5140843c20 Reviewed-on: https://gerrit.libreoffice.org/72707 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-221-2/+2
| | | | | | | Change-Id: I88e2a10836ae961764d899b8d74fd707a3e15b2c Reviewed-on: https://gerrit.libreoffice.org/72708 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-221-1/+1
| | | | | | | Change-Id: I97909d9d6ece176f519318ebb53b4cdfeeba9146 Reviewed-on: https://gerrit.libreoffice.org/72709 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-221-1/+1
| | | | | | | Change-Id: I09c624e4def7a0a3f0a753f9f325b4863dceac0e Reviewed-on: https://gerrit.libreoffice.org/72706 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-221-1/+1
| | | | | | | Change-Id: Ib28c9a3df6b6d6b6f65e2c9b0810655b963eb1ff Reviewed-on: https://gerrit.libreoffice.org/72711 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-211-1/+1
| | | | | | | Change-Id: I2c4fcfee1ee9901297acebc11a7698633c3c21ef Reviewed-on: https://gerrit.libreoffice.org/72696 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-211-4/+4
| | | | | | | Change-Id: I5f062a2d3260110b1108dd28c8a536652416acf2 Reviewed-on: https://gerrit.libreoffice.org/72692 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-211-3/+3
| | | | | | | Change-Id: I9adff89a575fce0db2b64df73f3ddc90867da408 Reviewed-on: https://gerrit.libreoffice.org/72694 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* tdf#90297 set default SmEditWindow backgroundJan-Marek Glogowski2019-05-154-18/+1
| | | | | | | | | | | | | | | This implements ApplySetting for the proper background of the undocked SfxDockingWindow. In addition, like all other code, this sets the text color via the EditEngine font objects and therefore reverts the uneeded EditEngine interface from the original commit ea191cf9807d ("tdf#90297 use field colors for math's edit engine"). Change-Id: Ib7df4ce730da92a1e41f58b8348a5aec18208166 Reviewed-on: https://gerrit.libreoffice.org/72312 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
* tdf#90297 use field colors for math's edit engineJan-Marek Glogowski2019-05-144-1/+18
| | | | | | | | | | | | | | | | | | This adds a maTextColor to the EditEngine, which will override the default AutoColor. There is also a NOCOLORS mode and I thought about using it instead, but it defaults to COL_BLACK and overriding this seems wrong. Since the EditEngine does the whole drawing and now has the explicit FieldColor() and FieldTextColor() for background and text, my guess is we don't need an ApplySettings implementation. Change-Id: I6c2ecc843a3e07de98f97c86fc00a3b83cb78d97 Reviewed-on: https://gerrit.libreoffice.org/72197 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* regenerate PCH headersLuboš Luňák2019-05-121-4/+4
| | | | | | | Change-Id: I4894023e42cbfa32916ee3ddfb2cfb5426cfc69f Reviewed-on: https://gerrit.libreoffice.org/72195 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
* handle empty tools::Rectangle in editengNoel Grandin2019-05-102-4/+6
| | | | | | | Change-Id: Ie59a7ee3b95eafe2a2f743a76f8feb993c0c3daa Reviewed-on: https://gerrit.libreoffice.org/72110 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* regenerate PCH headers for the 4 new levelsLuboš Luňák2019-05-091-102/+25
| | | | | | | | | Plus some build fixes triggered by this. Change-Id: I59b21def706598ceffd45ae5b1f0262ec9c1ad50 Reviewed-on: https://gerrit.libreoffice.org/71581 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
* avoid copying when placing items into SfxItemSetNoel Grandin2019-05-092-5/+3
| | | | | | | Change-Id: I05c627f590e7794c1ba11b66021dc30aa3285eb0 Reviewed-on: https://gerrit.libreoffice.org/71941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#74702 partial cleanup of OutDevTypeAdrien Ollier2019-05-072-7/+4
| | | | | | | | | | XParaPortionList::RefDevIsVirtual() does not depend on eRefDevType Change-Id: I22182bbe26502552125d24aa1a8c33ffb5a38971 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/71649 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* improve loplugin:stringconstantNoel Grandin2019-04-301-2/+1
| | | | | | | | | | to find more places we can elide the OUString() constructor at call sites Change-Id: Ie09f3c61f2c4b4959c97dc98ebcbaf7c51d5d713 Reviewed-on: https://gerrit.libreoffice.org/71514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* drop Graphic::operator boolNoel Grandin2019-04-302-4/+4
| | | | | | | | | | which tends to interact in very weird ways with other code, for example it makes Graphic appear to have an operator< Change-Id: I335fe8f3644b710bc61291e625cbca7334a37716 Reviewed-on: https://gerrit.libreoffice.org/71532 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* Decouple reading/writing of Color into GenericTypeSerializerTomaž Vajngerl2019-04-272-18/+40
| | | | | | | | | | | | | | | | This adds GenericTypeSerializer, which is now responsible of serializing the Color into a stream (other types will follow), but only for the older version of the binary format. The new version we just write the sal_UInt32 mValue directly. This is a start of decoupling the serialization of generic types in tools and vcl module from the actual type, so we can in the future replace those with basegfx variant. Change-Id: I92738e7c178cac5cbca882dcbe45c80cc8269466 Reviewed-on: https://gerrit.libreoffice.org/71404 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* Removed executions flags on source filesAndrea Gelmini2019-04-261-0/+0
| | | | | | | | Change-Id: I165d417a8e28d5732945722158b83e2ac5edb402 Reviewed-on: https://gerrit.libreoffice.org/71388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* ofz#13491 SvxRTFItemStackType dtor excessive recurse depthCaolán McNamara2019-04-261-0/+40
| | | | | | | | | | | | | | | ofz#13491 SvxRTFItemStackType dtor recursively calls the dtor of its m_pChildList. The recurse depth can grow sufficiently to trigger asan. So breadth-first iterate through the nodes and make a flat vector of them which can be iterated through in order of most distant from root first and release their children linearly Change-Id: Icc7d7130935a27595dae7b55cea41c6a53aed956 Reviewed-on: https://gerrit.libreoffice.org/71386 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-05-04 05:11:35 +0000