summaryrefslogtreecommitdiffstats
path: root/editeng
Commit message (Collapse)AuthorAgeFilesLines
* Add comments to autocorrect functionsIlmari Lauhakangas2019-01-291-7/+10
| | | | | | | | | | | | | It was difficult to find the sentence capitalization function. I thought it would be a good idea to add the UI strings of the options as comments before the function blocks. Also added a couple of notes inside FnCapitalStartSentence. Change-Id: I7047b199193ee0b61ba7fd955411952aae33ab41 Reviewed-on: https://gerrit.libreoffice.org/66812 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* tdf#42949 Fix IWYU warnings in include/xmloff/*Gabor Kelemen2019-01-224-0/+4
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id20e0bc42e39f868a7c5d49d756f2ad5e14a86c0 Reviewed-on: https://gerrit.libreoffice.org/66637 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* o3tl::make_unique -> std::make_unique in dbaccess...frameworkGabor Kelemen2019-01-2113-61/+48
| | | | | | | | | | Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: Iad5a422bc5a7da43d905edc91d1c46793332ec5e Reviewed-on: https://gerrit.libreoffice.org/66545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Check OS_FOR_BUILD for behavior of sed executed during buildStephan Bergmann2019-01-171-2/+2
| | | | | | | | | | Follow-up to d8106b6db488a4439f7bb781920c92a056b91ba6 "Non-standard sed -i option is different on macOS than with GNU sed", thanks to mst for spotting it. Change-Id: Ida51cfa7c4dd216a5164df4f8143ac89cf2c6b7f Reviewed-on: https://gerrit.libreoffice.org/66498 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Non-standard sed -i option is different on macOS than with GNU sedStephan Bergmann2019-01-171-2/+2
| | | | | | | | | | | | | | | While with GNU sed the optional backup suffix is given directly as part of the -i[SUFFIX] (or --in-place[=SUFFIX]) argument, on macOS it must unconditionally be given as a (potentially empty) argument following the -i argument. That means that on macOS the -e that happens to follow the -i in these sed invocations (and that happens to not be necessary to introduce the following script in these invocations) was mistaken as the backup suffix, causing creation of pointless workdir/CustomTarget/*/generated/tokens.cxx-e backup files. Change-Id: Icd865c76139afa348d03813eb83653afd7221a0e Reviewed-on: https://gerrit.libreoffice.org/66491 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Drop o3tl/clamp.hxx, use C++17 std::clamp insteadStephan Bergmann2019-01-111-3/+5
| | | | | | | Change-Id: I5043c787dcc3b78bc7fdff130564801194e39f46 Reviewed-on: https://gerrit.libreoffice.org/66177 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Replace OUStringBuffer::appendCopy with append(std::u16string_view)Stephan Bergmann2019-01-112-3/+5
| | | | | | | | | ...which is more general Change-Id: I94f28f8eda887120cf5f143b4549e0339b60e6a7 Reviewed-on: https://gerrit.libreoffice.org/66155 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen2019-01-0715-0/+15
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Fix typoAndrea Gelmini2018-12-231-1/+1
| | | | | | | Change-Id: I2111770ea4356c13e8703165774bb3c4cd06356c Reviewed-on: https://gerrit.libreoffice.org/65577 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:useuniqueptr in editengNoel Grandin2018-12-126-32/+29
| | | | | | | Change-Id: I1172359ed57e5f19e7d3d7af30e6fbf8e54d9e75 Reviewed-on: https://gerrit.libreoffice.org/64950 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#42949 Fix IWYU warnings in include/vcl/s*Gabor Kelemen2018-12-108-0/+8
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152 Reviewed-on: https://gerrit.libreoffice.org/64479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Remove obsolete SAL_FALLTHROUGH completelyStephan Bergmann2018-12-087-18/+18
| | | | | | | | | | ...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b "HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now" Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937 Reviewed-on: https://gerrit.libreoffice.org/64800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#121779: extend TWo CApitals list to also ignore sMALL iNITIALSMike Kaganski2018-12-071-0/+8
| | | | | | | | | | | | Now this list is used also in rules for capitalizing first letter of every sentence, and for correcting accidental use of Caps Lock key. Change-Id: I4fbdbccbae32743d5e9a6757344361eefd88e167 Reviewed-on: https://gerrit.libreoffice.org/64759 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* remove unused EditStatusFlags enum valueNoel Grandin2018-12-071-2/+0
| | | | | | | Change-Id: I859a0ebba11aaa9edbe14863c06703585defa66c Reviewed-on: https://gerrit.libreoffice.org/64716 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove unused SvxNumRuleFlags::CHAR_TEXT_DISTANCENoel Grandin2018-12-071-1/+1
| | | | | | | | | | | | | which is dead as far back as its introduction in commit fd069bee7e57ad529c3c0974559fd2d84ec3151a Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: Ieff923732005aaa48cfae4918e8094020e6a540b Reviewed-on: https://gerrit.libreoffice.org/64715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:singlevalfields in editengNoel Grandin2018-12-053-13/+1
| | | | | | | Change-Id: I369090dd2da59e9227d633ff8390518d38769db1 Reviewed-on: https://gerrit.libreoffice.org/64603 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unnecessaryparen include more assignmentsNoel Grandin2018-12-052-3/+3
| | | | | | | Change-Id: I9fb8366634b31230b732dd38a98f800075529714 Reviewed-on: https://gerrit.libreoffice.org/64510 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski2018-12-031-2/+2
| | | | | | | Change-Id: Id7af9a6eaefc8b49a790eb299620c4fa97067a11 Reviewed-on: https://gerrit.libreoffice.org/64429 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:unusedmethodsNoel Grandin2018-11-301-5/+0
| | | | | | | Change-Id: Id0d68d659fa06a8230ed0d927b85b6b504525d1e Reviewed-on: https://gerrit.libreoffice.org/64328 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedfieldsNoel Grandin2018-11-281-2/+1
| | | | | | | Change-Id: Iffbb4e7107a0b1ae35c879c193a9ec209addf453 Reviewed-on: https://gerrit.libreoffice.org/64144 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedmethodsNoel Grandin2018-11-282-61/+0
| | | | | | | Change-Id: Idbdf2d5d12fad894a3dfc3a86cae839502f42cf6 Reviewed-on: https://gerrit.libreoffice.org/64114 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove unused EEControlBits enum valueNoel Grandin2018-11-273-18/+0
| | | | | | | Change-Id: Ic363903bb6e32c029f5aac6810f69d590df1bf79 Reviewed-on: https://gerrit.libreoffice.org/64091 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove unused EVControlBits enum valuesNoel Grandin2018-11-272-30/+1
| | | | | | | Change-Id: I4e10f0a2f40f9e7b6cc40a810468f43b2ab97aa9 Reviewed-on: https://gerrit.libreoffice.org/64090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#42949 Fix IWYU warnings in include/vcl/[f-h]*Gabor Kelemen2018-11-272-0/+2
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ice2eb8c5994bf2ccb88972332ca4a1d3ed41752a Reviewed-on: https://gerrit.libreoffice.org/63826 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* add dumpAsXml methods to more pool itemsMarkus Mohrhard2018-11-261-0/+13
| | | | | | | Change-Id: Ia33ac2dfa23bdc4e2990e6d028d1bae7fedfe4f5 Reviewed-on: https://gerrit.libreoffice.org/63853 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski2018-11-252-6/+5
| | | | | | | Change-Id: If173f42302553b164267909a0a3156bb25a6d558 Reviewed-on: https://gerrit.libreoffice.org/63957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:unusedenumconstants in EEControlBitsNoel Grandin2018-11-224-31/+4
| | | | | | | | | | | | | (*) remove effectivly unused enum constants (*) tweak the plugins heuristics some more to remove false+ in this enum (*) twweak the python post-processing step to avoid a KeyError Change-Id: I2943ec94c00f71dcd049f5c9ef33db259c005ba3 Reviewed-on: https://gerrit.libreoffice.org/63709 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* improve function-local statics in dbaccess..filterNoel Grandin2018-11-221-6/+5
| | | | | | | Change-Id: I64939ad4b6c53696e33300114db384abfe73f13f Reviewed-on: https://gerrit.libreoffice.org/63702 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:redundantfcast improvementsNoel Grandin2018-11-213-5/+5
| | | | | | | | | | check for calls to constructors, and extend the list of types we check for unnecessary temporary creation Change-Id: Ia2c1f202b41ed6866779fff5343c821128033eec Reviewed-on: https://gerrit.libreoffice.org/63472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#42949 Fix IWYU warnings in include/vcl/[B-E]*Gabor Kelemen2018-11-211-0/+1
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iabe571aa8f00492902c499094bea8365a3e17fca Reviewed-on: https://gerrit.libreoffice.org/63623 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#42949 Fix IWYU warnings in include/vcl/[ab]*Gabor Kelemen2018-11-1918-0/+18
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If18c80fc64e55d797953e24e40e5d5e62bd9c625 Reviewed-on: https://gerrit.libreoffice.org/63453 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Fix typosAndrea Gelmini2018-11-191-35/+35
| | | | | | | Change-Id: I0c966f517e337caa340526b48fa62b9910ce0a3e Reviewed-on: https://gerrit.libreoffice.org/63504 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typosAndrea Gelmini2018-11-181-1/+1
| | | | | | | Change-Id: I2a7877dc341e9bcbea231f5ce9edb1236f97df1c Reviewed-on: https://gerrit.libreoffice.org/63505 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Revert "tdf#115639: Align right/center with trailing spaces the same"Tamás Zolnai2018-11-166-178/+7
| | | | | | | | | | | .. as MS PowerPoint" This reverts commit 1da3a3cb74a415a76fa547ef0c8f61780e260e7f. It was a bad solution for the problem. Change-Id: I6f6fecb7c74a884fbfb04c6e7204eb8bf347a272 Reviewed-on: https://gerrit.libreoffice.org/63473 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
* loplugin:buriedassign in dbaccess..ooxNoel Grandin2018-11-161-7/+10
| | | | | | | Change-Id: Ic0ca695a1d9d05418213475a68e233953136cc8e Reviewed-on: https://gerrit.libreoffice.org/63468 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:staticmethods in editengNoel Grandin2018-11-153-8/+8
| | | | | | | Change-Id: Ib1a45e69736beb034c1e99e8e0fcb10aef9ffb70 Reviewed-on: https://gerrit.libreoffice.org/63405 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#42949 Fix IWYU warnings in include/svl/*Gabor Kelemen2018-11-146-0/+9
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ide75232858599c275e023c2300201090acd22307 Reviewed-on: https://gerrit.libreoffice.org/63237 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski2018-11-111-10/+4
| | | | | | | Change-Id: I1027242192dfd2be4918094d59f2a8f8c8fec041 Reviewed-on: https://gerrit.libreoffice.org/63266 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2018-11-103-70/+64
| | | | | | | Change-Id: I0b3c407331bfa1fa0c5003250d327d4f26de3643 Reviewed-on: https://gerrit.libreoffice.org/63235 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Fix typosAndrea Gelmini2018-11-081-1/+1
| | | | | | | Change-Id: Ifd1affb7c3945de84a210dfbda894b60014f6cd6 Reviewed-on: https://gerrit.libreoffice.org/63020 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Resolves: tdf#121200 better ofz#7802 infinite loop fixCaolán McNamara2018-11-081-1/+17
| | | | | | | | Change-Id: I50163d6545782012b177a48a1aded0572499f9af Reviewed-on: https://gerrit.libreoffice.org/63097 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* More --enable-debug --disable-assert-always-abort fixesStephan Bergmann2018-11-086-22/+26
| | | | | | | | | | ...which <https://ci.libreoffice.org/job/lo_tb_random_config_linux/> occasionally stumbles across Change-Id: I2f28fda7522b2f6b009fc2b64766ec9e43c1ab67 Reviewed-on: https://gerrit.libreoffice.org/63067 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Convert FieldUnit to scoped enumMike Kaganski2018-11-082-3/+3
| | | | | | | Change-Id: Id2df31daa596a18c79af5fc6ea162deb6e24d5af Reviewed-on: https://gerrit.libreoffice.org/62958 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:unusedmethodsNoel Grandin2018-11-081-2/+0
| | | | | | | Change-Id: Id5cddc6d85e227f18d10d7af6a8d4b25c40ab9f3 Reviewed-on: https://gerrit.libreoffice.org/63026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move SvTreeListBox to vclCaolán McNamara2018-11-072-16/+2
| | | | | | | | Change-Id: I04a146d3d8a428ac1678827dc883525c40240a44 Reviewed-on: https://gerrit.libreoffice.org/62787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#120703 VPS: V547 Expression is always true/falseMike Kaganski2018-11-041-107/+89
| | | | | | | | | Some convoluted conditions present from the start turn out to be redundant Change-Id: I296928c7ca3852ce3f7b21791440e1b21c64b32c Reviewed-on: https://gerrit.libreoffice.org/62824 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:oncevarNoel Grandin2018-10-291-2/+1
| | | | | | | Change-Id: Iba892694acb378887a1d15ab59104c55f591f0bd Reviewed-on: https://gerrit.libreoffice.org/62498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedmethodsNoel Grandin2018-10-271-1/+0
| | | | | | | | Change-Id: I66ef078794ed1eb44dbfa854c589545e5f9ba78e Reviewed-on: https://gerrit.libreoffice.org/62407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#120703 PVS: V530 The return value of function is required to be utilizedMike Kaganski2018-10-271-1/+1
| | | | | | | Change-Id: Ifc170a45e25b3fd5b7f561cc50afb6452bb359bd Reviewed-on: https://gerrit.libreoffice.org/62420 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* use unique_ptr when Clone()'ing PoolItemsNoel Grandin2018-10-263-6/+3
| | | | | | | | | and fix a handful of small leaks in the process Change-Id: I876e12ff5305f9dda84532d4182fb91657d6fa0c Reviewed-on: https://gerrit.libreoffice.org/62389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>