summaryrefslogtreecommitdiffstats
path: root/editeng
Commit message (Collapse)AuthorAgeFilesLines
* use Any constructor instead of temporariesNoel Grandin2016-05-041-9/+3
| | | | Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
* While at it, delete Any functions on sal_Bool*Stephan Bergmann2016-05-042-32/+15
| | | | | | | (at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
* Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann2016-05-031-35/+33
| | | | | | | | | | | | | ...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
* Replace '||' with '&&'Rosemary Sebastian2016-05-011-1/+1
| | | | | | | | | so that the condition doesn't always evaluate to true Change-Id: I66ba3d4c7985e1fad60f12836e44167f19216588 Reviewed-on: https://gerrit.libreoffice.org/24548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* Fix typo in codeAndrea Gelmini2016-05-012-3/+3
| | | | | | | Change-Id: Ia1ec84da61aa353d481ada98c41cbebaca623c0e Reviewed-on: https://gerrit.libreoffice.org/24532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* teach stylepolice plugin about ref-counted-pointer namingNoel Grandin2016-04-281-5/+0
| | | | | | | Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* todo odd warnings being printedMichael Stahl2016-04-271-0/+1
| | | | Change-Id: I227ba7063827952525a4b190f864b4c7ffb3a6d8
* -Werror,-WvarargsStephan Bergmann2016-04-272-5/+5
| | | | | | | | | "passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]" just replace the variadic function with one taking an initializer list Change-Id: Ied3dfe835dcebef48cf35374ec4d8835f98e6779
* update loplugin stylepolice to check local pointers varsNoel Grandin2016-04-262-6/+6
| | | | | | | | | | | | are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy modernize-loop-convert in e*Noel Grandin2016-04-2618-103/+88
| | | | | | | Change-Id: If56abefa81b41479e3ea9890dee1c43f006086de Reviewed-on: https://gerrit.libreoffice.org/24384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* new plugin stylepoliceNoel Grandin2016-04-211-3/+3
| | | | | | | check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
* loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2016-04-2013-31/+31
| | | | Change-Id: I626b79e1450d78aec96c206db82bf64a47305d08
* Use IsRightToLeft()Stephan Bergmann2016-04-202-7/+5
| | | | | | ...instead of computing this from GetRightToLeftLevel() Change-Id: If0068c8aae581b6f097ba3897b4a3031db8d9afd
* So this is apparently about right-to-left levels, not a boolean flagStephan Bergmann2016-04-194-21/+21
| | | | | | | Although the cases where GetRightToLeftLevel() is contextually converted to bool look fishy, and might have been intended to use IsRightToLeft() instead? Change-Id: I741b90cb6f1ccdac0886c451d05f4cfac79dbd5f
* clang-tidy performance-unnecessary-copy-initializationNoel Grandin2016-04-183-22/+16
| | | | | | | | | | | probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* clean-up: unused using declarations and includesJochen Nitschke2016-04-181-1/+0
| | | | | | | | | | | | | | Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* -Werror=logical-op (GCC 6)Stephan Bergmann2016-04-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | "logical ‘and’ of mutually exclusive tests is always false" <sberg> alg, in editeng/source/uno/unoipset.cxx:208 (wid < START && wid > END), is what's actually wanted to check for contained or for not contained in the START..END range? You touched the code last, in b0c2ec72ff171d8b4303d39f11f67497e88e2d8c, 15+ years ago (although the line itself was already like that in the initial import, fd069bee7e57ad529c3c0974559fd2d84ec3151a) <alg> sberg: sorry cannot remember - but looks correct. All values outside OWN_ATTR_VALUE_START/_END are answered with defaut. The renge should be the one from ditEngine <sberg> alg, the code as is is clearly incorrect, as the condition is always false <alg> sberg: Ah, yes! Should probably be an '||' <sberg> alg, OK, thanks, I'll give that a "make check" try (a bit scary to thus enable code that had effectively been disabled since at least the turn of the century) <alg> sberg: Yes - scary is the right word. Looking further, eState == SfxItemState::DEFAULT should result when outside, thus pItem->QueryValue would be taken which *should* get the default from the pool when not in the local ItemSet range. In theory, the same *should* happen Change-Id: I906361272dfe3f6af0e1ed3cb4e245ead7eabaec
* -Werror=logical-op (GCC 6)Stephan Bergmann2016-04-141-1/+1
| | | | | | | | "logical ‘or’ of collectively exhaustive tests is always true"; apparently a typo in 63114e6d863de32e2d93f0da54caca928916d9c2 "Create SvxFieldData instance directly from the UNO textfield object" Change-Id: I9e504ccb5ebad5a42a8c07d7f16d7c316dd82cf1
* loplugin:passstuffbyref in editengNoel Grandin2016-04-132-9/+9
| | | | Change-Id: I11deb7c73a1c160d587d74c9851ff10c875c972b
* Avoid reserved identifiersStephan Bergmann2016-04-122-5/+5
| | | | Change-Id: I12118ad040d1791c7afa517081040961cc7e4677
* cleanup: remove unused com/sun/star/uno includesJochen Nitschke2016-04-124-4/+0
| | | | | | | | | | | | Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy performance-unnecessary-value-param in editengNoel Grandin2016-04-116-19/+19
| | | | Change-Id: Idfebcc36c756023e491baf2c4259bd580785dd44
* tdf#94306 replace boost::noncopyable ...Jochen Nitschke2016-04-114-11/+17
| | | | | | | | | | | | | ... in modules editeng to oox. Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes and one unused boost/checked_delete.hpp include in linguistic. Change-Id: I5a38d8e5ac1b4286bdeb3858d56490a53d13fe80 Reviewed-on: https://gerrit.libreoffice.org/23928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* don't pool SvxFieldItem, tdf#92773Markus Mohrhard2016-04-101-1/+1
| | | | | | | | In documents with many different hyperlinks pooling them is incredibly slow. I doubt that in most cases the hyperlinks are the same so let us just not pool them. Change-Id: I2387aee57ef0ab3183d9cc3486ddbf8ca2883e0b
* Avoid reserved identifierStephan Bergmann2016-04-061-5/+5
| | | | Change-Id: Ia2af17bbf08cebc9e3c8f772583a61bde194328f
* Avoid reserved identifiersStephan Bergmann2016-04-061-6/+6
| | | | Change-Id: I0505cf418688d568c0c110bc70b2552e2fb8265c
* Avoid reserved identifierStephan Bergmann2016-04-061-1/+1
| | | | Change-Id: I87a6afeffaf7c87c6037a416783f1f22015b2fbf
* Avoid reserved identifiersStephan Bergmann2016-04-062-10/+10
| | | | Change-Id: I4c76a7d3f5a209578b5a7c230fbbcdea2ec47ae0
* Avoid reserved identifiersStephan Bergmann2016-04-061-2/+2
| | | | Change-Id: I2c83911433a8f89e7366d9f7711ca4879e44bae9
* loplugin:constantparam in editengNoel Grandin2016-04-056-17/+12
| | | | | | | Change-Id: If8342112e0657014266133954269b9396085a27d Reviewed-on: https://gerrit.libreoffice.org/23807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* cleanup: remove unused Reference.h(xx) includesJochen Nitschke2016-04-022-2/+0
| | | | | | | | | and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* tdf#97525 vcl: make DeletionListener internalJochen Nitschke2016-03-311-1/+0
| | | | | | | | | | | | move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* use SAL_N_ELEMENTS more widelyNoel Grandin2016-03-311-1/+1
| | | | | | | found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
* Avoid reserved identifiersStephan Bergmann2016-03-293-18/+18
| | | | | | | Change-Id: I759939aa74570be63f5d41814c22aad1851d65c4 Reviewed-on: https://gerrit.libreoffice.org/23587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:constantparam in editengNoel Grandin2016-03-237-197/+47
| | | | Change-Id: I50ee4a0a3403cbed2aa8cdd6daaa951c9d0dad37
* loplugin:constantfunction in editengNoel Grandin2016-03-1815-42/+33
| | | | | | | Change-Id: I8f8414b4867d3248e6d836ed8037de4da41b97f1 Reviewed-on: https://gerrit.libreoffice.org/23331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:constantparamNoel Grandin2016-03-152-5/+3
| | | | Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
* coverity#1355507 uninitialized scalar fieldCaolán McNamara2016-03-105-17/+17
| | | | | | | | | | | | | | | I think commit b2fb84499e1f75735e8fd90bc2eece3fed9af5f6 Author: Noel Grandin <noel@peralex.com> Date: Mon Mar 7 14:19:22 2016 +0200 loplugin:write only fields wrong wrong and took out this param along with the unused nIndex beside it Change-Id: Idc34e03b5d59d4b0017fff456b79c807fda2535f
* loplugin:constantparam in editengNoel Grandin2016-03-107-29/+18
| | | | Change-Id: I078061c502c09bccf515151d3a5bdcd1176e64fb
* remove unused NOT_POOLABLE enum valueNoel Grandin2016-03-091-55/+55
| | | | | | | | | and simplify the resulting SfxItemInfo field down to a single bool Change-Id: I73e24e83d39afc7660ac85872ba96bc790713cb2 Reviewed-on: https://gerrit.libreoffice.org/23058 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:write only fieldsNoel Grandin2016-03-076-24/+22
| | | | Change-Id: Ia0fb487c5590e096659b81f76c4dc543e184c59c
* improve defaultparams lopluginNoel Grandin2016-03-071-1/+1
| | | | | | | | | to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:unuseddefaultparam in editengNoel Grandin2016-03-076-22/+20
| | | | | | | Change-Id: Ifd86b0f6cca5d5d30daeee1c087c0124f2f18f3c Reviewed-on: https://gerrit.libreoffice.org/22899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* bIsExpanding is unusedCaolán McNamara2016-03-061-3/+0
| | | | Change-Id: I187ca7dc0e9e1a99e82145f4bcdce6abaac68278
* coverity#1355252 Uninitialized pointer fieldCaolán McNamara2016-03-061-11/+13
| | | | Change-Id: I34c5565adcfd3fd39f9b03967e5c4272767a58ea
* editeng: fix -Werror=unused-but-set-variableMiklos Vajna2016-03-031-2/+0
| | | | Change-Id: I14364bc833c97dbb5dfe323c65282f69ba7e393f
* loplugin:unuseddefaultparams in editengNoel Grandin2016-03-0318-118/+72
| | | | Change-Id: I1dc0ba262c06bd69cf92aae20b344fe23f460f55
* let SvxSearchItem use SearchOptions2Eike Rathke2016-02-241-2/+2
| | | | | | And all those places that interface to SvxSearchItem. Change-Id: I08915824a596cd0f247a89f44e4684cd22b98082
* new loplugin: commaoperatorNoel Grandin2016-02-234-11/+21
| | | | Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
* editeng: remove never read mpLibreOfficeKitCallbackMiklos Vajna2016-02-194-12/+6
| | | | | | As all callback invocations happen with SdrModel's callback pointer. Change-Id: I0111040c501b7927332f88cc4797b8ebab2bc57a
generated by cgit (git 2.34.1) at 2024-05-30 19:23:35 +0000