summaryrefslogtreecommitdiffstats
path: root/editeng/qa
Commit message (Collapse)AuthorAgeFilesLines
* editeng: fix loplugin:cppunitassertequals warningsMiklos Vajna2016-09-231-14/+14
| | | | Change-Id: Icccd2db45616de708d83058d76ace312db8af94e
* Related cid#1371287: Improve code to not depend on missing move assignmentStephan Bergmann2016-09-201-10/+6
| | | | Change-Id: I4c03ad08078e25ea7f7d754e6eaa587da7984c9d
* don't autocapitalize words that follow a field markCaolán McNamara2016-07-011-0/+22
| | | | Change-Id: Ia8efa88aaf47edba9a590c858d0ea30d7bfe2977
* Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann2016-06-081-2/+2
| | | | Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
* teach refcounting clang plugin about uno::ReferenceNoel Grandin2016-05-311-14/+14
| | | | | | | | | | | | | | uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:unusedmethodsNoel Grandin2016-02-081-13/+4
| | | | | | | | | | | | | | | using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:unusedmethods unused return value in include/editengNoel Grandin2016-01-121-2/+1
| | | | | | | Change-Id: I1314480950b0d3a3e5ed066d71c175604dd41970 Reviewed-on: https://gerrit.libreoffice.org/21361 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-101-2/+2
| | | | Change-Id: I9fe00eef7ddcd4a3c87e497a8d62f98e71a0d6d8
* loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann2015-11-061-16/+16
| | | | Change-Id: Icf08e69ba327225da816bd57648d4242dcbf3280
* Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-121-11/+11
| | | | Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
* boost->stdCaolán McNamara2015-09-181-5/+5
| | | | | | | | Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0 Reviewed-on: https://gerrit.libreoffice.org/18670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* cppcheck: noExplicitConstructorCaolán McNamara2015-09-071-1/+1
| | | | Change-Id: I2a1add8cf526cdb305ad99ccb138454a88f2fdbd
* new loplugin: refcountingNoel Grandin2015-08-031-28/+28
| | | | | | | | | | | | | | This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* editeng: Use appropriate OUString functions on string constantsStephan Bergmann2014-12-181-1/+1
| | | | Change-Id: Iab879390c18a3ce2c5bfc49548ca273ce0b907da
* Adapt to int/sal_Int32 mismatch on 32-bit buildTor Lillqvist2014-12-021-1/+1
| | | | Change-Id: I9c5cb458ea7595c1b623ce14ed58fd3d5b3d961e
* Adapt to int/sal_Int32 mismatch on 32-bit buildTor Lillqvist2014-12-021-1/+1
| | | | Change-Id: Ifef81d53bee4241be3c0dd6b7ddb2c1bbf419b5e
* fdo#85496: editeng: do not add multiple 0-length attributes...Michael Stahl2014-12-011-0/+39
| | | | | | | | | ... at the same position. Since commit 0d57434180db6c8eda8c5b9b704f8a1c18b371df these will be exported by the ODF filter as duplicate attributes. Change-Id: I8befe55f61c59ab968409fa03359540c300f9198
* Revert "use the new OUString::fromUtf8 method"Stephan Bergmann2014-11-061-4/+4
| | | | | | | | This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
* use the new OUString::fromUtf8 methodNoel Grandin2014-11-061-4/+4
| | | | Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
* create a macro library for implementing bit-flags typesNoel Grandin2014-10-131-2/+2
| | | | | | | | | | | Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
* WaE: overriding virtual function declaration not marked 'override'Tor Lillqvist2014-07-281-1/+1
| | | | Change-Id: I18274d920865f8e28377acce8084eb1629ff8127
* bnc#467459 - fix editeng text search with expanded fields.Michael Meeks2014-07-271-6/+94
| | | | Change-Id: If59d0e2f886e94148b81cb6cfcad067733fcb918
* First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann2014-03-261-10/+10
| | | | | | | ...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
* editeng: sal_Bool->boolNoel Grandin2014-02-271-6/+6
| | | | Change-Id: Ice3b0a4ccf7a6d25311ff65a23efa9082cd501de
* fdo#74363: fix auto correct of initial capitals on start of first paraMichael Stahl2014-02-081-2/+2
| | | | | | | | | The GetPrevPara() method apparently has to return 0 when there is no previous paragraph. (regression from ac85b6cff11d193f5f71d11b1f3cc1c474653f59) Change-Id: I09a3e1d3a3adb33562e4e03c0755447047cbd433
* Remove LookupTree as it is replaced with Trie.Tomaž Vajngerl2014-02-061-185/+0
| | | | Change-Id: I7611c5307e4d4e925dc3e54c6b3f2d1a47bd9080
* Add getAllElements (strings) for Trie.Tomaž Vajngerl2014-02-061-3/+31
| | | | Change-Id: I9603cc51545f72fdb0854f2d76e2326706329000
* xub_StrLen and tools/string.hxx final strawNorbert Thiebaud2014-02-031-30/+30
| | | | | | | | | | Thre is still some 0xffff limit left and possibly some less than gracefully handled overflow/error cases Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638 Reviewed-on: https://gerrit.libreoffice.org/7787 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
* Related: #i17171# big xub_Strlen -> sal_Int32 changesCaolán McNamara2014-01-151-6/+6
| | | | Change-Id: I31bce794c95062abfa1171c13cf565498688b5f3
* bugs.freedesktop.org -> bugs.libreoffice.orgAndras Timar2013-11-171-1/+1
| | | | Change-Id: I56c1190c93333636981acf2dd271515170a8a904
* remove unnecessary sal_Unicode casts in various placesNoel Grandin2013-11-141-4/+4
| | | | Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
* map autocorrection files with LanguageTag keyEike Rathke2013-09-211-1/+2
| | | | | | ... as several tags (i.e. renamed) may map to the same LangID. Change-Id: I8202b18ea0dc8034522017be59bb104b3d06c0f4
* convert SvxAutoCorrect::DoAutoCorrect to OUStringCaolán McNamara2013-09-181-6/+3
| | | | | | which makes autocorrect in the editengine work again Change-Id: I97d56448e4abd6e563479ffee706b86cb04199ec
* convert SvxAutoCorrDoc from String to OUStringNoel Grandin2013-09-111-9/+9
| | | | | | | | | | Also: - simplify the return type of the GetPrevPara method, there is no need return an OUString by pointer - simply the ppPara parameter of the ChgAutoCorrWord method, passing a pointer to a pointer to a value type is unnecessary. Change-Id: I4a8c44fdab1cf68af88c34003827d1c20704f839
* Rename SectionAttribute to Section.Kohei Yoshida2013-08-281-9/+9
| | | | | | It fits better this way. Change-Id: I139de7858e999a6dd26633a548c47634dfad8a65
* Fix incorrect logic in section attribute array construction.Kohei Yoshida2013-08-281-41/+103
| | | | | | And a new test case to catch it. Change-Id: Ie51ddf185f70c656e7d838fc7016b5726efbdf3f
* Add a means to retrieve all formatting attributes in non-overlapping sections.Kohei Yoshida2013-08-201-0/+93
| | | | Change-Id: Id04dffc135fad6bb66ea157cd280dd481cb80117
* String to OUStringMatteo Casalin2013-07-301-1/+1
| | | | | | | Change-Id: I8d4f62b473ad43807621a9dbb826ed33857b737e Reviewed-on: https://gerrit.libreoffice.org/5189 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
* fdo#55315 Added simple Trie lookup tree for autocomplete words storageTomaž Vajngerl2013-06-111-4/+91
| | | | | | | | | | | | | Added simple Trie lookup tree which is more tailored to what is needed in autocomplete implementation, but still has the speed of the LatinLookupTree that has been used till now. As the implementation is much simpler it should be more managable and easier fixable. For now two actions: insert (word) and findSuggestions are supported. Acttion findSuggestion returns all words in a list for a searched sub-word, it also fixes fdo#62945. Change-Id: I63b69c30d28b4e1c465c2122ebc537f7f75a033a
* Work around -Werror=strict-aliasingStephan Bergmann2013-06-111-1/+2
| | | | Change-Id: I0184488344bd11c50bddd1bb1726e0d1225aff7e
* sw: fix AutoCorrect bold/underline regressionMichael Stahl2013-06-071-15/+30
| | | | | | | | | | | | | The horrible SvxAutoCorrect::AutoCorrect() inserts the character into the document half-way through, and then _expects_ this inserted character to show up in its rTxt parameter. This broke in Writer when SwTxtNode::m_Text was converted to OUString, because now a temporary String copy is created. Work around this disaster area for now. (regression from 0295c8a34e39326414c1b98cf4da905802f061b0) Change-Id: I1cb11a20cb0c2577036176e605426105631f3311
* Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks2013-04-301-24/+4
|
* Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks2013-04-221-23/+4
|
* mass removal of rtl:: prefixes for O(U)String*Luboš Luňák2013-04-072-21/+21
| | | | | | | | Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
* Related: fdo#55693 add regression tests for autocorrectionCaolán McNamara2013-03-011-0/+116
| | | | Change-Id: Ie9bbeb38ec9cc2fa0377709e75abb0338b20bab5
* Invalidate current position in LookupTree at remove action.Tomaž Vajngerl2012-07-311-6/+6
| | | | Change-Id: I7a32e8d7c21c1e87e1acab9020f9ecbb7e441f2c
* LookupTree for fast autocompletion lookups (by Nico Weyand).Tomaž Vajngerl2012-07-301-0/+225
| | | | | | | | | | | | | | LookupTree is a tree structure for fast autocompletion lookups. Additionally the tree structure stores word probabilities, so each autocompletion request returns a result with highest probability. LatinLookupTree is an implementation which was designed to be even faster and more efficient latin text, however it works with any kind of unicode strings. The tree structure was coded by Nico Weyand, Unicode strings support and conversion to Libreoffice code structure was done by me. Change-Id: I6549ee45d0952407b8a070f30ed0598fcb420aa7
* refactor handling of double border widths:Michael Stahl2012-07-041-4/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Word uses a completely different definition of "width" of a double border than OOo and ODF: for Word the width is apparently the largest of the 3 component widths, while OOo and ODF define the width as the total with of all 3 components. The new border implementation in LO 3.4 was apparently inspired by Word's double border definition, which resulted in various import filter regressions, see the previous fixes: 36e43b52992735c622833e923faa63774b9e2f76 e2ffb71305c5f085eec6d396651c76d6daee3406 70a6a4d425558340bb49507975343a3e0a1bdde8 These fixes set the ScaleMetrics, which actually seems sub-optimal as there is a ScaleItemSet function somewhere that apparently re-scales all items in an itemset, which could undo the fixes. Also, one of the fixes actually managed to break RTF/DOCX import of double borders, as that ended up in the same code via the API. This commit now reverses the change, so that the width of a border is now always the total with of all components, which is (imho) much more intutitive, and also leads to a consistent UI where selecting say 3pt width has predictable results, no matter what the border style. The border widths are now converted in the Word format import/export filters (writerfilter and sw/source/filter/ww8), and various tests were adapted to the new handling. Change-Id: I50456c49b1a298569607e6c88f19f18441348ac3
* replace enum SvxBorderStyle with css::table::BorderLineSyleMichael Stahl2012-07-041-8/+10
| | | | Change-Id: I1dadb53f46b23f92d34061ef78dda872bdbcda67
* targetted re-work of cppunit pieces.Michael Meeks2012-06-272-6/+1
|