summaryrefslogtreecommitdiffstats
path: root/dtrans
Commit message (Collapse)AuthorAgeFilesLines
* Fix typoAndrea Gelmini2019-05-211-1/+1
| | | | | | | Change-Id: I282902c410ab93017b3aea46f88f60c246ca9894 Reviewed-on: https://gerrit.libreoffice.org/72629 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-211-2/+2
| | | | | | | Change-Id: I828c0529ae935ed6076f8c5f2dc93df04c38d81f Reviewed-on: https://gerrit.libreoffice.org/72630 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-211-1/+1
| | | | | | | Change-Id: If3601066764ca33fd5321e318af6fee0501199e5 Reviewed-on: https://gerrit.libreoffice.org/72631 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-211-1/+1
| | | | | | | Change-Id: If25ae724fcac4bf9475eca506194593a7a5fdeab Reviewed-on: https://gerrit.libreoffice.org/72628 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-191-3/+3
| | | | | | | Change-Id: I6addc8273cbf46d047e2df4aa27dff11a8666bce Reviewed-on: https://gerrit.libreoffice.org/72569 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-191-2/+2
| | | | | | | Change-Id: I5fce4297a8172889e4a609da1f99e5e9cba371bb Reviewed-on: https://gerrit.libreoffice.org/72573 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-191-2/+2
| | | | | | | Change-Id: Ifd8b571d2331e3b11b38ee40fd2bc39de5e8d64c Reviewed-on: https://gerrit.libreoffice.org/72576 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-191-7/+7
| | | | | | | Change-Id: Ie0d2c0cde9c1fb58a63e8ef5331bdcb5126aaf28 Reviewed-on: https://gerrit.libreoffice.org/72577 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-191-1/+1
| | | | | | | Change-Id: Idc7a1e11b2d2e0e2383d742bf144e29ad0332269 Reviewed-on: https://gerrit.libreoffice.org/72540 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-191-1/+1
| | | | | | | Change-Id: I23bd7912a38845a050ef34cbd0efd17a028ef109 Reviewed-on: https://gerrit.libreoffice.org/72538 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-191-1/+1
| | | | | | | Change-Id: I931e9aaf623a1b405054df4aebe1d2e1b591f212 Reviewed-on: https://gerrit.libreoffice.org/72537 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-05-191-2/+2
| | | | | | | Change-Id: I57ddee21cb31c06b47eaf30010fa7378401a2f17 Reviewed-on: https://gerrit.libreoffice.org/72541 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Don't use resettable/clearable guard where plain guard is enoughMike Kaganski2019-04-072-23/+22
| | | | | | | | | | | Also use scope where possible. This allows to limit guard scope at language level; visualises the scope clearly; and helps avoiding errors like fixed in commit 61e4437c857854b331fa01da6f39b2b3b58a800b. Change-Id: Ifeca96e2df8e8a0897770d9546b2536806275f41 Reviewed-on: https://gerrit.libreoffice.org/70376 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Drop UNICODE/_UNICODE definesMike Kaganski2019-04-041-5/+0
| | | | | | | | | | | | The code is using expicit (mostly W) Windows API, and is independent from the macro. Removing it here allows to catch places where some UNICODE-dependent macro is used unintentionally. Change-Id: I5dff40aecfc3c3dc7fc4cf7271a995a675943a45 Reviewed-on: https://gerrit.libreoffice.org/70237 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
* IShellLinkA -> IShellLinkWMike Kaganski2019-04-011-7/+5
| | | | | | | Change-Id: If07d7e0d2a3a33f0bcc96352ea40ff83a2f483ed Reviewed-on: https://gerrit.libreoffice.org/70062 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#120703 PVS: remove redundant static castsMike Kaganski2019-03-313-6/+5
| | | | | | | | | | V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I54976062dc3f62eaaa79f89eff54454f0b24ac2c Reviewed-on: https://gerrit.libreoffice.org/69989 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:typedefparam (clang-cl)Stephan Bergmann2019-03-277-53/+53
| | | | | | | Change-Id: I07604028845c49cc084927e21db7f21c5d053bab Reviewed-on: https://gerrit.libreoffice.org/69796 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Simplify containers iterations in desktop, dtrans, editeng, extensionsArkadiy Illarionov2019-02-203-65/+38
| | | | | | | | | Use range-based loop or replace with STL functions Change-Id: Ic5389d123d0a6a32a8bb46b081165e94a7c55292 Reviewed-on: https://gerrit.libreoffice.org/68036 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Win64 fixes for dtrans.Damjan Jovanovic2019-02-102-9/+9
| | | | | | | | | | | | Patch by: me (cherry picked from commit 7595a809d2a4aea9299633546ca95f709133dee8) Change-Id: I59a561aad16073fec1567e1873842a2b11dff4df Reviewed-on: https://gerrit.libreoffice.org/67594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Cleanup event properly; handle error from MsgWaitForMultipleObjectsMike Kaganski2019-02-051-0/+10
| | | | | | | | | Commit 11a2809e369b2a6fcbb2d7f0db131a945557c6e2 follow-up Change-Id: Id70a95f46655ade3b867e0377ddd5bee13993187 Reviewed-on: https://gerrit.libreoffice.org/67402 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#122435: reimplement fix for tdf#109085Mike Kaganski2019-02-052-13/+90
| | | | | | | | | | | | | | | | | | This reverts commit 3d8c159841bcab7365b2bed3df71ed3c15188312, and instead, checks if the MtaOleReq window is not destroyed yet, in addition to the wait for the condition. This allows to avoid wait forever for condition which never gets signalled, and process the sent messages when waiting. The window's WM_DESTROY handler sets the event signalling that. The Win32Condition's wait() is changed to take the abort event, and return true if its own event fired, and false if abort event fired. Change-Id: I1861dd3dabb39329976a3ccf2a5392c9ddbf9613 Reviewed-on: https://gerrit.libreoffice.org/67383 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:redundantfcast (clang-cl)Stephan Bergmann2019-01-301-1/+1
| | | | | | | Change-Id: I814e7b61ebbef1a0bbd38a5e70beeb7f99a0cfa1 Reviewed-on: https://gerrit.libreoffice.org/67146 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* -Werror,-Wunused-const-variable (clang-cl)Stephan Bergmann2019-01-301-1/+0
| | | | | | | Change-Id: I3a1ebc4cc4cadd3b4a69b772addbb51eace84e27 Reviewed-on: https://gerrit.libreoffice.org/67142 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:redundantinline (clang-cl)Stephan Bergmann2019-01-303-7/+1
| | | | | | | Change-Id: Ib6320ddc049e93cca4c5931ad28d1873d34bd8b4 Reviewed-on: https://gerrit.libreoffice.org/67137 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix typosAndrea Gelmini2018-11-162-2/+2
| | | | | | | Change-Id: I25660634dcb9ebb31292275e31ed7a047e4ddd25 Reviewed-on: https://gerrit.libreoffice.org/63474 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Win: implement Clipboard Format Listener instead of obsolete ViewerMike Kaganski2018-11-052-61/+10
| | | | | | | | | | | | | | | | | | | | https://docs.microsoft.com/en-us/windows/desktop/dataxchg/using-the-clipboard discusses the techniques to monitor clipboard contents on Windows, and recommends Clipboard Format Listener for Vista+. https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-setclipboardviewer further mentions that using the current "Clipboard Viewer Window" approach, "The clipboard viewer chain can be broken by an application that fails to handle the clipboard chain messages properly". This change reimplements our listener to use recommended way; this should make our clipboard handling more robust, avoiding the need to handle the chain with other applications' windows. Change-Id: Ib33b27a57d7a6af2ab7e3e59d030aa55329694f9 Reviewed-on: https://gerrit.libreoffice.org/62909 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#109085: don't assume MtaOleReq window is still valid at shutdownMike Kaganski2018-11-051-95/+5
| | | | | | | | | | | | | | | | | | | The window can be destroyed by e.g. WM_QUERYENDSESSION/WM_ENDSESSION sequence, and then the message MSG_REGCLIPVIEWER handler would not run and the condition would never be set. Since we need to wait for the message processed, let's just use sendMessage which would return only after the message has been processed anyway, and also will return immediately on failure (e.g., window handle invalid). Also this changes other cases where postMessage + wait pattern was used, and removes the condition from MsgContext. Change-Id: Ic12deafbaedd1cc99b9d6145650d99069c618f0e Reviewed-on: https://gerrit.libreoffice.org/62881 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* fix signatures of deleted copy/assign operatorsNoel Grandin2018-11-021-2/+2
| | | | | | | Change-Id: Id1a0749b78a7021be3564487fb974d7084705129 Reviewed-on: https://gerrit.libreoffice.org/62718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#119235 svx,sd: fix drag&drop from ColorBarMichael Stahl2018-10-281-1/+1
| | | | | | | | | | | | | | | | | | | This was using the SfxPoolItem serialisation of XATTR_FILL* items, where only XFillColorItem and XFillStyleItem were actually used; the binary serialisation was removed without being aware of this feature. Fix this by using uno::Any instead, rather than reviving the binary serialisation. Also change the clipboard format strings, just to be safe. (regression from 97b889b8b2b2554ce33fd6b3f0359fc18f39832d) Change-Id: I1828621a9aae606a1ca47835eef608062efe64a0 Reviewed-on: https://gerrit.libreoffice.org/62455 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
* Remove unnecessary mutexStephan Bergmann2018-10-122-7/+0
| | | | | | | | | CMimeContentType::m_ParameterMap isn't modified after construction Change-Id: Ib3dbfbd4212ed0d7e8a9f29c655f935d3fc4f1bf Reviewed-on: https://gerrit.libreoffice.org/61698 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Remove undefined member function declarationsStephan Bergmann2018-10-121-12/+0
| | | | | | | | | | | ...that had accidentally not been removed along with the definitions in b75e3ded1f73c943fb09f117e476e367ac0c3413 "tdf#120158: Base CMimeContentType on INetMIME::scanContentType" Change-Id: If94c0c413b891480c12a098c7b15caa1422213b0 Reviewed-on: https://gerrit.libreoffice.org/61697 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#120158: Base CMimeContentType on INetMIME::scanContentTypeStephan Bergmann2018-10-113-255/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...instead of using yet another local implementation of parsing media types. CMimeContentType is the implementation of the UNO css.datatransfer.XMimeContentType interface. One observable change in behavior is that type, subtype, and parameter names will now always be reported in lower case instead of with the casing from the input preserved (but those differences in casing are functionally equivalent per the media type specification). Also, parameter names supplied to the hasParameter and getParameterValue functions are now also treated case-insensitive. The upside of this change is that INetMIME::scanContentType (via "The encoding of rMediaType should be US-ASCII, but any Unicode values in the range U+0080.. U+FFFF are interpreted 'as appropriate.'") already implicitly supports RFC 6532 "Internationalized Email Headers" extensions for media types, allowing quoted- string parameter values to contain non-ASCII Unicode characters. That means that tfd#120158 "Impossible to paste special in Writer from Calc in Libreoffice 6.1.x in some UI languages - the dialogue caption says 'unknown source'" can be fixed by just allowing non-ASCII typename parameters being generated in ImplGetParameterString in svtools/source/misc/transfer.cxx, and reverting the problematic (see the comments there) previous fix <https://gerrit.libreoffice.org/61601> "tdf#120158: fix ImplGetParameterString for typename". (Which will be done in a follow-up commit, to ease potential backporting, as that previous fix has already been backported to some versions but not to others.) Change-Id: I5d4d3586e8046f288a97605b000e262a8db5a4e9 Reviewed-on: https://gerrit.libreoffice.org/61684 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Drop duplicate WINVER and _WIN32_WINNT definesJan-Marek Glogowski2018-10-111-4/+0
| | | | | | | | | | | Just keep the definition of _WIN32_WINNT in windows.mk, which claims it automatically derivates WINVER in some sdk header. Change-Id: I0a83e91ffdc9e0fc847433a92a45424fbfcb189c Reviewed-on: https://gerrit.libreoffice.org/61631 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
* Properly check HRESULTMike Kaganski2018-10-101-1/+1
| | | | | | | | | | | | | | Although the IEnumFORMATETC::Next documentation only mentions S_OK and S_FALSE, there are error codes that also may be returned: e.g., 0x800706BA RPC server unavailable (encountered locally in a unit test). In that case, this used to loop infinitely. We are only interested in S_OK result, so check for it. Change-Id: I062e409e84efb68353321f7c48d922ec83191f73 Reviewed-on: https://gerrit.libreoffice.org/61621 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:external (clang-cl)Stephan Bergmann2018-09-245-13/+13
| | | | | | | | | | | | | | | | | | | | | | Including: * expanding STDAPI to its definition (as per <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#42949 Fix IWYU warnings in include/cppuhelper/*Gabor Kelemen2018-09-105-0/+5
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45 Reviewed-on: https://gerrit.libreoffice.org/59297 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* Fix some std::unique_ptr array allocsJan-Marek Glogowski2018-09-071-1/+1
| | | | | | | | | | | | Found by reviewing the output of and the code around git grep -n "unique_ptr.*new.*\[.*\]" | grep -v "\[\]" The onlineupdater code needs a little bit more attention. Change-Id: I8b70c7da7db60af52bfac12314a21602ede8bfc0 Reviewed-on: https://gerrit.libreoffice.org/60162 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Cppcheck: release the handle that CreateThread returnsMike Kaganski2018-09-071-1/+1
| | | | | | | | Change-Id: I4d6d04873d69d2ff1e5409372b353e0bb9a5d68d Reviewed-on: https://gerrit.libreoffice.org/60120 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:stringloop in variousNoel Grandin2018-07-291-9/+10
| | | | | | | Change-Id: Ic2436c6d94729211cd5bc72fee18af228381e4a3 Reviewed-on: https://gerrit.libreoffice.org/58250 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#42949 remove unused compheler includes ..Jochen Nitschke2018-06-051-1/+0
| | | | | | | | | and fix the fallout Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e Reviewed-on: https://gerrit.libreoffice.org/54882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* tdf#96099 Remove some trivial std::vector typedefsArkadiy Illarionov2018-06-031-5/+4
| | | | | | | Change-Id: I21171bd90b5e19fe8e5b8f2d125b6dfcb9a8b766 Reviewed-on: https://gerrit.libreoffice.org/55198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
* Fix typosAndrea Gelmini2018-04-272-2/+2
| | | | | | | Change-Id: I32c0966f8489d58f02b32bf205aedbb8303a217d Reviewed-on: https://gerrit.libreoffice.org/53432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* remove unused processfactory.hxx includesJochen Nitschke2018-04-012-2/+0
| | | | | | | | | and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* Use for-range loops in drawinglayer and dtransJulien Nabet2018-03-112-13/+7
| | | | | | | Change-Id: I4d3368e2ffa4d98c04d69b8f5ef485558d812fda Reviewed-on: https://gerrit.libreoffice.org/51047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* dtrans: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski2018-02-0120-123/+1
| | | | | | | Change-Id: I7a043bc152373e98635bf2bd3513113a8ea45958 Reviewed-on: https://gerrit.libreoffice.org/48974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* More loplugin:cstylecast on WindowsStephan Bergmann2018-01-232-2/+2
| | | | | | | | | | | | Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* inline some definesNoel Grandin2018-01-191-2/+1
| | | | | | which don't add any value anymore Change-Id: I45977d972d4d02926630b749d3ec736416138cf5
* Fix typosAndrea Gelmini2017-12-193-3/+3
| | | | | | | Change-Id: Ibffe19c1dfda9d0f4ba8d2a0761ad1222491007f Reviewed-on: https://gerrit.libreoffice.org/46599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:salcall (clang-cl)Stephan Bergmann2017-12-1516-68/+68
| | | | | | | Change-Id: Idda630320bb5e02e1ea675b3b3786c9ec6ac166b Reviewed-on: https://gerrit.libreoffice.org/46504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:salcall fix functionsNoel Grandin2017-12-112-3/+3
| | | | | | | | | | since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-05-05 20:17:49 +0000