summaryrefslogtreecommitdiffstats
path: root/desktop
Commit message (Collapse)AuthorAgeFilesLines
* Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann2016-05-101-1/+1
| | | | | | | | | | | | | | | | ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
* desktop: warning C4101 unreferenced local variableMichael Stahl2016-05-091-1/+1
| | | | Change-Id: I6059dd33828e4d8034e0489068615e96bf5f2e02
* LOK: drop identical invalidation notificationsAshod Nakashian2016-05-092-13/+19
| | | | | | | | | | | And drop duplicate GRAPHIC_SELECTION notifications. (cherry picked from commit 7cdfe080432f69c2247cc7ff28316b653bd654ff) Change-Id: I0c372efa9a58620e24cea219d82479cdc9dff359 Reviewed-on: https://gerrit.libreoffice.org/24771 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
* LOK: SAL_WARN for each removed event is unnecessaryAshod Nakashian2016-05-091-2/+2
| | | | | | | Change-Id: If5e4c7b8751ae4eeb278475fb00118e32c6bb565 Reviewed-on: https://gerrit.libreoffice.org/24730 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
* Don't change part on text documents to paint tilesAshod Nakashian2016-05-091-4/+10
| | | | | | | | Change-Id: Icb5fb46cbc9d2f72c814cf9f1f166382493d403f Reviewed-on: https://gerrit.libreoffice.org/24702 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit aadab5f4a72e38ccc8bbe9b7811d2cdcaa00124c)
* Allow painting for arbitrary partAshod Nakashian2016-05-092-1/+59
| | | | | | | | | | | | | | | | | | | | | | | | Painting should not cause any state changes, but to paint a tile on a different part than the current has to change the document, which sends notifications to all clients. A new API, paintPartTile, allows for painting tiles on any part without sending change of part notifications. Furthermore, because we block notifications during this operation, no tile invalidation is issued due to changing of the part. One issue remains in the cases when the LO Core resets the cursor position internally and we resume editing after painting, the cursor might be at the top of the page. This needs fixing separately. Change-Id: If19bd1c90ecad4d5ed5e8d09513741b7994fa6e5 Reviewed-on: https://gerrit.libreoffice.org/24698 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
* Some LOK notifications are dropped if they are superseeded by later onesAshod Nakashian2016-05-092-61/+98
| | | | | | | | Change-Id: I323e46a2a6c60b200b182b89199945f99a7f384a Reviewed-on: https://gerrit.libreoffice.org/24567 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit cf98799fff7ae999bd62cec6486c986bf44000cc)
* std::tuple -> std::pairAshod Nakashian2016-05-091-3/+3
| | | | | | | | Change-Id: I2f11436a5c9691c2a0aac3655bc2c543d1c3d684 Reviewed-on: https://gerrit.libreoffice.org/24566 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 8a6dab5da851f38a8ecef633e06e3cb2ac5e7849)
* More LOK callback notification compressionAshod Nakashian2016-05-092-1/+25
| | | | | | | | | | SET_PART, CELL_CURSOR, CELL_FORMULA, and CURSOR_VISIBLE are now deduplicated. Change-Id: I4c17307c6f8b7c68bdfe55b4e90da4d34c55d085 Reviewed-on: https://gerrit.libreoffice.org/24565 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit a9771e1f4d0d2602713983ab1f3e743784e9ae72)
* loplugin:redundantcastTor Lillqvist2016-05-091-1/+1
| | | | | | | reinterpret_cast from 'void *' to 'std::vector<std::tuple<int, std::string> > *' can be simplified to static_cast. Change-Id: I1899a1c570c4c56d8c7fe73745eac45061fb8bae
* Desktop compresses text selection start/end notificationsAshod Nakashian2016-05-092-1/+36
| | | | | | | | | | Change-Id: Ia85ded04d0eaf9d9b846fab6d86a44a758fccb69 Reviewed-on: https://gerrit.libreoffice.org/24320 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 45037438d84485356a5ceb820ecc3e0bae4b112e) Reviewed-on: https://gerrit.libreoffice.org/24380 Tested-by: Jenkins <ci@libreoffice.org>
* Desktop compresses mouse pointer notificationsAshod Nakashian2016-05-082-4/+10
| | | | | | | | | | Change-Id: Id76f4e2952c4c551b626d094c11eb3339d76e50c Reviewed-on: https://gerrit.libreoffice.org/24319 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 7c01cf652850a8b8d3fd5ef6eb0a12ca6e725943) Reviewed-on: https://gerrit.libreoffice.org/24379 Tested-by: Jenkins <ci@libreoffice.org>
* Test desktop notification compressionAshod Nakashian2016-05-081-0/+54
| | | | | | | | | | | | Reviewed-on: https://gerrit.libreoffice.org/24314 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit bb52a54aa49cbb75820f8ddbfc8e9e94b63281cd) Change-Id: Ibb9a62bb5e1500a068c24346d6d433012a1bc7dd Reviewed-on: https://gerrit.libreoffice.org/24378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* loplugin:redundantcastTor Lillqvist2016-05-081-1/+1
| | | | | | | Reinterpret_cast from 'void *' to 'desktop::CallbackFlushHandler *' can be simplified to static_cast. Change-Id: I648e91d0ca234162833f19595ae60838f81963bc
* New LOKDocument callback queue to flush events lazily on idleAshod Nakashian2016-05-074-27/+134
| | | | | | | | | | | | | | | | | Since desktop now queues up callback notifications and flushes them to the client on idle, the unit-tests must yield and process all tasks before they validate post-conditions. (cherry picked from commit e6a429770bde5da75239961ae88c06c78cfa5686) (cherry picked from commit 1f278848117080cd6e819f04ba428be52416af7c) (cherry picked from commit 6ca6f22777eb3651109cbf403577d0022a735c9b) (cherry picked from commit 548faf728cf097d93c3f6478ceea5f8747e789c6) Change-Id: I78307db29a9ce647ffaed3539f953227c605968e Reviewed-on: https://gerrit.libreoffice.org/24377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* coverity#1359235 Resource leakCaolán McNamara2016-05-061-11/+9
| | | | Change-Id: I3f307211c70384b55b62314a7aa302ffcdfc7398
* -Werror,-Wlogical-not-parenthesesStephan Bergmann2016-05-021-1/+1
| | | | Change-Id: I0ed6445964523b17ca5635d4d26cd429ff60c294
* tdf#99311 Detect SSDs in pageinNurhak ALTIN2016-05-011-0/+29
| | | | | | | | | Avoid doing the pagein work if we can detect a non-rotational disk. Change-Id: I1ce11050d7ed2a805568343cd385f2612d7c8939 Reviewed-on: https://gerrit.libreoffice.org/24560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* Fix typosAndrea Gelmini2016-05-011-1/+1
| | | | | | | Change-Id: Ideafa411b53fe4a5f2e6559be10c4cb82b58a256 Reviewed-on: https://gerrit.libreoffice.org/24543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* Fix typosAndrea Gelmini2016-04-301-1/+1
| | | | | | | Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* update loplugin stylepolice to check local pointers varsNoel Grandin2016-04-261-8/+8
| | | | | | | | | | | | are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy modernize-loop-convert in d*Noel Grandin2016-04-259-39/+36
| | | | Change-Id: I0830a41b48e884ef63d32b5873c7007195659bb9
* Avoid reserved identifierStephan Bergmann2016-04-221-1/+1
| | | | Change-Id: Ifad7619d1d5ed101cf098787461bca31b02fc81e
* lok: getPartHash should be at the end, it is a new API call.Jan Holesovsky2016-04-211-1/+21
| | | | | | Also add it to the init.cxx so that it is actually used. Change-Id: I255411158d0822718116ac05aad1ee925a9a7a9a
* new plugin stylepoliceNoel Grandin2016-04-213-7/+7
| | | | | | | check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
* loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2016-04-209-27/+27
| | | | Change-Id: Ie48c55954d479092ef0447711c442b760905a2b4
* In lok_init_2, allow vnd.sun.star.pathname user_profile_urlStephan Bergmann2016-04-191-3/+18
| | | | | | | | | | | | | | | ...which takes a raw filesystem pathname that is internally converted to a file URL (similarly to what is supported for the INIFILENAME and URE_BOOTSTRAP bootstrap variables in rtl::Bootstrap). That way, the gtktiledviewer executable doesn't need to try convert a pathname into a URL. Also adapted various parameter names to make it obvious that URLs get passed, not pathnames. Change-Id: I33ab31fe142d94ee47885033ef48278ef5ff55a2 Reviewed-on: https://gerrit.libreoffice.org/24241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* clang-tidy performance-unnecessary-copy-initializationNoel Grandin2016-04-183-4/+3
| | | | | | | | | | | probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* clean-up: unused using declarations and includesJochen Nitschke2016-04-181-1/+0
| | | | | | | | | | | | | | Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Use the true exit code 77 hereStephan Bergmann2016-04-141-1/+1
| | | | Change-Id: Ice61e770dd3cc9ac3beb7646a6fb298c1a4e46d9
* loplugin:passstuffbyref in variousNoel Grandin2016-04-146-13/+13
| | | | Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
* tdf#94306 remove unused boost dependenciesJochen Nitschke2016-04-132-2/+0
| | | | | | | | | | remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* lok context menu: Add module specific unit testsPranav Kant2016-04-132-5/+239
| | | | | | | | | | For calc, now click on the image to have more diverse context menu with checkbuttons etc. Change-Id: Ibe2471348b2572523f2684144bd18664ab48a2bb Reviewed-on: https://gerrit.libreoffice.org/24006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.com>
* Avoid reserved identifierStephan Bergmann2016-04-121-4/+3
| | | | Change-Id: I2c9d6a750f3a7d1ce29f3e9fe315defc63c46e46
* remove that unused old codeMarkus Mohrhard2016-04-121-28/+0
| | | | Change-Id: I576f6be6d229e29d0ae35ffb00d118bfd44b5544
* loplugin:defaultparamsStephan Bergmann2016-04-121-1/+1
| | | | Change-Id: I5748482eb246b2ccf87a02df6406e2624ee66921
* lok context menu: unit testPranav Kant2016-04-123-0/+149
| | | | | | | Change-Id: I244fbf4b98368c7c0d66cdd865e1243639727026 Reviewed-on: https://gerrit.libreoffice.org/23985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.com>
* cleanup: remove unused com/sun/star/uno includesJochen Nitschke2016-04-121-1/+0
| | | | | | | | | | | | Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#94306 replace boost::noncopyable in d...Jochen Nitschke2016-04-086-19/+31
| | | | | | | | | | | | | | dbaccess, desktop and drawinglayer. Replace with C++11 delete copy-constructur and copy-assignment. Nothing special, only one unused include in dbaccess/source/filter/xml/xmlfilter.cxx. Change-Id: Iebabbc658215162450d4caf08d4fb2f116c456d9 Reviewed-on: https://gerrit.libreoffice.org/23918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
* refactor pagein, as it still seems to cause rare crashesBjoern Michaelsen2016-04-071-19/+11
| | | | | | | | Change-Id: I51e6cdf79c19c3709e00dc10175527ec6583a758 Reviewed-on: https://gerrit.libreoffice.org/23872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* CppunitTest_desktop_lib: avoid #include "../..." style includeMiklos Vajna2016-04-072-1/+6
| | | | Change-Id: Ib5ce0dee00c9306f89ad4b43af4b34e604147a1c
* RequestHandler::Disable(join = false) is problematicStephan Bergmann2016-04-052-4/+4
| | | | | | | | | | | | | | ...as it causes ~RequestHandler to be called with mIpcThread still running, triggering the assert in ~RequestHandler and keeping the thread potentially still running during exit. The odd SalMainPipeExchangeSignal_impl acting upong just SIGTERM (instead of turning off the IPC thread early for each invocation of LO's signal handler, say) is effectively like that ever since ee3351d78c9b6ffbc4dfe62853e81b84e65879c7 "#89023# splash screen optimization"; just change it to use RequestHandler::SetDowning instead. Change-Id: I238476706c2463130a6ede64a062d46af953ba6f
* loplugin:constantparamNoel Grandin2016-04-054-16/+6
| | | | | | | Change-Id: I821ed77a6c6014c9a82d31a4b117ed6f1b4abf18 Reviewed-on: https://gerrit.libreoffice.org/23832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Consistently use "desktop.app" log area hereStephan Bergmann2016-04-051-3/+3
| | | | Change-Id: Ie31f1ea788cc2b8b0d6c672d93df84adb3326a05
* Remove whitespace randomly insertedStephan Bergmann2016-04-051-1/+1
| | | | | | | ...with 221144f9c995fe30adf577c02f756b3123fb2550 "tdf#91794 OSL_DEBUG_LEVEL > 1 removed (desktop)" Change-Id: Ief7193bb5cb10e633744b545bca9416ffa37c20e
* -Werror,-Wunused-functionStephan Bergmann2016-04-051-36/+0
| | | | Change-Id: I2d0a21b0f38feafa6e3fde0245b1fdb9b5771152
* sequence->vector in xmlscriptNoel Grandin2016-04-059-45/+39
| | | | | | | Change-Id: I4f99cd9dc659f54bd4818559dd3e0dbce1e8f5d4 Reviewed-on: https://gerrit.libreoffice.org/23795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* No DBUS_TIMEOUT_INFINITE before D-Bus 1.4.12Stephan Bergmann2016-04-041-2/+1
| | | | Change-Id: Ie53359fb2b6a73fa3611e56314ae2df00457adc0
* ...and MSVC "warning C4701: potentially uninitialized local variable used"Stephan Bergmann2016-04-041-2/+2
| | | | Change-Id: I4a7eab0cbca2da04b81867158d15c94eda16d3b2
* Try silence bogus -Werror,-Wsometimes-uninitializedStephan Bergmann2016-04-041-1/+1
| | | | Change-Id: I85528ab58e6f29464a3b4a78096e5b9575735220
generated by cgit (git 2.34.1) at 2024-08-04 05:49:04 +0000