summaryrefslogtreecommitdiffstats
path: root/desktop
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:subtlezeroinit: desktopStephan Bergmann2017-02-211-1/+1
| | | | Change-Id: I23ffaa7e5f138f877832ad3afe591980aada6578
* desktop: unit test to for sd ViewAnnotations commandPranav Kant2017-02-202-0/+60
| | | | Change-Id: Ib830ff786f12d9edc791623dead74b3eeeabad71
* lok: listen for DeleteAnnotation state changesPranav Kant2017-02-201-0/+1
| | | | Change-Id: I2ea0d237cbbfd912b012ed400a328bfb6546cdfb
* tdf#100826 related: initialize stdout/stdin/strerr properlyMike Kaganski2017-02-181-25/+9
| | | | | | | | | The previous code doesn't work with VS2015. Change-Id: Ide75b2f978dda871874572a093039b5772a2b537 Reviewed-on: https://gerrit.libreoffice.org/34409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Drop :: prefix from std in [de]*/Tor Lillqvist2017-02-1742-153/+153
| | | | | | | Change-Id: I3247894fe022dce7f0aa351bd85fefcd7c545dd4 Reviewed-on: https://gerrit.libreoffice.org/34377 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
* sc lok: Unit tests for Comments APIPranav Kant2017-02-172-1/+56
| | | | | | | Change-Id: I896c8b25cab6d80d374d273eb3945716bc0694d6 Reviewed-on: https://gerrit.libreoffice.org/34365 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* sw lok: Move this test to sw/Pranav Kant2017-02-171-102/+3
| | | | | | | Change-Id: I9bf901a4c8ffbdd54a98ff043ea1e658aeb62839 Reviewed-on: https://gerrit.libreoffice.org/34364 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* drop BitmapMode enumNoel Grandin2017-02-161-27/+0
| | | | | | since we only use the BM_DEFAULTMODE enumerator Change-Id: I425a2ca09d4a15d755010e8f963387071c0138ae
* convert HelpProcessingErrorClass to scoped enumNoel Grandin2017-02-161-3/+2
| | | | | | and drop unused HELPPROCESSING_INTERNAL_ERROR enumerator Change-Id: I0f2cf063a3f1472e1d52bab5039b1c3158d4865e
* SvxPostItIdItem is now string typePranav Kant2017-02-161-4/+4
| | | | Change-Id: Id44bf5dd623749b6e9a46f121f035aa5ce617557
* LOK - Calc: Increase the row limit to 10.000 rows.Marco Cecchetti2017-02-131-19/+57
| | | | | | | Change-Id: Ie91e4caf33d3b31df4c3de8dc6e78e223dc1e4b3 Reviewed-on: https://gerrit.libreoffice.org/34216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
* Upon failure, 'cd' itself already prints a message to stderrStephan Bergmann2017-02-112-20/+6
| | | | Change-Id: Iabe3a6bb14ca3e83a0792d7fc131ae0ac74e578c
* Remove MinGW supportStephan Bergmann2017-02-105-36/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* convert InsertOperation to scoped enumNoel Grandin2017-02-105-8/+8
| | | | | | and drop unused LINK enumerator Change-Id: I6c42424ae5a7503b3e14e5f04fcf7a49b595b416
* convert SearchParam::SearchType to scoped enumNoel Grandin2017-02-102-3/+3
| | | | | | | | | and drop unused SRCH_LEVDIST enumerator Change-Id: Ic5118757060656562e04dd7da24a3f143abec3fb Reviewed-on: https://gerrit.libreoffice.org/34065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* coverity#1242486 Out-of-bounds accessCaolán McNamara2017-02-081-1/+1
| | | | Change-Id: I24d73edd90a7fbfe63dd70a1784fb2276ceb079b
* Add missing #includesStephan Bergmann2017-02-0629-3/+52
| | | | | | | | | ...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
* Revert "fix desktop scripts"Stephan Bergmann2017-02-062-2/+2
| | | | | | | | | | | | This reverts commit f52eb759f61e1806014972cb736e07479f157aa6. I assume this was intented to be a fix for e6a9dc22a4e58b565894f8cdb6a19755af7b14de "tdf#105204 fix shellcheck warnings in desktop/scripts" (later addressed with 7ba0b28cc3ac82f5c5c6d7e2536cb89771041893 "Unbreak soffice.sh"). But I think these quotations are actually useful parts of that original commit. I fail to see how pathname expansion (aka globbing; nor field splitting, if that is what was actually meant in "we want globbing here") should be a useful feature here. Change-Id: I5c33c40cfe2a817f628442fed70a07f06dd275cc
* Unbreak soffice.shStephan Bergmann2017-02-041-2/+2
| | | | Change-Id: I8c827db4c16a4a169dd710787bf9beb123ddc7b6
* fix desktop scriptsJochen Nitschke2017-02-042-2/+2
| | | | | | | | | | reverts parts of e6a9dc22a4e58b565894f8cdb6a19755af7b14de we want globbing here Change-Id: Ibe4672f41b0fe6a75d1aca898cc55414e138f6ef Reviewed-on: https://gerrit.libreoffice.org/33913 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* tdf#105204 fix shellcheck warnings in desktop/scriptsqarkai2017-02-0410-45/+67
| | | | | | | | | | | | Use $(..) instead of `..`, use && and || instead of -a and -o, double quote to prevent word splitting, handle cd failure. Change-Id: I860891323a81ac4a46c868ab028df1e1f837c115 Reviewed-on: https://gerrit.libreoffice.org/33897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
* sc rowlimit: Make the cursor better fit the rendering.Marco Cecchetti2017-02-041-1/+1
| | | | Change-Id: If4d02161bd8a37100d7403c05ea0840a3d2d0cf8
* Typo: progess->progressJulien Nabet2017-02-031-1/+1
| | | | | | | Change-Id: Ic13529f4bc9ac49059a59067c50d5f2c0f569822 Reviewed-on: https://gerrit.libreoffice.org/33902 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* unnecessary use of OUStringBuffer in throwing exceptionsNoel Grandin2017-02-021-7/+3
| | | | | | | Change-Id: Iec1473264426f19c31e72260dfce9494389e474f Reviewed-on: https://gerrit.libreoffice.org/33788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Need <config_features.h> here, tooTor Lillqvist2017-02-011-0/+1
| | | | Change-Id: I39d443e582a6e82947f9c833b157f137a082a358
* stoi not a member of std under android toolchainCaolán McNamara2017-02-012-5/+5
| | | | Change-Id: I73a4e7894e33dd95ca50ea25f5f95bf94a43531e
* Replace a terribly expensive json parsing with a peek for the value.Jan Holesovsky2017-01-311-4/+20
| | | | | | | | We should reduce the amount of callbacks from the core in the first place, so that we don't have to deduplicate this much here, but this already helps a lot. Change-Id: Idf4a3681ac0f47536e00c1d97152f3f8bb99894b
* Revert "Lok: support for batch API calls"Jan Holesovsky2017-01-313-75/+0
| | | | | | | | This was for the moment removed from the online.git, so let's disable the API bits too before it shows this is really necessary. Reverts also: Revert "Lok: unittest batch API" Change-Id: I7bf3fe62d1e73b6f233992d51f587868a78f4bec
* Remove meaningless commentStephan Bergmann2017-01-311-2/+0
| | | | Change-Id: I4385376dffa6b7cbc0da3903f285185a6db928dc
* Create missing parent dirs when checking for r/o dirStephan Bergmann2017-01-311-2/+22
| | | | | | | ...can happen when 'unopkg add' is called before soffice had ever been run, so UserInstallation isn't populated yet Change-Id: I0c6b9444f196da5ad5a32cc90f2e1e2a5dbd0f58
* teach lolugin:stringconstant about calling constructorsNoel Grandin2017-01-314-6/+6
| | | | | | | | | | | so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* a whole bunch of SAL_WARN_UNUSEDNoel Grandin2017-01-311-1/+0
| | | | | | | Change-Id: Iea28debc7d3abc58cca21bd3856cb65b321dc1e6 Reviewed-on: https://gerrit.libreoffice.org/33693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* lok: Allow to edit comment by postit idPranav Kant2017-01-301-0/+14
| | | | | | | Change-Id: Ice1d40b7813226fe99c423047392b3416d763dd4 Reviewed-on: https://gerrit.libreoffice.org/33614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
* lok: Unit test for comments apiPranav Kant2017-01-272-0/+141
| | | | | | | Change-Id: Ieedb50a4d376c1214ea23b56c8cab19c96c159d0 Reviewed-on: https://gerrit.libreoffice.org/33615 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* lok: Allow to reply to comments using postit idPranav Kant2017-01-271-0/+1
| | | | | | | Change-Id: Ic6aaa3066923d62f197bc2b0e02e8049c9d7cd2c Reviewed-on: https://gerrit.libreoffice.org/33612 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* lok: New commandvalues command - .uno:ViewAnnotationsPranav Kant2017-01-271-0/+19
| | | | | | | Change-Id: I1c3560ab4609c64da7a77e9a65febeb569ec1a3c Reviewed-on: https://gerrit.libreoffice.org/33468 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* Put crash directory config in soffice.ini, instead of own ini fileSamuel Mehrbrodt2017-01-271-3/+11
| | | | | | | Change-Id: I3a7aa394792c47c6c5a3a553174d177e66ade617 Reviewed-on: https://gerrit.libreoffice.org/33582 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Remove dynamic exception specifications from !LIBO_INTERNAL_ONLYStephan Bergmann2017-01-272-46/+22
| | | | | | ...only odk/examples/ remains to be clean up Change-Id: I875a1e8d6750b6b007bd75126b8010273e1f32d5
* Remove dynamic exception specificationsStephan Bergmann2017-01-2661-1086/+345
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Crashdump: Make crash directory configurableSamuel Mehrbrodt2017-01-241-11/+13
| | | | | | | Change-Id: I8106ec674080ede7072581dab2e6700040de5828 Reviewed-on: https://gerrit.libreoffice.org/33032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Change all Idle* LINKs to be Timer*Jan-Marek Glogowski2017-01-233-8/+8
| | | | | | | | | | | | | | | | | | | | | Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
* lok: New feature flag to turn off tiled annotationsPranav Kant2017-01-231-0/+2
| | | | | | | Change-Id: Ie418642242ada98d4a41f30bb6cefcd57f398ef0 Reviewed-on: https://gerrit.libreoffice.org/33472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
* loplugin: unnecessary destructor: comphelper..desktopNoel Grandin2017-01-234-10/+0
| | | | | | | | Change-Id: I9df4cb6a4b1734dac6141d6b0ee7a09e3e05f92e Reviewed-on: https://gerrit.libreoffice.org/33453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* lok: Listen for state change events for cell alignment commandsPranav Kant2017-01-231-0/+3
| | | | | | | | | | | | We used to use HorizontalAlignment uno command for cell alignment both in online and gtktiledviewer. To make things simpler, lets use separate cell alignment uno commands for spreadsheets like we have in writer and impres. Change-Id: I2a959d1892f6b02db7a9ce51d55309216e4b3c6c Reviewed-on: https://gerrit.libreoffice.org/33444 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* Lok: unittest batch APIAshod Nakashian2017-01-231-0/+45
| | | | | | | Change-Id: I33bc59756f46b51a69efd91b89813ba17eca6218 Reviewed-on: https://gerrit.libreoffice.org/33403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* Lok: support for batch API callsAshod Nakashian2017-01-232-0/+30
| | | | | | | | | | | | | | | | | | | | | Mouse and keyboard operations typically come in batches, and often each results in tile invalidations and/or layout modifications. Processing each input event on its own, then processing the resulting output event is very costly and unecessary when we know there is more of the same. The new API adds support for batching such related input events by disabling the output events generated by Core until the batch is done. The client can then process the resulting events, which will be compressed and deduplicated. Change-Id: Id381dab807186d010021a8778ee440074a739920 Reviewed-on: https://gerrit.libreoffice.org/33402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* coverity#1399016 Logically dead codeCaolán McNamara2017-01-211-2/+6
| | | | Change-Id: Ib3f0ca4d07dffb568287bcd6a283ab4e529519ff
* unused hicontrast iconCaolán McNamara2017-01-202-7/+0
| | | | Change-Id: Iebab45a52319ab531ec27d10fc5c5304d8e7a0a0
* const these upCaolán McNamara2017-01-201-14/+14
| | | | Change-Id: Ide19ec6a04a591327effe6d3c4da5db62e58b4c9
* New loplugin:dynexcspec: Add @throws documentation, desktopStephan Bergmann2017-01-195-0/+14
| | | | Change-Id: I1e97b929174ba23fdf21c405ec4129f0e56ed2f3