summaryrefslogtreecommitdiffstats
path: root/desktop
Commit message (Collapse)AuthorAgeFilesLines
* typo fixes in commentsAndras Timar2014-02-061-1/+1
| | | | Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
* Typo: seam(s) -> seem(s)Julien Nabet2014-02-061-1/+1
| | | | Change-Id: I840d120644760b61a39ad88b4095056f0f753bb7
* Introduce com.sun.star.ui.theWindowStateConfiguration singleton.Matúš Kukan2014-02-061-2/+2
| | | | Change-Id: I50861ac8952d54cb1a45846ea72a2ecac4f83409
* Change Application::SystemSettingsChanging to OverrideSystemSettingsChris Sherlock2014-02-042-23/+22
| | | | | | | | | | | | The name Application::SystemSettingsChanging implies that the app is being notified that system settings are being changed. This is not what the function does - in fact, SystemSettingsChanging overrides a settings object with user defined settings Change-Id: Ibbf821ff3c7ec5b38e2e79751058494c749b6428 Reviewed-on: https://gerrit.libreoffice.org/7629 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
* EXC_SYSOBJNOTCREATED was not really usedTor Lillqvist2014-02-031-7/+0
| | | | Change-Id: Id5ece6db33aa92b619571252df91b965a8805c96
* coverity#707748 : Uninitialized scalar fieldNorbert Thiebaud2014-02-011-9/+10
| | | | Change-Id: I9155c4ab7409d1fa00abbc3c81ff03d0c0d3910b
* Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton.Matúš Kukan2014-01-301-2/+2
| | | | Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
* coverity#1158237 Resource leakCaolán McNamara2014-01-291-0/+1
| | | | Change-Id: I2204ec36344b8f7662efa8aed31e9363bb791616
* Introduce com.sun.star.ui.theUIElementFactoryManager singleton.Matúš Kukan2014-01-291-2/+2
| | | | | | | To replace single-instance com.sun.star.ui.UIElementFactoryManager service. Change-Id: I4262909c4396e3907d271a56696a06903168a58d
* Introduce com.sun.star.frame.ControllerFactory singletons:Matúš Kukan2014-01-291-3/+2
| | | | | | | | | | com.sun.star.frame.thePopupMenuControllerFactory com.sun.star.frame.theStatusbarControllerFactory com.sun.star.frame.theToolbarControllerFactory To replace their single-instance service variants. Change-Id: I00586d0d61e63f9482cb659071e88aa9cf02d5b5
* bool improvementsStephan Bergmann2014-01-2816-24/+24
| | | | Change-Id: Ie4c9d7f01fef2604d80d8e465ce30daab7481eed
* Introduce com.sun.star.frame.theUICommandDescription singleton.Matúš Kukan2014-01-282-4/+4
| | | | Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
* Introduce com.sun.star.frame.theAutoRecovery singleton.Matúš Kukan2014-01-281-2/+2
| | | | | | | | | To replace com.sun.star.frame.AutoRecovery single-instance service, incorrectly converted in 279859fdbc40f68d8f1649fa5b928d9de49e8d9e Unfortunately needs a lot of changes in autorecovery.cxx. Change-Id: Iba5188dffea3e03803236f23e0b3f343746ace90
* Introduce com.sun.star.task.theJobExecutor singleton.Matúš Kukan2014-01-244-5/+2
| | | | | | | | | | | | To replace com.sun.star.task.JobExecutor single-instance service, incorrectly converted in 748aa84e9808ad31c6ff6b71459525c82de10e58 [including changes by Stephan Bergmann <sbergman@redhat.com>] Change-Id: I4cea2c63a20b5b22f6e1f822fb35fcc4d0397687 Reviewed-on: https://gerrit.libreoffice.org/7609 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* Let C++ inline functions return bool instead of sal_BoolStephan Bergmann2014-01-231-1/+1
| | | | | | | | | | | | | ...to improve diagnosing misuses of boolean expressions in client code (cf. compilerplugins/clang/implicitboolconversion.cxx). This change should be transparent to client code. Missing overloads of insert() for bool have been added to OStringBuffer and OUStringBuffer (which required dropping one !VALID_CONVERSION check that would now pick that overload, but would be flagged by compilerplugins/clang/pointertobool.cxx). Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
* Move defines into settings.hxxChris Sherlock2014-01-231-8/+1
| | | | | | | | | | | | | | | | | | For some unknown reason, there are a bunch of defines in the middle of Desktop::SystemSettingsChanging() that should really be in include/vcl/settings.hxx. I have now moved DRAG_OPTIONS_ALL into settings.hxx but entirely removed DRAG_OPTIONS_NONE because it is confusing. I also removed it in the one place this combination of options is used in the Desktop class. I have also removed the options DRAG_OPTIONS_OBJECT_* from settings.hxx because they are used nowhere in the code. I have carefully looked through the code and nothing flips bits 0x00000004 or 0x00000008 on the private member of ImplStyleData's mnDragFullOptions in any way. Basically, it is safe to remove. Change-Id: Icf6268f940cfaed271bd43c977473fecfc726949 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* Improve settings code reabilityChris Sherlock2014-01-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | Application::SetSettings relies on Application::GetSettings to initialize the application's settings if this hasn't happened. This means that GetSettings is being used not to get the app's settings, but to initialize the settings! I have corrected this by introducing a private static function InitSettings(). Note that I assert if it attempts to initialize already initialized settings, because the (Get|Set)Settings does the check for you. Also changed a local variable from nGet to nDragMode in Desktop::SystemSettingsChanging to make it easier to read the code. Whilst this is minor, a variable name of "nGet" seems very sloppy. Change-Id: I04975217c2028b3489179997db4287957578cc93 Reviewed-on: https://gerrit.libreoffice.org/7586 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
* bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)Stephan Bergmann2014-01-222-4/+4
| | | | Change-Id: I9869d9709f28b68ef7b518527175589d80644668
* bool improvementsStephan Bergmann2014-01-223-7/+7
| | | | Change-Id: Iddc92e42a100a0fb36c77c21d4c176dded8f3391
* Remove unused Window parameter from SystemSettingsChangingChris Sherlock2014-01-202-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This took a bit of code archaelogy for me to track down. It turns out that as part of an effort to optimize startup, the line of code in this function was commented out, presumably to be rewritten later. This happened in commit ee3351d78c in July 2001 (!). About three years later, in February 2004, the function was rewritten in commit 189c2388d80. As it turns out, the only two functions that used the Window parameter were vcl/source/window/window.cxx (which passed itself in, but of course this did nothing) and vcl/source/window/winproc.cxx. Furthermore, winproc only ever passed in the first frame, so it didn't really do anything either. Consequently, the function as it stands *now* only notifies the application that system settings have been changed. It doesn't care which window it tells. Therefore, I have excised this parameter from the function. I don't think it made sense when it was implemented anyway, so there is no net loss. After removing the unneeded parameter, I was also able to remove the Window parameter from winproc.cxx's ImplHandleSalSettings function as it was only ever used to set the top level window, which is now irrelevant. Change-Id: I84f2c5c5ff8969387da3af81e4a9c7f9ac6237e1 Reviewed-on: https://gerrit.libreoffice.org/7541 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* fdo#73549 do not attempt to resolve an empty localeEike Rathke2014-01-171-0/+3
| | | | | | ... to match installed UI locales Change-Id: If0ad0fde392bc5ea3cf454f4858330f5e93a6666
* Window::Notify should return boolStephan Bergmann2014-01-174-6/+6
| | | | Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
* Introduce com.sun.star.frame.theGlobalEventBroadcaster singletonStephan Bergmann2014-01-161-2/+2
| | | | | | | ...to supersede com.sun.star.frame.GlobalEventBroadcaster single-instance service. Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
* EndDialog takes long nResult, not boolStephan Bergmann2014-01-141-2/+2
| | | | Change-Id: Ic6283b7a71a5d1c539ae99155f448e34e877080a
* Missing XServiceInfoStephan Bergmann2014-01-083-4/+47
| | | | Change-Id: Ifc5454bbcd29730002b0a3261d2c34dee8ffb843
* Some ConfigurationProvider -> theDefaultProvider simplificationsStephan Bergmann2014-01-081-9/+6
| | | | Change-Id: I7c25cd94f8a1ca339f7423c26f21f13c7a68906d
* remove unnecessary sal_Unicode casts in OUStringBuffer::append callsNoel Grandin2014-01-079-12/+12
| | | | | | | | | Convert code like: buf.append( static_cast<sal_Unicode>('!') ); to: buf.append( '!' ); Change-Id: Iacb03a61de65a895540940953b49620677b3d051
* Some make file fixingZolnai Tamás2013-12-271-1/+1
| | | | | | Related to d1c74734c8d9026b0f0c03f7382ca60165cec8c6 Change-Id: Ic3a6147f0615e79640ec9f567168f93219d34020
* Transex3: NO_LOCALIZE_EXPORTZolnai Tamás2013-12-271-1/+4
| | | | | | | | | | | | | In the past, NO_LOCALIZE_EXPORT macro must be used to skip uneeded parsing of src files which has no localizable content. It is unsued by now and it is more effective to handle this files on gmake level: gb_SrsTarget_add_nonlocalizable_files gb_SrsTarget_add_nonlocalizable_templates Plus remove some empty src file. Change-Id: I8fc9b2db0b5fd7a3379d3c5be970c4fc691f4c53
* WaE: unused variable 'ARGUMENT_PREFIX'Tor Lillqvist2013-12-261-2/+1
| | | | Change-Id: I88b8a66ccc4da951e92cce0e4b5d66dcff8bf477
* WaE: unused variable 'url'Tor Lillqvist2013-12-261-1/+1
| | | | Change-Id: I6ae6a95bdf9b0f82384dfdcbdefc6a546f81ef0f
* WaE: unused variable 'XDG_CONFIG_PART'Tor Lillqvist2013-12-261-1/+2
| | | | Change-Id: I35435dc466478002d065e13f6e31c3c68528d7d5
* typo fixesAndras Timar2013-12-202-3/+3
| | | | Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
* use proper LanguageTag fallback instead of dumb startsWith(), fdo#68714Eike Rathke2013-12-191-9/+4
| | | | | | | A ca_ES@valencia (=> ca-ES-valencia) locale did not result in 'ca-valencia' UI being selected but 'ca' only instead. Change-Id: Ifa405add2ff7b45e030b02af4338de195b457cb2
* resolved fdo#72778 keep setting system locale and LanguageTag in syncEike Rathke2013-12-181-1/+1
| | | | Change-Id: I3547786bf77b8f611bc08d0e52c66ac00e199f13
* No need for implbase1.hxx to include XComponentContext.hppStephan Bergmann2013-12-171-0/+4
| | | | | | | ...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up, of course. Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
* Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann2013-12-176-12/+12
| | | | Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
* Keep using component_getImplementationEnvironment in extensionsStephan Bergmann2013-12-172-0/+16
| | | | | | | | | ...instead of relying on the implicit CPPU_CURRENT_LANGUAGE_BINDING_NAME convention. Keeping that convention an implementation detail makes it easier to do improvements in the future. (Theoretically, the bundled extension in mysqlc could be considered internal code and not adapted, but just be safe.) Change-Id: Iae41a6e072dabc2bf7c1481ba6cfed61680edf37
* remove unnecessary double calls to OUString constructorNoel Grandin2013-12-171-1/+1
| | | | Change-Id: Ib2690e3ec9987b97363687b61fe8ddae4ace9058
* Remove unnecessary use of OUString constructor in + expressionsNoel Grandin2013-12-173-4/+4
| | | | | | | | | Convert code like aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp"); to aFilename = OUString::number(nFilePostfixCount) + ".bmp"; Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
* Clean-up uno/lbnames.hStephan Bergmann2013-12-162-2/+0
| | | | Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
* uiconfig is a l10n-relevant targetBjoern Michaelsen2013-12-161-1/+1
| | | | Change-Id: I8a2ca73c02fd6b04ce60e7701c51d2362ef7ec06
* m_bHasActive must be false after last visible entry is removedStephan Bergmann2013-12-161-0/+6
| | | | | | ...otherwise, ExtensionBox_Impl::RecalcAll would crash in CalcActiveHeight(-1). Change-Id: If399825951c79b821ed44ebefa19d1032ab4f850
* Re-enable building test-active.oxtStephan Bergmann2013-12-1610-80/+89
| | | | Change-Id: I56bd0630f8d238488d9d6598d87acefe1a08fdf0
* Missing "boost_headers"Stephan Bergmann2013-12-161-0/+4
| | | | Change-Id: I6ad89134dbecf043fc3e07f035b43cb504a4fafb
* Targetted text updates, with seasonable changes before l10n freeze.Michael Meeks2013-12-132-2/+2
| | | | Change-Id: If37ef9f68711da3a0aa9a3ba59b111a8a23421df
* Revert "fix windows build"Michael Stahl2013-12-127-35/+42
| | | | | | | | | | | | | | | | | | | | | This reverts commit 45504f9ba8de2a4372193910b2cb9405f1ea896a. The problem that is apparently fixed here is that link.exe is too dumb to pick the right entry-point if the WinMain definition does not come from an object file but a .lib; in that case it apparently defaults to archaic 8-bit WinMain so tell it to use Unicode one with /ENTRY. Conflicts: desktop/Executable_sbase.mk desktop/Executable_scalc.mk desktop/Executable_sdraw.mk desktop/Executable_simpress.mk desktop/Executable_smath.mk desktop/Executable_sweb.mk desktop/Executable_swriter.mk Change-Id: Ib6239eb0fd3d64fd4a292a0d42d65ef75475c389
* use OUString::endsWith where possibleNoel Grandin2013-12-121-1/+1
| | | | Change-Id: Ie2b68f79a7f9a54899f1d727f9a1fc7cfb14d90a
* simplify - use OUString::startsWith where possibleNoel Grandin2013-12-121-1/+1
| | | | | | | | | Convert code like if( !aStr.isEmpty() && aStr[0] == 'x' ) to if( aStr.startsWith("x") ) Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
* Do not use C++-UNO internal static_type functions in client codeStephan Bergmann2013-12-124-11/+11
| | | | | | ...use cppu::UnoType instead. Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31