summaryrefslogtreecommitdiffstats
path: root/desktop/source
Commit message (Collapse)AuthorAgeFilesLines
* clearly we want to match "-env:" only at arg start, not as substring anywhereEike Rathke2016-08-221-1/+1
| | | | Change-Id: Id7238329118ac6f9ddf58b31c6477be002895307
* sw redlines: expose description as part of the UNO/LOK APIMiklos Vajna2016-08-191-0/+4
| | | | | | | | | A redline can have a manual comment and also an autogenerated description, like "Insert 'abc'". Expose this later property as well, as it provides useful additional information, especially when the comment property is empty. Change-Id: Id0f0ff62aef58d96b9b6071706c6f5b4a0d74800
* coverity#1371375 Resource leakCaolán McNamara2016-08-191-1/+2
| | | | Change-Id: I53b5ddc26e77168c29ba1bcfd199b1accbc54d3a
* coverity#1371119 Unchecked return valueCaolán McNamara2016-08-191-1/+1
| | | | Change-Id: I6a39ee4aafe646c542f03c8548e1822837dfde5c
* tdf#101592 sw: track changes state is doc-specific, not view-specificMiklos Vajna2016-08-191-1/+2
| | | | | | | | | So update the bindings of all views after changing it. Change-Id: I5355f40ba27be521dcdf343b08305f3736979bbb Reviewed-on: https://gerrit.libreoffice.org/28233 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* experiment with renaming for bogus coverity#1371326 Misused comma operatorCaolán McNamara2016-08-181-15/+15
| | | | Change-Id: Idd2cc5e888c85a33c9d26aac26c48f3c74571724
* lok::Document::getCommandValues: expose redline infoMiklos Vajna2016-08-171-0/+53
| | | | | | | Index is added as a property for each item, so that later changes can be identified by the index when they are accepted/rejected. Change-Id: I9362d208fdbed1f46d64558d44498d2b19150c81
* Resolves: tdf#44241 highlight the newly installed extensionCaolán McNamara2016-08-152-12/+2
| | | | | | | | | | | | | | | | | | this was changed by commit a6efec83cee0ab447f9e6a5716aee5d2165f95c7 Date: Mon Nov 28 10:54:55 2011 -0200 Fix for bug fdo39748, Easy-hack Cleanup extension list. so restore addPackageToList to not remove the old one before potentially re-adding it, and instead follow the same model as TheExtensionManager::modified to refresh the list Change-Id: I8c3207760361dbd42e400fa9f323ca42971bbcc0 Reviewed-on: https://gerrit.libreoffice.org/28137 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#100965: Restart on initialisation-time OpenCL crashTor Lillqvist2016-08-141-0/+1
| | | | | | | | | | | | | | | | | Add a flag to the OpenCLZone indicating whether we are performing the first-start OpenCL functionality verification, so that if we run into a crash that is caught by the VCL VCLExceptionSignal_impl() handler, we terminate the process with the EXITHELPER_NORMAL_RESTART status after first having disabled OpenCL use. The wrapper process will then restart soffice.bin. This is for Windows only so far. This matches what we do if OpenGL fails early during start of LibreOffice. Change-Id: Ibb9bf3a86b7521bf16728de2a118ad4323be674b Reviewed-on: https://gerrit.libreoffice.org/28086 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
* (initial) sparc64 portJames Clarke2016-08-051-0/+2
| | | | Change-Id: I8ec9bb5415a9e6b9083ba89a7790872d67625de1
* desktop: add undo/redo support to lok::Document::getCommandValues()Miklos Vajna2016-08-051-1/+43
| | | | | | | | | Expose the undo/redo stack and the metadata of each item. Change-Id: I66b81e855a945c97be3d491ed709959f310d4b73 Reviewed-on: https://gerrit.libreoffice.org/27905 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* loplugin:countusersofdefaultparams in chart2..desktopNoel Grandin2016-08-052-2/+2
| | | | | | | Change-Id: Iaca94acd6ef91f07ed0c0085390500c418099dee Reviewed-on: https://gerrit.libreoffice.org/27896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* lok: re-load UNO bootstrap pieces and set UserInstallation on second init.Michael Meeks2016-08-011-1/+3
| | | | | | | | | | Ideally should check whether the path is different. Changing the user-install path is useful for valgrinding online outside of a chroot jail. Change-Id: I6ad76af1245491acdcb6664896be89073406b742 Reviewed-on: https://gerrit.libreoffice.org/27782 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* tdf#100837: honor LibreOffice command line arguments for Office URIsMike Kaganski2016-07-311-80/+67
| | | | | | | | | | | | This patch allows modifying open mode set in Office URI by using LibreOffice usual command line arguments. For instance, if there is -p "ofe:...", then the file won't be open for editing, but instead will be printed. Change-Id: I4bde9b6e1c0e92b63ee3834ee1fd8f6e1bd321f2 Reviewed-on: https://gerrit.libreoffice.org/27629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* desktop: fix Android buildMiklos Vajna2016-07-281-0/+2
| | | | Change-Id: I1ea8edba2dc34386c2748c3ee2310963252082e6
* improve passstuffbyref return analysisNoel Grandin2016-07-273-6/+6
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Restructure CommandLineArgs::ParseCommandLine_ImplMike Kaganski2016-07-262-178/+88
| | | | | | | | | | | | | | | | | | | | | | | | | | | | CommandLineArgs::ParseCommandLine_Impl is restructured to remove multiple redundant booleans and make its structure more clear. Command line "events" (that specify following filenames treatment) are grouped to an enum. (NB: "events" is not invented by me, this is currently used term). Normalized treatment of --display param: now it is always ignored. Previously, if it happened to be a known switch like --writer, it handled as it's not after --display. Immediate parameters to switches --pt, --convert-to, --outdir, --printer-name are now treated likewise. They are treated as corresponding values, even if they happen to be known switches. --language (without "=") is no more a recognized switch. Before this it skipped all filenames until next file management switch. After this gets approved, TODO is to tweak Office URIs to take current event into account: e.g., to print opened file if it's after -p. Change-Id: Ic2f3980548f8906f695d297dc6677bd2cbd19c5b Reviewed-on: https://gerrit.libreoffice.org/27316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* masses of MessBoxes not being disposed promptlyCaolán McNamara2016-07-261-2/+2
| | | | | | | | | | | | | | | | since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
* Fix some misleading commentsTor Lillqvist2016-07-251-4/+2
| | | | Change-Id: I0f29133c3e9b881835b970b2226583ec348828cb
* tdf#100837: Support Office URI SchemesMike Kaganski2016-07-191-1/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds support for Office URI Schemes (see https://msdn.microsoft.com/en-us/library/dn906146). This will enable browser (non-CMIS) integration of LibreOffice with MS SharePoint server (v.2013 tested). In this patch, in addition to ms-* schemes, a new scheme is introduced: vnd.libreoffice.command, which is analogous to ms-*. Its purpose is to enable flexible configuration of server and client, where some types of documents are declared as handled by LibreOffice, and other are handled by other software. E.g., ODTs may have "vnd.libreoffice.command" scheme, while DOCXs could be "ms-word". Client may register LibreOffice to handle both, or to handle only "vnd.libreoffice.command" scheme. Unit test included. TODO in a later patch: add a mechanism to register LibreOffice to the schemes with OS. Change-Id: I1c449a211102036f87163058a4c90a93eb32c948 Reviewed-on: https://gerrit.libreoffice.org/27094 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* lok: Skip saving unmodified doc if DontSaveIfUnmodified=truePranav Kant2016-07-181-2/+48
| | | | | | | Change-Id: Ia2687bd4bef61df1ff101cab2a19394859b7df58 Reviewed-on: https://gerrit.libreoffice.org/27212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
* Related tdf#37531: Make --cat headless/hidden like --convert-toStephan Bergmann2016-07-152-3/+7
| | | | | | | | ...which automatically takes care of the open problem from 08960441558743f222280637985690bb8b41b861 "Related tdf#37531: Handle conversion args sent over pipe" that --cat terminates the called soffice. Change-Id: Ief8cdf8c1335749dad1504966d635e0519fe92f7
* Related tdf#37531: --convert-to output relative to caller's CWDStephan Bergmann2016-07-151-1/+8
| | | | Change-Id: Ifad33650694c16e89fc5e51fd4322da732f7d3eb
* Related tdf#37531: Handle conversion args sent over pipeStephan Bergmann2016-07-151-0/+6
| | | | | | | | | | | However: * "soffice --convert-to pdf foo.odt" creates foo.pdf in the called soffice's CWD, not the caller's. * "soffice --cat foo.odt" prints to the called soffice's stdout, not the caller's (though this will unlikely ever be fixed), and then also terminates the called soffice. Change-Id: I2f4420881b2bee00b0476c76f739966c13101be4
* Log PipeIpcThread communicationStephan Bergmann2016-07-151-1/+7
| | | | Change-Id: I9e818351a435d39a9d1d8988214185f5bc504e8c
* new loplugin unnecessary overrideNoel Grandin2016-07-151-16/+0
| | | | | | | Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* sc lok: add more toolbar itemsHenry Castro2016-07-141-1/+3
| | | | | | | | | | .uno:SortAscending .uno:SortDescending Change-Id: I3d307b43fb18ffce75b00a0b919b63320bf6db05 Reviewed-on: https://gerrit.libreoffice.org/27223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
* tdf#100883 - opencl impls. that use SEH are still bad.Michael Meeks2016-07-121-0/+12
| | | | | | | | | | Amazingly we fell-back to the old calculation path for crashes in older LibreOffices, might as well have this on master. Change-Id: Ifc1de41c93329207d7a1917c736e361d840c2821 Reviewed-on: https://gerrit.libreoffice.org/27166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* opencl: bail out early in missing OpenCL case.Michael Meeks2016-07-121-0/+1
| | | | | | | Change-Id: I2ff1466ec89f4ad9743cedbfa5dd52be8bf86590 Reviewed-on: https://gerrit.libreoffice.org/27136 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
* desktop: validate OpenCL drivers before use.Michael Meeks2016-07-122-0/+178
| | | | | | | | | | | | | | | | | | | | | | OpenCL validation needs to happen before drivers are used in anger. This should isolate any crashes, and/or mis-behavior to We use app version, CL driver version and file time-stamp to trigger re-testing the device. If anything fails: hard disable OpenCL. We use an opencl validation sheet (cl-test.ods) and install it. It is a minimal CL set - it requires a very short formula group length, and combines several CL functions into few formulae to test more. The sheet structure, in particular the manual squaring / SQRT is necessary to stick within the default CL subset, and ensure that formulae are CL enabled from the root of the dependency tree up. Change-Id: I18682dbdf9a8ba9c16d52bad4447e9acce97f0a3 Reviewed-on: https://gerrit.libreoffice.org/27131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* loplugin:nullptr: Better heuristic to determine code shared between C and C++Stephan Bergmann2016-07-112-2/+2
| | | | Change-Id: I51e1c5fa4639e51fac90f92adf3d87d12960d589
* lok: disable unused UNO commandsHenry Castro2016-07-101-4/+0
| | | | | | | Change-Id: I9804c1c8528747e719971f51b59d0a01a9fba878 Reviewed-on: https://gerrit.libreoffice.org/27091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
* sw lok: add LOK_CALLBACK_VIEW_CURSOR_VISIBLEMiklos Vajna2016-07-081-0/+3
| | | | | | | | | | With this, in case a text cursor is turned into a graphic selection in view#0, then view#1 can also hide the text cursor of view#0. Change-Id: I7de89b8537ef8b0985336793b719d93733604bff Reviewed-on: https://gerrit.libreoffice.org/27044 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* Resolves: tdf#100713 on cancel curData points to deleted parents vector entryCaolán McNamara2016-07-081-6/+8
| | | | Change-Id: Ic2f313c357ce9526eb045791e2d27451e52a7572
* Related: rhbz#100713 move extensions restart to a better placeCaolán McNamara2016-07-085-9/+26
| | | | | | | | | | | | | | | move it to when the dialog is closed rather than trying to launch it as soon as any modifications take place because those are happening during threaded code and the restart is always cancelled by the dialog itself leading to repeated restart dialogs Now at least it doesn't crash, but if we open an oxt on the command line, a restart will reopen it, which is probably not what we want. Maybe this restart on an extension modification is a bad idea in the first place. Change-Id: Ib7d6179e6703ed3353fce44c3e54f5be1c1dfa68
* loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann2016-07-072-3/+3
| | | | Change-Id: Ibeb53a944551b9a654979fefaae85ba3f82c52fb
* sc lok: add number format toolbar itemsHenry Castro2016-07-071-1/+4
| | | | | | | Change-Id: I420750d99d5998cb589d0d6ec0fb6555c41a85cf Reviewed-on: https://gerrit.libreoffice.org/27015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
* sc lok: add toolbar item wrap text and merge cellsHenry Castro2016-07-061-1/+3
| | | | | | | Change-Id: I266b7171ee0a8a324ee8f71680f76c132b5c5fbd Reviewed-on: https://gerrit.libreoffice.org/26985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
* clang-tidy performance-implicit-cast-in-loopStephan Bergmann2016-07-061-1/+1
| | | | | | | ...where the first component of the pair returned by the iterator would be const, so an implicit conversion would be required. Change-Id: I62b6ddd799261e1dd63ea5c42a85d8b071f8b8b7
* use a dynamic library for minidump shared codeMarkus Mohrhard2016-07-052-1/+7
| | | | | | | | | | | | This has the disadvantage to make the minidump_upload executable depend on LibreOffice libraries but there seems to be no other way to make the 7.1 SDK happy. Change-Id: I82c37f503ed29cb50711eae7db22063f49747a48 Reviewed-on: https://gerrit.libreoffice.org/26055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 3498cd3e7b2c820fc3f3025eb4434666a444fda1) Reviewed-on: https://gerrit.libreoffice.org/26915 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* Fix some spelling errors in comments and stringsOtto Kekäläinen2016-07-041-1/+1
| | | | | | | Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e Reviewed-on: https://gerrit.libreoffice.org/26883 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* sd: add status bar UNO commandsHenry Castro2016-07-031-1/+4
| | | | | | | Change-Id: I7da065edf76ccdbf9e410756c4d1fe81462975ed Reviewed-on: https://gerrit.libreoffice.org/26881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
* sw lok: add status bar UNO commandsHenry Castro2016-07-031-1/+5
| | | | | | | Change-Id: I4ffa3a3e07d00cfac48e67a0c32e85de0eda803d Reviewed-on: https://gerrit.libreoffice.org/26876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
* sc lok: add status bar UNO commandsHenry Castro2016-07-021-1/+11
| | | | | | | Change-Id: I2dbed808a23609773baf9154820a7121c7919c70 Reviewed-on: https://gerrit.libreoffice.org/26809 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
* svx lok: add LOK_CALLBACK_GRAPHIC_VIEW_SELECTIONMiklos Vajna2016-07-011-0/+2
| | | | | | | | | So a view can be aware where the graphic selections of other views are. Change-Id: I0cc420cfe4bf3824fbfa1a58da889cac5e9a7b60 Reviewed-on: https://gerrit.libreoffice.org/26863 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* sc lok: add LOK_CALLBACK_CELL_VIEW_CURSORMiklos Vajna2016-07-011-0/+2
| | | | | | | | | So a view can be aware where the cell cursors of other views are. Change-Id: Ifcf06c0019c6af8b859e2e92222e4f3fd18da74f Reviewed-on: https://gerrit.libreoffice.org/26844 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* LOK: change back type of view ids to intMiklos Vajna2016-06-301-8/+8
| | | | | | | | | | | | | | | Commit 45c2410041c48c22bd860efb42d4daadad7869b0 (LOK: change type of view ids to uintptr_t, 2016-06-17) fixed the problem of view IDs being reused for the price of random IDs, which makes debugging harder. Implement a simple shellToView() function that makes sure view IDs are not reused, and stop exposing view shell pointer addresses, which allows reverting the LOK API change. Change-Id: I63089e6de08ee7e1c7706757d43a11f6cf4d6e06 Reviewed-on: https://gerrit.libreoffice.org/26773 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* loplugin:singlevalfields in dbaccessNoel Grandin2016-06-272-21/+9
| | | | | | | Change-Id: I5c8990187b2b488eb75369c2a3e3dc7f855ce06a Reviewed-on: https://gerrit.libreoffice.org/26633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Revert "desktop: fix loplugin:oncevar"Miklos Vajna2016-06-231-1/+1
| | | | | | This reverts commit 8dc2873081bff3fe7107d472a91a24af8b67a87d. Instead of working around the warning, the plugin will be disabled, as its warnings are not useful in all cases.
* tdf#46279 Show restart message after extension installationirem2016-06-231-0/+6
| | | | | | | Change-Id: I91feab63b77055b8f73d0fb481a76586b249160c Reviewed-on: https://gerrit.libreoffice.org/24595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>