summaryrefslogtreecommitdiffstats
path: root/dbaccess
Commit message (Collapse)AuthorAgeFilesLines
* Revert "add missing component"David Tardon2016-11-211-1/+0
| | | | This reverts commit 7fe1b39e8abe68357c88536923b7058807b32119.
* Revert "add missing component"David Tardon2016-11-211-1/+0
| | | | This reverts commit b55d17471f73b843943269c6cbd30f99995d8354.
* add missing componentDavid Tardon2016-11-211-0/+1
| | | | Change-Id: I53d50f8e338fcc64e24370a80ce390f7a2be34ba
* add missing componentDavid Tardon2016-11-211-0/+1
| | | | Change-Id: I8b6f6d650c011fc0611d6933894bc64a780ff8c0
* add missing deps on ui filesDavid Tardon2016-11-211-0/+4
| | | | Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
* gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud2016-11-201-1/+1
| | | | | | | | | | | | | | | this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
* loplugin:datamembershadowNoel Grandin2016-11-171-2/+0
| | | | Change-Id: I0206905ce95467a560f8ed24db4403df07d3680e
* Fix typosSamuel Mehrbrodt2016-11-151-1/+1
| | | | | | | Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* loplugin:constantparamNoel Grandin2016-11-153-4/+4
| | | | | | | Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0 Reviewed-on: https://gerrit.libreoffice.org/30858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* coverity#1394296 Dereference before null checkCaolán McNamara2016-11-122-15/+12
| | | | Change-Id: I143b7439b33695aa5bc4e32fd9386692eac37697
* update vclwidget loplugin to find ref-dropping assigmentNoel Grandin2016-11-118-10/+10
| | | | | | | | | | Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* 'make screenshot' use-after-free fixesStephan Bergmann2016-11-101-2/+2
| | | | Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
* 'make screenshot' loplugin fixesStephan Bergmann2016-11-101-8/+1
| | | | Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
* loplugin:expandablemethods in dbaccessNoel Grandin2016-11-0941-276/+88
| | | | | | | Change-Id: I6087a3eff46926646ac1637615a0af30b38956a4 Reviewed-on: https://gerrit.libreoffice.org/30712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* make comphelper::containerToSequence a little smarterNoel Grandin2016-11-091-1/+1
| | | | | | | | | So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin2016-11-084-10/+8
| | | | | | | Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* style fix for cppcheck redundantConditionJochen Nitschke2016-11-071-1/+1
| | | | | | | Change-Id: I5d02c6f4c6b411c23a6de43374884a76e1c408fe Reviewed-on: https://gerrit.libreoffice.org/30667 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Resolves: #i119892# Missing "by" in descriptionDamjan Jovanovic2016-11-071-1/+1
| | | | | | | | | | | Fixes spelling errors in some Base messages. Reported by: Dwayne Henderson Patch by: me (cherry picked from commit 8df1c30b7f5e79c2757e7224677f9a487b1bed0a) Change-Id: I18dcf20e51e941ca8ccb47315ea453399ca0d88a
* loplugin:oncevar in dbaccessNoel Grandin2016-11-0417-92/+43
| | | | | | | Change-Id: I956063bb354fbbd002e922bb06d0b3863a2750fc Reviewed-on: https://gerrit.libreoffice.org/30565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu2016-11-031-8/+1
| | | | | | | | Change-Id: I53bca2a9113862b8e7058937e231721c5f81a9de Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30511 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedfieldsNoel Grandin2016-11-021-6/+0
| | | | | | | Change-Id: I96634c18ba6600f8f7d5d04a162dcd7e1e312923 Reviewed-on: https://gerrit.libreoffice.org/30474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* style fixes for cppcheck noExplicitConstructorJochen Nitschke2016-11-011-1/+1
| | | | | | | Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* No good reason for dbaccess::OCacheSet::updateRow to be pure?Stephan Bergmann2016-10-313-7/+1
| | | | | | | | | | Most of its virtual member functions are (though insertRow is already a curious exception), even though they are defined, so smells like a copy/paste error rather than deliberate design. And appears to have been the only reason why loplugin:unnecessaryoverride filtered out such overriding of pure base functions. Change-Id: Ib2a40af9cd3cd3dbb26c4147f7d01de4e11f5f6e
* update vclwidgets plugin to check local variablesNoel Grandin2016-10-311-2/+2
| | | | | | | Change-Id: I91f7fc6b8419c0ed82194726eeb4c4657e998f22 Reviewed-on: https://gerrit.libreoffice.org/30428 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#95014 initial support for 32 px icons in toolbarTomaž Vajngerl2016-10-301-1/+1
| | | | | | | | | | | | | | | | This adds support for 32 pixel icons - mainly to get them into the toolbar. Most changes made are to change the behavior of having only small and large icons as a boolean choice, but not every code path was converted to non-boolean choice yet. Breeze icon theme has the 32px variants so it can be used already. Change-Id: Iadf832a87826c16b3a83522104dd6c35d61a0f87 Reviewed-on: https://gerrit.libreoffice.org/30398 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
* Allow using xml menus in DBTreeListBoxMaxim Monastirsky2016-10-302-15/+60
| | | | Change-Id: I8dfab0ae5d64b416123ab5690b43cf2db77d92dc
* Add resource name method to IContextMenuProviderMaxim Monastirsky2016-10-306-2/+21
| | | | Change-Id: I218fd18101f8f7039052fe8a065096e4c9809adb
* Convert RID_MENU_APP_EDIT to xmlMaxim Monastirsky2016-10-303-130/+35
| | | | Change-Id: I6868624b1726b1044e741a1fc0cdabe703f84c31
* update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin2016-10-287-17/+6
| | | | | | | | | | | | which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara2016-10-281-1/+1
| | | | | | | Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Sub menus no longer need manual disposingMaxim Monastirsky2016-10-272-2/+2
| | | | | | | | | | | | | | | after: commit ee79a2dd7ea60e902cab3a9203e307b8a78fee23 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jul 29 14:33:22 2016 +0100 Resolves: tdf#101169 crash using column menu in base Change-Id: I7c6e54dd5574c61cffd5884d1cf1b63075073001 Reviewed-on: https://gerrit.libreoffice.org/30343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
* dbaccess: OToolboxController is now unusedMaxim Monastirsky2016-10-277-337/+0
| | | | | | | | | | | | | | | | | | | This also removes the only occurrence of the "com.sun.star.frame.ToolboxController" service. However it shouldn't be considered as API CHANGE, as no 3rd-party code should rely on undocumented services, and fortunately a toolbox controller like this has no use for 3rd-party anyway. BTW there are other cases of using non-existent (unique) service names for toolbox controllers in non-sfx2 modules, rather than using the standard "com.sun.star.frame.ToolbarController". There is OToolboxController in reportdesign (which I hope to remove soon too, as it's just a wrapper around SvxColorToolBoxControl). And there was also ShapeToolbarController in chart2 which I removed in 2aea9e37d697ce51efc5fb37ba50f1bf177e0445 ("Introduce generic sub toolbar controller"). Change-Id: Iea8858be2406f32bb5a022920b4b1cee70603c09
* Convert RID_MENU_REFRESH_DATA to xmlMaxim Monastirsky2016-10-275-19/+34
| | | | Change-Id: I22107396eaab848224f26eb54f8638a354c13509
* Convert RID_MENU_APP_NEW to xmlMaxim Monastirsky2016-10-274-72/+24
| | | | | | | Achieved by using GenericPopupToolbarController for the associated toolbar button. Change-Id: I406ff40e0c80d6db903de5629088d35487ab6416
* make the AbstractDialog stuff extend from VclReferenceBaseNoel Grandin2016-10-274-7/+10
| | | | | | | | | | | | | | | Because some stuff wants to multiple-inherit from VclAbstractDialog and OutputDevice-subclasses, and we'd prefer to keep all the lifetime management through a single smart pointer class (VclPtr) The change in msgbox.cxx and window.cxx is to workaround a bug in VS2013 to do with virtual inheritance and delegating constructors. Change-Id: I178e8983b7d20a7d2790aa283be838dca5d14773 Reviewed-on: https://gerrit.libreoffice.org/29140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* coverity#1374284 Uncaught exceptionCaolán McNamara2016-10-262-2/+2
| | | | Change-Id: Ie43165d3f6abd420b951a80e0101d8e77946d4a3
* coverity#1374268 Uncaught exceptionCaolán McNamara2016-10-262-2/+4
| | | | Change-Id: Ife6e9897c12a9754afd5f4754c7de41eef7f00eb
* The default std::less<sal_uInt16> is fineTakeshi Abe2016-10-261-1/+1
| | | | | | | Change-Id: I29cd62ef0b687613ed9bda5170511dcae2fc6e7e Reviewed-on: https://gerrit.libreoffice.org/30282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* Enable save as when editing view tooMaxim Monastirsky2016-10-231-1/+1
| | | | | | Not sure why it was disabled, works very well for me. Change-Id: I76648d06aa20162defd96fb22e3eb8fd04db28d0
* loplugin:expandablemethodds in include/svtoolsNoel Grandin2016-10-211-3/+0
| | | | | | | Change-Id: I679b7985861203496813782138d1cf965fbc427b Reviewed-on: https://gerrit.libreoffice.org/30107 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* '>>=' with rhs Any is a copy assignmentJochen Nitschke2016-10-192-5/+3
| | | | | | | | | | replace '>>=' operator with '=' where return value is not checked and simplify. (note: switches lhs with rhs) Change-Id: I0d283e8786ea996ed80d7aa9d8a4ea930a3d52f8 Reviewed-on: https://gerrit.libreoffice.org/30004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#96015 (part) link to Doc'tation in Help menuOlivier Hallot2016-10-195-0/+5
| | | | | | | | | | | | | | | | | | | | | Add the entry "Documentation" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/documentation/?&LOlang=<locale> <locale> is obtained from .getLocale() Patch2: create a member with try/catch for external URLs Patch3 Use sfx2::openUriExternally Revert to User Guides.. in UI. Change-Id: I8332253c31bd3be330cdd794f9e056b632b38037 Patch4: remove 1st '&' in URLs Reviewed-on: https://gerrit.libreoffice.org/28817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
* loplugin:expandablemethodds in dbaccess..drawinglayerNoel Grandin2016-10-1916-32/+14
| | | | | | | Change-Id: Iee9143999f5c94040dadd378006f2a429ca0edb5 Reviewed-on: https://gerrit.libreoffice.org/30012 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* replace <<= with assign for <<= with rhs AnyJochen Nitschke2016-10-181-1/+1
| | | | | | | | | found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* tdf#89307: Removed T* SvRef::opeartor &()Jacek Fraczek2016-10-181-1/+1
| | | | | | | | | Usage has been replaced with SvRef::get() or removed where applicable. Change-Id: I49f108910b668466134c40940b53fc3ab2acd816 Reviewed-on: https://gerrit.libreoffice.org/29780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* clang-cl loplugin: dbaccessStephan Bergmann2016-10-167-64/+59
| | | | | | | Change-Id: I96982e5298783384c2978056af7955d012289f25 Reviewed-on: https://gerrit.libreoffice.org/29872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* remove (yet yet another) StringListResource implementationCaolán McNamara2016-10-1318-80/+17
| | | | Change-Id: Ifaf89badfc339f8253a629c6960df8a943b8cce5
* de-src RID_DB_TAB_EDITOR controlCaolán McNamara2016-10-123-21/+9
| | | | Change-Id: Idba73ea9bf2486d40b24e59bf6f1f5092ec70558
* safemode: Add uno command and menu entrySamuel Mehrbrodt2016-10-105-0/+10
| | | | | | | Change-Id: I1843767160b79041c42e506eff0cf39399c74f26 Reviewed-on: https://gerrit.libreoffice.org/29668 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* tdf#89307: Removed SvRef::operator T*()Jacek Fraczek2016-10-102-3/+3
| | | | | | | | | | | | | | Conditional statements are using SvRef::Is() method. Changed static_cast<T*>(svRef<T>) occurances to svRef.get(). Added operator == and != to SvRef. SbxObject::Execute is using SbxVariableRef internally. SbxObject::FindQualified is using SbxVariableRef internally. Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395 Reviewed-on: https://gerrit.libreoffice.org/29621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>