summaryrefslogtreecommitdiffstats
path: root/dbaccess
Commit message (Collapse)AuthorAgeFilesLines
* O[U]String::replaceAt overloads that take string_viewNoel Grandin2021-11-233-5/+5
| | | | | | | | | | which results in lots of nice string_view improvements picked up by the plugins Change-Id: Ib0ec3887816b3d4436d003b739d9814f83e244b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove ORowSetValue implicit conversion methodsNoel Grandin2021-11-239-96/+95
| | | | | | | | | | | | | | | | in favour of the existing get*() methods. The get*() methods 0 or false or empty in the case of "null", which is exactly the same behaviour as the conversion methods. These implicit conversion methods cause lookup problems when combined with some upcoming OUString changes. And the code looks cleaner this way too, and has less magic when calling methods. Change-Id: Ieb4756bf693e83b996a32667fc1b955f89193496 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125690 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Clear also m_aDestTypeInfo in dtor like m_aTypeInfo (dbaccess/WCopyTable)Julien Nabet2021-11-171-0/+1
| | | | | | | Change-Id: Ia73503628451a3e5ee5121022545c92b50d12b23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125261 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* add a rule to enforce always-show-image of True if an image is usedCaolán McNamara2021-11-152-0/+8
| | | | | | | | | | | If not set, then gtk3 will show the image if there is no text, but only the text if there's an image. For simplicity sake just enforce it as true if an image is referenced. Change-Id: Id4bb9140ba83e7e07e0d8ec5e3c29aece49b9087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Replace some macros in dbaccess part 9Julien Nabet2021-11-123-152/+457
| | | | | | | | | | | | Remove IMPLEMENT_LISTENER_MULTIPLEXER_CORE + BEGIN_DECLARE_LISTENER_MULTIPLEXER + END_DECLARE_LISTENER_MULTIPLEXER + DECLARE_MULTIPLEXER_BOOL_METHOD + DECLARE_MULTIPLEXER_VOID_METHOD + STOP_MULTIPLEXER_LISTENING + START_PROPERTY_MULTIPLEXER_LISTENING + STOP_PROPERTY_MULTIPLEXER_LISTENING + START_MULTIPLEXER_LISTENING Change-Id: I23dfa9d71b8ae84b9c4ff5e55145e8b350a1eeba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125105 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* insert special character in sql view in dbaccess using an arbitrary fontCaolán McNamara2021-11-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The font to use in the editengine is set with the fallback list notation "Font1;Font2;Font3" and while SvxCharacterMap::SetCharFont explicitly has... { // first get the underlying info in order to get font names // like "Times New Roman;Times" resolved vcl::Font aTmp(m_xVirDev->GetFontMetric(rFont)); } which is supposed to resolve to what the physical font is, it appears that since the ancient merge of: commit 2f382d6c2579a25c68dbd121af7f1f5dc7ec9852 Date: Thu Mar 27 16:59:30 2003 +0000 MWS_SRX644: migrate branch mws_srx644 -> HEAD a change was included of: - // Fontdaten ermitteln und setzen - aMetric.SetName( pMetric->maName ); + // set aMetric with info from font + aMetric.SetName( maFont.GetName() ); which means that font names like "Times:Times New Roman" appear in the FontMetric for the font and not the font name of the physical font that the metric describes. That doesn't look right to me, but rather than get bogged down in changing that and the undoubtedly infinite chain of knock on problems that will trigger just start with a simple font name here not the fallback list. The font is "Liberation Mono;etc;etc" so the first one is certain to be available. Change-Id: I58809be8edb515d9823867c7a0bce5931dccbd27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Resolves: tdf#145582 modify called too oftenCaolán McNamara2021-11-121-1/+3
| | | | | | | | | | | | | | | | | | | | | a problem since: commit 5b98dd53c7dc101d3a5ff693d3f0520ec1abd3d1 Date: Tue Aug 3 12:28:23 2021 +0100 tdf#143657 'execute' button doesn't get enabled when contents changed which was a fix for the problem since: commit 73c9ef661d9ef6237d3fd3c259fd040a545b44cf Date: Tue Jul 6 18:51:38 2021 +0200 tdf#132740 don't broadcast if modified status has not changed Change-Id: Ibae42251ce04229283283407bc2ab986272e945d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125090 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* simplify construction of XMLPropertyMapEntryNoel Grandin2021-11-121-37/+35
| | | | | | | | | | | | so we don't have to pass in the size of the string literal. This is mostly a preparatory change, to make an another patch of mine less noisy. Change-Id: Idafcd68586b8b465e63dc89e4a4180d2e70ac3a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Replace some macros in dbaccess part 8Julien Nabet2021-11-123-210/+515
| | | | | | | | | | | Remove DECLARE_PROPERTY_MULTIPLEXER + IMPLEMENT_LISTENER_MULTIPLEXER_BOOL_METHOD + IMPLEMENT_LISTENER_MULTIPLEXER_VOID_METHOD + IMPLEMENT_LISTENER_ADMINISTRATION + IMPLEMENT_PROPERTY_MULTIPLEXER + IMPLEMENT_PROPERTY_LISTENER_ADMINISTRATION Change-Id: Ib0522fc895166489c70c163b9d6c0f65cd9a3d59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125078 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* rtl::Static to thread-safe staticNoel Grandin2021-11-121-3/+0
| | | | | | | Change-Id: I6390d1811bad59c09a074039c635710d25a660d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124886 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Replace some macros in dbaccess part 7Julien Nabet2021-11-118-117/+155
| | | | | | | | | | | | | Remove FIRST_USER_DEFINED_FEATURE and LAST_USER_DEFINED_FEATURE + GRANT_REVOKE_RIGHT + ALL_STRING + ALL_INT + NSQLAllocHandle + NSQLFreeHandle + NSQLSetEnvAttr + NSQLDataSources + LbText + LbPos + CHECK_INVARIANTS + OUT_LF + TAG_OFF_LF + TAG_ON_LF + TAG_OFF + TAG_ON Change-Id: I07261ea0eafcc9f0630f92e47bf5c2f694661933 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125065 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Replace some macros in dbaccess part 6Julien Nabet2021-11-1111-155/+177
| | | | | | | | | Remove DECL_PROP_IMPL + ELEMENT_COUNT + HANDLE_SQL_ERRORS + DO_SAFE Change-Id: I2208a22329f7611a7fdc896e25bb0ef0bb378abd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125050 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Replace some macros in dbaccess part 5Julien Nabet2021-11-1124-79/+230
| | | | | | | | | | | | Remove BEGIN_PROPERTY_SEQUENCE + BEGIN_PROPERTY_HELPER + BEGIN_PROPERTY_SEQUENCE + BEGIN_PROPERTY_HELPER + END_PROPERTY_HELPER + IMPLEMENT_SERVICE_INFO_IMPLNAME + IMPLEMENT_SERVICE_INFO_SUPPORTS Change-Id: I44499ba68a162b01a9dd5192228b8190b1f40c98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125028 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Replace some macros in dbaccess part 4Julien Nabet2021-11-118-119/+104
| | | | | | | | | Remove DECL_PROP0_BOOL + DECL_PROP1_BOOL + DECL_PROP0/1/2 Change-Id: I422d3dc4c09b5f8a88c8992de187458d74dc3d50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125015 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Replace some macros in dbaccess part 3Julien Nabet2021-11-1019-70/+162
| | | | | | | | | | | | | Remove IMPLEMENT_SERVICE_INFO1 + IMPLEMENT_SERVICE_INFO2 + DECLARE_PROPERTYCONTAINER_DEFAULTS + DECLARE_PROPERTYCONTAINER_DEFAULTS + IMPLEMENT_PROPERTYCONTAINER_DEFAULTS2 + DECL_PROP3 (unused) + DECL_PROP2_IFACE Change-Id: Idf18179218b9b1f2da8e4354d8e4909edc925143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125011 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Replace some macros in dbaccess part 2Julien Nabet2021-11-1012-73/+125
| | | | | | | | | | Remove MAP_CONST_TEXT + MAP_CONST_ROW + IMPLEMENT_SERVICE_INFO3 + IMPLEMENT_GETTYPES3 + IMPLEMENT_GETTYPES2 Change-Id: I56e96a782eda1e570a43cb6bad3fa5e52bc08d2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124960 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Replace some macros in dbaccess part 1Julien Nabet2021-11-085-66/+70
| | | | | | | | | | Remove NOTIFY_LISTENERS_CHECK + CHECK_MATRIX_POS + REGISTER_PROPERTY_BV + REGISTER_PROPERTY + MAP_END + MAP_CONST_COLUMN + MAP_CONST_CELL Change-Id: I3cd32059aef6787c0e5f8338320d7e924199830c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124892 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Werror=nonnull in SbaXFormAdapter::cancelNoel Grandin2021-11-051-1/+1
| | | | | | | | | | | | | | | ever since commit 38d78d3c30183b11f5b643c147667b1d30325784 Author: Ocke Janssen <oj@openoffice.org> Date: Thu Oct 26 13:46:14 2000 +0000 new datasource browser spotted by new gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0 Change-Id: If054b949f4b4f93e785d315ddeb3423b52d1f55b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124759 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Refer to TLS/SSL in optionsIlmari Lauhakangas2021-11-052-2/+2
| | | | | | | | | Change-Id: I07bddadd9421ee5584f8d978c5c43eab067414af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124745 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Sophie Gautier <sophi@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
* elide unnecessary UNO_QUERY_THROW callsNoel Grandin2021-11-042-5/+2
| | | | | | | Change-Id: I0d0fc57f352e9717e721416c8941cfcf48af24c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124650 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Drop char*-based API from NamedValueCollectionMike Kaganski2021-11-028-71/+61
| | | | | | | Change-Id: I87f339b348580e256a8d65470ad15cbdabf2c9dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124609 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Resolves: tdf#144793 add scrollbar to sql editviewCaolán McNamara2021-11-016-7/+83
| | | | | | | Change-Id: I23126a89c136a134590900c38ccd589fb4ea29a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* uniformly allow focus into GtkToolbarCaolán McNamara2021-10-311-1/+1
| | | | | | | Change-Id: I110daf882d9196cf7552e43a157ba4ae73fd670b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* gtk[3 vs 4]: remove can-focus from GtkToolButtonCaolán McNamara2021-10-311-5/+0
| | | | | | | | | | | | so tab-cycling inside sidebar panel toolbars works as wanted It needs to be false for gtk3 and true for gtk4, leaving it unspecified gets a desired working default. Change-Id: I34869d5dcffc814f62ec2b717108f90c395a067b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* simplify framework::TitleHelperNoel Grandin2021-10-292-9/+2
| | | | | | | | | | | Every callsite (bar one) calls setOwner and connectWithUntitledNumbers after construction, so just pass them in the constructor. And for that lone callsite we can just nullptr as an argument. Change-Id: If838e068bb59a407225d853a0f67983be400f2f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124426 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#143392 fix title on Base windowNoel Grandin2021-10-292-2/+14
| | | | | | | | | | | regression from commit 857caa5fc69b92e781457a1b67a89aa051c2d70f tdf#79049 speed up OOXML workbook load Change-Id: Ia2d55386a7508dc2bbb2fa8501b45c3f30ad6a75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Prepare for removal of non-const operator[] from Sequence in dbaccessMike Kaganski2021-10-2937-237/+185
| | | | | | | Change-Id: Iddb96d39a512ef68827ecf89f3b5650950f88096 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124357 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Revert "Simplify vector initialization in dbaccess"Julien Nabet2021-10-221-2/+4
| | | | | | | | | | | This reverts commit dfa8dbf98ee872d22bb9e2c63ab07ed76fb81579. since it needs 2 allocations instead of one Change-Id: I64d449ca885880f3e6e795168978ffa99a005c37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124067 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Optimize assignment from OUStringLiteral to OUStringStephan Bergmann2021-10-221-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...by making the OUString's pData point to the OUStringLiteral, instead of copying the contained characters. This is one of the improvements that had not been done as part of e6dfaf9f44f9939abc338c83b3024108431d0f69 "Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uString": "To keep individual commits reasonably manageable, some consumers of OUStringLiteral in rtl/ustrbuf.hxx and rtl/ustring.hxx are left in a somewhat odd state for now, where they don't take advantage of OUStringLiteral's equivalence to rtl_uString, but just keep extracting its contents and copy it elsewhere. In follow-up commits, those consumers should be changed appropriately, making them treat OUStringLiteral like an rtl_uString or dropping the OUStringLiteral overload in favor of an existing (and cheap to use now) OUString overload, etc." (Simply dropping the OUStringLiteral overload was not possible in this case, though, as that would have lead to ambiguities among the various OUString and std::u16string_view overloads.) The now-deleted OUStringLiteral rvalue reference overload means that some existing assignments from ternary-operator OUStringLiteral<N> to OUString no longer compile and had to be replaced with uses of std::u16string_view. Those had not already been replaced in e6dfaf9f44f9939abc338c83b3024108431d0f69 because they happened to use OUStringLiteral instances of identical length N in both arms of the ternary operator, so did not already start to fail to compile back then. Change-Id: I328e25b8324d045774e811d20a639f40d6a9a960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124040 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:indentation check for indent inside blockNoel Grandin2021-10-201-65/+65
| | | | | | | | | | look for places where the statements inside a block are not indented Change-Id: I0cbfa7e0b6fb194b2aff6fa7e070fb907d70ca2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123885 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Simplify vector initialization in dbaccessJulien Nabet2021-10-151-4/+2
| | | | | | | Change-Id: Iad1f84a9e81c50a007c162a5043343233fdc23a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123664 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Remove non-const Sequence::begin()/end() in internal codeMike Kaganski2021-10-1511-12/+12
| | | | | | | | | | | | | | | | | | ... to avoid hidden cost of multiple COW checks, because they call getArray() internally. This obsoletes [loplugin:sequenceloop]. Also rename toNonConstRange to asNonConstRange, to reflect that the result is a view of the sequence, not an independent object. TODO: also drop non-const operator[], but introduce operator[] in SequenceRange. Change-Id: Idd5fd7a3400fe65274d2a6343025e2ef8911635d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123518 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* use std::vector::insert instead of push_backNoel Grandin2021-10-141-5/+2
| | | | | | | | | because it will pre-allocate space and often is optimised to memcpy Change-Id: I03ed7915f2762d3d27e378638052a47a28bbf096 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123588 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Avoid COW overhead using css::uno::SequenceMike Kaganski2021-10-148-18/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The scenarios are: 1. Calling sequence's begin() and end() in pairs to pass to algorithms (both calls use getArray(), which does the COW checks) 2. In addition to #1, calling end() again when checking result of find algorithms, and/or begin() to calculate result's distance 3. Using non-const sequences in range-based for loops, which internally do #1 4. Assigning sequence to another sequence variable, and then modifying one of them In many cases, the sequences could be made const, or treated as const for the purposes of the algorithms (using std::as_const, std::cbegin, and std::cend). Where algorithm modifies the sequence, it was changed to only call getArray() once. For that, css::uno::toNonConstRange was introduced, which returns a struct (sublclass of std::pair) with two iterators [begin, end], that are calculated using one call to begin() and one call to getLength(). To handle #4, css::uno::Sequence::swap was introduced, that swaps the internal pointer to uno_Sequence. So when a local Sequence variable should be assigned to another variable, and the latter will be modified further, it's now possible to use swap instead, so the two sequences are kept independent. The modified places were found by temporarily removing non-const end(). Change-Id: I8fe2787f200eecb70744e8b77fbdf7a49653f628 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123542 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:unusedmethodsNoel Grandin2021-10-122-21/+0
| | | | | | | Change-Id: Ifd3a1ccef68ebc4cd4e7785357e6a476f6669eb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123456 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* In O[U]StringBuffer, make string_view params replacements for OUString onesStephan Bergmann2021-10-111-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...for LIBO_INTERNAL_ONLY, instead of having them as additional overloads. That way, loplugin:bufferadd and loplugin:stringviewparam found many further opportunities for simplification (all addressed here). Some notes: * There is no longer an implicit conversion from O[U]String to O[U]StringBuffer (as that goes via user-defined conversions through string_view now), which was most noticeable in copy initializations like OStringBuffer buf = someStr; that had to be changed to direct initialization, OStringBuffer buf(someStr); But then again, it wasn't too many places that were affected and I think we can live with that. * I made the O[U]StringBuffer ctors taking string_view non-explicit, mainly to get them in line with their counterparts taking O[U]String. * I added an OUStringBuffer::lastIndexOf string_view overload that was missing (relative to OUStringBuffer::indexOf). * loplugin:stringconstant needed some addition to keep the compilerplugins/clang/test/stringconstant.cxx checks related to OStringBuffer::append and OStringBuffer::insert working. * loplugin:stringviewparam no longer needs the special O[U]StringBuffer-related code that had been introduced in 1250aecd71fabde4dba990bfceb61bbe8e06b8ea "loplugin:stringviewparam extend to new.." Change-Id: Ib1bb8c4632d99b744e742605a9fef6eae959fd72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122904 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:moveparam in dbaccessNoel Grandin2021-10-1131-59/+58
| | | | | | | Change-Id: Iff4c5069d25dddd58d61b2a09a57a112854144da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:moveparam in xmloffNoel Grandin2021-10-101-4/+3
| | | | | | | Change-Id: I46c1c8dc46cd2b8470b69506f6609f8bd7e42211 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Typo *ropertie -> *ropertyJulien Nabet2021-10-092-11/+11
| | | | | | | Change-Id: Id5ae03140ac4fd67bf4940569ac5cd2f15716749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123306 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* tdf#144674 no context menu in SQL QueryCaolán McNamara2021-10-042-0/+76
| | | | | | | Change-Id: I3c6e9e7896da171d089579165f466b4b6e59a1a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123030 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Add extended tips to generalpagewizard.uiOlivier Hallot2021-10-041-0/+35
| | | | | | | Change-Id: Ib5fd25fa109a7cd949fe455701e2240a5a2bcc1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123023 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Bump Glade release for generalpagewizard.uiOlivier Hallot2021-10-031-63/+63
| | | | | | | Change-Id: I5fbc312316e6fa790026f0b4514cf269ad99afcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123020 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* add missing use-underline to menu entriesCaolán McNamara2021-10-031-0/+4
| | | | | | | Change-Id: I86bf3b52c68e5b4de25af5724df09b817ece0f58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123028 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* A more lightweight O[U]StringConcatenationStephan Bergmann2021-10-032-7/+7
| | | | | | | | | | | | | | | | | | | | | | | ...compared to a full-blown O[U]String, for temporary objects holding an O[U]StringConcat result that can then be used as a std::[u16]string_view. It's instructive to see how some invocations of operator ==, operator !=, and O[U]StringBuffer::insert with an O[U]StringConcat argument required implicit materialization of an O[U]String temporary, and how that expensive operation has now been made explicit with the explicit O[U]StringConcatenation ctor. (The additional operator == and operator != overloads are necessary because the overloads taking two std::[u16]string_view parameters wouldn't even be found here with ADL. And the OUString-related ones would cause ambiguities in at least sal/qa/rtl/strings/test_oustring_stringliterals.cxx built with RTL_STRING_UNITTEST, so have simply been disabled for that special test-code case.) Change-Id: Id29799fa8da21a09ff9794cbc7cc9b366e6803b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122890 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:constmethod handle more casesNoel Grandin2021-09-301-4/+4
| | | | | | | | | | | | remove some of the naming limitations, and handle pointer parameters better. I only let the plugin run up till vcl/ Change-Id: Ice916e0157031ab531c47f10778f406b07966251 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122892 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparams improve handling of pointer paramsNoel Grandin2021-09-304-12/+12
| | | | | | | Change-Id: I4c0002e72703eded435bfe4985f5b0121bf8524b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* gives names to all the Idles and TasksNoel Grandin2021-09-288-3/+11
| | | | | | | | | enforce it by making the constructor parameter non-default. Change-Id: I321543e4dcf15ea0a43ad8cce91d2f8dc22df6ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* vcl: rename OutDevState to StackChris Sherlock2021-09-283-7/+8
| | | | | | | | | | | | | I have moved the header file to include/vcl/rendercontext as this will eventually be part of the RenderContext split from OutputDevice. State and associated enums have also been moved to the vcl namespace. I have also moved ComplexTextLayoutFlags into the vcl::text namespace. Change-Id: I0abbf560e75b45a272854b267e948c240cd69091 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121524 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* tdf#144712 Add extended tips to special database settings dialogOlivier Hallot2021-09-271-0/+90
| | | | | | | Change-Id: I897353be6b42d8d867e7cc6036b0e8555172b80e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122719 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Bump Glade version to 3.38 of specialsettingsdialog.uiOlivier Hallot2021-09-271-147/+147
| | | | | | | Change-Id: Idb638271bb5a1edfe51963e92d6a07f40a1cd779 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122685 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-05-04 05:45:34 +0000