summaryrefslogtreecommitdiffstats
path: root/dbaccess
Commit message (Collapse)AuthorAgeFilesLines
* calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin2015-10-156-26/+15
| | | | | | | | | | | | the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
* convert Link<> to typedNoel Grandin2015-10-154-8/+13
| | | | Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
* simplify the way we override behaviour hereNoel Grandin2015-10-159-70/+55
| | | | | | just send everything via callModifiedHdl() Change-Id: I011df1d1c376deae962b465e4a27e98af968de6f
* Assumed fix of a clang-analyzer-deadcode.DeadStoresStephan Bergmann2015-10-131-6/+9
| | | | | | | | | | | | | | ...where the "bOk = false" from the leading "if" is always overwritten in the following check of "bOk = sTableRange == _sUpdateTableName". The code had been effectively like that ever since it got introduced with 4ae41a466ad659524809c23c9086df70c5456a39 "INTEGRATION: CWS dba30," but it looks broken. I assume the two checks of "sTableRange == _sUpdateTableName" for pNode->GetChild(0) and pNode->GetChild(2) shall only be done if the leading "if" is not hit. (And one remaining uncertainty is if really only one of those "sTableRange == _sUpdateTableName" checks needs to be true or if both should be true for bOk to be true.) Change-Id: I453690d65326ed67d7a074d4e4783a743a60d454
* clang-analyzer-deadcode.DeadStoresStephan Bergmann2015-10-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 8b9e4e393eff8b89a37a5932548700c0b50bcab8 "initial import" the assignment to bCheck was in a for loop that used bCheck in its condition, sal_Int32 nPos = m_nStartPos+1; for(; aIter != m_pMatrix->end() && bCheck;) { if(!aIter->isValid()) ... m_pCacheSet->fillValueRow(*aIter++,nPos++); bCheck = m_pCacheSet->next(); } that loop was then replaced with sal_Int32 nPos = m_nStartPos; bCheck = fill(aIter,m_pMatrix->end(),nPos,bCheck); (without further use of bCheck) in 2facbebb88fe72614d566c3187c8f86c5c61f8bd "MWS_SRX644: migrate branch mws_srx644 -> HEAD" (and the braces around { ORowSetMatrix::iterator aIter(aEnd); sal_Int32 nPos = m_nStartPos + 1; bCheck = fill(aIter, m_pMatrix->end(), nPos, bCheck); } introduced in 1234d599d4ee67bd725f0513431b2d4c56c9e09d "ORowSetCache: overhaul internals," presumably to limit the scope of that aIter introduced there). Change-Id: I1cf4a22fbd1b76d524251a82c3ab4e6ca7a9eca1
* loplugin:mergeclasses, merge OOdbcLibWrapper with OOdbcEnumerationNoel Grandin2015-10-132-53/+25
| | | | Change-Id: I2e564e90c11bb46022a5e258ad013aeb2fe4ca2e
* loplugin:mergeclasses, merge ILabelProvider with LabelProviderNoel Grandin2015-10-131-16/+8
| | | | Change-Id: I8fb231b4189c09d8e049855d38b0f1eb518ac2b9
* loplugin:mergeclasses, merge IImageProvider with ImageProviderNoel Grandin2015-10-131-17/+9
| | | | Change-Id: I6af8b1ab9198439af60e38a9adc6bdd29d20ab52
* Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-12278-3220/+3220
| | | | Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
* Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-1210-21/+21
| | | | Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
* convert Link<> to typedNoel Grandin2015-10-1230-80/+92
| | | | | | | Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb Reviewed-on: https://gerrit.libreoffice.org/19305 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:mergeclassesNoel Grandin2015-10-129-126/+49
| | | | Change-Id: I1ce2e31e4dae780612e51b3806ee6044be9cf4bb
* formattingNoel Grandin2015-10-121-7/+5
| | | | Change-Id: Id712e25efc6ea99c0979b48e6cbec068864f4c46
* unnecessary and confusing typedefNoel Grandin2015-10-122-23/+22
| | | | Change-Id: Id16013c3e12312608eba2eda378debf362da7013
* Related tdf#45775: PgSQL new DB allow empty DatasourceJulien Nabet2015-10-122-0/+2
| | | | | | | | | Declare PostgreSql in dsn stuff Change-Id: I72343bff0d5e6a65a45fc47cc1d346155330f1e5 Reviewed-on: https://gerrit.libreoffice.org/19310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
* tdf#94709 - protect TableWindowTitle Command execution.Michael Meeks2015-10-071-1/+5
| | | | Change-Id: I202a154e18c1fbffc31abcc7ccd7f500b67a4c13
* loplugin:mergeclassesNoel Grandin2015-10-072-33/+9
| | | | Change-Id: I84dee96b7a1f72db46e3330ec5195367dfce894a
* Fix typosAndrea Gelmini2015-10-0613-18/+18
| | | | Change-Id: I54c32259750c0863a39f56fabaa1a0df7d208c9a
* loplugin:unusedmethodsNoel Grandin2015-10-062-6/+0
| | | | Change-Id: I150baadc442e57ee604563bc52965daa9d2e41af
* tdf#94559: 4th step to remove rtti.hxxOliver Specht2015-10-061-7/+8
| | | | | | | | | | replaced use of PTR_CAST, IS_TYPE, ISA in idl, editeng, sc, sd, sw, sfx2, sot, starmath Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653 Reviewed-on: https://gerrit.libreoffice.org/19132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
* cppcheck: noExplicitConstructorCaolán McNamara2015-10-052-7/+7
| | | | Change-Id: I80950aaf1385bd76b012eab7866fd16848751f45
* coverity#735690 Unchecked dynamic_castCaolán McNamara2015-10-011-4/+4
| | | | | | | | and coverity#735689 Unchecked dynamic_cast Change-Id: I1181e21146972c7c01b0a421d3c1c4ecc3d7e75a
* -Werror,-Wunused-private-fieldStephan Bergmann2015-10-012-3/+0
| | | | Change-Id: I24e4dde34993e4fc994a8dc4a318e7d17c357260
* loplugin:unusedmethodsNoel Grandin2015-10-0150-221/+13
| | | | | | | | | | | | - improvements to the plugin to find more method calls - improvements to python script to remove more false+ - fix the FORCE_COMPILE_ALL build flag to include code in the $WORKDIR Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836 Reviewed-on: https://gerrit.libreoffice.org/19064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Fix typosAndrea Gelmini2015-09-3014-15/+15
| | | | | | | Change-Id: Ia37c28bbb7a1b47ed4a6beffb3f03eb26742b653 Reviewed-on: https://gerrit.libreoffice.org/18944 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
* Renamed wrongly prefixed boolean variablesStefan Heinemann2015-09-295-18/+18
| | | | | | | | | Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* loplugin:removeunusedmethods, remove unused stuffNoel Grandin2015-09-2910-21/+1
| | | | Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
* tdf#94559: first step to remove rtti.hxxOliver Specht2015-09-2916-29/+30
| | | | | | | | | | replaced use of PTR_CAST, IS_TYPE, ISA in avmedia, basctl, basic, cui, dbaccess, vcl,xmloff Change-Id: If4496762e82e896b6fbc362e6626502703c245f5 Reviewed-on: https://gerrit.libreoffice.org/18905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
* Return std::unique_ptr from SvTreeListBox::CreateContextMenuStephan Bergmann2015-09-282-5/+6
| | | | Change-Id: I1e4c32099ec9741c0cab246eb627a2eb3b933e1a
* convert Link<> to typedNoel Grandin2015-09-262-5/+3
| | | | | | | Change-Id: If1dcc5e50b08540623bb21067c5f74e47192ef9a Reviewed-on: https://gerrit.libreoffice.org/18859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* convert Link<> to typedNoel Grandin2015-09-252-7/+5
| | | | | | | Change-Id: I7fd77490ab49a18f48e248ca277bc30b5a7d2071 Reviewed-on: https://gerrit.libreoffice.org/18858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* convert Link<> to typedNoel Grandin2015-09-246-50/+47
| | | | | | | Change-Id: I59d325c3b051690303a5841907317122fa1ec98b Reviewed-on: https://gerrit.libreoffice.org/18825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* convert Link<> to typedNoel Grandin2015-09-222-8/+8
| | | | | | | Change-Id: I12b3fdb443226a63786b94ce9836e9d2efa6a5c8 Reviewed-on: https://gerrit.libreoffice.org/18776 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* convert Link<> to typedNoel Grandin2015-09-211-5/+3
| | | | Change-Id: If3e2b00092440ebd42ae5b73ae2b0e44c3702683
* Some follow-up #include clean-upStephan Bergmann2015-09-182-3/+0
| | | | Change-Id: I4e91748701becfc92a379a490c08e9c7950007e3
* silence warning when not a warningLionel Elie Mamane2015-09-171-1/+2
| | | | Change-Id: I31d7835a5ed3053cd1a930b3fb922d689d6ddcbe
* boost->stdCaolán McNamara2015-09-1758-181/+155
| | | | Change-Id: Idfbcfa1e5ba7bff92e98693c33c4b33a6beda08f
* remove unused Link<> fieldNoel Grandin2015-09-172-7/+1
| | | | Change-Id: I4d9f7d0fb1a2621121aa26f1ddff0a04116bc561
* convert Link<> to typedNoel Grandin2015-09-172-21/+20
| | | | Change-Id: Iff53217807be85cbcd5f850739f8b0949521fca2
* convert Link<> to typedNoel Grandin2015-09-173-5/+5
| | | | Change-Id: I6c0898db47b39648bb143ad040864c0279269f96
* remove unused Link<> fieldsNoel Grandin2015-09-172-9/+2
| | | | Change-Id: I25bcec20f3a981ea681e29a0a1ef0726fa5e7e1c
* convert Link<> to typedNoel Grandin2015-09-178-49/+44
| | | | Change-Id: Ie331012fa9beed1da99d3741d816fb8ac0e94d6d
* remove unused Link<> fieldNoel Grandin2015-09-172-17/+0
| | | | Change-Id: Ic829d0e1acf11ce361f6bfe59364661ef9cb4b83
* convert Link<> to typedNoel Grandin2015-09-174-20/+18
| | | | Change-Id: I34e15999ecc73c5a330f637338ca9d8fce31b5d2
* convert Link<> to typedNoel Grandin2015-09-176-10/+8
| | | | Change-Id: I6f8ffaf59a1b22b66d3b92246384cd3203808bcf
* convert Link<> to typedNoel Grandin2015-09-174-15/+10
| | | | Change-Id: Ibb426c6d0cd81ff866c431be8277849e002df57a
* convert Link<> to typedNoel Grandin2015-09-174-8/+6
| | | | Change-Id: I3d35a0bb75b6989dd13371543d1bdf3ef5f47641
* convert Link<> to typedNoel Grandin2015-09-151-3/+1
| | | | Change-Id: I8f3e401afa27778678788b4ac90ea927a2fed1d7
* Resolves: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe2015-09-151-2/+2
| | | | | | | | | with the variadic variants. Change-Id: I7154f9472f02fdf47d27ba715db55bb1ec669a8a Reviewed-on: https://gerrit.libreoffice.org/18580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* convert Link<> to typedNoel Grandin2015-09-146-11/+14
| | | | Change-Id: I1c501671d72edd5b998e80c7fa1e91dbeb507af8
generated by cgit (git 2.34.1) at 2024-07-24 12:40:48 +0000