summaryrefslogtreecommitdiffstats
path: root/dbaccess
Commit message (Collapse)AuthorAgeFilesLines
* tdf#93724 KeySet insert: properly set default values: NULL & right typeLionel Elie Mamane2015-11-031-1/+12
| | | | | | | | Change-Id: I933eed918e18b6923d4e0d24748297cf0dd0088d Reviewed-on: https://gerrit.libreoffice.org/19651 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 11ce80e1e7085e2073850056e47e4e997905d286)
* Related tdf#45775: PgSQL new DB allow empty DatasourceJulien Nabet2015-10-172-0/+2
| | | | | | | | | | | | | Declare PostgreSql in dsn stuff Change-Id: I72343bff0d5e6a65a45fc47cc1d346155330f1e5 Reviewed-on: https://gerrit.libreoffice.org/19310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> (cherry picked from commit 898aff0d190b09d16cce866909b64cf023cba43f) Reviewed-on: https://gerrit.libreoffice.org/19315 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 6b8479107482b180723d01d2fcd90120663435c5)
* tdf#94709 - protect TableWindowTitle Command execution.Michael Meeks2015-10-171-1/+5
| | | | | | | | | Change-Id: I202a154e18c1fbffc31abcc7ccd7f500b67a4c13 Reviewed-on: https://gerrit.libreoffice.org/19233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f7e8fe2a4b0c2554200b1191cf4497c0ece8dbeb)
* java: 'final static' to 'static final'Noel Grandin2015-10-151-2/+2
| | | | | | | | | | | this is the canonical order, and it makes the code easier to read Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org> (cherry picked from commit 0c18bedb7328493040c1a20822b345e624d6041f) Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
* tdf#92434 - dispose the table contents.Michael Meeks2015-08-061-1/+1
| | | | | | | | | | | | fix issue from: 6d0c89123f353aed80d3a8a08ef5cd1ffaa1eea9 Change-Id: Ia5b7bb91c366ecbbb3111d6f5239d5360640ca2d Reviewed-on: https://gerrit.libreoffice.org/16893 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/16895 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* Related: tdf#92434 children cleared but parent hasn't completed dispose yetCaolán McNamara2015-08-064-59/+66
| | | | | | | | | | | | Table::dispose is being executed, so its not IsDisposed yet, but this a11y code gets called during the dispose and the children have been cleared at this point Change-Id: I20aa9b15b1c5c3da91af58ac61f59fcf52619d58 (cherry picked from commit 4bb2d015b332aa5e7623b4edba53f0503c64bbba) Reviewed-on: https://gerrit.libreoffice.org/16825 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* tdf#92431 Keep thumbnail for modified but unsaved docMaxim Monastirsky2015-08-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | A regression of 1166966eb4112fdf332c656eae5082d82a3ec2f2. We need to consider 2 use-cases: 1. Protecting an existing document with a password (by overwriting the original file). In this case we don't want to generate a thumbnail from the now encrypted file, but we do want to erase the stored thumbnail and show a generic icon instead. 2. Closing a modified document without saving the changes. Here we don't want to generate a thumbnail either, because it may contain the unsaved changes, but either we don't want to replace the stored thumbnail, because most likely it correctly represents the last saved state of the document. Change-Id: Ia7b1f3dbc9fbbc2ef1d87442c1dee25306f65826 Reviewed-on: https://gerrit.libreoffice.org/16659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit d9c476bfbb4a8f1858c072d2fba33aa9e8e0ae92) Signed-off-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#92520: LibO crash when editing .odb database propertiesZolnai Tamás2015-08-061-2/+1
| | | | | | | | | | | Regression from: f7424ed710e54bb2437a28380b03ed7c26290edc Change-Id: I7665d579696f21846abaed21ca8c4f14acdc964c (cherry picked from commit 9216e5ef76ab718568ebda64ccfa0c010390e11a) Reviewed-on: https://gerrit.libreoffice.org/16768 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* tdf#92434 - A series of hideous knock-on dbaccess crasher fixes.Michael Meeks2015-08-062-3/+3
| | | | | | | | | | | | Focus events during dispose, unfortunate incoming a11y events, etc. Change-Id: Iee296b767839904f5f330786891bc2513ca06c0c Reviewed-on: https://gerrit.libreoffice.org/16672 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/16686 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#92434 - fix iteration, and remember to disposeAndClear.Michael Meeks2015-08-061-7/+14
| | | | | | | | | | | Change-Id: Id9c7b33689ea51a18394a96acbb9c08d67992942 Reviewed-on: https://gerrit.libreoffice.org/16671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/16685 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Some missing SolarMutexGuard around VclPtr acquire/releaseStephan Bergmann2015-08-062-0/+4
| | | | | | | | | | | | | At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so apparently rely on the SolarMutex being locked whenever they are called. Fixed those places that caused "make check" to fail for me when temporarily adding DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is that a class fails to ensure the SolarMutex is locked around the destruction of non-null VclPtr members.) Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5 (cherry picked from commit 8e1ad966262932516b3368d9b5c44becb29524d4) Signed-off-by: Michael Stahl <mstahl@redhat.com>
* loplugin:implicitboolconversionStephan Bergmann2015-08-061-1/+1
| | | | | Change-Id: Ic0c6487661286efa04452427fc3a64da747c2ce8 (cherry picked from commit 08e278b411a3b824e9af611ebb1763c1f4f80ef2)
* gcc4.6: remove trigraph sequences '<::'Thorsten Behrens2015-08-061-1/+1
| | | | Change-Id: Iaea3121fbc4e826b5d1f76b052c21b4dcf18df70
* Apply new VclPtr clang plugin to catch potential problems.Noel Grandin2015-08-068-9/+12
| | | | | | | | | | Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* tdf#91702 - fix stack-based MessBox allocation.Michael Meeks2015-08-065-10/+10
| | | | | | | Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* do not try to get bookmark when in invalid positionLionel Elie Mamane2015-05-301-0/+1
| | | | Change-Id: I64fc14e527af4f0f846bbfae84cf8d1d2914b6b9
* handle getParameters being called before execute()Lionel Elie Mamane2015-05-302-5/+11
| | | | Change-Id: If81e745ee15df3848c6577a9e979672523718daf
* tdf#82591 ORowSetBase::getRow handles insert row correctlyLionel Elie Mamane2015-05-303-11/+22
| | | | | | and critically for this bug, modified row, too. Change-Id: I11c418d8926cabe81fcdb65d7293a4283e566f7a
* fix drawing treelistbox with redefined background in dbaccessTomaž Vajngerl2015-05-291-1/+5
| | | | | Change-Id: Ia55797e3e42309f9d37d5335088f7657d99954de Signed-off-by: Jan Holesovsky <kendy@collabora.com>
* fix Base's titlewindow font, font color and backgroundTomaž Vajngerl2015-05-292-11/+31
| | | | | Change-Id: Ide9c30385d15d0b8303f25d1a9eef132a32ec7d2 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
* convert WINDOW_POSSIZE constants to scoped enumNoel Grandin2015-05-291-1/+1
| | | | | Change-Id: Id85137ffc7309a66b04132d588d289db136117b9 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
* convert WINDOW constants for GetWindow() methods to scoped enumNoel Grandin2015-05-291-2/+2
| | | | | Change-Id: I0c7c6d095732704eb4ab48f1277a0592b1c7fa33 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
* convert POINTER constants to scoped enumNoel Grandin2015-05-292-6/+6
| | | | | | | | Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Signed-off-by: Jan Holesovsky <kendy@collabora.com>
* VclPtr: assert with query dialog open on closing query designCaolán McNamara2015-05-281-1/+1
| | | | | Change-Id: I40d196462ff2e37d86ca367d3a150c94872715f1 (cherry picked from commit 2ecf0ced9d2e55881033786fe95d45ceaeb73d37)
* VclPtr: undisposed things and dispose order on query design window closeCaolán McNamara2015-05-282-1/+4
| | | | | Change-Id: I3070d52e15febe2f5981ffdf5d665e28fa4f799b (cherry picked from commit 82f15336cfbcb766c060c4936d11ff33c54558e4)
* Rewrite all calls like Dialog(params).Execute()Philippe Jung2015-05-285-6/+6
| | | | | | | | | | | | | Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* Fix accidental mis-uses of VclPtr address-of operatorStephan Bergmann2015-05-271-1/+1
| | | | | | Change-Id: I3a82423378d3198a25f90ddfbf42af55d85c96fb (cherry picked from commit 668408fa1c69eaf0f0a37f24e2ec8b4a38fe3db7, w/o the accidentally included sw/htmlexport-swobjects.patch)
* tdf#91543 - TABLE DESIGN window menu option Close causes BASE to crashNoel Grandin2015-05-263-2/+9
| | | | | Change-Id: Ib169950f4e33dc71db66fd9a938838b568d2cc22 (cherry picked from commit 15e64391aeed35e5c85876650fd8093f20958d8b)
* Audit all PostUserEvent calls and instrument for VclPtr.Michael Meeks2015-05-267-14/+14
| | | | | | Hold a reference on the VclPtr while we're waiting for the UserEvent. Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
* convert DEFAULTCONSTANT constant to scoped enumNoel Grandin2015-05-203-3/+3
| | | | Change-Id: I5ebd77edfa29d6c6c7acea37e826ef1d625916c3
* convert TEXT_DRAW constants to scoped enumNoel Grandin2015-05-204-7/+7
| | | | Change-Id: Ic0f7f8fa236bb478b3598ae3fd3c1b30ebbf1a01
* remove the last of the OUString #defines in header filesNoel Grandin2015-05-191-1/+1
| | | | Change-Id: Id9e8ce7987e055e83b52c7024413570f262e6e8d
* Remove include stdio (part2)Julien Nabet2015-05-181-1/+0
| | | | | | | Change-Id: Iae58d107d8df1c543a165086fb2b7c288e7121dd Reviewed-on: https://gerrit.libreoffice.org/15775 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* pass RenderContext to PreparePaint in TreeListBoxTomaž Vajngerl2015-05-182-13/+14
| | | | Change-Id: I32961f5cd511b9ecc756e99ca95e4e9ddbc6b795
* refactor how font, fg. and bg. are applied in widgets/controlsTomaž Vajngerl2015-05-1810-15/+30
| | | | | | | | | | | | | - Move vcl::RenderContext to outdev. - Change some methods on vcl::Window to accept RenderContext as parameter. - Add ApplySettings to vcl::Window - This method is called before painting. Refactor existing classes that use InitSettings to have ApplySettings or mark the classes to be refactored later. - Add RenderSettings for adding defered settings to rendering. This is similar to ApplySettings but for more ad-hoc calls. Change-Id: I4ea58461f3b6b08ccfa3e0ddd1a4a3e04f8c4f45
* loplugin:staticmethodsStephan Bergmann2015-05-172-23/+26
| | | | Change-Id: Id3a8fee18a954a14b63fd922803f8a7f13b49727
* refactor dbacess classes to use RenderContextTomaž Vajngerl2015-05-1614-84/+67
| | | | Change-Id: I60e436ec1e6974e5fb8c6525552c6e172ceca0ca
* tdf#62475: partial handmade fixesAndrea Gelmini2015-05-156-16/+8
| | | | | | | Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4 Reviewed-on: https://gerrit.libreoffice.org/15712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* convert POPUPMENU_ constants to scoped enumNoel Grandin2015-05-151-1/+1
| | | | Change-Id: I4cdaf36581d1e1daa39929e621070d18a9996852
* convert QUICKHELP constants to scoped enumNoel Grandin2015-05-142-2/+2
| | | | Change-Id: Ie7302c909feb2e83b8b5e62a5e6a1f901783fb49
* convert ENDTRACK_ constants to scoped enumNoel Grandin2015-05-131-1/+1
| | | | Change-Id: Iaccd9c3be1ae24f7f9861f9049cd5b52f155170f
* loplugin:redundantcast: reinterpret_cast to void*Stephan Bergmann2015-05-122-2/+2
| | | | Change-Id: I947b49cfb15f0e7d6ddfaae386656c70e4bd48ba
* Switch VclBuilder constructors to use VclPtr.Michael Meeks2015-05-123-3/+3
| | | | Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
* Revert "Switch VclBuilder constructors to use VclPtr."Michael Meeks2015-05-113-3/+3
| | | | | | | | Behaves oddly; not ready yet. This reverts commit 9f016bd69422bdfb4cf7c4f5e57356eb98db2d8c. Change-Id: I30d746eac29d1dbe78d3072b10d2e22c051e3f4e
* Switch VclBuilder constructors to use VclPtr.Michael Meeks2015-05-113-3/+3
| | | | Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
* convert COMMAND_ constants to scoped enumNoel Grandin2015-05-118-17/+16
| | | | | | | Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95 Reviewed-on: https://gerrit.libreoffice.org/15671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann2015-05-111-1/+1
| | | | Change-Id: If8f59f3a9bc695ed407166e03e3e01e2725a4fed
* unused parameterTomaž Vajngerl2015-05-111-2/+2
| | | | Change-Id: Ied856c05594a0ee5bd43ec61e65d12dd18e746d8
* refactor TreeListBox to use RenderContextTomaž Vajngerl2015-05-114-18/+23
| | | | Change-Id: I901a1f1f9732fb66718dca34c698a851e5b0d87f
* Use IMPL_LINK_NOARG[_TYPED] where applicableStephan Bergmann2015-05-1023-41/+41
| | | | Change-Id: I70598072c1d492e360ef46dd7b5ef5a2fa4be495