summaryrefslogtreecommitdiffstats
path: root/dbaccess/source/ui/uno/copytablewizard.cxx
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:stringadd convert chained append to +Noel Grandin2021-04-271-1/+1
| | | | | | | | | | | | which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#119962 Fix autoincrement for copied tableOleksii Makhotin2021-04-171-0/+41
| | | | | | | Change-Id: Ic916288c4177734c93c423ac3823993ca95a941d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113668 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:referencecasting in dbaccessNoel2021-02-151-3/+3
| | | | | | | Change-Id: Ib4e751ce4ce83db4af66d2fd969108a86dcd2296 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110891 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* dbaccess: create instances with uno constructorsNoel Grandin2020-07-081-27/+5
| | | | | | | | | See tdf#74608 for motivation Change-Id: Ib03014444d8176417cbd00b56764ee45fdad557c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98322 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* new loplugin:simplifypointertoboolNoel Grandin2020-05-101-1/+1
| | | | | | | Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* CopyTableWizard: make code less confusingLionel Elie Mamane2020-05-101-3/+7
| | | | | | | | | | | | | | | | | createTable looked into the requested operation, and depending on that, either created the table or fetched the existing one. For a function named createTable, that made for confusing reading. Split that into: * createTable that creates the table * getTable that fetches the existing table * returnTable that automagically creates or fetches an existing table, depending on the requested operation. Change-Id: I91be67c24026c850530dcaef5ec95ab508e81434 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93882 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
* tdf#42949 Fix IWYU warnings in dbaccess/source/ui/[m-u]*/*cxxGabor Kelemen2020-04-271-2/+0
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6bf360b331589692141f6fca52eee5b8e11ef7bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92827 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorOnur Yilmaz2020-01-281-2/+1
| | | | | | | Change-Id: Ie5a381fc5e5b73490ab8b2036ef2a1164e475e8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87557 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
* Extend loplugin:external to warn about classesStephan Bergmann2019-11-221-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend loplugin:external to warn about enums". Cases where free functions were moved into an unnamed namespace along with a class, to not break ADL, are in: filter/source/svg/svgexport.cxx sc/source/filter/excel/xelink.cxx sc/source/filter/excel/xilink.cxx svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx All other free functions mentioning moved classes appear to be harmless and not give rise to (silent, even) ADL breakage. (One remaining TODO in compilerplugins/clang/external.cxx is that derived classes are not covered by computeAffectedTypes, even though they could also be affected by ADL-breakage--- but don't seem to be in any acutal case across the code base.) For friend declarations using elaborate type specifiers, like class C1 {}; class C2 { friend class C1; }; * If C2 (but not C1) is moved into an unnamed namespace, the friend declaration must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither qualified nor a template-id and the declaration is a function or an elaborated-type-specifier, the lookup to determine whether the entity has been previously declared shall not consider any scopes outside the innermost enclosing namespace.") * If C1 (but not C2) is moved into an unnamed namespace, the friend declaration must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882> "elaborated-type-specifier friend not looked up in unnamed namespace". Apart from that, to keep changes simple and mostly mechanical (which should help avoid regressions), out-of-line definitions of class members have been left in the enclosing (named) namespace. But explicit specializations of class templates had to be moved into the unnamed namespace to appease <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of template from unnamed namespace using unqualified-id in enclosing namespace". Also, accompanying declarations (of e.g. typedefs or static variables) that could arguably be moved into the unnamed namespace too have been left alone. And in some cases, mention of affected types in blacklists in other loplugins needed to be adapted. And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is not moved into an unnamed namespace (because it is declared in sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler doesn’t give this warning for types defined in the main .C file, as those are unlikely to have multiple definitions." (<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The warned-about classes also don't have multiple definitions in the given test, so disable the warning when including the .cxx. Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4 Reviewed-on: https://gerrit.libreoffice.org/83239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* merge msgbox and stdtextCaolán McNamara2019-10-031-1/+0
| | | | | | | | Change-Id: If95d78746eff3ae5343e7d4c6bb2433537ccb84d Reviewed-on: https://gerrit.libreoffice.org/80099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* drop newly unnecessary OGenericUnoDialog::DialogCaolán McNamara2019-09-201-4/+4
| | | | | | | | Change-Id: If047d08cea93fdfacff9ee00c69cf57ba08c916c Reviewed-on: https://gerrit.libreoffice.org/78972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* weld OCopyTableWizard clusterCaolán McNamara2019-09-121-8/+15
| | | | | | | | | Change-Id: I52547defb0e7ba328ec20d41a955e545556ffd16 note: get the toplevel parent by getting it from the XInteractionHandler Reviewed-on: https://gerrit.libreoffice.org/78751 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Revert "tdf#127093, tdf#127092 Fix pasting autoincremented"Tamas Bunth2019-09-031-6/+0
| | | | | | | | | This reverts commit fa177231cd20bf3c3f4bb9b50f6646da139c6766. Change-Id: Ia0c2d83c840c0ff8981b721766a6a1df810f971d Reviewed-on: https://gerrit.libreoffice.org/78559 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* dbaccess: delete old paste autoincrement logicTamas Bunth2019-08-311-11/+0
| | | | | | | Change-Id: I6a4392c9e93842838022370fe6c54908adcc627b Reviewed-on: https://gerrit.libreoffice.org/78358 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* tdf#127093, tdf#127092 Fix pasting autoincrementedTamas Bunth2019-08-311-0/+8
| | | | | | | | | | | Fix copy/paste functionality when trying to paste a table with auto incremental column in it. In that case we should let the DBMS handle the values in that column. Change-Id: Ia40a0056402ec540f469b94694629dd6db7d4e71 Reviewed-on: https://gerrit.libreoffice.org/78298 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* Improved loplugin:stringconstant (now that GCC 7 supports it): dbaccessStephan Bergmann2019-07-311-1/+1
| | | | | | | Change-Id: I85262c1f8d875fc8556773eab8636738340068c1 Reviewed-on: https://gerrit.libreoffice.org/76686 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:referencecasting in dbaccessNoel Grandin2019-07-191-1/+1
| | | | | | | Change-Id: If44176f85f460afca92cfa77b3cc1f7107a41690 Reviewed-on: https://gerrit.libreoffice.org/75938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Use hasElements to check Sequence emptiness in cppcanvas..desktopArkadiy Illarionov2019-06-051-3/+3
| | | | | | | | | Similar to clang-tidy readability-container-size-empty Change-Id: I81c0ff78d2ecc7d984e3ed5e5ce60efe327fc162 Reviewed-on: https://gerrit.libreoffice.org/71799 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin2019-05-131-2/+2
| | | | | | | | | | | By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typoAndrea Gelmini2019-05-121-2/+2
| | | | | | | Change-Id: Ic575e060a6f4d19213182acc32e4e9e6374f2ae2 Reviewed-on: https://gerrit.libreoffice.org/72178 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-04-221-1/+1
| | | | | | | Change-Id: I41e527ae8932bf5897c907d52a2053803dd8a7c6 Reviewed-on: https://gerrit.libreoffice.org/71058 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:indentation in dbaccess..drawinglayerNoel Grandin2019-02-081-2/+0
| | | | | | | Change-Id: I05de6c01e827e596c9802c04964f43508dfd4d64 Reviewed-on: https://gerrit.libreoffice.org/67537 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove obsolete SAL_FALLTHROUGH completelyStephan Bergmann2018-12-081-2/+2
| | | | | | | | | | ...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b "HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now" Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937 Reviewed-on: https://gerrit.libreoffice.org/64800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* weld ODbAdminDialogCaolán McNamara2018-10-241-1/+0
| | | | | | | | Change-Id: I691ce67b55fb16d06d7266ebe671ac31e30c05d5 Reviewed-on: https://gerrit.libreoffice.org/62297 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* make OGenericUnoDialog take an awt::XWindowCaolán McNamara2018-10-061-3/+4
| | | | | | | | Change-Id: I7c63397d0579306f4ade1947ce5bf9e1866bf876 Reviewed-on: https://gerrit.libreoffice.org/61469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* new loplugin:oustringbufferNoel Grandin2018-08-291-1/+1
| | | | | | | | | | | look for places where we are appending the temporary result of adding strings together, to an OUStringBuffer, where we could rather call append repeatedly and avoid the temporary creation Change-Id: I481435124291ac7fb54b91a78344a9fe5b379a82 Reviewed-on: https://gerrit.libreoffice.org/59708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Add missing sal/log.hxx headersGabor Kelemen2018-08-011-0/+1
| | | | | | | | | | | | | | rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from dbaccess to extensions Change-Id: I4d15aa35e11664ef78c836ffc2937c7e0bb6ea59 Reviewed-on: https://gerrit.libreoffice.org/58165 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* pass area param to DBG_UNHANDLED_EXCEPTIONNoel Grandin2018-04-031-5/+5
| | | | | | | | | and update sallogareas plugin to enforce this Change-Id: Id0782c8a1f619372e10d931aec3c6a4743a4c86a Reviewed-on: https://gerrit.libreoffice.org/52249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* support both vcl and weld in genericunodialog for interimCaolán McNamara2018-03-211-4/+4
| | | | | | | | Change-Id: Ife85dd7a4bd27260514b390ca3928152db0d688f Reviewed-on: https://gerrit.libreoffice.org/51699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* drop msgbox includeCaolán McNamara2018-03-201-1/+0
| | | | | | | | Change-Id: Ic7872adf8a7e8e4a8e1503dd21e22ec69509efaf Reviewed-on: https://gerrit.libreoffice.org/51652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* More loplugin:cstylecast: dbaccessStephan Bergmann2018-01-121-1/+1
| | | | | | | | auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I96df8923f7791288bbd350d75582a9220006ece6
* tdf#114755: Remove extra parenthesisJulien Nabet2017-12-311-1/+1
| | | | | | | | | from SELECT block of INSERT INTO <> SELECT <> Change-Id: Ibe3c3f5f2fbc15388c716ae262e87137958c1a7e Reviewed-on: https://gerrit.libreoffice.org/47218 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:unusedindexMike Kaganski2017-12-181-7/+3
| | | | | | | Change-Id: I256a807dd2a4c81126b5a76f3d472e31b8224146 Reviewed-on: https://gerrit.libreoffice.org/46652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use ColumnPositions name more consistentlyNoel Grandin2017-12-151-9/+8
| | | | | | | | | | mostly so I can track down more accurately what values are being stored in this vector<pair<>> Change-Id: I3755a098a577facef1c1af62c5583f0e2f7ca90b Reviewed-on: https://gerrit.libreoffice.org/46500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:salcall fix functionsNoel Grandin2017-12-111-1/+1
| | | | | | | | | | since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constantparam in connectivityNoel Grandin2017-11-011-1/+1
| | | | | | | Change-Id: Ia13d0931bbdf642fe04119ea1112788fb143eba8 Reviewed-on: https://gerrit.libreoffice.org/44110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:includeform: dbaccessStephan Bergmann2017-10-231-9/+9
| | | | Change-Id: I15aee966012612033ab7e2ee03ac1a553802f540
* Removed duplicated includesAndrea Gelmini2017-07-231-1/+0
| | | | | | | | | | Mainly about "core_resource.hxx" and "strings.hrc". It passed "make check" on Linux. Change-Id: I994420d5e33d02b64929f8a51c548a7322d88a79 Reviewed-on: https://gerrit.libreoffice.org/40311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* migrate to boost::gettextCaolán McNamara2017-07-211-16/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
* tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock2017-04-251-0/+1
| | | | | | | Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* Drop :: prefix from std in [de]*/Tor Lillqvist2017-02-171-8/+8
| | | | | | | Change-Id: I3247894fe022dce7f0aa351bd85fefcd7c545dd4 Reviewed-on: https://gerrit.libreoffice.org/34377 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
* loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin2017-01-281-8/+8
| | | | | | | | | ..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove dynamic exception specificationsStephan Bergmann2017-01-261-36/+36
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* New loplugin:dynexcspec: Add @throws documentation, dbaccessStephan Bergmann2017-01-191-0/+2
| | | | Change-Id: I117be0dca3cc5e204414613123422b4b0716d8ed
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-131-1/+1
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* coverity#1362680 Pointer to local outside scopeCaolán McNamara2016-06-131-1/+1
| | | | | | | | | | | | | | | | | this doesn't seem to make sense anymore since... commit 4d49c9601c9b3e26a336e08e057d299895683480 Author: Stephan Bergmann <sbergman@redhat.com> Date: Wed Jun 8 17:14:34 2016 +0200 Let loplugin:passstuffbyref also look at fn defn not preceded by any decl so lets revert that to be safe Change-Id: I78fe8ae48dc4c4f3d5786c7232d7e791ff50d9b4 Reviewed-on: https://gerrit.libreoffice.org/26189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann2016-06-081-1/+1
| | | | Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
* Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann2016-05-101-2/+3
| | | | | | | | | | | | | | | | ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
* clang-tidy modernize-loop-convert in d*Noel Grandin2016-04-251-3/+3
| | | | Change-Id: I0830a41b48e884ef63d32b5873c7007195659bb9
* loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2016-04-201-1/+1
| | | | Change-Id: I5cd8fd979fd4caa3d7cde599096627bfdd0dec7e
generated by cgit (git 2.34.1) at 2024-07-14 00:00:46 +0000