summaryrefslogtreecommitdiffstats
path: root/cui
Commit message (Collapse)AuthorAgeFilesLines
* Resolves: tdf#101196 line wrap very long checkbox contentCaolán McNamara2016-08-032-1/+13
| | | | | | | | Change-Id: Ie451b88240f755a0d64dd3db14d7981b8ed2a2a2 (cherry picked from commit 1c33b3f5f693d432f74c795a87f87bd487b09d47) Reviewed-on: https://gerrit.libreoffice.org/27811 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* masses of MessBoxes not being disposed promptlyCaolán McNamara2016-08-0314-27/+27
| | | | | | | | | | | | | | | | | | | | | since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X (cherry picked from commit a860df25dd7bf62ecb6b3d3ed38803b981f56d52) Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f Reviewed-on: https://gerrit.libreoffice.org/27537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* Resolves: tdf#96677 effects page didn't link labels to what they labelledCaolán McNamara2016-08-021-0/+20
| | | | | | | | | (cherry picked from commit b3b7669e7fb74b04d925f21a7f0b048434eeffa3) Change-Id: I29503324f221c42208267f4f0d36922e89119fdd Reviewed-on: https://gerrit.libreoffice.org/27677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* Resolves: tdf#101054 crash on options->path with non-native file pickerCaolán McNamara2016-07-221-1/+0
| | | | | | | | | | | | | | | | | | regression from... commit 3bbc0574d78d129359638b74612de2f93419eeb0 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jul 5 10:16:51 2016 +0100 Resolves: rhbz#1352835 path options doesn't promptly destroy folder picker only clear the xFolderPicker immediately in the non-async case Change-Id: Id6a411424d41262a9379ad3eb7976c8dd666a5cf (cherry picked from commit c1bd3156cf66318023f36d81ce809a38072588e4) Reviewed-on: https://gerrit.libreoffice.org/27417 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
* Revert "Addition of new controls and their rearrangement in gradient tab"Rishabh Kumar2016-07-205-219/+283
| | | | | | | | | | | | | Unfinished GSoC: Area Fill project feature. Introduces regression in LibreOffice-5-2. This reverts commit fe3d9ac20b0f27b8beca7e54efa8ba571e76101d. Change-Id: Ic1a9e2d7279e0b06e19b5d1020b37b44d28060b4 Reviewed-on: https://gerrit.libreoffice.org/27336 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Revert "Addition of new controls and their rearrangement in hatch tab"Rishabh Kumar2016-07-205-274/+335
| | | | | | | | | | | | | Unfinished GSoC: Area Fill project feature. Introduces regression in LibreOffice-5-2. This reverts commit 7a4bd998e900c7f7a28f9068b97707ef76c99b85. Change-Id: I94c24b252983732161b8f2f0de51780a4d5c13bd Reviewed-on: https://gerrit.libreoffice.org/27331 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Resolves: tdf#99963 line wrap very long checkbox contentCaolán McNamara2016-07-182-1/+11
| | | | | | | | Change-Id: I11ab52b8c6600d5d479ac3d4d2cd78d1957d8676 (cherry picked from commit ea3f74ba0a9d291f26a79f2568d59f1a030d0585) Reviewed-on: https://gerrit.libreoffice.org/27292 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* make sure that the thread has joined before disposing UI elementsMarkus Mohrhard2016-07-131-0/+3
| | | | | | | | | | | | | | | | | | | See e.g. http://crashreport.libreoffice.org/stats/crash_details/80884848-16e7-4512-be4a-74c53bfce34b#allthreads The thread can run while the UI elements have already been disposed. The StopExecute call is not enough to prevent that from happening. Reviewed-on: https://gerrit.libreoffice.org/27087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 4ebbb996ac159f57e0730c938667535af148cae1) Change-Id: Iab4209776e1403a6520c106f3521476ee50848a4 Reviewed-on: https://gerrit.libreoffice.org/27183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Resolves: rhbz#1352835 path options doesn't promptly destroy folder pickerCaolán McNamara2016-07-111-10/+9
| | | | | | | | | Change-Id: I5133f63fd92f384221fa2812c6e2a0e7f3b37ac1 (cherry picked from commit 3bbc0574d78d129359638b74612de2f93419eeb0) Reviewed-on: https://gerrit.libreoffice.org/26941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
* cui: add calculation mode to Help->About.Michael Meeks2016-07-071-0/+13
| | | | | | | | | | | | Reviewed-on: https://gerrit.libreoffice.org/26964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit adc3932dfc4fe763b7db0af8843b01614bdc6aa2) Change-Id: I4765436bed8a58c5097afcf7dce768d3ec325015 Reviewed-on: https://gerrit.libreoffice.org/27003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* tdf#100222: Show the dialog just once even if both toggles were changedTor Lillqvist2016-06-271-6/+4
| | | | | | | | Change-Id: If6058d68f80ebc3e235f0a681cfe3240985e2429 Reviewed-on: https://gerrit.libreoffice.org/26693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#100222: Inform user that a restart is needed after toggling OpenCL useTor Lillqvist2016-06-261-0/+3
| | | | | | | | | | (cherry picked from commit c7c27b9b191291cf36e4940aef3e3e7371855797) Change-Id: Ic33cb02440276bc0601c86f2c9eab7d74a6b9874 Reviewed-on: https://gerrit.libreoffice.org/26610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Resolves: tdf#93135 can't resize shape with "resize shape to fit text"Caolán McNamara2016-06-091-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are regressions from... commit 4a847bb4a2002d7f8f5854b7276ac67d369bdd3b Date: Sun Aug 2 21:20:48 2015 +0200 tdf#93079: "resize shape to fit text" state can't be disabled Wrong copy-paste and commit b2bae9b940fc34d2eecd7839e3cba1f41d111e87 Date: Thu Apr 9 23:38:47 2015 +0200 Related tdf#34467: Fit to Frame for text boxes is broken Wrong Copy-paste Its turns out that there is *no* SDRATTR_TEXT_AUTOGROWSIZE property. Only a SDRATTR_TEXT_AUTOGROWHEIGHT property e.g. see CustomShapeProperties::UpdateTextFrameStatus of svx/source/sdr/properties/customshapeproperties.cxx "change TextFrame flag when bResizeShapeToFitText changes (which is mapped on the item SDRATTR_TEXT_AUTOGROWHEIGHT for custom shapes, argh)" So the inconsistency between getting the itemstate of SDRATTR_TEXT_AUTOGROWSIZE and then setting/getting SDRATTR_TEXT_AUTOGROWHEIGHT is better resolved by getting the itemstate of SDRATTR_TEXT_AUTOGROWHEIGHT will have a follow up patch to remove SDRATTR_TEXT_AUTOGROWSIZE to show its not used by anything Change-Id: I8b8abde17c15761c621815ed2be62d6a8a5cd69a (cherry picked from commit d1df071c3fc452817746a8daa13000d2df667aba)
* Resolves: tdf#97839 a single character may be more than 1 utf-16 code pointsCaolán McNamara2016-05-291-1/+1
| | | | | Change-Id: Iba2460bfb9335615796db3f5e233b870a8d63339 (cherry picked from commit 847cdd8efd0662d61d288a4d944edc30e864d145)
* Window::SetData and Window::GetData are nearly unused nowCaolán McNamara2016-05-251-13/+2
| | | | | | | | | | except for.. a) one use in sw which we can replace with a map b) one use in svx which didn't do anything c) one amusing piece of crazy in cui Change-Id: If66d9f7eab1eaddfb2bdab7815c3a6f22f4d7745
* (nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara2016-05-253-16/+0
| | | | | | | | | The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
* Convert SnapType to scoped enumNoel Grandin2016-05-241-5/+5
| | | | | | | Change-Id: I3980c2999bab191bb9357c883868db17db79e81f Reviewed-on: https://gerrit.libreoffice.org/25353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Addition of new controls and their rearrangement in hatch tabRishabh Kumar2016-05-235-335/+274
| | | | | | | | | | | | | 1. Removal of rectangle hatch angle dial widget 2. Addition of slider widget for changing angle in hatch tab. 3. Move hatch background color control from area tab to hatch tab. 4. Rearrangement of controls 5. Removal of hatch controls from Area tab Change-Id: I596098b328fc183d2fdd5259e90013dbf74d9ad7 Reviewed-on: https://gerrit.libreoffice.org/25147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
* tdf#89329: use unique_ptr for pImpl in optsaveXisco Fauli2016-05-232-5/+4
| | | | | | | Change-Id: Ia442a6a5c570c45b03fc878099f1c50005ee7538 Reviewed-on: https://gerrit.libreoffice.org/25331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Resolves: tdf#99981 make ScriptSelectorDialog modal for its parentCaolán McNamara2016-05-233-15/+6
| | | | Change-Id: Ia522b36cd1f5d47d08afa74a22cec11de465f567
* tdf#89329: use unique_ptr for pImpl in optpathXisco Fauli2016-05-232-6/+5
| | | | | | | Change-Id: If9e627e2f0f091e8411d0c6f16f29b583723419a Reviewed-on: https://gerrit.libreoffice.org/25327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#99211 Use the restart dialog for notifications about restartirem2016-05-231-6/+9
| | | | | | | | Change-Id: I97a10cddafc464ccbdd37902c5d24b73246f5c3f Reviewed-on: https://gerrit.libreoffice.org/24877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Convert HYPERDLG_EVENT to scoped enumNoel Grandin2016-05-222-9/+9
| | | | | | | Change-Id: I8a0248bb91ee67596aa44d11ca862d2e127a65ad Reviewed-on: https://gerrit.libreoffice.org/25197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy modernize-make-uniqueNoel Grandin2016-05-193-20/+22
| | | | | | | Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Addition of new controls and their rearrangement in gradient tabRishabh Kumar2016-05-185-283/+219
| | | | | | | | | | | | 1. Addition of increment spin box and slider in gradient tab. 2. Addition of slider for border controls in gradient tab. 3. Rearrangement of controls. 4. Removal of gradient controls from Area tab. Change-Id: I56c3767a0d54990338982cd45ed10a10dd8a94c1 Reviewed-on: https://gerrit.libreoffice.org/24910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
* convert TAB to scoped enumNoel Grandin2016-05-182-16/+16
| | | | | | | | | and rename the SID constant to something more meaningful Change-Id: Ic07888936df3d537158fd2fb671b0df11350d676 Reviewed-on: https://gerrit.libreoffice.org/24986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* update unusedmethods plugin to deal with constructorsNoel Grandin2016-05-1810-85/+3
| | | | | | | | | | and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy modernize-make-sharedNoel Grandin2016-05-181-8/+8
| | | | | | | Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#88502 Added error box to denote connection errors instead of progress barSusobhan Ghosh2016-05-172-16/+24
| | | | | | | Change-Id: I8217fa487ed58f5d396e8769c76dd2d16f390472 Reviewed-on: https://gerrit.libreoffice.org/24757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
* Convert LB flags to scoped enumNoel Grandin2016-05-161-120/+131
| | | | | | | Change-Id: I6bce097e803ece5ddf7764651900e0d14a2d0393 Reviewed-on: https://gerrit.libreoffice.org/24985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Give unique, comprehensible names to idles tdf#97087Muhammet Kara2016-05-162-0/+2
| | | | | | | | | Timers and idles should have programmer comprehensible, unique names. Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a Reviewed-on: https://gerrit.libreoffice.org/24605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* mpDefDialogParent is not used since 2002Caolán McNamara2016-05-122-10/+1
| | | | | | | | | | | | | | i.e. commit c0ae87cb5f2989bc4b8dff4907994d513ee87e39 Author: Stephan Schäfer <ssa@openoffice.org> Date: Tue Oct 22 08:39:05 2002 +0000 #103442# choose DefDialogParent on-the-fly and so calling SetDefDialogParent doesn't achieve anything Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
* convert SFXWB file dialog flags to scoped enumNoel Grandin2016-05-1214-22/+20
| | | | | | | Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Convert MESS_BTN to scoped enumNoel Grandin2016-05-118-21/+18
| | | | Change-Id: I9332216f58268b20b3b8e9488471279d70c519ad
* Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann2016-05-106-7/+7
| | | | | | | | | | | | | | | | ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
* Insert explicit "break" when falling through to empty next caseStephan Bergmann2016-05-101-0/+1
| | | | | | | ...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
* convert WINDOWSTATE_MASK to scoped enumNoel Grandin2016-05-101-1/+1
| | | | Change-Id: Ic8259d81d8080c518aa07697e253a59cd6efaa4b
* fix windows and android buildNoel Grandin2016-05-091-1/+1
| | | | Change-Id: I4644c1e5ac143efc6b1e75d041f71fe7d9156f0c
* convert FONT_EMPHASIS_MARK to scoped enumNoel Grandin2016-05-091-6/+6
| | | | | | | Change-Id: I137c78b337e57d3442db08334128e79d186b278f Reviewed-on: https://gerrit.libreoffice.org/24753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* convert SfxStyleFamily to scoped enumNoel Grandin2016-05-092-2/+2
| | | | | | | | | | and update the RSC compiler to accept such In the process fix some confusion in SD where it was confusing SfxStyleFamily and the index of the relevant family (which other parts of the code in SVL use) Change-Id: I1efc9f85fbed8ab76eafe8f6e1ada411753ae5f9
* tdf#88502 Firefox Theme URL in custom theme searchSusobhan Ghosh2016-05-072-2/+5
| | | | | | | | | | Removed "suggested" from categories label. Fixed URL checking. Change-Id: Ifbea40cf724c91f6af72c485d9ae7eb599afff65 Reviewed-on: https://gerrit.libreoffice.org/24716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* basegfx,oox,slideshow: replace boost::next/prior with std::next/prevMichael Stahl2016-05-061-1/+0
| | | | Change-Id: I38fde54d0fdbb9c61e3df004242a70e14429f52f
* tdf#70998 Termchange: Graphic->ImageSamuel Mehrbrodt2016-05-064-6/+6
| | | | | | | Change-Id: I561a4d81a4fa8d5a6cc5f92b11ed480e833dadcc Reviewed-on: https://gerrit.libreoffice.org/24697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* teach passstuffbyref plugin to check for..Noel Grandin2016-05-061-8/+8
| | | | | | | | | | | | unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* SvxIconSelectorDialog was never destructedMaxim Monastirsky2016-05-051-1/+1
| | | | Change-Id: I6cc9bd70f3e3f4266af0eddfff8be406021a1d66
* loplugin:staticmethodsStephan Bergmann2016-05-042-67/+70
| | | | Change-Id: I679fd93c409035ce87101f7fe150822c2214765e
* tdf#88502 Firefox Theme URL in custom theme searchSusobhan Ghosh2016-05-046-278/+392
| | | | | | | | | | | | Persona Dialog modified. Search supports Firefox Theme URL. Added display of installed theme on personalization dialog. Fixed category buttons. Added SOLID as category. Removed invalid/duplicate results. Change-Id: I603c0c292fe5c3e380553b9a2eaab6f4bc0683e1 Reviewed-on: https://gerrit.libreoffice.org/23385 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
* use Any constructor instead of temporariesNoel Grandin2016-05-041-3/+1
| | | | Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
* While at it, delete Any functions on sal_Bool*Stephan Bergmann2016-05-041-2/+2
| | | | | | | (at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
* Prevent Any ctor from reinterpreting bool* as sal_Bool*Stephan Bergmann2016-05-031-1/+1
| | | | | | | | | | | | | ...which only happens to work in environments where sizeof (bool) == 1. The simpler alternative is to use the Any ctor template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: I0f72c73a088ef96e069c3ed8c78546b16d89b50a
generated by cgit (git 2.34.1) at 2024-06-03 04:46:25 +0000