summaryrefslogtreecommitdiffstats
path: root/cui
Commit message (Collapse)AuthorAgeFilesLines
* Resolves: tdf#132288 don't merge adjacent properties for spell checkingCaolán McNamara2021-04-091-17/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | spell checking relies on each attribute chunk being unmerged with identical adjacent chunks squash includes... nStartPosition and nEndPosition are always the same and tdf#132288 preservation of footnote depends on reverse iteration like TextCharAttribList::FindAttrib does which spell checking used before commit 243b5b392906042ab03800e0b5765e6f3513372c Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jun 14 21:56:44 2019 +0100 weld SpellDialog converted to use an EditEngine instead of a TextEngine in order to be able to host it in a native widget Change-Id: Ia835fa054cad0dee4304f16724b9eb0c29b46102 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92772 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 994526fadb3faeb57c47cf1060a2ad7d53bd4f94)
* tdf#133958 only move the selection to the error if its not already thereCaolán McNamara2021-04-091-2/+11
| | | | | | | | Change-Id: I3046c842cc6c8bcc867c79989a8978d382b08269 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99607 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins (cherry picked from commit 03b462fb609c57cb098069f19b7076c57710906e)
* tdf#126088 Display InternalPaths in UISamuel Mehrbrodt2021-04-092-17/+39
| | | | | | | | | | | | | | Reviewed-on: https://gerrit.libreoffice.org/74952 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit ed7e547e1241cf913e138436fa3d7bca8319ec1d) Conflicts: cui/source/options/optpath.cxx cui/uiconfig/ui/optpathspage.ui Change-Id: Ib729be9ff79a3e43d7ec838646b530be8beff2d8 (cherry picked from commit d2c2ca6832b1ae18597c9c7e4b29effe630ee4cd)
* Resolves: tdf#130658 there isn't a second column in non-exception modeCaolán McNamara2020-02-251-1/+4
| | | | | | | Change-Id: I35edf263251c087976aa9a2506bb23c083e1f7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88693 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
* Resolves: tdf#130548 click is sent to the other member of the groupCaolán McNamara2020-02-111-0/+8
| | | | | | | | | | | when toggling one the other gets a click signal, but its too early and the page size isn't set yet, making the dialog thing the margins won't fit in the page Change-Id: I5b51f2d91c69558d47f43b3f05eca3fd87a24125 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88387 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
* Resolves: tdf#130340 null deref when nothing selectedCaolán McNamara2020-02-071-1/+1
| | | | | | | Change-Id: Ie406006cbcca566ddd32fd86a7e88f0c754dd02e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88049 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
* fix "Use data for document properties" checkbuttonCaolán McNamara2020-02-071-1/+1
| | | | | | | | | | | | | | regression since... commit 3a15c034be9f557f350d0ba1f3a842151066eaae Date: Tue Mar 12 09:59:35 2019 +0000 weld SvxGeneralTabPage Change-Id: I7c4624255f70c3f0c4ccd4b79ebae7750ed2bbe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88110 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
* tdf#127112 repair "sticky" levels in Customize numbering style dialogSeth Chaiklin2020-01-282-5/+27
| | | | | | | Change-Id: Ifa841e7b63b28d6e0f84f5cd6b1800481b36425b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* gallery theme dialog should be modalCaolán McNamara2020-01-181-0/+1
| | | | | | | Change-Id: I3c32851cda40254c73b0040f92466eedb7427d6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87029 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
* Resolves: tdf#127417 delete-all tabs doesn't workCaolán McNamara2020-01-111-1/+1
| | | | | | | | | | | | | | | | | | since... commit 1e2682235cded9a7cd90e55f0bfc60a1285e9a46 Date: Thu Apr 18 19:25:06 2019 +0200 WIP: Further preparations for deeper Item changes because since then aNewTabs is cloned, but on delete-all aNewTabs is reset to a SvxTabStopItem with a 0 WhichId so its clones are useless Change-Id: I725bec90d8915b3546afeed590f21ebdbbdaa355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86580 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Fix SfxPoolItem use-after-freeStephan Bergmann2020-01-081-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...as observed with -fsanitize=address in Draw, after drawing some rectangle (so that there is at least one marked object) doing "Format - Area... - Area - Bitmap": > ERROR: AddressSanitizer: heap-use-after-free on address 0x6030004aca50 at pc 0x7f14d0ef5fe1 bp 0x7ffd966c6cb0 sp 0x7ffd966c6ca8 > READ of size 4 at 0x6030004aca50 thread T0 > #0 in CntUInt32Item::GetValue() const at include/svl/cintitem.hxx:163:42 > #1 in SvxBitmapTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/tpbitmap.cxx:278:124 > #2 in SvxAreaTabPage::CreatePage(int, SfxTabPage*) at cui/source/tabpages/tparea.cxx:448:21 > #3 in SvxAreaTabPage::SelectFillType(weld::ToggleButton&, SfxItemSet const*) at cui/source/tabpages/tparea.cxx:381:9 > #4 in SvxAreaTabPage::SelectFillTypeHdl_Impl(weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:364:5 > #5 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:358:1 > #6 in Link<weld::ToggleButton&, void>::Call(weld::ToggleButton&) const at include/tools/link.hxx:111:45 > #7 in weld::ToggleButton::signal_toggled() at include/vcl/weld.hxx:1130:42 [...] > 0x6030004aca50 is located 16 bytes inside of 24-byte region [0x6030004aca40,0x6030004aca58) > freed by thread T0 here: > #0 in operator delete(void*, unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:172:3 > #1 in SfxUInt32Item::~SfxUInt32Item() at include/svl/intitem.hxx:113:21 > #2 in SfxItemPool::Remove(SfxPoolItem const&) at svl/source/items/itempool.cxx:710:13 > #3 in SfxItemSet::~SfxItemSet() at svl/source/items/itemset.cxx:252:42 > #4 in SvxBitmapTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/tpbitmap.cxx:276:9 > #5 in SvxAreaTabPage::CreatePage(int, SfxTabPage*) at cui/source/tabpages/tparea.cxx:448:21 > #6 in SvxAreaTabPage::SelectFillType(weld::ToggleButton&, SfxItemSet const*) at cui/source/tabpages/tparea.cxx:381:9 > #7 in SvxAreaTabPage::SelectFillTypeHdl_Impl(weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:364:5 > #8 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:358:1 > #9 in Link<weld::ToggleButton&, void>::Call(weld::ToggleButton&) const at include/tools/link.hxx:111:45 This appears to be broken ever since d543d66a4ee34d3b0088f45951b56c150f7206ec "tdf#104615: there's no mpView when opening odc directly". Change-Id: Id0b3991f3e953ca5b10f466daab890383b0428ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86368 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 4d59436258702251a881a007ccc52ffd5a3eeb38) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86424 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
* tdf#129300 If it would create no change, don't force itCaolán McNamara2019-12-121-0/+5
| | | | | | | | | | | | | | | | | | | otherwise a bogus "change" from the parent style is shown in the organizer this dates to... commit 755ad6834625488c5d31d4bacc9370eae7ffd8f3 Date: Tue Oct 5 11:15:56 2010 -0400 Ported calc-distributed-cell-text-*.diff from ooo-build. Change-Id: I49fc654a232d3c0f43f8add9a9f9fee34a6c5add Reviewed-on: https://gerrit.libreoffice.org/84895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/84985 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Resolves: tdf#128923 should be able to change attributes of multiple lines...Caolán McNamara2019-12-091-0/+1
| | | | | | | | | without changing color Change-Id: I76cf21af4611afc11bf1861abe7d0b903362e798 Reviewed-on: https://gerrit.libreoffice.org/84639 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
* tdf#125449 Fix custom gradient fill settings being lostGabor Kelemen2019-11-201-2/+2
| | | | | | | | | | | | Change-Id: Ia2377274e0fc9da5873bf55735af25ed6ae3d65c Reviewed-on: https://gerrit.libreoffice.org/82393 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 53c474633c4e658f096669fb0225d751a5701aaf) Reviewed-on: https://gerrit.libreoffice.org/83186 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 5979fc4a3fa5713b8df49ba624445ce9ed4ccace) Reviewed-on: https://gerrit.libreoffice.org/83287
* Resolves: tdf#128811 Alignment option "Distributed" not working in calcCaolán McNamara2019-11-201-0/+2
| | | | | | | Change-Id: I605b62ef0dfa29db93e4d7df8285a05a12bda8e3 Reviewed-on: https://gerrit.libreoffice.org/83272 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
* Resolves: tdf#128802 manage dnd ourselfCaolán McNamara2019-11-197-9/+61
| | | | | | | | | | | | | instead of relying on the built-in dnd which is allowing toplevel entries to be dropped on other ones to become children of another entry, which is not what we want here. Change-Id: I8c5528d9b26e994b7eda9d2972af0b3783187f3e Reviewed-on: https://gerrit.libreoffice.org/82772 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Revert "Resolves tdf#127317 - Make text of tips of the day selectable"Heiko Tietze2019-11-151-1/+0
| | | | | | | | | | | | | Selectable text makes the GtkLabel unwrap; revert is needed until the control works properly This reverts commit 54a3044ebd7f946235ba1d0a8af11ad94872afb7. Change-Id: I7b63e0e29a22f3feddac99ac42735a1880a9b1c2 Reviewed-on: https://gerrit.libreoffice.org/78864 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 22f3cca81039ac97bee96ba47498fbea1ccc1557) Reviewed-on: https://gerrit.libreoffice.org/82750
* Resolves tdf#127994 - Totd dialog get resized horizontallyHeiko Tietze2019-11-141-0/+1
| | | | | | | | | | | | | Width request set to 350 Change-Id: Ib974417282c76b4cede1b4773159b1fa748ddbfb Reviewed-on: https://gerrit.libreoffice.org/80887 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit dae96d4e629c5eccaacdc763cd390d341c16175d) Reviewed-on: https://gerrit.libreoffice.org/82672 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#128010: Don't ask to enable JRE when populating available scriptsMike Kaganski2019-11-111-2/+11
| | | | | | | | | | | | | | It was user's intention to not use JRE, so omitting the JRE-dependent scripts in dialogs is just consistent with user's configuration. Change-Id: Ic551f5dd1d797fbaa2dc6d7e443e23d46b0ac5d3 Reviewed-on: https://gerrit.libreoffice.org/82353 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit ebccc375248faebdfbca273b149483593c753387) Reviewed-on: https://gerrit.libreoffice.org/82355 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* autocorrect dialog width grows on change of new to replaceCaolán McNamara2019-10-083-9/+11
| | | | | | | | | | | | the sizegroup isn't working as I'd expect, so just make the replace button visible, get the preferred width of the buttonbox, lock that down then hide the place button and the container will stay at the max width that will be wanted Change-Id: Idfe632aa5af404abb92fc8f7267f0dda5cdbe295 Reviewed-on: https://gerrit.libreoffice.org/79863 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* should use DialogController hereCaolán McNamara2019-10-082-6/+3
| | | | | | | Change-Id: Ie0ad42e98d574d15172c6ed3a58714c3f87593cd Reviewed-on: https://gerrit.libreoffice.org/79356 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* set wait on the dialog, not the page parentCaolán McNamara2019-10-081-2/+1
| | | | | | | Change-Id: If782e774fee91a427d4bda575b2f404fd636f534 Reviewed-on: https://gerrit.libreoffice.org/79320 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#83618 Make line spacing values agreeJim Raykowski2019-10-081-2/+4
| | | | | | | | | | Change-Id: I372a673bbad442d28314498248b12ce7f86fce09 Reviewed-on: https://gerrit.libreoffice.org/73737 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 849b837d1a3b185a8dd893a8f6eaed53605bcab1) Reviewed-on: https://gerrit.libreoffice.org/80314 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* return should activate okCaolán McNamara2019-10-051-0/+1
| | | | | | | Change-Id: Id9bfa9badb6b4661d6ad4c0a04323c60c4a3c749 Reviewed-on: https://gerrit.libreoffice.org/79864 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Resolves: tdf#127450 max_content_[width|height] isn't available in gtk 3.18Caolán McNamara2019-10-011-2/+0
| | | | | | | | | so this crashes Change-Id: Ie9b2607e4c4290f9745b8bc5f36b80d8970018b1 Reviewed-on: https://gerrit.libreoffice.org/79876 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
* Fix Typo SvxMenuConfigPage -> SvxConfigPageStephan Bergmann2019-09-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | ...introduced with ccb2b0078f07194befa61f1e3fd88e53ff236871 "weld SvxMenuConfigPage/SvxToolbarConfigPage", causing -fsanitize=dynamic-type- mismatch during UITest_writer_demo: > include/tools/link.hxx:163:10: runtime error: downcast of address 0x613000204b40 which does not point to an object of type 'SvxMenuConfigPage' > 0x613000204b40: note: object is of type 'SvxConfigPage' > 83 01 00 4e b0 a1 bb 2e f6 7f 00 00 20 c4 56 00 e0 60 00 00 50 f8 a4 00 40 60 00 00 e8 49 38 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SvxConfigPage' > #0 in SvxMenuConfigPage* tools::detail::castTo<SvxMenuConfigPage*, SvxConfigPage*>(SvxConfigPage*) at include/tools/link.hxx:163:10 > #1 in SvxConfigPage::SvxConfigPage(weld::Container*, weld::DialogController*, SfxItemSet const&) at cui/source/customize/cfg.cxx:997:41 [...] Change-Id: Ie36ebabd3075cade590cc504fb06b5319b346dcf Reviewed-on: https://gerrit.libreoffice.org/79666 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 2377d937225adb17dc3f76d72937d5cd29d2ef69) Reviewed-on: https://gerrit.libreoffice.org/79746 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#109158 improve sorting when loading large autocorrect fileNoel Grandin2019-09-231-7/+9
| | | | | | | | | | | | | | | | | reduces time from 2.0s to 1.7s reduce work by (*) reserving some arrays (*) pre-sorting with a cheaper comparator (*) don't copy when returning result, just return a const& (*) flattening the data-structures to reduce pointer-chasing Change-Id: I972bd7ffdbf2121c2d38c24aca9618ca708e920c Reviewed-on: https://gerrit.libreoffice.org/79119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/79377
* cui: infinite loop in SentenceEditWindow_Impl::MarkNextError()Michael Stahl2019-09-181-2/+2
| | | | | | | | | | | | | | | | Looks like previously the aCursor never moved backwards so try to ensure the same for nCursor. (regression from 5261417cbb3051b812164838d19c0f748573df45) Change-Id: I7d2f04bbc6d1274ec4feff57927494f2eb5d665c Reviewed-on: https://gerrit.libreoffice.org/79071 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit a370107d86c32c1631b00422e2e35ff4b867ce57) Reviewed-on: https://gerrit.libreoffice.org/79088 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Resolves: tdf#127033 use UI font for spell checking widgetCaolán McNamara2019-09-182-0/+21
| | | | | | | Change-Id: I18e0459bf16ee69860b7dcc8c5ecc75a7805fe13 Reviewed-on: https://gerrit.libreoffice.org/78634 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Resolves: tdf#126935 a11y for hosted EditEngineCaolán McNamara2019-09-172-2/+2
| | | | | | | | | | | move it to svx so we can reuse the a11y code in svx for EditEngines hosted in shapes to provide a11y for EditEngines hosted in a native widget Change-Id: I4068c413cdb8ddb0d0ef899774fbe9f65e1bdc60 Reviewed-on: https://gerrit.libreoffice.org/78545 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* use common WeldEditViewCaolán McNamara2019-09-132-137/+10
| | | | | | | | | | | | | Reviewed-on: https://gerrit.libreoffice.org/74705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2cebba0e4042ca2cab37cf38874c2576c2ac6a6f) Change-Id: I873cb64a167027030c9eeef61344e6f6f885a924 Reviewed-on: https://gerrit.libreoffice.org/78544 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Related: tdf#126935 rearrange spell dialog for expected tab traversalCaolán McNamara2019-09-081-257/+319
| | | | | | | | | so tabbing through goes in visual left to right top to bottom direction Change-Id: I6ad13b7989464af805aa5ed8a080effe04b9b4c0 Reviewed-on: https://gerrit.libreoffice.org/78410 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Resolves tdf#127317 - Make text of tips of the day selectableHeiko Tietze2019-09-061-0/+1
| | | | | | | | | | Change-Id: If0e0b04be8f7086d18fe3481c3bd8f65b48a0676 Reviewed-on: https://gerrit.libreoffice.org/78683 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 54a3044ebd7f946235ba1d0a8af11ad94872afb7) Reviewed-on: https://gerrit.libreoffice.org/78698 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Resolves: tdf#127120 double selection in B&N dialogCaolán McNamara2019-09-042-7/+27
| | | | | | | | | | | | | | | because the list wants to ensure that at least one thing is selected and the multiselect is implemented with two events of deselect-all followed by select. post a user event on getting either deselect or select and process it once when the dust has settled Change-Id: I553bf23d7a8c4625a8706fb2df4b169d91b7ad32 Reviewed-on: https://gerrit.libreoffice.org/78542 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Related: tdf#127029 true was substituted for FALSECaolán McNamara2019-08-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | presumably accidentally by... commit 6ed0bcdd5bc07692fc81406942509eb9c30d3904 Date: Tue Oct 5 07:57:51 2010 -0500 FASTBOOL to bool conversion @@ -1305,7 +1305,7 @@ BOOL SvxCharNamePage::FillItemSet_Impl( SfxItemSet& rSet, LanguageGroup eLangGrp if ( m_pImpl->m_bInSearchMode && bChanged && aInfo.GetWeight() == WEIGHT_NORMAL && aInfo.GetItalic() != ITALIC_NONE ) - bChanged = FALSE; + bChanged = true; } if ( !bChanged && pExampleSet && Change-Id: I711e6dbf26570189f9940958b02ca4e9561bf318 Reviewed-on: https://gerrit.libreoffice.org/77737 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
* Related: tdf#126693 cannot put focus into combobox entryCaolán McNamara2019-08-241-1/+1
| | | | | | | | | | set can-focus=True in internal GtkComboBoxText GtkEntry where the GtkEntry is editable=True Change-Id: I32cc7686c3a3cb9827f05f192227c0ad39669aa5 Reviewed-on: https://gerrit.libreoffice.org/78041 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Resolves tdf#126805 - Alignment of Tip-of-the-day labelHeiko Tietze2019-08-211-0/+1
| | | | | | | | | | | Change-Id: Ic4845dd87325ec952b8b987b69eedd8530b1cf02 Reviewed-on: https://gerrit.libreoffice.org/77703 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 96b5152e0009ff0ea26200d9b6e4bd3e0e8073ed) Reviewed-on: https://gerrit.libreoffice.org/77876 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#126254 Help - About is black with Linux gen and gtk2Caolán McNamara2019-08-192-8/+5
| | | | | | | Change-Id: If18693e1cb8a92a7a152dd9decc892fc5f2b7ab5 Reviewed-on: https://gerrit.libreoffice.org/77592 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* avoid invalid cast from 'GtkImage' to 'GtkLabel'Caolán McNamara2019-08-151-0/+1
| | | | | | | Change-Id: I6fbc991e288b150dcbcfb61018f97fdce69c90cd Reviewed-on: https://gerrit.libreoffice.org/77406 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#126684: store "DialogUseCharAttr" in RES_PARATR_GRABBAGMike Kaganski2019-08-141-1/+1
| | | | | | | | | | | | | | | | | | ... because RES_CHRATR_GRABBAG value may be later reset by initial value read from char format, when it's present there. OTOH, RES_PARATR_GRABBAG shouldn't be present in character format, so it should be safe to pass the grabbag item there. Regression after commit 074fc4a1499aac6eb67cd0b2dca00a51071cff0e. Change-Id: Iebbee04929714d6a3fb72274a211699b2a80b3d2 Reviewed-on: https://gerrit.libreoffice.org/76981 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 30d03b495f437e9b2edbb0f8ceebe3020ba7459c) Reviewed-on: https://gerrit.libreoffice.org/77016 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Resolves: tdf#126736 change range on change of unitCaolán McNamara2019-08-121-3/+12
| | | | | | | | | | | | and make the max % 800 instead of 500 while we're at it (0.15cm is considered 100% FWIW) when flipping from measurement unit to % Change-Id: Ia1b15559f3db0d1e11d4563ad7c6aacc3f9ba32d Reviewed-on: https://gerrit.libreoffice.org/77193 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
* Resolves: tdf#126691 width/height considered changed, but it didn'tCaolán McNamara2019-08-081-0/+2
| | | | | | | | | | | | | | | regression from... commit c4041a3b6c703254ee3977eef1a989992506772b Author: Caolán McNamara <caolanm@redhat.com> Date: Mon May 28 14:33:42 2018 +0100 weld SvxSwPosSizeTabPage Change-Id: Ib8a5359a1aee9ac7b645621b9de9311cd56449f5 Reviewed-on: https://gerrit.libreoffice.org/77122 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
* Resolves: tdf#125483 locale separator label needs to be derived from originalCaolán McNamara2019-08-082-1/+5
| | | | | | | | | | | | | | regression from... commit fa3d5ca1f99fe253689004a45ec2888ebbe85fd3 Date: Thu May 30 12:33:32 2013 +0200 Convert Languages tab page to .ui Change-Id: I940269d14a0a84768c4f8e62c153cfac51cf577f Reviewed-on: https://gerrit.libreoffice.org/77087 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
* should toggle all others to false, not trueCaolán McNamara2019-08-071-1/+1
| | | | | | | | | | | | | | | regression since... commit 5c32ba63163d9556ff89782a8074924cdf9dc554 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Apr 4 14:30:03 2019 +0100 weld OTableSubscriptionPage Change-Id: Iec3bec1b49af3e60b80301665ff3834f24f72222 Reviewed-on: https://gerrit.libreoffice.org/76790 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
* bFirst means 1st vs 2nd column, and needs to alternate on each loopCaolán McNamara2019-08-071-9/+13
| | | | | | | | | | | | | | | | this went wrong at... commit f423ac2d3bdba4263f1f41e31e7e2b7715afdd6e Date: Tue Mar 5 15:16:16 2019 +0200 remove sal_IntPtr in OfaMSFilterTabPage2 and just use a scoped enum Change-Id: I74bcca9ffee9faf4600da64b3c409dbf19a1290e Reviewed-on: https://gerrit.libreoffice.org/76620 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
* tdf#126643: avoid unnecessary asking for JRE in script organizer dialogMike Kaganski2019-08-031-7/+19
| | | | | | | | | | | | | | | Use two-pass search for the needed language node; if it fails with Java interaction disabled, only then repeat the search with it enabled, like in commit f3ce30ec75a4d7116b9cd4d7b21d9aaa0e237eeb. Change-Id: Icde5dbeb552a6837af02182f7b8cbbc90765c5a5 Reviewed-on: https://gerrit.libreoffice.org/76831 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 1a1f4e73b7ab9e5b071aab74c8d7e27ba2b2d29c) Reviewed-on: https://gerrit.libreoffice.org/76878 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Resolves: tdf#126485 remove max limitCaolán McNamara2019-07-291-0/+4
| | | | | | | Change-Id: Ieda7b500c1c08d169bfbfa995b42d3761d2427d7 Reviewed-on: https://gerrit.libreoffice.org/76527 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
* tdf#126070 Show scroll bars when preview overflows.Gülşah Köse2019-07-251-3/+6
| | | | | | | | | | Change-Id: Ibb904fc1c5d283d8ca9d8ff8b2249d25d7091b5b Reviewed-on: https://gerrit.libreoffice.org/75954 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 9a516a4b229f9a52c9c1f05d247cebddb1ba5c17) Reviewed-on: https://gerrit.libreoffice.org/76239 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#125871 - new Tooltip window has empty area selectedHeiko Tietze2019-07-181-0/+2
| | | | | | | | | | | | Ok button focused by default Change-Id: Ibe7653c09dd9f76d6b9feda295b92c90a4b26058 Reviewed-on: https://gerrit.libreoffice.org/75637 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit fdd826eefd0f184fd832582237a8ccdae3572f48) Reviewed-on: https://gerrit.libreoffice.org/75864 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* Fix welded general option pageJan-Marek Glogowski2019-07-152-8/+9
| | | | | | | | | | | | | | * replace the wrong m_xFileDlgFrame with m_xPrintDlgFrame (some search and replace error, I guess) * set filedlgframe's visibility to True, so hiding actually works Change-Id: I5f77f3930096acd885bf8c2fbbf798d6f1b110db Reviewed-on: https://gerrit.libreoffice.org/75574 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 1ab2395355d61e705a251c6eb8bdc870cc20e785) Reviewed-on: https://gerrit.libreoffice.org/75589 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
generated by cgit (git 2.34.1) at 2024-04-27 05:44:23 +0000