summaryrefslogtreecommitdiffstats
path: root/cpputools
Commit message (Collapse)AuthorAgeFilesLines
* Add version resource to executables where it was missingMike Kaganski2019-08-311-0/+2
| | | | | | | Change-Id: Iee965c3f720827b20347f6228e891562c8295d22 Reviewed-on: https://gerrit.libreoffice.org/78327 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin2019-05-131-1/+1
| | | | | | | | | | | By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typoAndrea Gelmini2019-04-201-1/+1
| | | | | | | Change-Id: I1032065e6b4dd14ea9aa426375080da416abb180 Reviewed-on: https://gerrit.libreoffice.org/70993 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Reduce OUString operations and use indexed getTokenMatteo Casalin2018-12-281-9/+15
| | | | | | | Change-Id: I41bc361cbbbf1a446138354eb7bf80729a79bc1f Reviewed-on: https://gerrit.libreoffice.org/65673 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
* clang-tidy readability-misleading-indentationNoel Grandin2018-10-191-1/+1
| | | | | | | Change-Id: I4673fc7c694924b41d048a1918ddb8b0e0af1f79 Reviewed-on: https://gerrit.libreoffice.org/61935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann2018-10-091-2/+2
| | | | | | | | | | | | | | | | ...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* New loplugin:externalStephan Bergmann2018-09-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Add missing sal/log.hxx headersGabor Kelemen2018-07-161-0/+1
| | | | | | | | | | | | | | rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from connectivity to cui Change-Id: I9903c10d0a04bbeb93d0f776d1d252b152459499 Reviewed-on: https://gerrit.libreoffice.org/57408 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* loplugin:includeform: cpputoolsStephan Bergmann2017-10-232-5/+5
| | | | Change-Id: I72982ad64a546421e8b6dd07f42c088c87d1dfcd
* loplugin:flatten check for throw in then clauseNoel Grandin2017-09-291-6/+3
| | | | | | | | | | | also make the plugin ignore the case where we have var decl's in the clause we want to flatten, which could lead to problematic extension of variable lifetime Change-Id: I3061f7104e8c6a460bf74f5eac325a516ec50c59 Reviewed-on: https://gerrit.libreoffice.org/42889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:flatten in connectivity..desktopNoel Grandin2017-09-211-46/+44
| | | | | | | Change-Id: Iff59d3049ba40b4338ef8eec67d08a96b0834d2b Reviewed-on: https://gerrit.libreoffice.org/42578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more OUString::operator== comphelper..cuiNoel Grandin2017-07-131-2/+2
| | | | | | | Change-Id: Ib5f3037249152be2b66acf347d1a0c236dc7adfa Reviewed-on: https://gerrit.libreoffice.org/39888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* spelling instanciate -> instantiateNoel Grandin2017-06-051-1/+1
| | | | | | | Change-Id: Ic1393da64328c0dc7e2860334b204139bf537d81 Reviewed-on: https://gerrit.libreoffice.org/38401 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2017-04-211-1/+0
| | | | | | | | | Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
* Fix typosAndrea Gelmini2017-03-251-1/+1
| | | | | | | Change-Id: I56e429ff1b8ee55ccb8df16002b509770762172c Reviewed-on: https://gerrit.libreoffice.org/35618 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typosAndrea Gelmini2017-03-111-1/+1
| | | | | | | Change-Id: Ic54e808956e5cf4e8079942c0ff799f802cd4b6c Reviewed-on: https://gerrit.libreoffice.org/35053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* new loplugin unoanyNoel Grandin2017-02-281-1/+1
| | | | | | | Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* makeAny->Any in cppuhelper..cuiNoel Grandin2017-02-241-1/+1
| | | | | | | Change-Id: Ia54e6e9b71df68bd04c304a0bb02da8ebac74420 Reviewed-on: https://gerrit.libreoffice.org/34603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:subtlezeroinit: cpputoolsStephan Bergmann2017-02-211-1/+1
| | | | Change-Id: Ib4a04395f067a3a288a57547daa734c4c9768eb8
* Some simplifications, using UNO_QUERY_THROWStephan Bergmann2017-02-151-12/+2
| | | | | | | Change-Id: Icefafed29c9702730181f61bb03296b5b474bfa6 Reviewed-on: https://gerrit.libreoffice.org/34269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Remove dynamic exception specificationsStephan Bergmann2017-01-261-11/+3
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* New loplugin:dynexcspec: Add @throws documentation, cpputoolsStephan Bergmann2017-01-191-0/+4
| | | | Change-Id: I7a9ac7cdc3d5e19dc63a4711a0ce2c23054367e1
* tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar2016-03-111-21/+3
| | | | | | | | | | I replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0 and made sure that it doesn't break the build Change-Id: I9febeed949a24d7bc5afb13dedde03fd812b5b20 Reviewed-on: https://gerrit.libreoffice.org/23077 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
* Remove excess newlinesChris Sherlock2016-02-091-6/+0
| | | | | | | | | | | | | | | | | | | A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-101-4/+4
| | | | Change-Id: I65186f574c8bbc4004eb40a95a33aea1ea3f4e96
* new loplugin: oncevarNoel Grandin2015-11-091-4/+2
| | | | | | | Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann2015-11-061-3/+3
| | | | Change-Id: Iefb181010ad8514227dfe617379eeaccb8d70152
* use uno::Reference::set method instead of assignmentNoel Grandin2015-10-301-1/+1
| | | | Change-Id: I080668f86f0ab8b3bba857ee21411f907ae285c4
* Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-121-2/+2
| | | | Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
* tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe2015-07-171-3/+3
| | | | | | | | | with the variadic variants, in cppcanvas / cpputools / cui. Change-Id: Ic28d0830ab86555494004c27b1468de2ea6825dc Reviewed-on: https://gerrit.libreoffice.org/17119 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:loopvartoosmallNoel Grandin2015-05-291-1/+1
| | | | Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
* Clean up template-parameter-dependent C-style castsStephan Bergmann2015-03-291-1/+1
| | | | Change-Id: Ia1ab134a0afbeeb3ae40264bd4233a47df26b734
* cpputools: Use appropriate OUString functions on string constantsStephan Bergmann2014-12-121-6/+2
| | | | Change-Id: Iea0f7b4ee3ef867a061c159d90efb5d210ae92a4
* markup with event type not checker typeCaolán McNamara2014-11-051-1/+1
| | | | Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
* coverity#982593 experiment with silencing Infinite loopCaolán McNamara2014-10-281-0/+1
| | | | | | etc. Change-Id: I1548d60280ab4f74fe023d026435a05f7865b516
* remove more unnecesary OUString constructor useNoel Grandin2014-05-291-2/+2
| | | | | | when throwing exceptions Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
* remove unnecessary use of OUString constructor when throwingNoel Grandin2014-05-271-2/+2
| | | | Change-Id: I4a3f3f911dcfbf88696053215a2fb7a94678244c
* remove boilerplate in UNO Exception constructor callsNoel Grandin2014-05-231-1/+1
| | | | | | | Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
* add default value for Context param in uno::Exception constructorsNoel Grandin2014-05-231-26/+14
| | | | | | | and all it's subtypes, which is almost never used, so this allows us to simplify lots of call sites. Change-Id: I0b05793ea2bdd1027679f63252d42ce4af89433b
* various: sal_Bool->boolNoel Grandin2014-05-082-21/+21
| | | | Change-Id: I30fa5227f30373f95060148f269450d2945c1bb9
* First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann2014-03-261-2/+2
| | | | | | | ...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
* cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann2014-02-261-4/+4
| | | | Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
* remove unnecessary use of OUString constructor in equalsIgnoreAsciiCaseNoel Grandin2013-11-221-1/+1
| | | | | | | | | Convert code like: sType.equalsIgnoreAsciiCase(OUString("VIEW")); to: sType.equalsIgnoreAsciiCase("VIEW"); Change-Id: I6fb47e6a83b561c7e5a25da76b63606a3174858d
* convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin2013-11-111-6/+6
| | | | | | | | | | Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
* Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin2013-10-311-2/+2
| | | | | | | | | | | | | | | | | | | | | | This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
* remove RTL_CONSTASCII_(U)STRINGPARAMChr. Rossmanith2013-10-231-41/+24
| | | | | Change-Id: I0bce921bfc7102b9a33b1c87eee3ddec0ebaed7b Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, with one little typo fix
* Remove odd "bootstrapping" of acceptor/connector/binaryurp componentsStephan Bergmann2013-10-011-43/+0
| | | | | | | | | | ...that had effectively been in uno.exe since c460c0ccb6f389339b2ff9e57a101557c30df676 "initial import," for whatever reason it was supposed to be good for, but would no longer work anyway at least since 644c33a857c46d540202189228f519946dc33833 "fdo#67313: Use "lo" suffix for private URE libs." Change-Id: I98c038a4d9d963eefc542c91247cf263d7d988bb
* remove OUString wrap for string literalsThomas Arnhold2013-06-291-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For some functions and all kinds of Exceptions. CannotConvertException CloseVetoException DisposedException EmptyUndoStackException ErrorCodeIOException Exception GridInvalidDataException GridInvalidModelException IOException IllegalAccessException IllegalArgumentException IllegalTypeException IndexOutOfBoundsException NoMasterException NoSuchElementException NoSupportException PropertyVetoException RuntimeException SAXException ScannerException StorageWrappedTargetException UnsupportedFlavorException VetoException WrappedTargetException ZipIOException throwGenericSQLException throwIllegallArgumentException createInstance createInstanceWithContext forName getByName getPackageManager getPropertyValue getUnpackedValueOrDefault getValueByName hasPropertyByName openKey setName setPropertyValue supportsService bash command: for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx' | cut -d ':' -f1 | sort -u | xargs sed -i -e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g" -e "s/\($i.*\)\"+ /\1\" + /g"; done Change-Id: Iaf8e641b0abf28c082906014f87a183517630535 Reviewed-on: https://gerrit.libreoffice.org/4624 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
* gbuild: allow to use RepositoryFixes also for executablesMatúš Kukan2013-06-152-21/+0
| | | | | | | Helps to kill package in cpputools. And autoinstall uno executable. Change-Id: Ib1d546371ec8d2b06381d88eff98dbc5b70da400
* fdo#46808, Use service constructor for connection::AcceptorNoel Grandin2013-06-101-5/+2
| | | | Change-Id: I0e69e43b5e6c6907447d6a8c23c0579b88ceb9a3
generated by cgit (git 2.34.1) at 2024-06-05 16:55:08 +0000