summaryrefslogtreecommitdiffstats
path: root/connectivity
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:unusedfieldsNoel Grandin2018-11-082-4/+1
| | | | | | | Change-Id: Id16846c19c57ec437a64146d0fa771c1bfc05135 Reviewed-on: https://gerrit.libreoffice.org/63028 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:collapseif in accessibility..cuiNoel Grandin2018-11-063-26/+19
| | | | | | | Change-Id: I1437b493f3289b4ac97d061bd71973580571e792 Reviewed-on: https://gerrit.libreoffice.org/62933 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typo in codeAndrea Gelmini2018-11-051-2/+2
| | | | | | | Change-Id: If1b7b6c157a250baae054d94a5cdf788651bb7bd Reviewed-on: https://gerrit.libreoffice.org/62906 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
* Fix typosAndrea Gelmini2018-11-051-1/+1
| | | | | | | Change-Id: Id5489f3e8f1d3ced3d57b56f8d3a7a4818af0fca Reviewed-on: https://gerrit.libreoffice.org/62377 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
* replace double-checked locking patterns with thread safe local staticsMike Kaganski2018-11-051-9/+3
| | | | | | | Change-Id: I4ed97cc6d9f733292156d71551d5ce3af6071445 Reviewed-on: https://gerrit.libreoffice.org/62858 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* mysqlc: allow multiple open statementsTamas Bunth2018-11-054-157/+200
| | | | | | | | Change-Id: I07e57ea7d9e6af1c7543483b1ab54a0b8c5be2d5 Reviewed-on: https://gerrit.libreoffice.org/62640 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* coverity#1440839: COPY_PASTE_ERRORJulien Nabet2018-11-041-1/+1
| | | | | | | | | Regression from 39e0bbfdf77cf9653ec68ffcb4374d929838b2a8 Change-Id: Ibb0dea1a78ccf3ef446bbbaad28945f1ac8bdf48 Reviewed-on: https://gerrit.libreoffice.org/62834 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* fix signatures of deleted copy/assign operatorsNoel Grandin2018-11-023-8/+8
| | | | | | | Change-Id: Id1a0749b78a7021be3564487fb974d7084705129 Reviewed-on: https://gerrit.libreoffice.org/62718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* gbuild: rename value OS=IOS to OS=iOSMichael Stahl2018-11-011-1/+1
| | | | | | | | | | | | | | | | This gets rid of the horrible hack in gbuild.mk to accomodate the case-incorrect iOS platform makefiles that cannot be renamed without upsetting git on file systems that sadly lack the case sensitivity feature. Keep the macro defined to IOS though. Change-Id: I1022bfef4900da00e75fc1ccce786b20f8673234 Reviewed-on: https://gerrit.libreoffice.org/62705 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
* mysqlc: filter schema in getColumnsTamas Bunth2018-11-011-4/+12
| | | | | | | | | | | Filter schema in XDatabaseMetaData::getColumns so it would show correct results in case there are more tables with the same name in different schemas. Change-Id: I8a986a43a8b049db3615d7ec2585ce68ebe3340e Reviewed-on: https://gerrit.libreoffice.org/62696 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* Fix build on HaikuKacper Kasper2018-11-011-2/+2
| | | | | | | | Change-Id: I4a21258c2405bd6e5c539ec0206e28a316c6ce13 Reviewed-on: https://gerrit.libreoffice.org/60835 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* mysqlc: Add support for mediumnint and char typesTamas Bunth2018-10-311-2/+2
| | | | | | | | | | | When reading column types from information schema, it can be mediumint and char types as well. Mediumint should be 3 bytes long. We can use sal_Int32 for that. Change-Id: Id3507b1f38cabfb96800fc7743c911e36609a346 Reviewed-on: https://gerrit.libreoffice.org/62697 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* loplugin:oncevarNoel Grandin2018-10-291-4/+2
| | | | | | | Change-Id: Iba892694acb378887a1d15ab59104c55f591f0bd Reviewed-on: https://gerrit.libreoffice.org/62498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#120703 (PVS): V519 The variable is assigned values twice successivelyMike Kaganski2018-10-271-1/+0
| | | | | | | Change-Id: I9265425a215609ef6bf4298ba39c8399f215ce27 Reviewed-on: https://gerrit.libreoffice.org/62406 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#42949 Fix IWYU warnings in include/unotools/*Gabor Kelemen2018-10-264-1/+3
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444c43b9d549977039f25bec2b5bf666c3e15e0e Reviewed-on: https://gerrit.libreoffice.org/62041 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* tdf#120713 correctly handle boolean values in filtersLionel Elie Mamane2018-10-251-0/+5
| | | | | | | | | | | | This commit has two parts: - Hardcode the correct BooleanComparisonMode in the firebird-sdbc driver (this fixes on Firebird databases, among others, the AutoFilter for bools) - Generic to all DBMS, have the "form-based filter" obey the BooleanComparisonMode Change-Id: Ib14e6c3d5cb773ae1f972840f8b53062f0224396 Reviewed-on: https://gerrit.libreoffice.org/62319 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
* loplugin:unusedmethodsNoel Grandin2018-10-252-8/+0
| | | | | | | Change-Id: I1f9ac5f8a090f365d9a21486029e1c13d721a4a4 Reviewed-on: https://gerrit.libreoffice.org/62338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove more rtl::OUString and OString prefixesNoel Grandin2018-10-2438-524/+507
| | | | | | | | | which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Add 5 properties to not pass to JDBC driverJulien Nabet2018-10-241-0/+5
| | | | | | | | | | | | | | | | AppendTableAliasInSelect DisplayVersionColumns GeneratedValues UseIndexDirectionKeyword UseKeywordAsBeforeAlias So we don't get this kind of message: warn:legacy.osl:4402:4415:connectivity/source/drivers/jdbc/tools.cxx:153: OSL_ASSERT: 0 Change-Id: Id74e2a914d76e199c0f18d25d4169401ab500136 Reviewed-on: https://gerrit.libreoffice.org/61740 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* clang-tidy performance-unnecessary-copy-init in canvas..cuiNoel Grandin2018-10-2310-14/+13
| | | | | | | Change-Id: I08c137d852b5f1f817c171ee4f1cee7971417dc4 Reviewed-on: https://gerrit.libreoffice.org/62214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* pvs-studio: V571 Recurring checkCaolán McNamara2018-10-221-8/+5
| | | | | | | | Change-Id: I1ad7bcfa557b38488adf26b434433e6bae259f43 Reviewed-on: https://gerrit.libreoffice.org/62190 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Add unit test for mysqlc connectorTamas Bunth2018-10-224-0/+266
| | | | | | | | | | | | | | | | | | | | | It can be used to test the mysqlc connector whenever there is an external mysql or mariadb server running. The test runs only when CONNECTIVITY_TEST_MYSQL_DRIVER environment variable is set. This variable should contain the URL of the database, including the port number and the host name. The URL should also contain a user name password pair which can be used to connect to the external database. The URL format is the following: [user]/[passwd]@sdbc:mysql:mysqlc:[host]:[port]/[db_name] README is updated and contains detailed information about the test. Change-Id: I1bbc9369ff193a29c06de63a0f6cc975877c8da3 Reviewed-on: https://gerrit.libreoffice.org/62171 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* pvs-studio: Expression 'condition == MQueryExpression::AND' is always true.Caolán McNamara2018-10-211-3/+2
| | | | | | | | Change-Id: Ib3c5a5a09eff26acabf64e4cbc2e7019ca3264e6 Reviewed-on: https://gerrit.libreoffice.org/62098 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* queryComplete is always trueCaolán McNamara2018-10-213-33/+3
| | | | | | | | Change-Id: I455fc328a0b9aa3af3e37e9a9fa86ecba97dc5a4 Reviewed-on: https://gerrit.libreoffice.org/62099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* pvs-studio: Expression '_par0 > 0' is always true.Caolán McNamara2018-10-211-6/+3
| | | | | | | | Change-Id: I61e49c665d84e34748ae9e5974edb7ee2785e044 Reviewed-on: https://gerrit.libreoffice.org/62100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* pvs-studio: Not all members of a class are initialized inside the constructorCaolán McNamara2018-10-211-0/+6
| | | | | | | | Change-Id: I914c715c96a6701995212fdb76615a19c984a128 Reviewed-on: https://gerrit.libreoffice.org/62113 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* copy and paste errorCaolán McNamara2018-10-201-1/+1
| | | | | | | | Change-Id: I30a8fb0568f00253f8d7a55eab51279f639b33cc Reviewed-on: https://gerrit.libreoffice.org/61982 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* clang-tidy readability-delete-null-pointerNoel Grandin2018-10-201-2/+1
| | | | | | | Change-Id: Ib47fc58f1cdfdd54adff07687c56198aa6f2091e Reviewed-on: https://gerrit.libreoffice.org/62029 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy readability-container-size-emptyNoel Grandin2018-10-1910-25/+25
| | | | | | | Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422 Reviewed-on: https://gerrit.libreoffice.org/61967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy readability-misleading-indentationNoel Grandin2018-10-192-3/+3
| | | | | | | Change-Id: I4673fc7c694924b41d048a1918ddb8b0e0af1f79 Reviewed-on: https://gerrit.libreoffice.org/61935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy modernize-redundant-void-argNoel Grandin2018-10-191-1/+1
| | | | | | | Change-Id: Ia25ac2e40f29e5b766a4c5c013fb53274196f656 Reviewed-on: https://gerrit.libreoffice.org/61934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy readability-simplify-boolean-exprNoel Grandin2018-10-183-15/+3
| | | | | | | Change-Id: I78fa01a6c803dec782488490b730af3a11814d64 Reviewed-on: https://gerrit.libreoffice.org/61902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy readability-redundant-smartptr-getNoel Grandin2018-10-178-27/+21
| | | | | | | | | redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:staticvar in avmedia..connectivityNoel Grandin2018-10-173-3/+3
| | | | | | | Change-Id: I5dcac79131c810787e8fa49df75e55cc78147860 Reviewed-on: https://gerrit.libreoffice.org/61834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:singlevalfieldsNoel Grandin2018-10-172-15/+1
| | | | | | | | | tighten up the handling of binary operators Change-Id: I262ec57bf7142fa094d240738150a94d83fd15ee Reviewed-on: https://gerrit.libreoffice.org/61777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typosAndrea Gelmini2018-10-151-1/+1
| | | | | | | Change-Id: Iffa6d87339f7ba338e74b2b9d061dd2815b19408 Reviewed-on: https://gerrit.libreoffice.org/61790 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:simplifyconstructNoel Grandin2018-10-151-1/+1
| | | | Change-Id: Ia74a2493ad780314a832b384ca6326c7fd420631
* fix missing includeNoel Grandin2018-10-151-0/+1
| | | | | | | | after commit b2cefc2e36925b4384eb0aea54aa2c6bcfb018a8 Revert removal of mysql jdbc connector Change-Id: I379cfba0f36b0e55ea135e5c9eb14a2851fb2881
* add SvStream::TellEndNoel Grandin2018-10-152-6/+5
| | | | | | | | | | | and simplify callsites to use it instead of the current "seek to end, find pos, seek back to original pos" pattern Change-Id: Ib5828868f73c341891efc759af8bd4695ae2f33c Reviewed-on: https://gerrit.libreoffice.org/61738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Revert removal of mysql jdbc connectorTamas Bunth2018-10-1414-0/+2176
| | | | | | | | | | And also make some minor fixes so it cooperates with the new mysqlc library. Change-Id: I866add99a699150c6550ee7f7ff2ee947e07117c Reviewed-on: https://gerrit.libreoffice.org/61648 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* Missing include (Windows --disable-pch)Stephan Bergmann2018-10-101-0/+1
| | | | | | | Change-Id: I28632c47b397705ea03592321b8b7c3cc3c0e838 Reviewed-on: https://gerrit.libreoffice.org/61613 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann2018-10-093-5/+5
| | | | | | | | | | | | | | | | ...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* cppcheck: variableScopeJochen Nitschke2018-10-082-3/+2
| | | | | | | Change-Id: I56b06b4c69bdb501535a43780b6a10d5ceb0c7da Reviewed-on: https://gerrit.libreoffice.org/61524 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* tdf#42949 Fix IWYU warnings in include/comphelper/[m-z]*Gabor Kelemen2018-10-0811-0/+12
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I04c5ba277d5b3398c07de6ae66713d977636088d Reviewed-on: https://gerrit.libreoffice.org/61347 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* Fix some drivers xcu (connectivity/registry)Julien Nabet2018-10-034-11/+11
| | | | | | | | | | | | | | | | 1) Revert partly 568778874429595855b435792e5ebecd52956dae UseKeywordAsBeforeAlias should be put to true in Features section (see https://gerrit.libreoffice.org/#/c/61144/) 2) Fix BooleanComparisonMode Use xs:int for Properties part but stay with xs:boolean in Features (see https://gerrit.libreoffice.org/#/c/61144/ again) Change-Id: I4397327ceef408be9ee0563f25fe700c1bfd82d3 TODO: add README in connectivity/registry to provide some info Reviewed-on: https://gerrit.libreoffice.org/61271 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Add README for xcu drivers in connectivity/registryJulien Nabet2018-10-031-0/+24
| | | | | | | | | | | | I used comments from https://bugs.documentfoundation.org/show_bug.cgi?id=119743 + https://gerrit.libreoffice.org/#/c/61144/ Thank you to Lionel and Stephan Change-Id: I956b0c2009e3fa1169ba57a059dde0016375def5 Reviewed-on: https://gerrit.libreoffice.org/61272 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Revert "Fix type for BooleanComparisonMode"Julien Nabet2018-10-014-18/+18
| | | | | | | | | This reverts commit a9a7f32d23eaa24ee9e416e76f5607c84f7a59bd. Change-Id: I9bbdc6f6df493394ccd69f8fb0839db0fc900cd6 Reviewed-on: https://gerrit.libreoffice.org/61206 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Fix type for BooleanComparisonModeJulien Nabet2018-10-014-18/+18
| | | | | | | Change-Id: I73fe0695e3ffb3fd2369d9865b277590665cc4d0 Reviewed-on: https://gerrit.libreoffice.org/61144 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* remove remainders of mysqlc extension filesAndras Timar2018-09-293-66/+0
| | | | | | | Change-Id: I0eaaeef001c70450319e0b3d8774a76ffa163945 Reviewed-on: https://gerrit.libreoffice.org/61122 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
* Fix typoAndrea Gelmini2018-09-291-1/+1
| | | | | | | Change-Id: Ibf1f949d19959413792d1a4689bfecacfd4a8170 Reviewed-on: https://gerrit.libreoffice.org/61097 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-06-13 06:04:52 +0000