summaryrefslogtreecommitdiffstats
path: root/connectivity
Commit message (Collapse)AuthorAgeFilesLines
* Missing includeStephan Bergmann2024-03-021-0/+4
| | | | | | | | | (for std::unique_ptr, with recent libstdc++ 12 trunk) Change-Id: I61b7823dd740ea7cdfe0d7403a50ac73b24d1c4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120229 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* disable script dumpCaolán McNamara2023-02-151-0/+31
| | | | | | | | | Change-Id: I04d740cc0fcf87daa192a0a6af34138278043a19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146986 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147051 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
* ofz#46526 AbrtCaolán McNamara2022-05-161-1/+1
| | | | | | | | | | Change-Id: Iaec536b0989c4ec11b39b1534c7798e46715d7a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132710 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 67851564d74bc8108e4802abfeb4fb88f4adf71d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133928 Tested-by: Michael Stahl <michael.stahl@allotropia.de>
* Adapt to Bison 3.8 internal yyn -> yyrule renameStephan Bergmann2021-12-201-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | see <https://git.savannah.gnu.org/cgit/bison.git/commit/?id=f30067ed51f23802fc91761ede1506dfa72b2865> "glr2.cc: log the execution of deferred actions" including "Rename argument yyn as yyrule for clarity." YYBISON was defined as 1 rather than as a representation of the Bison version prior to <https://git.savannah.gnu.org/cgit/bison.git/commit/?id=21c147b6e5372563b7c4741deadaddb9354f4b09> "yacc.c: provide the Bison version as an integral macro", which shouldn't be a problem here. And YYBISON is apparently completely undefined with /usr/bin/bison on macOS. (The preceding comment always mentioned "yyi" and "yyrmap" in apparent mismatch with the actually used "yyn" and "yyr1" ever since c25ec0608a167bcf1d891043f02273761c351701 "initial import", so just leave it untouched.) Change-Id: I4f901407aa21ed4abec84e661d813ee7599f02f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122082 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 45227d9b79dc4f2a2aa6874cd4e3c02b7934b197) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127124 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
* ofz#39304 short timestamp recordCaolán McNamara2021-11-171-5/+8
| | | | | | | | | | | Change-Id: I8f783473dd5d4679846c7c866cd1853ef7d919fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122628 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit bfc70a9f314bbb5b03247be25544e9b4cc467f8d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125331 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* ofz#39301 month has to be in range [1-12]Caolán McNamara2021-11-171-3/+6
| | | | | | | | | | | Change-Id: I5a4ca534b24098342d8f465a32bc1887f40f5b63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122629 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4a93b7a2f8a3fc13fed800d93e2103b785abeb62) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125330 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#135202: Mysql use openssl libs to be able to use caching_sha2_pwJulien Nabet2020-12-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | Change-Id: I7552b65022b725c6e87fef61478dc6e9c4322559 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105376 (cherry picked from commit 8c9b8c5970a08c2ef0ccddb7a691f3731d39175a) mariadb-connector-c: fix makefile for GNU make 3.82 Old make thinks that ; terminates the recipe, have to escape it. (other changes are just cosmetic) (regression from 8c9b8c5970a08c2ef0ccddb7a691f3731d39175a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105516 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit ed564a411beb13a75a8f06d7cd040acad3e93dcb) Change-Id: Ifd86ef3f17257139a078d23cb5471b9599ab6556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105359 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 482e5f8c2d2979b5d6c3b58194b8e37e7df7480e)
* Merge branch 'libreoffice-6-4'Thorsten Behrens2020-07-024-13/+28
|\ | | | | | | | | | | | | into distro/lhm/libreoffice-6-4+backports Conflicts: writerfilter/qa/cppunittests/dmapper/GraphicImport.cxx
| * connectivity: fix mysql testMichael Stahl2020-06-243-12/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * rename the gbuild target according to conventions * fix -Werror=unused-but-set-variable * disable assert in testMultipleResultsets() that fails presumably since commit 86c86719782243275b65f1f7f2cfdcc0e56c8cd4 * document how to set up mariadb for dummies like me in README Change-Id: I7f92b80fef90b47e69e4e9a7a02187882a4cab06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96537 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 0c07d849a4709f896072cb9c707af17c309c2f7f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96555 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
| * tdf#122461 SQL identifiers (names) can contain newlinesLionel Elie Mamane2020-06-051-1/+3
| | | | | | | | | | | | | | | | | | | | Change-Id: Ic58e6b65e146b2e0d9cb656aa5fa06cfe955d11d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93690 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> (cherry picked from commit b6ab865a371f5c46f96d931721f03afde82b7ec1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93787 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
* | Merge branch 'libreoffice-6-4'Michael Weghorn2020-05-145-2/+18
|\| | | | | | | | | | | into distro/lhm/libreoffice-6-4+backports Change-Id: Iddad99c684fb0a7401ae39f64c54f55808b83d6c
| * tdf#122408 make StatementComposer apply HAVING clauseLionel Elie Mamane2020-05-132-0/+14
| | | | | | | | | | | | | | Change-Id: I381c918e8cac2800367bc586f8c230d46bcd71e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93378 Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
| * tdf#126468: MySQL/MariaDB and Firebird don't require order field in select partJulien Nabet2020-05-112-2/+2
| | | | | | | | | | | | | | | | | | | | Change-Id: I75f050dd6f38fefe83d24a4886610d421f72826e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93937 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 572c9db0440d9aba4945fb1761ec7f83e717c2f0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93801 Tested-by: Jenkins
| * tdf#132814: fix put autovalue to Yes in gui for Mysql/MariaDBJulien Nabet2020-05-111-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See part of bt: https://bugs.documentfoundation.org/show_bug.cgi?id=132814#c3 Like this since at least: https://cgit.freedesktop.org/libreoffice/core/commit/?id=b2cefc2e36925b4384eb0aea54aa2c6bcfb018a8 author Tamas Bunth <tamas.bunth@collabora.co.uk> 2018-10-08 11:04:48 +0200 committer Tamás Bunth <btomi96@gmail.com> 2018-10-14 22:16:05 +0200 commit b2cefc2e36925b4384eb0aea54aa2c6bcfb018a8 (patch) tree f1ab6e9fec3c66f0a3285b3ffffcbae38dc7185d parent ba6723431afa843232fadf44e12ddab44e85c9f0 (diff) Revert removal of mysql jdbc connector And also make some minor fixes so it cooperates with the new mysqlc library. Change-Id: Id328c8378be1555fb5934c738def7fcd62f7a14b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93915 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit f8c62ed408ae9b390d8268b43f4d49c2c6057227) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93794 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
* | Merge branch 'libreoffice-6-4' into distro/lhm/libreoffice-6-4+backportsMichael Weghorn2020-05-071-8/+10
|\| | | | | | | | | | | | | Conflicts: writerfilter/qa/cppunittests/dmapper/GraphicImport.cxx Change-Id: I2e0b84875a10a1255d88d54a3c5857c3e5832521
| * tdf#132385: sql parser: don't drop clauses from window specificationJulien Nabet2020-04-261-8/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bison rule window_specification: '(' window_specification_details ')' { $$ = SQL_NEW_RULE; $$->append(newNode("(", SQLNodeType::Punctuation)); $$->append($2); $$->append(newNode(")", SQLNodeType::Punctuation)); } ; makes it look like rule "window_specification_details" is a single node, but in reality it is a sequence of four nodes: window_specification_details: opt_existing_window_name opt_window_partition_clause opt_order_by_clause opt_window_frame_clause ; The result is that only the "opt_existing_window_name" clause was being put in the parse tree, and the other three were simply discarded. Since that will forever be a trap, and this is the only place where window_specification_details is used, we inline it into window_specification and remove it. Change-Id: I568904355174d2bc36155bde1d4dd09f57759cd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92776 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
* | Merge branch 'libreoffice-6-4'Michael Weghorn2020-04-021-0/+1
|\| | | | | | | | | | | into distro/lhm/libreoffice-6-4+backports Change-Id: I001e9de9df11d4c38ca4378859f78ea1f2b2e9f1
| * tdf#131712: fix crash on table with non null float field (mysql native)Julien Nabet2020-03-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | See bt with infinite loop here: http://bugs.documentfoundation.org/attachment.cgi?id=159161 Change-Id: Iaa4e998c640c414dec60a72d5977f8d6a6a8433f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91379 Tested-by: Jenkins (cherry picked from commit 192ee96db3bc3544c388034b19fa7a9cd6e7537d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91386 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
* | Merge branch 'libreoffice-6-4'Michael Weghorn2020-03-271-6/+6
|\| | | | | | | | | | | into distro/lhm/libreoffice-6-4+backports Change-Id: I586df286d337e2f6d7986e2d9cea8271d9e72f3d
| * tdf#130334: Firebird deal with array fieldsJulien Nabet2020-03-251-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://bugs.documentfoundation.org/show_bug.cgi?id=130334#c11 See https://firebirdsql.org/file/documentation/reference_manuals/fblangref25-en/html/fblangref25-datatypes-bnrytypes.html#fblangref25-datatypes-array Change-Id: I27c53b9c771fcdb3b89e66af325a8234c7de08bb Change-Id: I7b9d27f78e351eda611d13f5a07ef3c80ff00e3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90239 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 2ede753a8b7adecbf6ca78745e43e23c7498e289) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90042 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
* | Merge branch 'libreoffice-6-4' intoMichael Weghorn2020-03-196-17/+27
|\| | | | | | | | | | | distro/lhm/libreoffice-6-4+backports Change-Id: I6ce433221ed737d2783c4518d9884d6a82e04e77
| * tdf#131212: Implement change user password in FirebirdJulien Nabet2020-03-103-6/+16
| | | | | | | | | | | | | | | | | | | | Command retrieved from https://firebirdsql.org/refdocs/langrefupd25-security-sql-user-mgmt.html Change-Id: Idd16c74cd3b00f8a5c9cc135e11ac032811557f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90182
| * tdf#131217: position arg in Blob::getBytes begins at 1 not 0 (Firebird)Julien Nabet2020-03-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See part of bt here: https://bugs.documentfoundation.org/show_bug.cgi?id=131217#c5 According to: https://cgit.freedesktop.org/libreoffice/core/commit/?id=38ce989b4f9d2aead097e5a2e95b819def7e2624 position can't be 0 Change-Id: Ia7bf973b820b8642b45eb0bbc125011cab99de9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90186 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit bb51f81507a405266d251297684bd3ab60998197) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90036 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
| * tdf#131164: Fix crash on Tools>User Administration (Firebird)Julien Nabet2020-03-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | see https://bugs.documentfoundation.org/show_bug.cgi?id=131164#c8 Change-Id: If55a7b015e4e14575c3933a98c70ed4aaf4d7c73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90123 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit dada19a89cbdc5f089fe1200275a1688a1ff1967) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90032 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
| * Postgresql native, fix readLogLevelFromConfigurationJulien Nabet2020-02-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With: osl_getModuleURLFromFunctionAddress( reinterpret_cast<oslGenericFunction>(readLogLevelFromConfiguration), &fileName.pData ); The method retrieves the path to libpostgresql-sdbc-impllo.so, eg: file:///home/julien/lo/libreoffice/instdir/program/libpostgresql-sdbc-impllo.so but then instead of retrieving path + "postgresql-sdbc.ini" we obtained ".so" filename + "postgresql-sdbc.ini"=> libpostgresql-sdbc-impllo.sopostgresql-sdbc.ini Regression from 1bdb2b6f06c556b9af91dba4f29f3ac73190b09e author Noel Grandin <noel@peralex.com> 2013-11-04 13:51:21 +0200 committer Noel Grandin <noel@peralex.com> 2013-11-11 11:21:25 +0200 commit 1bdb2b6f06c556b9af91dba4f29f3ac73190b09e (patch) tree 1d941e17952cd891f5309fd862215dd09a84b001 parent 2f2416ff060c780ad87b4d3979112f52da2ae902 (diff) remove unnecessary use of OUString constructor in CONNECTIVITY module Change-Id: Ie7be4b1078760f94d34dd1f6cb9932bd7fa70962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89303 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit abf44a9ddd084952bde4609e3f6d386f7916b68a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89275 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
| * tdf#130708: Firebird: fix wrong precision and scale for DECIMAL and NUMERICJulien Nabet2020-02-171-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | See https://firebirdsql.org/file/documentation/reference_manuals/fblangref25-en/html/fblangref25-datatypes.html Change-Id: I2377679bb925425ceb0bf80c5309005421fe2c2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88778 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 4605dfa29649864638187940de4d1064ff056ac8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88786 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
* | tdf#117331 Merge jurt and unoil into ridlSamuel Mehrbrodt2020-02-051-2/+0
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | jurt.jar and unoil.jar are kept as effectively empty jars, each with a Class-Path: ridl.jar in their meta-inf/manifest.mf, so that 3rd-party code loading them (with or without also loading ridl.jar) will still have access to their content. Conceptually, the UNOIDL entities in unoil.jar (corresponding to module offapi) are not part of the URE, but are now made available by URE's ridl.jar. This should probably not cause problems in practice. At least for now, we seal exactly those packages in ridl.jar that were originally sealed in jurt.jar. Ideally, all of ridl.jar could be sealed now, but that would be mildly incompatible, as it would prevent 3rd-party code from introducing additional UNOIDL entities in the relevant namespaces (even if that is something we do not want 3rd-party code to do anyway). However, some JunitTest_jurt_* define classes in those sealed packages. In the past they got away with that by using gb_JunitTest_use_jar_classset,*,jurt. Instead they now need to gb_JunitTest_use_jar_classset,*,ridl and drop the gb_JunitTest_use_jar,*,ridl. But the former only makes available the classes that are specified in ridljar/Jar_ridl.mk with gb_Jar_add_sourcefiles, not the UNOIDL entities specified via gb_Jar_add_packagedirs. But the tests need the udkapi UNOIDL entities, so introduce gb_JunitTest_add_classpath to let the tests get them explicitly. (Curiously, JunitTest_jurt_uno and JnitTest_jurt_util use gb_JunitTest_use_jar_classset,*,jurt but don't seem to acutally need it; lets leave that for a follow-up clean up.) As a follow-up clean up, relevant files could be moved from jurt/ to ridljar/. Change-Id: I836f4e7bb47fb41f1306e3f223da90dba988eb9a Co-authored-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit ae855bf48163ff64d94cfc34aff8e37abdb5518d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88005 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* Related tdf#128974: Really deal with "default" and "default-release" profilesJulien Nabet2019-12-181-0/+10
| | | | | | | | | | | | See https://support.mozilla.org/gl/questions/1264072 for some background info. Change-Id: I4939a0c9a8ad09753de4a152f464c647ec637f31 Reviewed-on: https://gerrit.libreoffice.org/84077 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit a3822a44100ddba8b5f1e0cdd469a89244eaf498) Reviewed-on: https://gerrit.libreoffice.org/84085 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
* In the same way as 97ad402d58b52a1f2636905137c21298531c2935Julien Nabet2019-12-021-1/+1
| | | | | | | | | | | | OPreparedStatement::setDate works but let's use good habits. Change-Id: Ic410910ea138cc23d7f33bccd96812efd041732c Reviewed-on: https://gerrit.libreoffice.org/83842 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 4895e01dee323d97d5573a6a2ff4696c3e7bcd25) Reviewed-on: https://gerrit.libreoffice.org/84134 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
* tdf#128698: MySQL/MariaDB direct Connection: time-values not written to tableJulien Nabet2019-11-271-1/+1
| | | | | | | | | | | | | Initialize MYSQL_TIME my_time structure before using it Same idea as part of f4393330b2bbebc7290b72ad2f5b81d26244ac64 but by using modern initialization instead of memset Change-Id: Ife9741604e7bf8f0fbe4671ddb16a56204f4fa43 Reviewed-on: https://gerrit.libreoffice.org/83811 (cherry picked from commit 97ad402d58b52a1f2636905137c21298531c2935) Reviewed-on: https://gerrit.libreoffice.org/83840 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
* Extend loplugin:salbool to loplugin:fakeboolStephan Bergmann2019-11-138-29/+29
| | | | | | | | | | | | | | | | | ...checking for unnecessary uses of more "fake bool" types. In the past, some of the checks involving the types of variables or data members, or the return types of functions, issued warnings that required surrounding code to be changed too (e.g., when changing the signature of a function whose address was taken). These checks have been tightened now to not warn in such cases (which avoids warnings that require changes to additional code, or changes that might even be impossible to make, at the cost of being less aggressive about removing all unnecessary uses of those "fake bool" types). Change-Id: I70eb75039817cda34ed611387ee27dc5f36a3e2e Reviewed-on: https://gerrit.libreoffice.org/82554 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* use std::move when popping stuff off stacksNoel Grandin2019-11-121-3/+3
| | | | | | | Change-Id: I6ba0ee8afee1a9579045643cd0118cf19599d5b9 Reviewed-on: https://gerrit.libreoffice.org/82497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* rename a PCH file to properly match its MakefileLuboš Luňák2019-11-113-2/+2
| | | | | | | Change-Id: I61f317f4cc31d329452a08b6cee5f59975fea007 Reviewed-on: https://gerrit.libreoffice.org/82398 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
* loplugin:stringadd (clang-cl)Stephan Bergmann2019-11-081-2/+1
| | | | | | | Change-Id: Icf2894f77c90aa4620910d621249947bad4be8b7 Reviewed-on: https://gerrit.libreoffice.org/82269 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Base/Firebird fix column creationJulien Nabet2019-11-061-1/+0
| | | | | | | | | | | | Avoid these logs when saving a brand new table in embedded Firebird: warn:legacy.osl:6038:6038:comphelper/source/property/propertycontainerhelper.cxx:181: OPropertyContainerHelper::implPushBackProperty: name already exists! warn:legacy.osl:6038:6038:comphelper/source/property/propertycontainerhelper.cxx:182: OPropertyContainerHelper::implPushBackProperty: handle already exists! ... Change-Id: I305791ad14d0bd18b3a527b848c031e02d661dbb Reviewed-on: https://gerrit.libreoffice.org/81926 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Build mysql_jdbc library even when building without javaTamas Bunth2019-11-041-0/+1
| | | | | | | | | Change-Id: Iecf49ab466a77f8342e69bf245a30e1529fe0078 Reviewed-on: https://gerrit.libreoffice.org/79056 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/81917 Tested-by: Jenkins
* mysqlc: replace initializer list with assignmentTamas Bunth2019-11-031-17/+23
| | | | | | | | | | | | | | | Because visual c++ compiler may not support it without creating a constructor for the struct. Change-Id: I6c8868c4e34cbe7b67e413b1db18aed01378c959 Reviewed-on: https://gerrit.libreoffice.org/65905 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/76727 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/81901 Tested-by: Jenkins
* Fix StringAdd::isCompileTimeConstantStephan Bergmann2019-10-311-2/+2
| | | | | | | | | | | | | | | | | | | | | | | ...to find StringLiteral on the RHS of +=. Which revealed that the VisitCompoundStmt/checkForCompoundAssign logic needed to be fixed, too, so that s += side_effect(); s += "literal"; s += side_effect(); only gets combined to s += side_effect() + "literal"; s += side_effect(); and not all the way to s += side_effect() + "literal" + side_effect(); Change-Id: I432e3458b933a7d0ad6141c747b675cc8b0f0ba4 Reviewed-on: https://gerrit.libreoffice.org/81804 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* size some stringbuffer to prevent re-allocNoel Grandin2019-10-261-5/+5
| | | | | | | | | | I started with 32 and kept doubling the size until the site did not need re-alloc, but clamped it at 512 (e.g. in emfio/). Change-Id: Ib7caf35a1b7e42b0e4ed8aa812493449e3eefc8f Reviewed-on: https://gerrit.libreoffice.org/81540 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:stringadd (macOS)Stephan Bergmann2019-10-211-1/+1
| | | | | | | Change-Id: Ic9c23fcda4c798c1ca2de5a010da292d56b10e8b Reviewed-on: https://gerrit.libreoffice.org/81201 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:bufferadd (macOS)Stephan Bergmann2019-10-211-5/+1
| | | | | | | Change-Id: I97822e6843d6adef1af2435e186ac93d016e5322 Reviewed-on: https://gerrit.libreoffice.org/81202 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* mariadb still uses char for my_boolCaolán McNamara2019-10-191-1/+1
| | | | | | | | | | | | | | mariadb-devel-10.3.17-1.fc30.x86_64 still has typedef char my_bool; Change-Id: I3d1f5423c8750180bc28c56bc0ead4f746fd1c23 Reviewed-on: https://gerrit.libreoffice.org/81137 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* make bin/update_pch.s always include code in trivial #if'sLuboš Luňák2019-10-188-11/+39
| | | | | | | | | | E.g. #ifdef LIBO_INTERNAL_ONLY is always true for code that builds with our PCHs. Change-Id: I3cf311ea3621b909105754cfea2cb0116b8b67f5 Reviewed-on: https://gerrit.libreoffice.org/80961 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
* Fix building against MySQL Connector/C 8Peter Levine2019-10-181-2/+8
| | | | | | | | | | | | | In MySQL Connector/C 8, my_bool is replaced by bool. It was previously defined as char. When building against MySQL Connector/C 8, this leads to type punning build errors. Redefine affected members of struct BindMetaData as bool if using version 8 of greater. Otherwise, default to char. Change-Id: If12b975d95afae86502867cb334cb4195802f91d Reviewed-on: https://gerrit.libreoffice.org/81002 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* loplugin:buffereadd find stuff involving adding *StringBufferNoel Grandin2019-10-171-10/+6
| | | | | | | | | and create conversion methods on *StringBuffer to make this work Change-Id: I3cf5ee3e139826168894b46eff8ee4bcde00cb7e Reviewed-on: https://gerrit.libreoffice.org/80949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove some memset callsMike Kaganski2019-10-177-20/+9
| | | | | | | | | Replace them with default initialization or calloc Change-Id: I747f53c2ced2d0473fd5a5ede4f8520a0633dcc1 Reviewed-on: https://gerrit.libreoffice.org/80805 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Remaining loplugin:bufferaddStephan Bergmann2019-10-177-134/+56
| | | | | | | | | | | | | | | | | | | | | | ...that had been missing because the plugin didn't implement postRun, so it didn't report anything when run as part of the shared plugin. (But did report the expected warnings when run as a standalone plugin during CompilerTest_compilerplugins_clang.) Most fixes are straightforward. A noteworthy one is PreparedStatement::setBytes in connectivity/source/drivers/postgresql/pq_preparedstatement.cxx: The old preallocation of a 20 character OStringBuffer might have prevented buf.append( reinterpret_cast<char *>(escapedString), len -1 ); from potentially throwing std::bad_alloc, which would have caused escapedString to be leaked. Even though that 20-character preallocation was likely just random junk and not meant to address the potential leak, lets address it now. Change-Id: Ib506332d061684a22a74e5e39e591539fd2c4900 Reviewed-on: https://gerrit.libreoffice.org/80925 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Rename OUStringLiteral1 to OUStringCharStephan Bergmann2019-10-173-5/+5
| | | | | | | | | | | | | It started out as a wrapper around character literals, but has by now become a wrapper around arbitrary single characters. Besides updating the documentation, this change is a mechanical for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f Reviewed-on: https://gerrit.libreoffice.org/80892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* new loplugin:bufferaddNoel Grandin2019-10-156-36/+25
| | | | | | | | | | look for OUStringBuffer append sequences that can be turned into creating an OUString with + operations Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6 Reviewed-on: https://gerrit.libreoffice.org/80809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Replace getDefaultValue by getColExprForDefaultSettingVal (postgresql)Julien Nabet2019-10-154-4/+4
| | | | | | | Change-Id: I8e0eea84a711ce45d991c07d7811094e33bcce38 Reviewed-on: https://gerrit.libreoffice.org/80787 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-07-26 20:22:04 +0000