summaryrefslogtreecommitdiffstats
path: root/connectivity/source
Commit message (Collapse)AuthorAgeFilesLines
* remove more rtl::OUString and OString prefixesNoel Grandin2018-10-2438-524/+507
| | | | | | | | | which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Add 5 properties to not pass to JDBC driverJulien Nabet2018-10-241-0/+5
| | | | | | | | | | | | | | | | AppendTableAliasInSelect DisplayVersionColumns GeneratedValues UseIndexDirectionKeyword UseKeywordAsBeforeAlias So we don't get this kind of message: warn:legacy.osl:4402:4415:connectivity/source/drivers/jdbc/tools.cxx:153: OSL_ASSERT: 0 Change-Id: Id74e2a914d76e199c0f18d25d4169401ab500136 Reviewed-on: https://gerrit.libreoffice.org/61740 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* clang-tidy performance-unnecessary-copy-init in canvas..cuiNoel Grandin2018-10-2310-14/+13
| | | | | | | Change-Id: I08c137d852b5f1f817c171ee4f1cee7971417dc4 Reviewed-on: https://gerrit.libreoffice.org/62214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* pvs-studio: V571 Recurring checkCaolán McNamara2018-10-221-8/+5
| | | | | | | | Change-Id: I1ad7bcfa557b38488adf26b434433e6bae259f43 Reviewed-on: https://gerrit.libreoffice.org/62190 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* pvs-studio: Expression 'condition == MQueryExpression::AND' is always true.Caolán McNamara2018-10-211-3/+2
| | | | | | | | Change-Id: Ib3c5a5a09eff26acabf64e4cbc2e7019ca3264e6 Reviewed-on: https://gerrit.libreoffice.org/62098 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* queryComplete is always trueCaolán McNamara2018-10-213-33/+3
| | | | | | | | Change-Id: I455fc328a0b9aa3af3e37e9a9fa86ecba97dc5a4 Reviewed-on: https://gerrit.libreoffice.org/62099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* pvs-studio: Expression '_par0 > 0' is always true.Caolán McNamara2018-10-211-6/+3
| | | | | | | | Change-Id: I61e49c665d84e34748ae9e5974edb7ee2785e044 Reviewed-on: https://gerrit.libreoffice.org/62100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* pvs-studio: Not all members of a class are initialized inside the constructorCaolán McNamara2018-10-211-0/+6
| | | | | | | | Change-Id: I914c715c96a6701995212fdb76615a19c984a128 Reviewed-on: https://gerrit.libreoffice.org/62113 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* copy and paste errorCaolán McNamara2018-10-201-1/+1
| | | | | | | | Change-Id: I30a8fb0568f00253f8d7a55eab51279f639b33cc Reviewed-on: https://gerrit.libreoffice.org/61982 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* clang-tidy readability-delete-null-pointerNoel Grandin2018-10-201-2/+1
| | | | | | | Change-Id: Ib47fc58f1cdfdd54adff07687c56198aa6f2091e Reviewed-on: https://gerrit.libreoffice.org/62029 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy readability-container-size-emptyNoel Grandin2018-10-1910-25/+25
| | | | | | | Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422 Reviewed-on: https://gerrit.libreoffice.org/61967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy readability-misleading-indentationNoel Grandin2018-10-192-3/+3
| | | | | | | Change-Id: I4673fc7c694924b41d048a1918ddb8b0e0af1f79 Reviewed-on: https://gerrit.libreoffice.org/61935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy modernize-redundant-void-argNoel Grandin2018-10-191-1/+1
| | | | | | | Change-Id: Ia25ac2e40f29e5b766a4c5c013fb53274196f656 Reviewed-on: https://gerrit.libreoffice.org/61934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy readability-simplify-boolean-exprNoel Grandin2018-10-183-15/+3
| | | | | | | Change-Id: I78fa01a6c803dec782488490b730af3a11814d64 Reviewed-on: https://gerrit.libreoffice.org/61902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy readability-redundant-smartptr-getNoel Grandin2018-10-178-27/+21
| | | | | | | | | redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:staticvar in avmedia..connectivityNoel Grandin2018-10-173-3/+3
| | | | | | | Change-Id: I5dcac79131c810787e8fa49df75e55cc78147860 Reviewed-on: https://gerrit.libreoffice.org/61834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:singlevalfieldsNoel Grandin2018-10-172-15/+1
| | | | | | | | | tighten up the handling of binary operators Change-Id: I262ec57bf7142fa094d240738150a94d83fd15ee Reviewed-on: https://gerrit.libreoffice.org/61777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typosAndrea Gelmini2018-10-151-1/+1
| | | | | | | Change-Id: Iffa6d87339f7ba338e74b2b9d061dd2815b19408 Reviewed-on: https://gerrit.libreoffice.org/61790 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:simplifyconstructNoel Grandin2018-10-151-1/+1
| | | | Change-Id: Ia74a2493ad780314a832b384ca6326c7fd420631
* fix missing includeNoel Grandin2018-10-151-0/+1
| | | | | | | | after commit b2cefc2e36925b4384eb0aea54aa2c6bcfb018a8 Revert removal of mysql jdbc connector Change-Id: I379cfba0f36b0e55ea135e5c9eb14a2851fb2881
* add SvStream::TellEndNoel Grandin2018-10-152-6/+5
| | | | | | | | | | | and simplify callsites to use it instead of the current "seek to end, find pos, seek back to original pos" pattern Change-Id: Ib5828868f73c341891efc759af8bd4695ae2f33c Reviewed-on: https://gerrit.libreoffice.org/61738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Revert removal of mysql jdbc connectorTamas Bunth2018-10-1410-0/+1857
| | | | | | | | | | And also make some minor fixes so it cooperates with the new mysqlc library. Change-Id: I866add99a699150c6550ee7f7ff2ee947e07117c Reviewed-on: https://gerrit.libreoffice.org/61648 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* Missing include (Windows --disable-pch)Stephan Bergmann2018-10-101-0/+1
| | | | | | | Change-Id: I28632c47b397705ea03592321b8b7c3cc3c0e838 Reviewed-on: https://gerrit.libreoffice.org/61613 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann2018-10-093-5/+5
| | | | | | | | | | | | | | | | ...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* cppcheck: variableScopeJochen Nitschke2018-10-082-3/+2
| | | | | | | Change-Id: I56b06b4c69bdb501535a43780b6a10d5ceb0c7da Reviewed-on: https://gerrit.libreoffice.org/61524 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* tdf#42949 Fix IWYU warnings in include/comphelper/[m-z]*Gabor Kelemen2018-10-0811-0/+12
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I04c5ba277d5b3398c07de6ae66713d977636088d Reviewed-on: https://gerrit.libreoffice.org/61347 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* remove remainders of mysqlc extension filesAndras Timar2018-09-293-66/+0
| | | | | | | Change-Id: I0eaaeef001c70450319e0b3d8774a76ffa163945 Reviewed-on: https://gerrit.libreoffice.org/61122 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
* Fix typoAndrea Gelmini2018-09-291-1/+1
| | | | | | | Change-Id: Ibf1f949d19959413792d1a4689bfecacfd4a8170 Reviewed-on: https://gerrit.libreoffice.org/61097 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* tdf#42949 Fix IWYU warnings in include/comphelper/[a-l]*Gabor Kelemen2018-09-242-0/+2
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I22ba2c8aec235e34cd7835b8a0a716bf3057db7a Reviewed-on: https://gerrit.libreoffice.org/60837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* new loplugin:methodcyclesNoel Grandin2018-09-211-67/+0
| | | | | | | | | | look for closed cycles of methods i.e. unused code that would not otherwise be found by the unusedmethods loplugin Change-Id: I3fb052132d97aabca573bb8e9fc424201b1e2042 Reviewed-on: https://gerrit.libreoffice.org/60875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Replace SAL_OVERRIDE with override in internal codeStephan Bergmann2018-09-208-464/+456
| | | | | | | Change-Id: Ifa446647b11fd1f1b0dc6a991b752480545634db Reviewed-on: https://gerrit.libreoffice.org/60788 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:simplifyconstruct (clang-cl)Stephan Bergmann2018-09-173-5/+1
| | | | | | | Change-Id: I7cae6b3f31b10efc72884bce4bda7bf6b380cbc2 Reviewed-on: https://gerrit.libreoffice.org/60597 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* New loplugin:externalStephan Bergmann2018-09-1718-35/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:simplifyconstruct (macOS)Stephan Bergmann2018-09-143-3/+2
| | | | | | | Change-Id: I460732b2ea9e7366943162bef8f4fced5f975e95 Reviewed-on: https://gerrit.libreoffice.org/60466 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* mysqlc: fix XPreparedStatement::setTimestampTamas Bunth2018-09-131-1/+2
| | | | | | | Change-Id: Ia0d0290517fdebd9a7700d52fa0e86de0e958b2d Reviewed-on: https://gerrit.libreoffice.org/60406 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* mysqlc: prep stmt: check if cursor out of rangeTamas Bunth2018-09-131-0/+3
| | | | | | | Change-Id: I81307c6e45220081c39ddd7d1672457202bbc517 Reviewed-on: https://gerrit.libreoffice.org/60404 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* mysqlc: Fix XResultSet::absolute and previousTamas Bunth2018-09-131-1/+4
| | | | | | | | | | We need to update the actual row position after using absolute or previous. Change-Id: Ie85f9679b7a06649a88ac8ee08436bf7f4a58a22 Reviewed-on: https://gerrit.libreoffice.org/60328 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* tdf#42949 Fix IWYU warnings in include/ucbhelper/*Gabor Kelemen2018-09-132-0/+2
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I7bfeef47abaf94cfb355db95c0fdb928ce36c0a6 Reviewed-on: https://gerrit.libreoffice.org/60232 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* -Werror,-Wunused-macros (clang-cl)Stephan Bergmann2018-09-111-4/+0
| | | | | | | Change-Id: I53b736d8b243f6e9da09856e0729b8702c4167d2 Reviewed-on: https://gerrit.libreoffice.org/60323 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:unusedmethodsNoel Grandin2018-09-119-68/+5
| | | | | | | Change-Id: I34009aabf0befb346470b5c0d96ad8fc476b7c4e Reviewed-on: https://gerrit.libreoffice.org/60300 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constantparamNoel Grandin2018-09-111-4/+2
| | | | | | | Change-Id: Ia11bf93768d5f722b7fe62df15f24809cb7e7f04 Reviewed-on: https://gerrit.libreoffice.org/60280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#42949 Fix IWYU warnings in include/cppuhelper/*Gabor Kelemen2018-09-1018-0/+19
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45 Reviewed-on: https://gerrit.libreoffice.org/59297 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* Fix typosAndrea Gelmini2018-09-081-3/+3
| | | | | | | Change-Id: I75692373028a64ba71899a4fd8c240fa4f2f1c02 Reviewed-on: https://gerrit.libreoffice.org/60172 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
* mysqlc: ensure cursor is not out of rangeTamas Bunth2018-09-072-22/+70
| | | | | | | | | when calling getXXX() methods of a simple result set. Change-Id: I9e018385bb73468ea520b03275232c0982cbcba0 Reviewed-on: https://gerrit.libreoffice.org/60095 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* loplugin:simplifyconstruct in canvas..cuiNoel Grandin2018-09-0631-49/+10
| | | | | | | Change-Id: I02eba1df117a9d0df42bcac13c3251cb4fa6da14 Reviewed-on: https://gerrit.libreoffice.org/60074 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in OResultSetMetaDataNoel Grandin2018-09-061-8/+7
| | | | | | | Change-Id: I74a12381a222fb3b394176db41cb9d6a9091d5a3 Reviewed-on: https://gerrit.libreoffice.org/60052 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* mysqlc: implement beforeFirst and fix findColumnTamas Bunth2018-09-012-4/+3
| | | | | | | Change-Id: I9a12ef6c61b83f588be89ed9aff301d570155d74 Reviewed-on: https://gerrit.libreoffice.org/59880 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* tdf#119615 Ownership of m_aFields is..Tamas Bunth2018-08-314-8/+7
| | | | | | | | | .. on Mariadb side Change-Id: Id65487191c29f7af1a171c06345034d1dc5b20ec Reviewed-on: https://gerrit.libreoffice.org/59856 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* mysqlc: implement getImpotedKeysTamas Bunth2018-08-311-6/+58
| | | | | | | Change-Id: Ic819389000b5b31de69bece6b280cf89f93db948 Reviewed-on: https://gerrit.libreoffice.org/59851 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* Combine mysqlc and connectivity.mysqlc log areasStephan Bergmann2018-08-302-2/+2
| | | | | | | Change-Id: I2d13401dc21548018235bab715d54eb3ae81b51b Reviewed-on: https://gerrit.libreoffice.org/59807 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-31 11:26:21 +0000