| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...the direct-initializations were introduced with
032d5126e41562917b91b8f4826b0be628169968 "cppcheck: fix some uninitMemberVar in
configmgr part," presumably to avoid false positives from static analysis tools.
But the initializations are redundant, as the invariants of the affected classes
imply that the members have meaningful values at their points of use. And the
direct-initializations with arbitrary values make it harder for a maintainer to
understand the relevant invariants, namely to ensure the members must have been
assigned /meaningful/ values by the time they are used. Give a (subtle) clue by
making those into value-initializations.
Change-Id: Iadb25fa08b6d6b12d5bf8a8f04271270b6a7f7cb
|
|
|
|
| |
Change-Id: I5ff293b2e06fe5891487616fcfba510e46acebfd
|
|
|
|
| |
Change-Id: I9b18f033c46e16cf75cc513d00712c40bfddda14
|
|
|
|
|
|
|
| |
Change-Id: Ifab7cef3e883bc10632ac280ca382b2c68bc79e1
Reviewed-on: https://gerrit.libreoffice.org/4317
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...which has become necessary since bd60d41176da540b01d7583cfe00637431967f39
"Handle oveflow in O(U)String::toInt() functions" reduces values in the range
(SAL_MAX_INT32 .. SAL_MAX_UINT32] to zero, but some calls of toInt32(16) relied
on getting a correct (unsigned) value for the whole input range ["0" ..
"FFFFFFFF"] (see libreoffice-4-1 commit 9bf6c83367cedb7be81bf67f30d2147d26c7a8c3
"Revert overflow checks in O[U]String::toInt{32,64} again").
Audited all uses of toInt32/64 with non-decimal radix. (There is still a TODO
comment in oox/source/helper/attributelist.cxx, and
stoc/source/typeconv/convert.cxx will still need some love and test code.)
Change-Id: Iadaca1c0e41dab553687d0ce41c20c10cd657a95
|
|
|
|
| |
Change-Id: I108882af13fa97fa094547ec4efb468f988f337d
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
support for recursive STL containers is not required by the standard.
Boost TR1 containers allow them explicitly though but for some compiler/stl
combinations there are constness issues that prevent the default
assignment operator to work. Adding a small helper function solves
this problem in a clean way.
(cherry picked from commit 58d204292c12eb5237106d223251d8855aca3ca2)
Conflicts:
configmgr/source/partial.hxx
Change-Id: I301765e47db12f3b158d4525e896e090f4b81bbb
|
| |
|
| |
|
|
|
|
| |
Change-Id: Id3f41e2a620c47bb848718d0fc994739be2d64fc
|
|
|
|
|
|
|
|
| |
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
|
|
|
|
|
|
|
|
|
|
|
| |
Moved portions from module i18npool, all of former i18nisolang1 library
that now is i18nlangtag. Included are languagetag, isolang and mslangid.
This i18nlangtag code is now even used by module comphelper, so
disentangling i18npool and making this an own module was needed to not
create circular module dependencies.
Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
|
|
|
|
|
|
|
|
| |
This creates a circular dependency between modules i18npool and
comphelper, but not between libraries. To be resolved by moving
languagetag, isolang and mslangid stuff to a separate module.
Change-Id: I669aa66010800632c5637b42c6136a7ca14e7e68
|
|
|
|
| |
Change-Id: I54958974b01d753dcb2cb797dbb028aa51a7a765
|
|
|
|
| |
Change-Id: I6e5e85e2c81030f9b599e3ade416ba25f7be4e5e
|
|
|
|
| |
Change-Id: I98cac783ff1db94d1d7135dd0db8ee0d809b3457
|
|
|
|
| |
Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49
|
|
|
|
|
|
|
|
|
|
|
| |
Done with a perl regex:
s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms
Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
| |
|
|
|
|
|
|
|
|
|
| |
Only applies to PropertyAttribute::REMOVEABLE, and all instances in comments.
All other instances of the misspelling have remained the same.
Example: AF_REMOVEABLE
Change-Id: I391f4101bbc3e06689318235a37d616065bc1686
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
|
|
| |
Change-Id: Icba4218c5f9fe89d183d25ea82a8eae52881f885
|
|
|
|
| |
Change-Id: Ib6e570a9f409a4700b73da133c57628e9c10eeb1
|
|
|
|
|
|
|
|
|
| |
- do not use gb_UnpackedTarball_copy_header_files for boost
- adapt the optimization in concat-deps.c for new path
- use boost_headers in all LinkTargets that require it
- add explicit include paths to mysqlc, mysqlcppconn, libvisio, liborcus
Change-Id: I0c43e73ed43cc9d2e6bce8faf55e992d655a0bb9
|
|
|
|
|
|
|
| |
Change-Id: I2f11f2f15a652a9edc3c7e5b67c854debeed20de
Reviewed-on: https://gerrit.libreoffice.org/1784
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This dialog is still of some use with some Writer Wizards and templates.
Re-added the dialog, but moved the menu entry to Tools menu in Writer.
The menu entry has not been added back in the other applications.
Conflicts:
sfx2/sdi/appslots.sdi
sfx2/source/appl/appserv.cxx
sfx2/source/doc/docvor.cxx
sfx2/source/doc/docvor.hrc
sfx2/source/doc/docvor.src
Change-Id: I1388d955752e99ab6d39dfc81bb41a97b33bdfcd
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Conflicts:
basctl/uiconfig/basicide/menubar/menubar.xml
extensions/source/bibliography/uiconfig/sbibliography/menubar/menubar.xml
framework/uiconfig/startmodule/menubar/menubar.xml
sc/uiconfig/scalc/menubar/menubar.xml
sd/uiconfig/sdraw/menubar/menubar.xml
sd/uiconfig/simpress/menubar/menubar.xml
sfx2/sdi/appslots.sdi
sfx2/source/appl/appserv.cxx
sfx2/source/doc/docvor.cxx
sfx2/source/doc/docvor.hrc
sfx2/source/doc/docvor.src
svtools/source/dialogs/addresstemplate.cxx
sw/uiconfig/sglobal/menubar/menubar.xml
sw/uiconfig/sweb/menubar/menubar.xml
sw/uiconfig/swform/menubar/menubar.xml
sw/uiconfig/swreport/menubar/menubar.xml
sw/uiconfig/swriter/menubar/menubar.xml
sw/uiconfig/swxform/menubar/menubar.xml
Change-Id: Iaec660c2d8da109bd644f5c88213fdb0c51a9c0f
|
|
|
|
|
|
|
|
|
|
|
| |
- removed rtl:: prefix
- removed RTL_CONSTASCII_USTRINGPARAM
- corrected some misspells
Change-Id: I88bb0beec718a7fe38c61220aa61401419f23b42
Reviewed-on: https://gerrit.libreoffice.org/1291
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes all generated API headers (.hpp and .hdl) to use a
namespace alias 'css' instead of the pointlessly long com::sun::star
Makes the change in cppumaker & associated tools, adds a global
namespace alias definition in sal/types.h, and removes a kiloton
of local, now pointless-to-harmful versions of that alias from all
over the code.
Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
|
|
|
|
|
|
|
| |
...that are effectively ignored if the depended-on file does not exist. This
will be needed by a subsequent commit to make PDF Import optionally installable.
Change-Id: I2283be3ce75f52811a371f41aa8784f507425ee3
|
|
|
|
|
|
|
|
|
|
| |
For some reason that escapes me now, the old code double-expanded URLs in
CONFIGURATION_LAYERS and in extension layer's configmgr.ini SCHEMA/DATA. That
produced wrong results when the pathnames represented by those URLs contain
any "$" characters, as apparently routinely happens on Windows with roaming
profiles.
Change-Id: Iff149e7d8736cbcda579376cdc89e24cf99ccc97
|
|
|
|
| |
Change-Id: I91ded7801f4959f2dac7b5b3e4c8d1f3929f4ed9
|
|
|
|
|
|
|
| |
Always link in gb_STDLIBS, except when the library explicitly opts out
with gb_LinkTarget_disable_standard_system_libs.
Change-Id: I489a99114fbfa46d0421a27cf6c7b899dc268a4a
|
|
|
|
|
|
| |
... new gb_LinkTarget_add_standard_system_libs
Change-Id: Ib2bc843098db3d8c6822b45a3d21724e67f57d69
|
|
|
|
| |
Change-Id: I53316e0b9369d806197bccb42cf22d3497af43e7
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the intent of this header has canged over time. now it is already
systematically included with ustring.hxx and the operator overload it
provide fit nicely there...
Just to be safe, since that include as been added to the api during the
3.5 timeframe and therefore is already in 'production'
the header remain and simply attempt to include ustring.hxx
but a warning is issued indicating that this header should not be used
anymore... in a couple of major release we will thenr emove it completely
All internal users of that header are converted.
Change-Id: I8934c55f089e29d78c0f5649b7c87b2ecf024bad
Reviewed-on: https://gerrit.libreoffice.org/634
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
This is such a fatal error that there is probably no point in trying to handle
it, so allow to simplify client code by removing the requirement to check for a
null return value.
Simplified some client code accordingly (modules configmgr and ure, and the code
generated by cppumaker and javamaker).
Change-Id: I51c0b270ec73409374f7439a47ee061407a46e31
|
|
|
|
|
|
|
| |
Change-Id: I0e6992afbeffaf3b993e6630fb396d93012890e0
Reviewed-on: https://gerrit.libreoffice.org/632
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
|
|
| |
Change-Id: I9f49970e5e06d1afd3fc066a20d1671c93e262fc
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See aebf5bf22304c73e121b16dc0b51f909c5f34c28 "fdo#52232 ConfigurationSet wrapper
unusable for localized properties" for a discussion of the problems with the
original design.
1 Redesigned configmgr's localized property access to understand ['*<locale>']
paths that select the best existing value match for the requested <locale>.
Adapted ConfigurationWrapper::getLocalizedPropertyValue accordingly.
2 Redesigned ConfigurationChanges to fix the locale at instantiation time.
That takes care of ConfigurationWrapper::setLocalizedPropertyValue,
ConfigurationWrapper::getGroupReadWrite, and
ConfigurationWrapper::getSetReadWrite. (This required an additional constructor
parameter for the ReadWriteAccess service, to specify a locale at instantiation
time.)
3 Redesigned ReadOnlyAccess to be a service that fixes the locale at
instantiation time. That allows to take care of
ConfigurationWrapper::getGroupReadOnly and ConfigurationWrapper::getSetReadOnly.
Change-Id: I2ae7342b278b6f4222a0189a1deb2a53e204059f
|
|
|
|
| |
Change-Id: Iffe25051c8357019521196f9a27065d6108ede47
|
|
|
|
| |
Change-Id: I445499755dc92103b3777229f22db0bc6ec1a80e
|
| |
|
| |
|
|
|
|
| |
Change-Id: I1625af99f9b13eaae7b74c65b6306bae6d063627
|
|
|
|
| |
Change-Id: Iee1b78242e210466375376da3e4dbbaec609cc03
|
|
|
|
|
|
|
|
|
|
|
| |
Added zoom submenu to View with the same entries of the zoom status bar
right mouse button menu.
This feature was requested on the design-mailing list:
http://www.mail-archive.com/design@global.libreoffice.org/msg03561.html
Additionally the zoom menu entries were sorted in a more logical way.
Change-Id: I5f2df8aa33be9305841fd5505c95963bee8a0ed0
|
| |
|
|
|
|
| |
Change-Id: Ic00cdfce4172af0a2f0aa1aa33ef5e386d407976
|
|
|
|
|
|
|
|
| |
this removes dmake completely out of the build for migrated modules
build.pl now assumes modules to be gbuild, unless there is a
prj/dmake file
Change-Id: I674a036b182ee13c5ec093e83cb3d38133112d3b
|
|
|
|
|
|
|
|
|
| |
Naming convention for gbuild methods:
- "add" is used for stuff that is logically a part of the target
(i.e. not registered at the Module, but defined in the target's makefile)
- "use" is used for stuff that is logically a different target
(i.e. it is registered at the Module, has it's own makefile, may be
in a different module than the target)
|