summaryrefslogtreecommitdiffstats
path: root/configmgr
Commit message (Collapse)AuthorAgeFilesLines
* Simplify containers iterations in chart2, cli_ure, comphelper, configmgrArkadiy Illarionov2019-03-121-26/+14
| | | | | | | | | Use range-based loop or replace with STL functions Change-Id: I7c229faa96e08b76cb4f182a1bd77c15bac4ba76 Reviewed-on: https://gerrit.libreoffice.org/69010 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* re-land "new loplugin typedefparam""Noel Grandin2019-03-053-3/+3
| | | | | | | | | | This reverts commit c9bb48386bad7d2a40e6958883328145ae439cad, and adds a bunch more fixes. Change-Id: Ib584d302a73125528eba85fa1e722cb6fc41538a Reviewed-on: https://gerrit.libreoffice.org/68680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedfields look for classes where we can make all the..Noel Grandin2019-02-271-1/+1
| | | | | | | | | fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Some uses of C++17 class template argument deductionStephan Bergmann2019-02-194-7/+7
| | | | | | | Change-Id: I47c469c0fcdff41d83729be9489c946e81ef3686 Reviewed-on: https://gerrit.libreoffice.org/68020 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Replace uses of rtl/instance.hxx with plain local static vars in configmgrStephan Bergmann2019-01-161-10/+2
| | | | | | | Change-Id: Iebd72f1cfd2b3af54efaabba04a89d043eef28c8 Reviewed-on: https://gerrit.libreoffice.org/66405 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Replace OUStringBuffer::appendCopy with append(std::u16string_view)Stephan Bergmann2019-01-111-1/+2
| | | | | | | | | ...which is more general Change-Id: I94f28f8eda887120cf5f143b4549e0339b60e6a7 Reviewed-on: https://gerrit.libreoffice.org/66155 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* o3tl::string_view -> std::string_view (in configmgr)Stephan Bergmann2019-01-102-14/+15
| | | | | | | Change-Id: I64131f59ce859a252baa9c84291d262bcb04fffd Reviewed-on: https://gerrit.libreoffice.org/66012 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Use indexed getToken()Matteo Casalin2018-12-281-2/+2
| | | | | | | Change-Id: If5338305e1955c2cad2d9073fdd3f09d6bf55093 Reviewed-on: https://gerrit.libreoffice.org/65666 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
* Fix typoAndrea Gelmini2018-12-281-1/+1
| | | | | | | Change-Id: Iabf8ef0fb5b9fd1d768b705b62db9083cec592c8 Reviewed-on: https://gerrit.libreoffice.org/65653 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Remove obsolete SAL_FALLTHROUGH completelyStephan Bergmann2018-12-088-11/+11
| | | | | | | | | | ...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b "HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now" Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937 Reviewed-on: https://gerrit.libreoffice.org/64800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* improve function-local statics in basic..cuiNoel Grandin2018-11-211-3/+1
| | | | | | | Change-Id: If737e8478f6f1c8fffb060ce132d80e0f07ef8ee Reviewed-on: https://gerrit.libreoffice.org/63701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Simplify and fix Java UNO API test makefilesJan-Marek Glogowski2018-11-091-18/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Originally I just wanted to add the juh.jar to the list of jars of the UNO API tests, but this became tedious work, so after the first few files I decided to replace the similiar makefiles with a common define for the *_unoapi* tests. This patch adds two new make defines to be used used by Java UNO and UNO API tests: - gb_JunitTest_set_unoapi_test_defaults - gb_JunitTest_set_unoapi_test_class_and_jars The first one will deduce most defaults from the test name, but still allows to optionally override most settings. If a test doesn't match the default at all, the 2nd define still shares the common jar files and the main Java UNO class, so the second define adds these to your makefile. The real fix is to add juh.jar to gb_JunitTest_use_jars. Change-Id: I4342fdac5e31f85ea18fb4268e13c287a7adc2b7 Reviewed-on: https://gerrit.libreoffice.org/63118 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
* fix signatures of deleted copy/assign operatorsNoel Grandin2018-11-021-10/+10
| | | | | | | Change-Id: Id1a0749b78a7021be3564487fb974d7084705129 Reviewed-on: https://gerrit.libreoffice.org/62718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove more rtl::OUString and OString prefixesNoel Grandin2018-10-241-1/+1
| | | | | | | | | which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy readability-redundant-smartptr-getNoel Grandin2018-10-171-2/+4
| | | | | | | | | redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy performance-inefficient-vector-operationNoel Grandin2018-09-051-0/+2
| | | | | | | Change-Id: Iebcaea7b08c5284946d83b6b6b9ed26b218025d4 Reviewed-on: https://gerrit.libreoffice.org/59992 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Replace find_if with proper quantifier algorithmsArkadiy Illarionov2018-08-291-3/+2
| | | | | | | Change-Id: Icc820a47ac891c358883f9c01224f676c58fdd11 Reviewed-on: https://gerrit.libreoffice.org/59744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Simplify containers iterations, tdf#96099 follow-upArkadiy Illarionov2018-08-201-3/+3
| | | | | | | | | | | Use range-based loop or replace with std::any_of, std::find and std::find_if where applicable. Change-Id: I2f80788c49d56094c29b102eb96a7a7c079567c6 Reviewed-on: https://gerrit.libreoffice.org/59143 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* create appendCopy method in OUStringBufferNoel Grandin2018-08-141-1/+1
| | | | | | | | | | | | | | | | so we can avoid temporary copies when appending a substring of an OUString to the buffer. I would have preferred to call the method just "append" but that results in ambiguous method errors when the callsite is something like sal_Int32 n; OUStringBuffer s; s.append(n, 10); I'm not sure why Change-Id: I6b5b6641fcb5b26ce2269f89ef06e03c0b6aa76f Reviewed-on: https://gerrit.libreoffice.org/58666 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Add missing sal/log.hxx headersGabor Kelemen2018-07-091-0/+1
| | | | | | | | | | | | | | | | rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from a* to configmgr Change-Id: I6ea1a7f992b1f835f5bac7a725e1135abee3f85a Reviewed-on: https://gerrit.libreoffice.org/57170 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* Improve re-throwing of UNO exceptionsNoel Grandin2018-05-252-6/+13
| | | | | | | | | | | | | | | | | (*) if we are already throwing a Wrapped*Exception, get the exception using cppu::getCaughtexception. (*) when catching and then immediately throwing UNO exceptions, use cppu::getCaughtException to prevent exception slicing (*) if we are going to catch an exception and then immediately throw a RuntimeException, rather throw a WrappedTargetRuntimeException and preserve the original exception information. Change-Id: Ia7a501a50ae0e6f4d05186333c8517fdcb17d558 Reviewed-on: https://gerrit.libreoffice.org/54692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Missing template clone() in configmgr dconf modeStephan Bergmann2018-05-091-0/+1
| | | | | | | | | | | ...that could cause infinite recursion, e.g. when an erroneously modified /org.openoffice.ucb.Hierarchy/Entry template (which recursively has children of the same template type) is later used to instantiate a new set member. Change-Id: I7b9e55fa1c92979aed98b9f23f4432600afffed4 Reviewed-on: https://gerrit.libreoffice.org/54023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Add possibility to read <value xsi:nil="true"/> from winreg conf backendAndras Timar2018-05-091-2/+35
| | | | | | | | | | Change-Id: I67bc14d7ee1bacc15d34e6ee25ca7638de268643 Reviewed-on: https://gerrit.libreoffice.org/53942 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/53943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
* Winreg config layer: Allow to define external backend separatelyMike Kaganski2018-04-251-3/+14
| | | | | | | | | | | Defining backend separately allows e.g. creating ADMX templates with easy-to-use UI, where user defines only LDAP names for the setting, and doesn't need to type the LO configuration backend name. Change-Id: I64f23043c94a5a4e0ba7281d0f711a427d694126 Reviewed-on: https://gerrit.libreoffice.org/53413 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Ignore dangling symlink configuration filesStephan Bergmann2018-04-041-0/+8
| | | | | | | | | | | | | This will be used by the Flatpak build, to offload per-locale data to a Locale extension (which expects all per-locale files to be in one place, so we need to add---potentially dangling, if a given locale is not installed---symlinks from the original places to the location where that Locale extension stores the actual files). Change-Id: Id13b8c53fbc9e0763e53fd09c0c059c9e638c13d Reviewed-on: https://gerrit.libreoffice.org/52381 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Use for-range loops in comphelper and configmgrJulien Nabet2018-02-277-144/+101
| | | | | | | Change-Id: I91033395cb30a4ba9e65adb89712b3c70a39a508 Reviewed-on: https://gerrit.libreoffice.org/50396 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Better return nil than an arbitrary xml:lang="..." valueStephan Bergmann2018-02-081-6/+7
| | | | | | | | | | | | | | | | ...for a localized property that doesn't have a suitable value, but is nillable. E.g., /org.openoffice.Office.Writer/Insert/Caption/CaptionOrderNumberingFirst (once fixed to indeed be a localized property as apparently intended, with a follow-up commit to this) only has an explicit value (true) for xml:lang="hu", but shouldn't return that for any other locale (where the implicit default for a nil value should instead be false, cf. the else branch at the end of SwInsertConfig::Load, sw/source/uibase/config/modcfg.cxx). Change-Id: I7b991c1bc4df22bf2359175b0734e85e0844ce99 Reviewed-on: https://gerrit.libreoffice.org/49409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* configmgr: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski2018-02-011-6/+0
| | | | | | | Change-Id: I7f98fa855ff521db42bf9b379bfac3d430791ae0 Reviewed-on: https://gerrit.libreoffice.org/48968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:passstuffbyref improved returnsNoel Grandin2017-12-234-4/+4
| | | | | | | | | | improve the detection of stuff we can return by const &, instead of by copying Change-Id: I479ae89d0413125a8295cc3cddbc0017ed61ed69 Reviewed-on: https://gerrit.libreoffice.org/46915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* inline use-once typedefsNoel Grandin2017-12-191-3/+1
| | | | | | | Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:salcall fix functionsNoel Grandin2017-12-117-20/+20
| | | | | | | | | | since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Replace lists by vectors in configmgr/unotoolsJulien Nabet2017-11-051-2/+1
| | | | | | | | | + use for range loops Change-Id: I4cebcf0536dc6c3ddfdce9532e94c0c380ea3ab9 Reviewed-on: https://gerrit.libreoffice.org/44308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Winreg configuration layer: don't assert on user inputMike Kaganski2017-11-021-1/+2
| | | | | | | Change-Id: I1314e37315450ead3bf131ed3fabd9351a88a4e5 Reviewed-on: https://gerrit.libreoffice.org/44191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Winreg configuration layer: use writeAttributeValue for oox:externalMike Kaganski2017-11-011-7/+7
| | | | | | | Change-Id: Ib15250c738f98b26adf9745d453a8d22189b271e Reviewed-on: https://gerrit.libreoffice.org/44153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Winreg configuration layer: support oox:external valuesMike Kaganski2017-11-011-10/+43
| | | | | | | Change-Id: Ie03cd4e351de62bf298009e220ed25338dc42f62 Reviewed-on: https://gerrit.libreoffice.org/44148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* typo: xs::boolean -> xs:booleanAndras Timar2017-10-311-1/+1
| | | | Change-Id: I4a7df6bf56a5b8367d3717fc4e48b535e829e96f
* loplugin:constmethod in idl,helpcompilerNoel Grandin2017-10-302-2/+2
| | | | | | | Change-Id: I9b328fc0a3ebdd15a646ee6dab800ffbadb1aaef Reviewed-on: https://gerrit.libreoffice.org/44050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:includeform: configmgrStephan Bergmann2017-10-233-10/+10
| | | | Change-Id: Ie3b0b80409a7897db6700c80d6ff41dbb4845652
* Replace list by vector in components (configmgr)Julien Nabet2017-10-131-6/+6
| | | | | | | Change-Id: I772b9b1b1d8fdbbc1dc7e38904490a6533686a90 Reviewed-on: https://gerrit.libreoffice.org/43353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Rename and move SAL_U/W to o3tl::toU/WMike Kaganski2017-10-051-5/+6
| | | | | | | | | | | | | | | | Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* add << operator for css::uno::ExceptionNoel Grandin2017-10-041-10/+5
| | | | | | | Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* Use SAL_W/SAL_U instead of reinterpret_cast btwn wchar_t* and sal_Unicode*Mike Kaganski2017-09-301-16/+10
| | | | | | | | | | This is type-safe, and allows to catch cases where a source type is changed for some reason, but reinterpret_cast masks that Change-Id: Ib64b6fa2e22d94a6bba890f0ccc3e20325c6f0a1 Reviewed-on: https://gerrit.libreoffice.org/42961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Fresh run of bin/update_pch.shMike Kaganski2017-09-221-2/+5
| | | | | | | Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: https://gerrit.libreoffice.org/42565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:flatten in basctl..configmgrNoel Grandin2017-09-211-16/+13
| | | | | | | Change-Id: I674cad57ce30a885e126d3bcc921f8fcb53dc36d Reviewed-on: https://gerrit.libreoffice.org/42577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more default copy ctorsJochen Nitschke2017-09-174-13/+2
| | | | | | | | | | if ctor should be private or protected explicitly default them. boost::optional has copy ctors, so use them. Change-Id: If1855626b297e739afef0dc5ad57958f7ad199bc Reviewed-on: https://gerrit.libreoffice.org/42363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* New rtl::isUnicodeScalarValue, rtl::isSurrogateStephan Bergmann2017-09-131-2/+2
| | | | | | | | | | | | | | | There are apparently various places that want to check for a Unicode scalar value rather than for a Unicode code point. Changed those uses of rtl::isUnicodeCodePoint where that was obvious. (For changing svtools/source/svrtf/svparser.cxx see 8e0fb74dc01927b60d8b868548ef8fe1d7a80ce3 "Revert 'svtools: HTML import: don't put lone surrogates in OUString'".) Other uses of rtl::isUnicodeCodePoint might also want to use rtl::isUnicodeScalarValue instead. As a side effect, this change also introduces rtl::isSurrogate, which is useful in a few places as well. Change-Id: I9245f4f98b83877145a4d392f0ddb7c5d824a535
* clang-tidy modernize-use-emplace in c*Noel Grandin2017-09-113-34/+25
| | | | | | | Change-Id: I419d1f67ba301050d05981db2a3d6178878684a9 Reviewed-on: https://gerrit.libreoffice.org/42110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparamsStephan Bergmann2017-08-301-1/+1
| | | | Change-Id: I8bc9fd2a3ad727f1a0f4b98254efdae085a2b8cd
* convert std::map::insert to std::map::emplace IINoel Grandin2017-08-114-10/+6
| | | | | | | Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331 Reviewed-on: https://gerrit.libreoffice.org/41019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* error: ‘class configmgr::NodeMap’ has no member named ‘emplace’Caolán McNamara2017-08-111-2/+2
| | | | Change-Id: I434739024afa97d05b5cf6e959973d845fdb2dfe
generated by cgit (git 2.34.1) at 2024-10-27 17:48:01 +0000