summaryrefslogtreecommitdiffstats
path: root/configmgr/source
Commit message (Collapse)AuthorAgeFilesLines
* Remove dynamic exception specificationsStephan Bergmann2017-01-2611-617/+175
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin: unnecessary destructor: comphelper..desktopNoel Grandin2017-01-231-2/+1
| | | | | | | | Change-Id: I9df4cb6a4b1734dac6141d6b0ee7a09e3e05f92e Reviewed-on: https://gerrit.libreoffice.org/33453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Fix typosAndrea Gelmini2016-10-232-2/+2
| | | | | | | | Change-Id: Ib7b17f85c7b6a1937c3f6e1617ceec58074643b4 Reviewed-on: https://gerrit.libreoffice.org/30040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* clang-cl loplugin: configmgrStephan Bergmann2016-10-163-8/+8
| | | | | | | Change-Id: Ia7324ffcd3aa11ac904c926fe82bb636fbb19f70 Reviewed-on: https://gerrit.libreoffice.org/29875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* profilesafe: Multiple adaptionsArmin Le Grand2016-10-121-21/+8
| | | | | | | | | | | | | | Added own directory in User config to where the saved content is written and taken from, adapted to also handle ExtensionConfiguration, changed point for creating backups of configuration to doShutdown, create no configuration when a restart is triggered (untested configuration) Change-Id: Id7a96195b765842c31cacf81cc08d2965a205281 Reviewed-on: https://gerrit.libreoffice.org/29729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
* profilesafe: Add values for SecureUserConfigfeature/profilesafemodeArmin Le Grand2016-10-111-2/+0
| | | | | | | | | | Added default values for SecureUserConfig values to soffice.ini/rc which enable the mechanism, enable by default and set a maximum of three backups file in packed form. Added more handy flag for easy decision to add compressed/uncompressed. Change-Id: I5a624c09fec4e4278314e13fc5f693ac085d5e61
* profilesafe: Collect copies in single *.pack fileArmin Le Grand2016-10-112-13/+65
| | | | | | | | | | | | | | | | | Enhanced helper classes for BackupFileHelper to allow writing a stack of rescued last valid configuration files to a single file package. Added configuration values for enabling this and defining the number of entries, added max entry limitation. Using FileSize and CRC32 now to dectect if config file did change. To make this work I added sorting to writing the configuration so that with no change the same configuration file is written. Use std::vector for better mem performance for sorting, defined static const for buffer size of manipulation, prepare inflate/deflate usages. Fixes to setPos, warnings Change-Id: Ib286e2a3f25b0085a1e3ae4f50c9ff1ff3a5dcf5
* profilesafe: Enhancements to BackupFileHelperArmin Le Grand2016-10-111-10/+33
| | | | | | | | | | Added helper class to allow easy creation/deployment of backups of a file. It works like a 'stack' of backups, supports easy add/remove/delete of last entry (LIFO). Added some work top allow opening dialogs in DeInit under linux. Change-Id: Idacec97ec2f097af9bd22a8a67b410c7677d17f1
* profilesafe: Initial creation of BackupFileHelperArmin Le Grand2016-10-111-0/+17
| | | | | | | | | Added helper class to allow easy creation/deployment of backups of a file (here: registrymodifications). It works like a 'stack' of backups, supports easy push/pop of backed-up versions. Change-Id: Ie19e1209534f23a3dbd6106a5ca13b24b8fefe4d
* loplugin:constantparam in chart2..connectivityNoel Grandin2016-09-143-6/+4
| | | | | | | Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d Reviewed-on: https://gerrit.libreoffice.org/28834 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-1321-23/+23
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* Tell where the colon is missing in the exception messageTor Lillqvist2016-08-051-1/+1
| | | | | | | | But sure, it would be surprising if the message was actually displayed even if the exception is caught and causes some failure somewhere... (See previous commit.) Change-Id: I7375b869d08a465d9720a619d5ef49a77c4782e5
* improve passstuffbyref return analysisNoel Grandin2016-07-276-6/+6
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann2016-07-071-1/+1
| | | | Change-Id: I7bc9219d2e04e68f8b2bd8802f60098669d28e44
* Convert XmlReader::Result to scoped enumNoel Grandin2016-05-251-5/+5
| | | | | | | Change-Id: I6a0d1dcf5ae51d2ac08aacdfec50865f93e51c21 Reviewed-on: https://gerrit.libreoffice.org/25365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Convert XmlReader::Text to scoped enumNoel Grandin2016-05-242-4/+4
| | | | | | | Change-Id: I4741b13fcf887a95b85886cb41f8236e128e81a2 Reviewed-on: https://gerrit.libreoffice.org/25364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* update unusedmethods plugin to deal with constructorsNoel Grandin2016-05-181-2/+1
| | | | | | | | | | and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Silence -Werror,-Wimplicit-fallthrough under NDEBUGStephan Bergmann2016-05-121-6/+5
| | | | Change-Id: I030404b445f310a850e0fee2f7ff06baebc9932a
* Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann2016-05-108-11/+11
| | | | | | | | | | | | | | | | ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
* clang-tidy modernize-loop-convert in c*Noel Grandin2016-04-212-36/+32
| | | | Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
* clang-tidy performance-unnecessary-value-param in variousNoel Grandin2016-04-142-3/+3
| | | | | | | Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:passstuffbyref in variousNoel Grandin2016-04-142-2/+2
| | | | Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
* cleanup: remove unused com/sun/star/uno includesJochen Nitschke2016-04-123-4/+0
| | | | | | | | | | | | Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* cleanup: remove unused Reference.h(xx) includesJochen Nitschke2016-04-025-5/+0
| | | | | | | | | and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* Missing includeStephan Bergmann2016-03-311-1/+2
| | | | Change-Id: I0babe806f04aa41110e87f9fd6b6febf892cd66d
* tdf#96099 fix trival typedefs, Path to std::vector<OUString>Jakub Trzebiatowski2016-03-1519-101/+50
| | | | | | | Change-Id: I23fca48becbfdfd92db02a11b739a668fc1cd8c4 Reviewed-on: https://gerrit.libreoffice.org/23007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Let's use the iterator return by erase method (part b)Julien Nabet2016-03-121-1/+1
| | | | | | | | | std::list seems ok but let's try for std::set and std::multiset Change-Id: I1d4875468517c732680ba98ac9f2e08d1baa61bd Reviewed-on: https://gerrit.libreoffice.org/23161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* use consistent #define checks for the Windows platformNoel Grandin2016-02-173-4/+4
| | | | | | | | | | | | stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Remove excess newlinesChris Sherlock2016-02-094-4/+0
| | | | | | | | | | | | | | | | | | | A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* Fix typosAndrea Gelmini2016-01-073-3/+3
| | | | | | | Change-Id: I90b04b8eda6fc3d530c9db72052720cbe9de0343 Reviewed-on: https://gerrit.libreoffice.org/21197 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* cppcheck:useInitializationListNoel Grandin2015-11-225-14/+14
| | | | | | | Change-Id: I744ff3e268fbffca9499121f3567640934aaae51 Reviewed-on: https://gerrit.libreoffice.org/20110 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-1016-109/+109
| | | | Change-Id: I520c7e35d539ba804da17185353317eca504a582
* new loplugin: oncevarNoel Grandin2015-11-096-12/+6
| | | | | | | Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Replace a local functor in configmgr by a lambda.Mario J. Rugiero2015-11-091-21/+2
| | | | | | | Change-Id: Ida4317ec6b96ab8cb3362243b4acace3680bcd31 Reviewed-on: https://gerrit.libreoffice.org/19846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#94269: Replace "n" prefix for bool variables with "b"Benjamin Ni2015-11-023-10/+10
| | | | | Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797 Signed-off-by: Michael Stahl <mstahl@redhat.com>
* use uno::Reference::set method instead of assignmentNoel Grandin2015-10-302-3/+2
| | | | Change-Id: I080668f86f0ab8b3bba857ee21411f907ae285c4
* Get this remove/re-add dance finally sorted out for goodStephan Bergmann2015-10-301-1/+6
| | | | Change-Id: I16cb3fdd699dcd45de25b49d30e0d1b6392fd82b
* loplugin:unusedmethodsNoel Grandin2015-10-301-2/+0
| | | | | | | Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f Reviewed-on: https://gerrit.libreoffice.org/19636 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* configmgr/dconf: Simplify Fleet Commander write-back modeStephan Bergmann2015-10-213-14/+31
| | | | | | | | | | | | | * Get rid of different dconf trees for reading and writing again; the one single tree is /org/libreoffice/registry/. * Trigger the special write-back mode when a file $SYSUSERCONFIG/libreoffice/dconfwrite is present; then, ignore the default user:!... entry in CONFIGURATION_LAYERS (i.e., don't use the UserInstallation's registrymodifications.xcu) and instead write changes back to the dconf tree. Change-Id: I6b4d7251851da3fe7abbc9dcb080d57b278de96b
* Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-1218-211/+211
| | | | Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
* Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-1214-31/+31
| | | | Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
* Revert function removal that breaks --enable-dconfStephan Bergmann2015-10-011-0/+2
| | | | | | ...from 58aea3f36c14414f95668e229a7350598f6c53a8 "loplugin:unusedmethods" Change-Id: I2b218ca01589f3d2efd583aa4e5fb21d19d6319e
* loplugin:unusedmethodsNoel Grandin2015-10-012-3/+1
| | | | | | | | | | | | - improvements to the plugin to find more method calls - improvements to python script to remove more false+ - fix the FORCE_COMPILE_ALL build flag to include code in the $WORKDIR Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836 Reviewed-on: https://gerrit.libreoffice.org/19064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Avoid false -Werror=maybe-uninitializedStephan Bergmann2015-09-291-1/+1
| | | | Change-Id: I5493c49eb97c630e91cdc8368ad8b017557f1fa1
* Report nil-valued localized property as suchStephan Bergmann2015-09-231-2/+1
| | | | | | | ...regression introduced with 879aa54e895a56cb65f93ae98e6a9e7b08981a47 "configmgr: accelerate simple config key fetches." Change-Id: Ifb732a25d902f58c76e06ebaad3a6178ff102f58
* cppcheck: noExplicitCopyMoveConstructorCaolán McNamara2015-09-071-1/+1
| | | | Change-Id: I8718ddd144bec48541e6412a8c9feb74d9391ecc
* Restored missing includes from source files.Ashod Nakashian2015-09-031-0/+1
| | | | | | | | | | | | | | | | | These source files relied on pch to include these missing headers (at least on Windows). Also included the script used to find the missing includes. The script is self-contained and includes unittests. It detects superfluous includes and required includes (which was used to restore the includes in this patch). Change-Id: I7ee09e5c712f42d5f6c3524898bc62dda78f5cc0 Reviewed-on: https://gerrit.libreoffice.org/18208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Fix documentationStephan Bergmann2015-09-021-1/+2
| | | | Change-Id: I8fc081d3f445a362f5e1ee735ce8baeab1d6cc9b
* configmgr: Split dconf in two /org/libreoffice/registry/{system,user}/Stephan Bergmann2015-09-023-6/+11
| | | | | | | | | | | | | | | ...so that the lower-layer "dconf:*" reads from the .../system/ dconf tree while the final-layer "dconf:!" reads from and writes to the .../user/ dconf tree. Using a single tree would not really work: For one, a sysadmin will want to finalize a property so it cannot be changed by extensions; that means that property must be set and finalized in the lower-layer "dconf:*". But for another, a user will want to change a property for which an extension provides a value; that means that property must be set in the final-layer "dconf:!". So the two "dconf:*" and "dconf:!" must store their respective data in different places. Change-Id: I9029e7f779bcb86e8f26cfc22401e97e0cb3362b
* configmgr: support writing back to dconf (WIP)Stephan Bergmann2015-09-014-3/+594
| | | | | | | Needs to be enabled manually for now by changing CONFIGURATION_LAYERS's tail from " user:..." to " user:*... dconf:!". Change-Id: I31cd806f21d2ded376832faf98f49167b7243d1c