summaryrefslogtreecommitdiffstats
path: root/configmgr/source/access.cxx
Commit message (Collapse)AuthorAgeFilesLines
* Some uses of C++17 class template argument deductionStephan Bergmann2019-02-191-3/+3
| | | | | | | Change-Id: I47c469c0fcdff41d83729be9489c946e81ef3686 Reviewed-on: https://gerrit.libreoffice.org/68020 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix typoAndrea Gelmini2018-12-281-1/+1
| | | | | | | Change-Id: Iabf8ef0fb5b9fd1d768b705b62db9083cec592c8 Reviewed-on: https://gerrit.libreoffice.org/65653 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Remove obsolete SAL_FALLTHROUGH completelyStephan Bergmann2018-12-081-1/+1
| | | | | | | | | | ...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b "HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now" Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937 Reviewed-on: https://gerrit.libreoffice.org/64800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* clang-tidy performance-inefficient-vector-operationNoel Grandin2018-09-051-0/+2
| | | | | | | Change-Id: Iebcaea7b08c5284946d83b6b6b9ed26b218025d4 Reviewed-on: https://gerrit.libreoffice.org/59992 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Use for-range loops in comphelper and configmgrJulien Nabet2018-02-271-94/+54
| | | | | | | Change-Id: I91033395cb30a4ba9e65adb89712b3c70a39a508 Reviewed-on: https://gerrit.libreoffice.org/50396 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Better return nil than an arbitrary xml:lang="..." valueStephan Bergmann2018-02-081-6/+7
| | | | | | | | | | | | | | | | ...for a localized property that doesn't have a suitable value, but is nillable. E.g., /org.openoffice.Office.Writer/Insert/Caption/CaptionOrderNumberingFirst (once fixed to indeed be a localized property as apparently intended, with a follow-up commit to this) only has an explicit value (true) for xml:lang="hu", but shouldn't return that for any other locale (where the implicit default for a nil value should instead be false, cf. the else branch at the end of SwInsertConfig::Load, sw/source/uibase/config/modcfg.cxx). Change-Id: I7b991c1bc4df22bf2359175b0734e85e0844ce99 Reviewed-on: https://gerrit.libreoffice.org/49409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* New rtl::isUnicodeScalarValue, rtl::isSurrogateStephan Bergmann2017-09-131-2/+2
| | | | | | | | | | | | | | | There are apparently various places that want to check for a Unicode scalar value rather than for a Unicode code point. Changed those uses of rtl::isUnicodeCodePoint where that was obvious. (For changing svtools/source/svrtf/svparser.cxx see 8e0fb74dc01927b60d8b868548ef8fe1d7a80ce3 "Revert 'svtools: HTML import: don't put lone surrogates in OUString'".) Other uses of rtl::isUnicodeCodePoint might also want to use rtl::isUnicodeScalarValue instead. As a side effect, this change also introduces rtl::isSurrogate, which is useful in a few places as well. Change-Id: I9245f4f98b83877145a4d392f0ddb7c5d824a535
* clang-tidy modernize-use-emplace in c*Noel Grandin2017-09-111-21/+17
| | | | | | | Change-Id: I419d1f67ba301050d05981db2a3d6178878684a9 Reviewed-on: https://gerrit.libreoffice.org/42110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert std::map::insert to std::map::emplace IINoel Grandin2017-08-111-3/+2
| | | | | | | Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331 Reviewed-on: https://gerrit.libreoffice.org/41019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* makeAny->Any in canvas..configmgrNoel Grandin2017-02-031-14/+14
| | | | | | | Change-Id: Id06812595f373cd0da8b421dbac34a60a266ae6e Reviewed-on: https://gerrit.libreoffice.org/33869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove dynamic exception specificationsStephan Bergmann2017-01-261-92/+8
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:constantparam in chart2..connectivityNoel Grandin2016-09-141-1/+1
| | | | | | | Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d Reviewed-on: https://gerrit.libreoffice.org/28834 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Silence -Werror,-Wimplicit-fallthrough under NDEBUGStephan Bergmann2016-05-121-6/+5
| | | | Change-Id: I030404b445f310a850e0fee2f7ff06baebc9932a
* Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann2016-05-101-1/+1
| | | | | | | | | | | | | | | | ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
* clang-tidy modernize-loop-convert in c*Noel Grandin2016-04-211-31/+29
| | | | Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
* tdf#96099 fix trival typedefs, Path to std::vector<OUString>Jakub Trzebiatowski2016-03-151-6/+5
| | | | | | | Change-Id: I23fca48becbfdfd92db02a11b739a668fc1cd8c4 Reviewed-on: https://gerrit.libreoffice.org/23007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Fix typosAndrea Gelmini2016-01-071-1/+1
| | | | | | | Change-Id: I90b04b8eda6fc3d530c9db72052720cbe9de0343 Reviewed-on: https://gerrit.libreoffice.org/21197 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* cppcheck:useInitializationListNoel Grandin2015-11-221-2/+1
| | | | | | | Change-Id: I744ff3e268fbffca9499121f3567640934aaae51 Reviewed-on: https://gerrit.libreoffice.org/20110 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-101-16/+16
| | | | Change-Id: I520c7e35d539ba804da17185353317eca504a582
* tdf#92639: Slashes are allowed in set member names, of courseStephan Bergmann2015-07-131-6/+6
| | | | Change-Id: I30944fe9611e83566c891a7d1461ad02979daddd
* Validate names of elements added via the APIStephan Bergmann2015-07-071-0/+37
| | | | Change-Id: I052f8ca6a8788665acb1bf87456f7cc67d64c365
* Various #include <sal/log.hxx> fixupsStephan Bergmann2015-04-221-0/+1
| | | | | | | | | | | | | | rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
* Add support for cppu::UnoType<void>Stephan Bergmann2015-04-011-2/+2
| | | | Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
* fdo#75757: Remove inheritance from std::vectorMatthew Pottage2015-02-061-11/+11
| | | | | | | | | | | | | | | | | | | Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
* configmgr: accelerate getPropertyValue.Michael Meeks2014-06-281-4/+4
| | | | Change-Id: Ie0460c8db6b1e7fcc9bab1f5e9ae1fbd00987994
* configmgr: accelerate simple config key fetches.Michael Meeks2014-06-281-13/+54
| | | | | | | | Avoid heap allocating UNO object wrappers for the underlying Node structures only to convert to Any and immediately free them agian when we can. Change-Id: Iae4612e9602f872f5d8cca2e516df594c9f1118c
* improve the inlinesimplememberfunctions clang pluginNoel Grandin2014-06-171-3/+0
| | | | Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
* loplugin: inlinesimplememberfunctionsNoel Grandin2014-06-091-3/+0
| | | | Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
* fix-includes.pl: configmgrThomas Arnhold2014-05-281-60/+60
| | | | Change-Id: Ica1dc0c8003203ba0ea65a668ea3d86f341ad05d
* cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann2014-02-261-52/+52
| | | | Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
* coverity#707680 Uninitialized scalar fieldCaolán McNamara2014-01-271-1/+3
| | | | Change-Id: I763dc95a393bf296a7f3f5ce2a739f175fd528fb
* Replace "known-good" dynamic_casts with static_castsStephan Bergmann2014-01-241-14/+14
| | | | | | | | | | ...it avoids false warnings about unchecked dynamic_cast results from static code analyzers, and potentially makes the code a little faster, too. (Most of these dynamic_casts were kind of a leftover from a very early design that dispateched on Node type via dynamic_cast instead of a Node::Kind, but which was much too slow.) Change-Id: I8db08a1c35783f8ea6c51eed55b11faa2d958807
* simplify - use OUString::startsWith where possibleNoel Grandin2013-12-121-1/+1
| | | | | | | | | Convert code like if( !aStr.isEmpty() && aStr[0] == 'x' ) to if( aStr.startsWith("x") ) Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
* Do not create paths starting "//" when root is just "/"Stephan Bergmann2013-12-061-3/+4
| | | | Change-Id: If0b413a4fdd93465074548c7ea5451288c1d12aa
* remove unnecessary sal_Unicode casts in various placesNoel Grandin2013-11-141-5/+5
| | | | Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
* The getSupportedServiceNames implementations will already take careStephan Bergmann2013-10-171-4/+1
| | | | Change-Id: I0c7ae8e0393f069259b943e04368e874abdf8386
* fdo#54938: Adapt svtools and comphelper module ...Marcos Paulo de Souza2013-10-171-7/+2
| | | | | | | to use cppu::supportsService and other pieces. Change-Id: I16893b3d31a8055acd214ff23d01e63d38fe0826 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* Allow starts-/endsWith* to also return the rest of the matched stringStephan Bergmann2013-10-151-4/+6
| | | | | | | | | | | | | | ...as there are many cases where the code later wants to obtain this part, and esp. for the string literal variants it is awkward to calculate the length of the literal again if this is coded with a following copy() call. Adapt some code to use this new feature. (Strictly speaking, the @since tags for the---backwards-compatibly---modified functions are no longer accurate of course. Also, clean up some sal_Bool and SAL_THROWS(()) that are unnecesssary cargo-cult here, and where the clean-up should have no practical compatibility consequences.) Change-Id: I43e5c578c8c4b44cb47fd08f170b5c69322ad641
* fdo#69028 Set PropertyAttribute::READONLY for finalized configmgr propsStephan Bergmann2013-09-251-3/+4
| | | | | | ...thanks to Andras for pointing me to the problem Change-Id: I98786e8fe3159426b7e4c8b5345be500be2fc87b
* Clean up redundant explicit OUString(...) ctorsStephan Bergmann2013-07-231-81/+52
| | | | Change-Id: Ieb5d4a1d669e0472ec08704c618a9d9c1d30b77f
* fdo#43460 configmgr: use isEmpty()Jelle van der Waa2013-06-171-5/+5
| | | | | | | Change-Id: Ifab7cef3e883bc10632ac280ca382b2c68bc79e1 Reviewed-on: https://gerrit.libreoffice.org/4317 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
* automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStringsThomas Arnhold2013-03-191-1/+1
| | | | | | | | | | | Done with a perl regex: s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec Reviewed-on: https://gerrit.libreoffice.org/2832 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
* fdo#60724 change spelling error REMOVEABLE -> REMOVABLEKenneth Beck2013-03-061-1/+1
| | | | | | | | | Only applies to PropertyAttribute::REMOVEABLE, and all instances in comments. All other instances of the misspelling have remained the same. Example: AF_REMOVEABLE Change-Id: I391f4101bbc3e06689318235a37d616065bc1686 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* rtl:: prefix removal from configmgrRadu Ioan2012-12-111-180/+115
| | | | | | | | | | | - removed rtl:: prefix - removed RTL_CONSTASCII_USTRINGPARAM - corrected some misspells Change-Id: I88bb0beec718a7fe38c61220aa61401419f23b42 Reviewed-on: https://gerrit.libreoffice.org/1291 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
* c++ API: use css alias in generated headers, adds global css declThorsten Behrens2012-11-301-6/+0
| | | | | | | | | | | | This changes all generated API headers (.hpp and .hdl) to use a namespace alias 'css' instead of the pointlessly long com::sun::star Makes the change in cppumaker & associated tools, adds a global namespace alias definition in sal/types.h, and removes a kiloton of local, now pointless-to-harmful versions of that alias from all over the code. Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
* migrate some of the biggest consumer of osl_*InterlockedCount to osl_atomicNorbert Thiebaud2012-09-171-2/+2
| | | | | | | Change-Id: I0e6992afbeffaf3b993e6630fb396d93012890e0 Reviewed-on: https://gerrit.libreoffice.org/632 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
* Make comphelper/configuration.hxx work for localized propertiesStephan Bergmann2012-07-251-0/+75
| | | | | | | | | | | | | | | | | | | | | | | See aebf5bf22304c73e121b16dc0b51f909c5f34c28 "fdo#52232 ConfigurationSet wrapper unusable for localized properties" for a discussion of the problems with the original design. 1 Redesigned configmgr's localized property access to understand ['*<locale>'] paths that select the best existing value match for the requested <locale>. Adapted ConfigurationWrapper::getLocalizedPropertyValue accordingly. 2 Redesigned ConfigurationChanges to fix the locale at instantiation time. That takes care of ConfigurationWrapper::setLocalizedPropertyValue, ConfigurationWrapper::getGroupReadWrite, and ConfigurationWrapper::getSetReadWrite. (This required an additional constructor parameter for the ReadWriteAccess service, to specify a locale at instantiation time.) 3 Redesigned ReadOnlyAccess to be a service that fixes the locale at instantiation time. That allows to take care of ConfigurationWrapper::getGroupReadOnly and ConfigurationWrapper::getSetReadOnly. Change-Id: I2ae7342b278b6f4222a0189a1deb2a53e204059f
* re-base on ALv2 code.Michael Meeks2012-06-121-26/+17
|
* Fix for fdo43460 Part VIII getLength() to isEmpty()Olivier Hallot2011-12-171-8/+8
| | | | | | Part VIII Module comfigmgr
* Unified configmgr::Node::getMember{s,Map} again.Stephan Bergmann2011-12-131-22/+19
| | | | (With the insight that Data::components is RootNode::members.)