| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Change-Id: If9d85236177c819c159d1b836e806fc2b03da45c
|
|
|
|
| |
Change-Id: I9b0b6affc60ae030b644fdd13eecfb1aed1f472a
|
|
|
|
| |
Change-Id: I214a9745f27c27868b3e74785cf7138fc1db1943
|
|
|
|
| |
Change-Id: I15c7f52c542549ad131400c9b5395a06a4777687
|
|
|
|
| |
Change-Id: Ibf1d8c74dc8abb8c1fef59c53a8873cc426e2932
|
|
|
|
| |
Change-Id: I45b323b326cc56cfc48e0abaa52d51fd86adbf79
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's boring and a waste of time to have to keep registering in
include/sal/log-areas.dox new log areas that other people have introduced.
We don't really have a uniform policy for logging anyway, so why bother trying
to enforce a such for the log areas? Anybody uses whatever log areas and log
output style and formatting they want in the code they happen to be working
on. And that's fine with me. We were supposed to be the project that avoids
unnecessary process, rules and bureaucracy, right?
Change-Id: I6bddcb56b58edcd885e5dc743c8730878de0036d
|
|
|
|
| |
Change-Id: Ic2faece46bebea046eee984a0d53d9cd2892e0c9
|
|
|
|
|
|
|
|
|
|
| |
We don't like C-style casts in our nice C++ code
Change-Id: I94e7ec90de9275cd6e20c4146d4f3a74bed93c9d
Reviewed-on: https://gerrit.libreoffice.org/10367
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
|
|
| |
Change-Id: Id1ce6c59f705f9c42855995e0ad590c6a3646613
|
|
|
|
| |
Change-Id: I0b7be1616a3e4206982f9f925de141ed9d53b96e
|
|
|
|
|
|
|
|
|
| |
...where prior to r183883 "Implement core issue 903: only integer literals with
value 0 and prvalues of type std::nullptr_t are null pointer constants from
C++11 onwards," Expr::isNullPointerConstant with NPC_NeverValueDependent could
go into an llvm_unreachable case.
Change-Id: I29cf093f18ece4cd83fd759e30f72c2a71f69554
|
|
|
|
| |
Change-Id: I00804b2dd63df44478a14a3eaf2fdcd4e4ce5d09
|
|
|
|
|
|
|
|
|
| |
Broken in commit 1f078fcaddd45bb074e4d0a4933db01f6e8b623e
Change-Id: Ica93c3b9309b2ae4d973ccc34a84b5accac7472c
Reviewed-on: https://gerrit.libreoffice.org/10478
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
|
|
|
|
|
|
| |
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.
Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
|
|
|
|
| |
Change-Id: I2746abd05edd00dadfe613c17b9874b1035c3be4
|
|
|
|
| |
Change-Id: Ib1f33387c50bcd853140eb2fc46995d23d7f367b
|
|
|
|
| |
Change-Id: I63d00cf5ab1dac953fae07ca4eb4d987610551a2
|
|
|
|
| |
Change-Id: I78a368ef2899b2462251b45a327fc7b1f31fe764
|
|
|
|
| |
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
|
|
|
|
| |
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
|
|
|
|
| |
Change-Id: I4a6280f47ca3c4a77b4e42fe05d79ded7fc30ef1
|
|
|
|
|
|
| |
to reduce copy-pasted code
Change-Id: I7728d85dea7d0161998c326d6648ca681a8250d0
|
|
|
|
| |
Change-Id: Ic414ad0416e27e223ff702996b796b68d39709b9
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
|
|
|
|
| |
Change-Id: I1bfdd865429cc6fa89ea3b6b4fc132b5d5b57b0d
|
|
|
|
| |
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
|
|
|
|
| |
Change-Id: Id46b391c09555c9ec30916fdd93b05455835d81b
|
|
|
|
| |
Change-Id: I32cd8e740855699036c420a091c282029f8d4a08
|
|
|
|
|
|
|
| |
after my commit 184a00b96235f6432294ded63ce4a4a318effdb5
"loplugin: inlinesimplememberfunctions"
Change-Id: Ib46d862b90566506c3035a12eeb01892b225ed51
|
|
|
|
|
|
| |
don't try and move functions containing comments
Change-Id: I2de8fc8be851af979acf9d1a91e7cdd9a5dc6a32
|
|
|
|
|
|
|
|
|
|
| |
Create a rewriting plugin for finding methods that simply return
object fields, and should therefore be declared in the header,
so that the compiler can reduce method calls into a simple
fixed-offset load instruction.
Change-Id: I7a620fc54250b79681918dc31ed9a8f21118c037
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
|
|
|
|
|
|
| |
...which does not make sense. On Linux and Mac OS X, they potentially end up
exported from multiple libs (weakly, though), while on Windows the potentially
even end up not emitted at all, which could cause link errors.
Change-Id: I092c9ba39e686c17b6e91581cdd4753f1c4d582f
|
|
|
|
| |
Change-Id: Ic809ddad81608f107749498c1432606403ee2314
|
|
|
|
|
|
|
| |
Only consider base declarations, not overriden ones, or we warn on methods that
are overriding stuff from external libraries.
Change-Id: I08791c96f7adba5997ad237a98e7c08a759042ad
|
|
|
|
|
|
|
| |
Detect arguments larger than 64 chars passed by value.
Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
|
|
|
|
|
| |
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
|
|
|
|
| |
Change-Id: Idac24afb7cb67fa2d539553fb9fa049c2d61ecf0
|
|
|
|
|
|
|
|
|
|
| |
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.
Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
| |
Change-Id: I3e78bd86c8010124a2d006f288095aac26e60797
|
|
|
|
| |
Change-Id: Idddc9a2b76e33c7e90ca51cb2c53e0d9f34d3906
|
|
|
|
|
|
|
|
| |
accidently removed by 5babf1b9037eb283798322eecd8334e6ff1db655
maybe obsolete now
Change-Id: Id1b8ce21e08ce2df5668252406bad6fb549b5206
|
|
|
|
|
|
|
|
|
| |
...which appears to be a good heuristic to identify functions that are either
unused or should better be declared just once in an include file. (It also
filters out SAL_DLLPUBLIC extern "C" function definitions, which are most likely
meant to be referenced dynamically via dlsym.)
Change-Id: I7fb78cb836b971791704851535dcfbda2b2f5bc0
|
|
|
|
| |
Change-Id: Ibb9b5b8f53ab8fdeba6d3db295339ead4bde7b6e
|
|
|
|
|
|
|
| |
since it only contains a single sal_Bool site now, and we want
to leave that alone since it's a copy of similar stuff in cppuhelper.
Change-Id: I3cf4cf5f67e95d5b6f70371181f77c5451fcbf50
|
|
|
|
|
|
| |
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
|
|
|
|
| |
Change-Id: I0e155c6c68a43020110a8e1c0cb29cabdcade454
|
|
|
|
|
|
|
|
| |
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
|
|
|
|
| |
Change-Id: I1d49aa9ad238cd5bd2e04479c2eb916f010417df
|
|
|
|
|
|
| |
(currently only used by a not-yet committed plugin, though)
Change-Id: I4cff7eb97dbe10a44a911be9db090ea8cd10d8f0
|