summaryrefslogtreecommitdiffstats
path: root/comphelper
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:subtlezeroinit: comphelperStephan Bergmann2017-02-213-30/+30
| | | | Change-Id: I6b97583d9bdc0d0f8c059d0fbc9e3f41f822bf3b
* cppcheck: unreadVariableJochen Nitschke2017-02-201-2/+0
| | | | | | | Change-Id: I701431f0346727cbb039f18ade55b5a98c97a135 Reviewed-on: https://gerrit.libreoffice.org/34438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Consistent formatting & indentation.Kohei Yoshida2017-02-191-192/+182
| | | | | | | Change-Id: I5dce7d05156313d460533040b8f7a3de3d8c59d7 Reviewed-on: https://gerrit.libreoffice.org/34420 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
* Drop :: prefix from std in c*/Tor Lillqvist2017-02-1522-102/+102
| | | | | | | Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155 Reviewed-on: https://gerrit.libreoffice.org/34324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
* Some simplifications, using UNO_QUERY_THROWStephan Bergmann2017-02-153-39/+10
| | | | | | | Change-Id: I143ec0287421675fb13a03e8cf3c7054a17be37f Reviewed-on: https://gerrit.libreoffice.org/34271 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Add missing #includesStephan Bergmann2017-02-0619-0/+39
| | | | | | | | | ...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
* makeAny->Any in canvas..configmgrNoel Grandin2017-02-038-23/+23
| | | | | | | Change-Id: Id06812595f373cd0da8b421dbac34a60a266ae6e Reviewed-on: https://gerrit.libreoffice.org/33869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* unnecessary use of OUStringBuffer in throwing exceptionsNoel Grandin2017-02-025-50/+24
| | | | | | | Change-Id: Iec1473264426f19c31e72260dfce9494389e474f Reviewed-on: https://gerrit.libreoffice.org/33788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin2017-01-283-7/+7
| | | | | | | | | ..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* User profile backups: Don't backup user galleriesSamuel Mehrbrodt2017-01-271-3/+0
| | | | | | | | | | As suggested in https://lists.freedesktop.org/archives/libreoffice/2017-January/076768.html Change-Id: I2562064ae906eb8b2d507ec971762625692a4bbf Reviewed-on: https://gerrit.libreoffice.org/33608 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Remove dynamic exception specificationsStephan Bergmann2017-01-2660-828/+510
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* lok: New feature flag to turn off tiled annotationsPranav Kant2017-01-231-0/+12
| | | | | | | Change-Id: Ie418642242ada98d4a41f30bb6cefcd57f398ef0 Reviewed-on: https://gerrit.libreoffice.org/33472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
* loplugin: unnecessary destructor: comphelper..desktopNoel Grandin2017-01-236-29/+0
| | | | | | | | Change-Id: I9df4cb6a4b1734dac6141d6b0ee7a09e3e05f92e Reviewed-on: https://gerrit.libreoffice.org/33453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* use rtl::Reference in OPropertyChangeListenerNoel Grandin2017-01-231-18/+7
| | | | | | instead of manual acquire/release Change-Id: Ie80253b5a59a3e3fcd52f98d9c26bcde42fe985a
* use rtl::Reference in OSelectionChangeListenerNoel Grandin2017-01-201-13/+2
| | | | | | instead of manual acquire/release Change-Id: I33e3018b5deb4240d4aff1d8136ae6f8f538c779
* use rtl::Reference in OContainerListenerNoel Grandin2017-01-201-18/+5
| | | | | | instead of manual acquire/release Change-Id: I83e6229029e662073e2e01e98f4846fb0a0ed643
* New loplugin:dynexcspec: Add @throws documentation, comphelperStephan Bergmann2017-01-194-0/+6
| | | | Change-Id: I115c5c34cf97858d9fdd96432cb57bde6d4537cb
* use rtl::Reference in DocPasswordRequest and SimplePasswordRequestNoel Grandin2017-01-171-16/+12
| | | | Change-Id: If1bad2bc852712b8315e44480ee81f797736bb95
* use rtl::Reference in OInstanceLockerNoel Grandin2017-01-172-12/+6
| | | | | | | | | no need to store a raw pointer and a refcount pointer Change-Id: I2dc3b87dd870c8d8128c2249a18fda30319ba08c Reviewed-on: https://gerrit.libreoffice.org/33157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use rtl::Reference in MasterPropertySetNoel Grandin2017-01-171-20/+19
| | | | | | no need to store a raw and a smart pointer Change-Id: Ic6b0b716812ec1dca3111f2162379c11389e963a
* use rtl::Reference in ChainablePropertySetNoel Grandin2017-01-172-20/+19
| | | | | | | | | no need to store both a raw pointer and a smart pointer Change-Id: If0bde337e6d9fa575a2fc7104ecffa97a8c37c31 Reviewed-on: https://gerrit.libreoffice.org/33159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use rtl::Reference in AttacherAllListener_ImplNoel Grandin2017-01-171-12/+11
| | | | | | | | | no need to store a raw and a smart pointer field Change-Id: Id9ce8365a413ee2dcac8e92b99768ccbb8bf7697 Reviewed-on: https://gerrit.libreoffice.org/33158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* new loplugin: useuniqueptr: comphelperNoel Grandin2017-01-162-8/+5
| | | | | | | Change-Id: Iafbaff60d10c9de7b57421e0c24809b08d813987 Reviewed-on: https://gerrit.libreoffice.org/33146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#97597: Ensure that each parsing thread has its own buffer.Kohei Yoshida2017-01-141-12/+34
| | | | | | | Change-Id: I93077f954a49b3922930e4fc86c80228be0f4dd2 Reviewed-on: https://gerrit.libreoffice.org/33069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
* default copy ctor and assignment operator are good enoughCaolán McNamara2017-01-071-4/+0
| | | | | | and block default move equivalents Change-Id: Ib8a1050803446c2e099f66602fae0465bd8165cf
* tdf#70998 Change word "Graphic(s)" to "Image(s)"Huzaifa Iftikhar2016-12-231-1/+1
| | | | | | | | | | There was an error in the previous patch inside the file embeddedobjectcontainer.cxx This is fixed in this patch. Change-Id: I01c9e254e58e1683a8e6e9a0bcff3c4663bf32e0 Reviewed-on: https://gerrit.libreoffice.org/32353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
* loplugin:unusedmethodsNoel Grandin2016-12-231-14/+0
| | | | | | | Change-Id: Ife4c8d948ffa116f044d43903de9485e43cfcae5 Reviewed-on: https://gerrit.libreoffice.org/32336 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* teach sallogareas plugin to catch inconsistenciesNoel Grandin2016-12-151-1/+1
| | | | | | | Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* OSL_TRACE->SAL in chart2..ooxNoel Grandin2016-12-132-6/+2
| | | | | | | Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* comphelper: cleanup class NameContainer.Arnaud Versini2016-12-121-7/+2
| | | | | | | | | Remove useless class NameContainerImpl. Change-Id: I3066abea69ed68d597aeecdd6b3ec7264f7ebe9c Reviewed-on: https://gerrit.libreoffice.org/31830 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert OSL_ENSURE to assert in AccessibleEventNotifierNoel Grandin2016-12-082-2/+2
| | | | | | | | | and fix the places that trigger it Change-Id: I97a04cff25ab5aa1d42c79a971d15ba742bf384e Reviewed-on: https://gerrit.libreoffice.org/31760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* This is presumably not meant to be exportedStephan Bergmann2016-12-071-1/+1
| | | | Change-Id: Id11393c44ddd217d3def259ea5a8df9f8bb27711
* tdf#88206 replace cppu::WeakImplHelper* miscJochen Nitschke2016-12-072-4/+4
| | | | | | | | | also edited two examples in canvas comments Change-Id: Iac82b462168f869f995c33bb2c639f3dbe09cbd5 Reviewed-on: https://gerrit.libreoffice.org/31715 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* SafeModeDialog: Add option to reset bundled extension registrationSamuel Mehrbrodt2016-12-061-20/+44
| | | | | | | Change-Id: Ic83ada7cc76142852643cefa60b4fc9286e0756a Reviewed-on: https://gerrit.libreoffice.org/31694 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* SafeModeDialog: Rename to match realitySamuel Mehrbrodt2016-12-061-5/+5
| | | | | | | | | | This doesn't remove shared&bundled extensions, but resets the registration database from shared extensions. Change-Id: I9f198fc7b771fd3bd31547008fd8d006a6d1b5d5 Reviewed-on: https://gerrit.libreoffice.org/31693 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* convert DecodeMechanism to scoped enumNoel Grandin2016-12-051-1/+1
| | | | Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
* tdf#104126 - comphelper thread-pool, use reliable std::condition_variable.Michael Meeks2016-12-011-147/+119
| | | | | | | | | | The existing osl::Condition is an API and reliability disaster area. Change-Id: I3be84e1c6a83e58c43c40c9c8720790d923a6694 Reviewed-on: https://gerrit.libreoffice.org/31163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* Fix race in ThreadTaskTagStephan Bergmann2016-12-011-8/+10
| | | | | | | | | | | | | | | | | | | | | | Assume T0 calls ThreadPool::pushTask twice, then ThreadPool::waitUntilDone: T0 calls ThreadTaskTag::onTaskPushed: mnTasksWorking = 1, maTasksComplete.reset T1 runs the 1st task to completion and calls ThreadTaskTag::onTaskWorkerDone: mnTasksWorking = 0; suspended... T0 calls ThreadTaskTag::onTaskPushed: mnTaskWorking = 1, maTasksComplete.reset T1 continues in the call to ThreadTaskTag::onTaskWorkerDone: ..., maTasksComplete.set T0 calls ThreadTaskTag::waitUntilDone and immediately returns T2 only now starts to run the 2nd task Change-Id: Ic29101a4791fca2a1a4d54b559f10ff706e8a20d
* Rewrite some (trivial) assignments inside if/while conditions: comphelperStephan Bergmann2016-11-291-6/+3
| | | | Change-Id: I8361f62199f45dbced45e5d4a4d5eeddf1c42d67
* loplugin:unnecessaryoverride (dtors) in comphelperStephan Bergmann2016-11-287-37/+0
| | | | Change-Id: I13ebc4efa7f8bd0d3732ed65e397c710ae65d14e
* Delete the "Any-to-Any" template specializations for LIBO_INTERNAL_ONLYStephan Bergmann2016-11-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | i.e., css::uno::Any function template specializations Any::has<Any>() const Any::get(Any const &) const operator >>=(Any const &, Any &) operator <<=(Any &, Any const &) that don't make much sense (the first is always true, the rest can be replaced with operator =, which additionally supports move semantics). For 3rd-party compatibility, do this only for LIBO_INTERNAL_ONLY, however. However, some generic template code did benefit from operator >>= working also for Any, so make up for that with a new (LIBO_INTERNAL_ONLY, given that operator >>= still covers if fine for !LIBO_INTERNAL_ONLY) fromAny, complementing the existing toAny. Change-Id: I8b1b5f803f0b909808159916366d53c948206a88 Reviewed-on: https://gerrit.libreoffice.org/30022 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:expandablemethods in comphelper..cppuhelperNoel Grandin2016-11-104-29/+19
| | | | | | | Change-Id: I9d5487af4729bd3ee4f6450092e4b77f74a12e6d Reviewed-on: https://gerrit.libreoffice.org/30717 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* comphelper: also bump PDBKDF2 count for password-to-modifyMichael Stahl2016-11-091-3/+3
| | | | | | | | The password-to-modify misfeature does not actually provide any security, but it may induce users to re-use passwords, so at least make it harder to crack the passwords. Change-Id: I0adf0e8e11b222fc469013e17a2695bd7122ad01
* make comphelper::containerToSequence a little smarterNoel Grandin2016-11-091-1/+1
| | | | | | | | | So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin2016-11-082-4/+4
| | | | | | | Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* SafeModeDialog: Allow to create zip file from profileSamuel Mehrbrodt2016-11-031-0/+5
| | | | | | | Change-Id: I4296d1cf5058be359ffed46745673cf26eba3375 Reviewed-on: https://gerrit.libreoffice.org/30479 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* SafeModeDialog: Add link to user profileSamuel Mehrbrodt2016-11-011-0/+5
| | | | | | | Change-Id: I0096b3d7db51e28eb58c7209109c30b73b382478 Reviewed-on: https://gerrit.libreoffice.org/30448 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* safemode: Add option to disable H/W accelerationSamuel Mehrbrodt2016-11-011-1/+80
| | | | | | | Change-Id: Ic6751717c14d317b5a4bc64c4fd1cf2b2f5efabf Reviewed-on: https://gerrit.libreoffice.org/30112 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Omit the default comparatorTakeshi Abe2016-11-011-2/+1
| | | | | | | Change-Id: Idea8ea8dab6a86d7be6394aef1cf7f25b75009e0 Reviewed-on: https://gerrit.libreoffice.org/30319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* coverity#1374269 Uncaught exceptionCaolán McNamara2016-10-261-1/+1
| | | | Change-Id: Ib3a876ea6463396784062bd53bfedff177818498