summaryrefslogtreecommitdiffstats
path: root/codemaker
Commit message (Collapse)AuthorAgeFilesLines
* Deprecate getCppuType et al in favor of cppu::UnoTypeStephan Bergmann2015-04-011-7/+7
| | | | | | ...which doesn't suffer from the sal_uInt16 vs. sal_Unicode ambiguity. Change-Id: I4de265145e720615652e88b6a68e03903ad8cba2
* loplugin:staticfunctionNoel Grandin2015-03-271-1/+1
| | | | Change-Id: Id796b799f8e2fcc3eae98d43800c5e31fec27fef
* const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann2015-03-261-1/+1
| | | | Change-Id: I3f5293be44ba87122de639f75ca477af827a1c51
* loplugin:deletedspecialStephan Bergmann2015-02-072-6/+6
| | | | Change-Id: Ice7788ebcfbc638ec21a824c4267757218c14478
* convert all remaining BOOST_STATIC_ASSERT to static_assertCaolán McNamara2015-02-051-3/+2
| | | | | | and we can include a few less headers Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
* SAL_DLLPUBLIC_RTTI for proper RTTI visibility for LLVMStephan Bergmann2015-01-221-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Itanium C++ ABI mandates that for a unique (complete) C++ type a single unique symbol for the type's RTTI name is used across a process's dynamic objects (so type equivalence can be determined via pointer comparison on the RTTI names). GCC nowadays deviates from that, using strcmp to determine equivalence, so it is resilient to RTTI names being bound locally within dynamic objects (which has performance benefits, but also makes it impossible to have unrelated types that happen to have the same name "encapsulated" in individual dynamic objects--- whether or not that would violate the ODR would be open to interpretation of how dynamic objects fit into the C++ Standard). LLVM sticks to the Itanium ABI, which becomes notable in at least two places: For one, libc++abi's __dynamic_cast uses strict checking. It still has a _LIBCXX_DYNAMIC_FALLBACK for now that additionally uses strcmp checking and syslogs visibility violations. Mac OS X uses libc++abi with _LIBCXX_DYNAMIC_FALLBACK enabled, and running LO routinely logs dynamic_cast errors to the Console there. For another, RTTI-based UBSan checks unconditionally only use strict checking (cf. isDerivedFromAtOffset in lib/ubsan/ubsan_type_hash.cc). This causes false positives from Clang -fsanitize=function and -fsanitize=vptr even on Linux not using libc++abi. Therefore, introduce SAL_DLLPUBLIC_RTTI to mark types for which RTTI needs to have default visibility under the Itanium/LLVM semantics. There is unfortunately no way to mark only the (implicitly generated) RTTI symbols for default visibility, but at least with the cases where SAL_DLLPUBLIC_RTTI is used for now that is no real problem---any class type marked SAL_DLLPUBLIC_RTTI only has inline (covered by -fvisibility-inlines-hidden) or undefined pure virtual functions. It appears that even the vtables of those classes remain hidden, at least with Mach-O on Mac OS X. (That also means there is no need for a SAL_DLLPRIVATE_RTTI marker analoguous to the---also superfluous in retrospect--- CPPU_GCC_DLLPRIVATE one.) Nevertheless, the number of exported symbols of course increases when SAL_DLLPUBLIC_RTTI is "active." For a full-blown --enable-dbgutil build on Mac OS X, find instdir/LibreOffice.app/Contents -name \*.dylib\* -exec nm -gU {} \; \ wc -l increased from 125541 to 139239. For Linux, an option might be to "activate" SAL_DLLPUBLIC_RTTI only for __clang__ plus !ENABLE_RUNTIME_OPTIMIZATIONS. The set of types marked SAL_DLLPUBLIC_RTTI with this patch (wholesale cppumaker- generated UNO enum, struct, and interface types; plus some IEmbeddedHelper and IUndoManager) is chosen so that a full "make check" on Mac OS X no longer syslogs any dynamic_cast errors to the Console. Change-Id: I42fa6ec01c2503ec24bcd9c0518abb112afa3235
* coverity#1019332 Unchecked dynamic_castCaolán McNamara2014-12-271-7/+6
| | | | Change-Id: I280928da005b8cdd94c8bf33eb5aaa86a5ea2fcd
* coverity#1019331 Unchecked dynamic_castCaolán McNamara2014-12-271-7/+6
| | | | Change-Id: I902fdbcfd171e93ac57b5021269d2279610b4b0d
* coverity#1019327 Unchecked dynamic_castCaolán McNamara2014-12-271-5/+4
| | | | Change-Id: Ibc5a1478d196681cbc124886924eebf065bbdb11
* coverity#1019325 Unchecked dynamic_castCaolán McNamara2014-12-271-0/+3
| | | | Change-Id: Ic1607eea119a7321f65b0a0145a263a03406ed6d
* Fix generation of com.sun.star.uno.[Runtime]Exception classesStephan Bergmann2014-12-101-5/+9
| | | | Change-Id: If9bd4d906906e0e6cd7c5bb61f8a67a163218395
* protected -> privateStephan Bergmann2014-12-081-8/+4
| | | | Change-Id: I807b31eaa0b0cd68e0ca018b6df4269c1aab5763
* cppumaker: only include rtl/instance.hxx and mutex.hxx when necessaryMichael Stahl2014-11-181-4/+22
| | | | Change-Id: Ib21a3cfe4b02e421f8848a6e2cca4e2a1c04adb9
* More iwyu suggested headers removalRiccardo Magliocchetti2014-11-182-2/+0
| | | | | | | | Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, undid one remove that was detrimental to loplugin:unreffun Change-Id: I18d8252084d828f94ef7a954e1dbfb45743d7970
* fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava2014-11-142-2/+2
| | | | | | | Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* Revert "use the new OUString::fromUtf8 method"Stephan Bergmann2014-11-061-1/+1
| | | | | | | | This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
* use the new OUString::fromUtf8 methodNoel Grandin2014-11-061-1/+1
| | | | Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
* Removed duplicated includesAndrea Gelmini2014-10-311-7/+6
| | | | | | | Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* remove unnecessary 'using namespace rtl' declarationsNoel Grandin2014-10-291-1/+0
| | | | | | | | | It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* coverity#441989 Uncaught exceptionCaolán McNamara2014-10-241-5/+4
| | | | Change-Id: I579bfc6f4a57aea49e2b023917d0dbd7c3db6c88
* coverity#441732 Uncaught exceptionCaolán McNamara2014-10-241-5/+4
| | | | Change-Id: Icd11b81566fec7ce4855cd4e54ff3a3d9862d354
* coverity#1242375 Don't call fscanf without specifiersCaolán McNamara2014-10-072-2/+2
| | | | Change-Id: I58082770ca79da9c4d235b5ea0dc79c688c7498b
* codemaker: std::auto_ptr -> std::unique_ptrStephan Bergmann2014-09-302-61/+21
| | | | Change-Id: I205c0908254f13970315f8e159997a5ec2f96ed3
* java: when rethrowing exceptions, store the original causeNoel Grandin2014-09-251-8/+129
| | | | | | | so that we get a nice complete stacktrace when it hits the final handler Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
* java: avoid unnecessary comparisons in boolean expressionsNoel Grandin2014-08-201-6/+6
| | | | | | i.e. stuff like "x == true" Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
* java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin2014-08-191-2/+2
| | | | Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
* coverity#1019323 Unchecked dynamic_castCaolán McNamara2014-07-261-1/+1
| | | | Change-Id: I3d8b598e86339fdd51af48e62393550821b6278d
* coverity#1219788 Unchecked dynamic_castCaolán McNamara2014-07-251-0/+3
| | | | Change-Id: I1bedfb601320bc27adc0d0d72fcb8b3c5dfe73ff
* New loplugin:stringconcatStephan Bergmann2014-07-011-4/+3
| | | | Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
* new compilerplugin returnbyrefNoel Grandin2014-06-242-7/+7
| | | | | | | | | | | | | | Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
* improve the inlinesimplememberfunctions clang pluginNoel Grandin2014-06-172-8/+1
| | | | Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
* loplugin: inlinesimplememberfunctionsNoel Grandin2014-06-091-4/+0
| | | | Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
* various: remove SAL_THROW macroNoel Grandin2014-06-051-17/+17
| | | | Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
* coverity#1019311 Unchecked return valueCaolán McNamara2014-05-261-4/+4
| | | | Change-Id: I682ca0b62e6eb0d02113218de97d1440089b782c
* coverity#1019326 Unchecked dynamic_castCaolán McNamara2014-05-261-1/+1
| | | | Change-Id: Ib3f0776048ca3dbb8a7efa4d9240f4ee9d6ac9dd
* coverity#1019329 Unchecked dynamic_castCaolán McNamara2014-05-261-1/+1
| | | | Change-Id: Ic340559c9ab9b74f4f932c90e08f2530c08e8d08
* coverity#1019330 Unchecked dynamic_castCaolán McNamara2014-05-261-1/+1
| | | | Change-Id: I9c7893f7c9af2b42dcc50f2d1463ec497bb85e30
* improve parameter flow in cpputype.cxxNoel Grandin2014-05-231-10/+8
| | | | | | | | after commit c5d47c327a57df55 "add default value for Context param in uno::Exception constructors" Change-Id: Ib429b58c559ecd48764a8df2f49d5470057c2c63
* add default value for Context param in uno::Exception constructorsNoel Grandin2014-05-231-7/+24
| | | | | | | and all it's subtypes, which is almost never used, so this allows us to simplify lots of call sites. Change-Id: I0b05793ea2bdd1027679f63252d42ce4af89433b
* Combine unoidl::loadProvider and unoidl::Manager::addProviderStephan Bergmann2014-05-231-3/+1
| | | | Change-Id: I1240656cc2a4d713c838eb80fa90ce3485aad614
* enhance pass-by-ref plugin to detect large argumentsNoel Grandin2014-05-202-3/+3
| | | | | | | Detect arguments larger than 64 chars passed by value. Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* coverity#1213117 Unchecked dynamic_castCaolán McNamara2014-05-111-0/+3
| | | | Change-Id: I6f55030ea7bebce99537c7cdd5156c83c38a765a
* prefer makefile-gmake-modeTakeshi Abe2014-04-283-3/+3
| | | | Change-Id: I9cc9bfbddd3a90e00eee3e674994e5d6207f9034
* Reduce the amount of strings in the release builds.Jan Holesovsky2014-04-141-23/+22
| | | | | | I guess even in the debug builds these strings do not add much info, but... Change-Id: I5cf765539a821513b5ce77c5484071d181459881
* codemaker: sal_Bool->boolNoel Grandin2014-04-044-6/+6
| | | | Change-Id: I0a0691df58455b712eb27695f4cce15fd3494b65
* Explicitly mark overriding destructors as "virtual"Stephan Bergmann2014-04-012-2/+2
| | | | | | | | It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
* First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann2014-03-263-50/+50
| | | | | | | ...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
* codemaker,editeng: prefer passing OUString by referenceNoel Grandin2014-03-172-11/+11
| | | | Change-Id: If3e2dd3905cc33f1e7fc9fbfbb9f2bb49a756a34
* Remove visual noise from codemakerAlexander Wilms2014-02-271-2/+2
| | | | | | | Change-Id: I098c636ed8794c858317fdbefa9ffa1c6d81c320 Reviewed-on: https://gerrit.libreoffice.org/8241 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* codemaker: sal_Bool -> boolStephan Bergmann2014-02-176-36/+36
| | | | Change-Id: I2cacac2aa7e48b3b9d8d060137d5c6d6f1d06b3f
generated by cgit (git 2.34.1) at 2024-07-28 07:04:06 +0000