| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Change-Id: I0ff1e44f17976fd3a3060d8ee7fe15d77c918b79
|
|
|
|
|
|
|
|
|
| |
This addresses some cppcheck warnings.
Change-Id: Ib35eb591534c3f23adc3cb7b7fa9696dc5cbeabf
Reviewed-on: https://gerrit.libreoffice.org/13383
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
|
|
|
|
|
|
| |
...assuming the delayLoadHook in cli_ure/source/native/native_bootstrap.cxx is
no longer necessary and loading of cppuhelper from the program dir cannot fail
regardless in whatever scenario the cli_cppuhelper library itself is loaded.
Change-Id: I13f32b327bca4cce9780864f5e57cdad3860afe5
|
|
|
|
|
|
| |
found by PMD
Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
|
|
|
|
|
|
|
|
|
| |
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
|
|
|
|
|
| |
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
|
|
|
|
|
| |
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
| |
Change-Id: Ibe794daffa347d194ff8c66a44c7eec4bcc9b83d
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit 4b56d82c7d20ba5897d87aaf7fc94da5356b8eec converted the cli_uno
library from "Managed C++" to "C++/CLI", but forgot one detail:
The destructors on "ref" classes were mapped to Finalize() methods in
the old syntax, but the new one maps them to Dispose() methods, which
are only invoked on stack-allocated objects. Presumably this omission
results in leaking of native C++ UNO objects.
Reading the C++/CLI documentation i get the impression that:
1) the destructor should explicitly call the finalizer
2) the CLR will not call the finalizer itself iff the destructor is
invoked
http://msdn.microsoft.com/en-us/library/ms235315.aspx
http://msdn.microsoft.com/en-us/library/ke3a209d%28v=vs.110%29.aspx
Change-Id: I509d9b69a399c3d7d6597060ab9b7c78c5916e11
Reviewed-on: https://gerrit.libreoffice.org/11132
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
|
|
| |
Change-Id: Ic8a76a9ab73a3466fe155e2ca8eecedeb6e810c9
|
|
|
|
|
|
| |
found by UCDetector
Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
|
|
|
|
| |
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
|
|
|
|
|
| |
Change-Id: Iab402035613a6cc96b7b4ebd2981a1fd0f8bed23
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
|
|
| |
Change-Id: I05e60964521d6ec3694483816d91359fb12c8e4b
|
|
|
|
| |
Change-Id: I1b04fbf4d4562ff8e74f6ccdb2fd989d79cc869b
|
|
|
|
| |
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
|
|
|
|
| |
Change-Id: Ic76a399fc4073fcb713bb566f3fbee2077e20e52
|
|
|
|
| |
Change-Id: I062c95ca8d478ba6c241723dda25c1dc4d7bb852
|
|
|
|
|
|
|
| |
It looks like what works is to give the source file names with
backslashes but everything else with forward slashes?
Change-Id: Iaf910ab5fc41984d1315a30b164a334d28344c16
|
|
|
|
| |
Change-Id: Ide8a3c574a1904e08921684453256d1d3c98fd78
|
|
|
|
| |
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
|
|
|
|
|
|
|
| |
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.
Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
|
|
|
|
| |
Change-Id: I1240656cc2a4d713c838eb80fa90ce3485aad614
|
|
|
|
|
|
|
| |
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
|
|
| |
Change-Id: Ia2f827381ec768a7867918d61d7afb2f68457832
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some blocks are completely unused.
According to http://msdn.microsoft.com/de-de/library/ms235298.aspx
rtl_uString * __pin * pp_sInterfaces = &_sInterfaces;
should be
pin_ptr<rtl_uString *> pp_sInterfaces = &_sInterfaces;
Change-Id: I039e94649d542fb5b51231b2e0df0a4dc1170c19
Reviewed-on: https://gerrit.libreoffice.org/9318
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
|
|
|
|
|
|
|
| |
Look for code like:
xxx ? yyy : false;
Which can be simplified to:
xxx && yyy
Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
|
|
|
|
| |
Change-Id: Id67d5375bedc6e6c10082d9c5ee69d6e932be158
|
|
|
|
| |
Change-Id: If52651c70ee659c83ef127da4fe5e266cfe7eec2
|
| |
|
|
|
|
| |
Change-Id: If6f975bdc3d554828ff1ad3adc656579eda92a42
|
|
|
|
|
|
|
| |
Change-Id: I1ddada46767b2840c663a0a077e1b723f9645b56
Reviewed-on: https://gerrit.libreoffice.org/8240
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
|
|
|
|
|
| |
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
|
|
| |
Change-Id: Id05440ffb8eb9990d2d08f721d6914f3dbc86cab
|
|
|
|
|
|
|
| |
Change-Id: Ia54def7a404e07974eb1e8a556f4659cd974e7f8
Reviewed-on: https://gerrit.libreoffice.org/7081
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Matúš Kukan <matus.kukan@collabora.com>
|
|
|
|
| |
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
|
|
|
|
|
|
|
|
|
|
| |
Convert code like:
aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
aStrBuf.append( "ln(x)" );
which compiles down to the same code.
Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
|
|
|
|
|
|
| |
Tweak the installer so it reads the included files from SRCDIR.
Change-Id: Ic4d3d2c003c2d0c5aebea6dd32f5989f3d4f04e4
|
|
|
|
| |
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186
|
|
|
|
|
|
|
| |
- cliuno.snk is used from SRCDIR
- climaker.exe.config is not packaged and appears unnecessary
Change-Id: Ia0e364bd3b488841aeb8ae75c26aa0cd4ff86012
|
|
|
|
|
|
|
|
|
|
|
| |
- stop copying the DLL to OUTDIR
- since that was the main reason for the separation between
CliLibrary and CliLibraryTarget, merge the targets;
the newly inherited variables are not expected to cause problems
- hardcode target to URE bin dir for now, no immediate need for
multiple layers
Change-Id: If0fea1337349c41f231c8cde122852c71d5080a7
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- stop copying the DLL to OUTDIR
- since that was the main reason for the separation between
CliNativeLibrary and CliNativeLibraryTarget, merge the targets;
the newly inherited variables are not expected to cause problems
- the Library remains in layer NONE; the derived CliNativeLibrary
is in INSTDIR
- hardcode target to URE bin dir for now, no immediate need for
multiple layers
Change-Id: I3bf4859e8c574f84d69eb43d12ddce0d34b5730c
|
|
|
|
| |
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce SDKDIRNAME as a configury variable and use it instead of the
gbuild gb_Package_SDKDIRNAME. Then we can easily construct the
SDKDIRNAME_FOR_BUILD variant that is needed to find the specially
named SDK in instdir on OS X when cross-compiling.
Move the version number section in configure.ac earlier.
Change-Id: Iee3db1a50ad4c7a9f91bbc5e0d0b01d76a76f701
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The library is already in the URE/bin directory, but that is not
sufficient to be able to run sdk/bin/climaker.exe.
There are apparently 4 ways for a .net/CLR executable to locate
shared libraries:
1) in the same directory as the executable
2) in some mysterious "GAC" thing in C:/Windows
(which is presumably how it works if you actually install LO)
3) via an application configuration file entry "probing",
which only works when it's in a sub-directory of the
one the executable is in
4) via a DEVPATH variable, but that only works with a
special configuration entry in a system "machine config" file
of the .net framework
Specifically PATH is apparently ignored. Since building on Windows is
enough of a PITA already and we don't want developers to have to edit
another config file, put another copy of the library into sdk/bin.
http://tutorials.csharp-online.net/.NET_CLR_Components%E2%80%94Resolving_Names_to_Locations
http://tutorials.csharp-online.net/.NET_CLR_Components%E2%80%94CLR_Loader
Change-Id: I511957ad9a9a918ed0c316126304a1980fb2d289
|
|
|
|
| |
Change-Id: I76b4815208354e78eb3575982235b6f26f1e02fd
|
|
|
|
| |
Change-Id: I06dca63053dae5d3dceb49bf67adb0c100b56e8b
|
|
|
|
|
|
|
|
| |
This is a follow up commit to
- 22d1beb78a475e4846af945afde1c4d6c263b5d6
- 1c7af455ab9345304a7ac48ce2e0310de2ac8a75
Change-Id: I55ff666c357c89ad355a1a5bc0d0347fcc188476
|
|
|
|
|
|
|
|
| |
This is a follow up commit to
- 22d1beb78a475e4846af945afde1c4d6c263b5d6
- 1c7af455ab9345304a7ac48ce2e0310de2ac8a75
Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
|
|
|
|
| |
Change-Id: I2575da1ccbe1c301dd826588aec2a787176d3cfd
|