summaryrefslogtreecommitdiffstats
path: root/chart2
Commit message (Collapse)AuthorAgeFilesLines
* resave with latest gladeCaolán McNamara2022-01-221-145/+141
| | | | | | | Change-Id: Idb87c5cfd4f2363bb139ff28307ea4efeeba1e6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* simplify function objectNoel Grandin2022-01-221-18/+4
| | | | | | | Change-Id: Iadba25f2c7ceae1dfc24de421b88ba9e8afb9155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, BaseCoordinateSystemNoel Grandin2022-01-223-176/+128
| | | | | | | Change-Id: Iea726c410829fbd3f116ecead76610e356ef83ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128739 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#135935 Ensure help page is opened in chart creation Wizard dialogRafael Lima2022-01-211-1/+2
| | | | | | | | | | | | Prior to this patch, if the user opens the Chart Wizard dialog (Insert > Chart) and clicks the Help button without clicking anywhere in the dialog, the help ID was not being applied. This problem happens on kf5 and gen, but not on gtk3. With this patch, the expected behavior is achieved in gtk3, gen and kf5. Change-Id: Ief7852fce00de45f65c21ea0ddc8e4d6477612d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127783 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* use more concrete types in chart2, ChartModelNoel Grandin2022-01-2140-156/+170
| | | | | | | Change-Id: I6930e09ed471592d7c8b8fb16565b355b17bffc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128731 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* asan: fix symbol visibility in chart2Noel Grandin2022-01-213-3/+5
| | | | | | | | | asan needs some more RTTI Change-Id: I77ffe652c3252a6d9b71f3b29b085170963eba3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128728 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, BaseCoordinateSystemNoel Grandin2022-01-218-46/+33
| | | | | | | Change-Id: I25fc26c9c3eb861d72c44ac04e502b2f002ef951 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* fix ChartDocumentWrapper::createInstanceNoel Grandin2022-01-214-19/+20
| | | | | | | | | | | | | | | | | | | | | | | which I broke in commit fe37aa64ff79abcd3aeedeb03d8d74798225a367 Date: Sat Jan 15 13:45:44 2022 +0200 use more concrete types in chart2, ChartView by copying behaviour from the wrong construction site. And then in commit c592574948b0a28bac965b508bc260aaa6c365d3 Date: Sun Jan 16 12:25:49 2022 +0200 use more concrete types in chart2, ChartView I spread the error further by using the incorrect behaviour I had introduced in the first commit in Chart2ModelContact::getChartView() Change-Id: I4b004b8893fa51b8968328b6a8b6ffde081f1269 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128705 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, DiagramNoel Grandin2022-01-2111-59/+64
| | | | | | | Change-Id: Ib78f327c8bf1b71c3bb038c029b10e6fe54edaa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Removed duplicated includesAndrea Gelmini2022-01-214-4/+0
| | | | | | | Change-Id: I9f8350f44952692a9efef297792a2326086d3d91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128704 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* use more concrete types in chart2, ChartModelNoel Grandin2022-01-2016-152/+144
| | | | | | | Change-Id: Ic3020221111fea9c1026a91c72f7a2d1d5da42dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128666 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, ChartModelNoel Grandin2022-01-2059-179/+256
| | | | | | | Change-Id: Ie38d941f855978b04995162040d8871a2577255c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128641 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* WASM re-activate and fix the Chart buildArmin Le Grand (Allotropia)2022-01-203-0/+23
| | | | | | | Change-Id: I13c50ac005e1e990bd185115b6e1717ce2c6bb45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128654 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
* WASM --enable-wasm-strip now skips lots of LO codeArmin Le Grand (Allotropia)2022-01-202-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... resulting in a stripped-down, Writer-only build to decrease the resulting WASM bytecode size. It removes the following code from the build: * All other major modules: Base, Calc, Chart, Draw, Impress and Math and related writerperfect filters * The premultiply tables * The (auto-)recovery functionality * All accessibility (but not the accessibility document checker) * The LanguageGuess component * EPUB support * The start center / BackingWindow * The TipOfTheDay functionality * The splash screen communication Currently crashs with anything different then soffice --writer. Closing the document also still crashes. FYI: many of these features are now behind ENABLE_WASM_STRIP_* defines, but they normally don't work on their own, globally! That's because we started with stripping the main components. Change-Id: Ib9c0f9452815910c0a2aceaf142ba1ad4a9cb0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126182 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
* cid#1497461 Logically dead codeCaolán McNamara2022-01-201-11/+6
| | | | | | | Change-Id: Ia8a7fe24e46d749f8837efb50145c66b0ecb5ee2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128642 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* use more concrete types in chart2, SvNumberFormatsSupplierObjNoel Grandin2022-01-192-5/+5
| | | | | | | Change-Id: I15bb69bab11e374db2bfa2b964ba820063f01cda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128631 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, InternalDataProviderNoel Grandin2022-01-197-29/+32
| | | | | | | Change-Id: Iee2cc56b00f0464e652a14eace2640e5d798eb5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128629 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, UncachedDataSequenceNoel Grandin2022-01-192-10/+12
| | | | | | | Change-Id: Ic5ca09567b74840c28d1c892a315476a6b7e9e0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128630 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, BaseCoordinateSystemNoel Grandin2022-01-1937-143/+161
| | | | | | | Change-Id: I1c246a3ea37595647ac254f492170a9e18540794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128623 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, ChartTypeTemplateNoel Grandin2022-01-1922-75/+93
| | | | | | | | | | and return data using a little struct rather than std::pair, to make the call sites read a little better. Change-Id: Ieb6fc24e053f50823789167ed0112aa04a083725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128613 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, DiagramNoel Grandin2022-01-193-15/+20
| | | | | | | Change-Id: Id21836b1258b8757e634fc9ab670ef1180748469 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128612 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* add ChartController::getFirstDiagram codeNoel Grandin2022-01-196-9/+16
| | | | | | | | | utility method to simplify some code Change-Id: I24225e993ef03e7e859a96e7ff2434df158c318b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128599 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, DiagramNoel Grandin2022-01-1938-135/+155
| | | | | | | Change-Id: I870f6d9fa4c0b51cf7c887199079fdbabbca1fec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128597 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, ChartModelNoel Grandin2022-01-1932-366/+341
| | | | | | | Change-Id: I36b6ac63ce62e0eb0e9bec951d582f39aed3be25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128592 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, ChartModelNoel Grandin2022-01-192-11/+11
| | | | | | | Change-Id: I6fea07e7b9684b5333c908dbb353aeda58dd73a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128583 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, PageBackgroundNoel Grandin2022-01-193-7/+9
| | | | | | | Change-Id: I432b77bab48c8574373daa00916ef6ceea4ebc93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128576 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, NameContainerNoel Grandin2022-01-194-32/+14
| | | | | | | | | and simplify the NameContainer class, since it has only one use site Change-Id: I5b68b8985c22bb5eb37fa559aba1d5314c3d3aa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128575 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, ChartTypeTemplateNoel Grandin2022-01-197-12/+19
| | | | | | | Change-Id: I1bfbc81ca0d44efc669e5bc2b525cfa8b51be1ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128561 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, ChartTypeTemplateNoel Grandin2022-01-1814-344/+326
| | | | | | | Change-Id: Ife0be0fde2f8d273411cbdbbafa2173ac80f80f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128560 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, ChartTypeManagerNoel Grandin2022-01-188-32/+39
| | | | | | | Change-Id: If5055256c3e3a20ab1a30e9c8bf46f453785e80c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:finalclasses in chart2Noel Grandin2022-01-1763-89/+90
| | | | | | | Change-Id: I6cc88d50df7a6c77285f8534de43fd0c8d251bf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128505 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, ChartViewNoel Grandin2022-01-165-10/+12
| | | | | | | Change-Id: I51d503cd71ef2adc0e590ef836dabf9906495bbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, DiagramNoel Grandin2022-01-1620-69/+87
| | | | | | | Change-Id: Iae84e16b3406f4c08139764a1838e38b13cebee7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128471 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, ChartModelNoel Grandin2022-01-1511-142/+126
| | | | | | | Change-Id: Iecbc92aa096ede1845936faa708d1a9e8747b658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128467 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, ChartViewNoel Grandin2022-01-155-17/+19
| | | | | | | Change-Id: I7316d01d08eb1d9d482937fdd87bd34e2ae7e3c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128461 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove XTransformation UNO APINoel Grandin2022-01-155-10/+0
| | | | | | | | | | | | unused after commit 18bc9ea75daf4eb3520a4d0ef6649d92261012a6 Date: Tue Jan 11 15:02:14 2022 +0200 replace XTransformation with more efficient class Change-Id: I9e6bf80d8a8cdba8514ad0e94ce090bdbceab853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128460 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* make comphelper::OInterfaceContainerHelper4 more threadsafeNoel Grandin2022-01-142-12/+18
| | | | | | | | | | | | | (*) make all the methods that require an external mutex take a std::unique_lock as a parameter, so that call sites cannot forget (*) make the forEach method drop the lock when firing listener methods, to reduce the odds of deadlock Change-Id: I0a80e3b3d1c1c03b7de4a658d31fcc2847690903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use cache value in ViewContactNoel Grandin2022-01-141-0/+1
| | | | | | | | | | | | Rely on the cached primitives without always rebuilding. But only enable it for calc and draw right now, by adding a flag at the SdrModel level. Change-Id: I295e5a366b1b21d0f1561e6736bac919082afb5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128380 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* improvements to ModifyEventForwarderNoel Grandin2022-01-142-151/+21
| | | | | | | | | | | | | (*) Firstly, the XWeak machinery in here was never useful. This class has always used hard references to its listeners. So just remove all that. (*) Convert from osl::Mutex to std::mutex and use the latest utility classes in comphelper with that. Change-Id: Id129527cf53da6d7a9f6e1c76b556c57fe1a0270 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128393 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2Noel Grandin2022-01-1438-406/+119
| | | | | | | | | | | in this case, ModifyEventForwarder. Instead of doing UNO_QUERY and implicitly relying on it's implementation, make it obvious what we are doing Change-Id: Ie02a11f115da9c8af7d4ca85bda9fb9a69c5d52f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128392 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Recheck modules [a-c]* with IWYUGabor Kelemen2022-01-1348-99/+19
| | | | | | | | | See tdf#42949 for motivation Change-Id: I74a3c3a67c3639376e2251c3eb917fa4139dfbd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127808 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* cache result of query for dataseries propertiesNoel Grandin2022-01-132-1/+3
| | | | | | | | | shaves some time off the perf profile of large charts Change-Id: Ic9feab719d784b2e58e96c8a1c642d363d3c5f27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128355 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* split the BarChart rendering method down a littleNoel Grandin2022-01-134-424/+477
| | | | | | | | | into slightly more manageable chunks Change-Id: I2a8c031618516102e2dccf071beef51fe9917f82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Small refactorMike Kaganski2022-01-131-5/+4
| | | | | | | Change-Id: I18a3bcce4aa7cac3d01b3889aff24b3ec992809d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128358 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#145538 - Use range based for loopsdtm2022-01-121-3/+2
| | | | | | | Change-Id: Ib16c742b39af62694ef591dcdaa975b9a720b4a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127203 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
* remove unused codeNoel Grandin2022-01-128-662/+0
| | | | | | | Change-Id: Ieb5100dab1ed8af23e765926a8a1f33d75132406 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128311 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* replace XTransformation with more efficient classNoel Grandin2022-01-118-82/+152
| | | | | | | | | | this UNO interface is not being used an a real UNO API, so replace it with something that doesn't pass around 3 doubles in a Sequence Change-Id: I39d8ae03a3e861daba87f46686c0f93815bb1805 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128292 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use vectors to build up point data, instead of SequenceNoel Grandin2022-01-1122-202/+1052
| | | | | | | | | which shaves 1% off the load time of a large chart Change-Id: Ieb8f029f760f41c3bef63bbc4cd221c1473f0f49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* skip unnecessary in DateScaling::doScalingNoel Grandin2022-01-111-28/+27
| | | | | | | | | when the timeunit is DAY, we don't need to do the AddDays thing Change-Id: Ie06c50dbb8b315e604f19e341bcdd88c75481a90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128282 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove E3D_INVENTOR_FLAG and convert SdrObjKind to scoped enumNoel Grandin2022-01-076-49/+49
| | | | | | | | | | | | | | | | | | | | | | We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is in the right range. Which exposes some dodgy code in DrawViewShell::GetMenuStateSel SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) || SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) || which has been there ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b Date: Mon Sep 18 16:07:07 2000 +0000 initial import just remove that. In SwFEShell::ImpEndCreate() move some logic around to avoid using an out-of-range SdrObjKind value Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>