summaryrefslogtreecommitdiffstats
path: root/chart2/source/controller/main/ChartController_Insert.cxx
Commit message (Collapse)AuthorAgeFilesLines
* add ChartController::getFirstDiagram codeNoel Grandin2022-01-191-4/+4
| | | | | | | | | utility method to simplify some code Change-Id: I24225e993ef03e7e859a96e7ff2434df158c318b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128599 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, DiagramNoel Grandin2022-01-191-2/+3
| | | | | | | Change-Id: I870f6d9fa4c0b51cf7c887199079fdbabbca1fec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128597 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2, ChartModelNoel Grandin2022-01-191-51/+51
| | | | | | | Change-Id: I36b6ac63ce62e0eb0e9bec951d582f39aed3be25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128592 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:stringviewparam extend to new..Noel2021-01-291-1/+1
| | | | | | | | | O[U]StringBuffer methods Change-Id: I0ffbc33d54ae7c98b5652434f3370ee4f819f6f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typo in codeAndrea Gelmini2020-09-011-2/+2
| | | | | | | | | It passed "make check" on Linux Change-Id: Icb950648977545c02ec8569f8b246359b33f8054 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101790 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* use for-range on Sequence in chart2Noel Grandin2020-05-181-6/+6
| | | | | | | Change-Id: Ief02e5d5284b0cbad26b04c0a282dccfee577b90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94398 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:flatten in chart2Noel Grandin2020-04-191-14/+14
| | | | | | | Change-Id: Iadc4da6515a7d82e7a92b33d74d589b61fa2c64f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92480 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove some unused local varsNoel Grandin2020-01-281-1/+1
| | | | | | | | | | found by my new aggressive unused var plugin. these are unused return values from function calls Change-Id: I3359c583f535828f192cb833762dfedc008d82f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#42949 tdf#119699 Fix IWYU warnings in chart2/Gabor Kelemen2019-11-211-1/+0
| | | | | | | | | | | | | | | | | * Recheck after recent refactorings and improvements in f-u-i * Drop now unused TabPageIds.h * The problem noticed in bug #119699 now seems to be gone too so drop those lines from the blacklist. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I44f26c7370f5328c8f67ac61cd8f0cdb29077f15 Reviewed-on: https://gerrit.libreoffice.org/83182 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* loplugin:redundantpointerops check other pointer typesNoel Grandin2019-10-091-2/+2
| | | | | | | | | as well as unique_ptr Change-Id: I54842bca161ee460fb96c46ca31b6f9c0a7dbbdf Reviewed-on: https://gerrit.libreoffice.org/80455 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:referencecasting in canvas..chart2Noel Grandin2019-07-191-18/+18
| | | | | | | Change-Id: I3a3671b5c44d1a7e5ca320d3d76dd5d902382cbc Reviewed-on: https://gerrit.libreoffice.org/75935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:logexceptionnicely in chart2Noel Grandin2019-06-141-26/+27
| | | | | | | Change-Id: Ib7933723e5506578bbc85cc431d54d1ed8466376 Reviewed-on: https://gerrit.libreoffice.org/74019 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* improve loplugin simplifyconstructNoel Grandin2019-04-151-2/+2
| | | | | | | | | | to find stuff like OUString s = OUString("xxx") Change-Id: Ie7ed074c1ae012734c67a2a89c564c1900a4ab04 Reviewed-on: https://gerrit.libreoffice.org/70697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#42949 Fix IWYU warnings in chart2/source/controller/*/cxx (1)Gabor Kelemen2018-12-141-3/+0
| | | | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Cleaned directories are: accessibility, drawinglayer, itemsetwrapper, main, sidebar Change-Id: I612eae9dec636d57a3a3a00102d74b964da5b54c Reviewed-on: https://gerrit.libreoffice.org/64307 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* weld AdvancedSettingsDialogCaolán McNamara2018-10-241-2/+2
| | | | | | | | | | | | make run virtual and fold executes into it, so GenericUnoDialog can call run on tabdialogs to do the right thing, and allows Start_Impl to be private again Change-Id: Ic457edfbdc7457f4c49d4e8ad679903f38ad9b42 Reviewed-on: https://gerrit.libreoffice.org/62227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* weld SchAttribTabDlgCaolán McNamara2018-10-201-9/+9
| | | | | | | Change-Id: Ia53547b7b42a3ff8848085ab8f8d214259d5cc7b Reviewed-on: https://gerrit.libreoffice.org/61959 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* weld InsertErrorBarsDialog and ErrorBarsTabPageCaolán McNamara2018-10-151-5/+5
| | | | | | | | Change-Id: I3fb2fb4d8010e43e59b4de5c488f137960bc6417 Reviewed-on: https://gerrit.libreoffice.org/61760 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* weld DataLabelsDialog and DataLabelsTabPageCaolán McNamara2018-10-131-3/+3
| | | | | | | | Change-Id: I509d58b2677b5e8f0db476e2650661cb128a5279 Reviewed-on: https://gerrit.libreoffice.org/61723 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* weld SchLegendDlgCaolán McNamara2018-10-041-4/+4
| | | | | | | | Change-Id: Ie57d195782d9fbfdf555205e53e733529b4c1ae8 Reviewed-on: https://gerrit.libreoffice.org/61360 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* weld SchTitleDlgCaolán McNamara2018-10-041-3/+3
| | | | | | | | Change-Id: Ie4537b9b6d856178ae378473fda4a1b27a1ed0b5 Reviewed-on: https://gerrit.libreoffice.org/61356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#42949 Fix IWYU warnings in chart2/source/inc/[l-z]*Gabor Kelemen2018-08-281-0/+3
| | | | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Some only-recently analyzed files were cleaned. Also tried harder to use more fw decls instead of blacklisting Change-Id: Ie4f8eb7065e44a2b5208d6da4fa8e3681a31820b Reviewed-on: https://gerrit.libreoffice.org/59420 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* loplugin:returnconstant in chart2Noel Grandin2018-08-011-3/+2
| | | | | | | Change-Id: If44096ccf8d176023a1b7b8ae722e04417e4c131 Reviewed-on: https://gerrit.libreoffice.org/58425 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Add missing sal/log.hxx headersGabor Kelemen2018-07-091-0/+1
| | | | | | | | | | | | | | | | rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from a* to configmgr Change-Id: I6ea1a7f992b1f835f5bac7a725e1135abee3f85a Reviewed-on: https://gerrit.libreoffice.org/57170 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* tdf#42949 Fix IWYU warnings in chart2/source/controller/inc/[I-V]*Gabor Kelemen2018-06-131-0/+1
| | | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. A bit of fallout management as well. Change-Id: Ie058eac6608d7c6dc2cfb29f1081b6684a4412ac Reviewed-on: https://gerrit.libreoffice.org/55541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* weld SchAxisDlgCaolán McNamara2018-05-211-6/+6
| | | | | | | | Change-Id: I18441b4fc06b69caf12dc73e5042ad2b609a7cc5 Reviewed-on: https://gerrit.libreoffice.org/54620 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* convert remaining WarningBox to weld::MessageDialogCaolán McNamara2018-02-271-1/+0
| | | | Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a
* inline ASSERT_EXCEPTION macro in chart2Noel Grandin2017-11-031-14/+13
| | | | | | | Change-Id: I6bdcde5fd416531e2cdd3c9ec160833f1022247c Reviewed-on: https://gerrit.libreoffice.org/44246 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:includeform: chart2Stephan Bergmann2017-10-231-32/+32
| | | | Change-Id: I5b455c684e7cd689d5160135246f3400363c7d40
* loplugin:checkunusedparamsNoel Grandin2017-08-011-3/+2
| | | | | | | | | the "check for taking address of function" part was generating false+ Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f Reviewed-on: https://gerrit.libreoffice.org/40613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* migrate to boost::gettextCaolán McNamara2017-07-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
* remove unused osl/mutex.hxx includesJochen Nitschke2017-06-181-1/+0
| | | | | | | Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* can drop SCH_RESSTR nowCaolán McNamara2017-05-181-31/+31
| | | | Change-Id: Ic9e82098101cb184faec6b3f7fe4c821f5df3278
* tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock2017-04-251-0/+1
| | | | | | | Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* UNO objects should never hold a VclPtr they dont own on heap ...Bjoern Michaelsen2017-03-241-8/+8
| | | | | | | | | | | ... so admit that the VclPtr that ChartController used to have is really owned by m_xViewWindow, and get fetch that (stack-scoped only) from there. Change-Id: Ib9e2cd20201ebe5019c3607a8c65cb1a9856812f Reviewed-on: https://gerrit.libreoffice.org/35603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
* Drop :: prefix from std in c*/Tor Lillqvist2017-02-151-1/+1
| | | | | | | Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155 Reviewed-on: https://gerrit.libreoffice.org/34324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
* makeAny->Any in basctl..chart2Noel Grandin2017-02-031-6/+6
| | | | | | | Change-Id: Ief1cdffbfc59ab4e35ac945d020772ff84c50d61 Reviewed-on: https://gerrit.libreoffice.org/33867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedfieldsNoel Grandin2016-11-171-8/+6
| | | | | | | Change-Id: Id2dbbf384637223db3d334d95332251832918003 Reviewed-on: https://gerrit.libreoffice.org/30927 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert ActionDescriptionProvider::ActionType to scoped enumNoel Grandin2016-08-301-32/+32
| | | | | | and remove an unused constant Change-Id: I8d46d16d3f575aa416bfc5a965986ee5dfb1f93c
* convert SvxChartRegress to scoped enumNoel Grandin2016-08-251-1/+1
| | | | Change-Id: Ibdaad10c7936a0e53ab61c2016c8c9f3ac278767
* Start tdf#100547 Trendline equation: customize X, Y namesLaurent Balland-Poirier2016-08-161-0/+2
| | | | | | | | | | | | Change trend line UI to add fields: X name and Y name to change "x" and "f(x)" in equation representation Next to be done: save it to ODF file Change-Id: I0680ee1bbfbbb74016ecc858917e10d6790ac63a Reviewed-on: https://gerrit.libreoffice.org/27069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
* chart2: cleanup local var assignmentsJochen Nitschke2016-07-131-1/+0
| | | | | | | | | | | and remove comments about a gcc 3.3 workaround. some comments went obsolete with other commits like 367105e0248c7b80b60b2554d04f5f248b4259b3 Change-Id: I15fff464e2f71a6ade29c141bb17216770f54ced Reviewed-on: https://gerrit.libreoffice.org/27127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* new plugin stylepoliceNoel Grandin2016-04-211-2/+2
| | | | | | | check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
* com::sun::star->css in chart2Noel Grandin2016-03-141-1/+1
| | | | Change-Id: I04320d32d6d5c54e461cfabef58645f8b772bc69
* cleanup some local var declarationsNoel Grandin2015-10-191-5/+5
| | | | | | | found with git grep -nP '(\w+)\s+=\s+\g1\(' | lots-of-hand-filtering Change-Id: I598b0cfa6607823eaef09d95e610e05145c727f7
* chart2: replace for_each with range-based forDaniel Robertson2015-10-081-22/+16
| | | | | | | | | | Replace complex uses of ::std::for_each with a range-based for-loop. Change-Id: I6f3d8488a63a5bed271ab70ad6f024e9869906cc Reviewed-on: https://gerrit.libreoffice.org/19143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
* boost->stdCaolán McNamara2015-09-141-2/+2
| | | | | | | Change-Id: Iff14f69c200217c5d868978e8ffc06962b99ac09 Reviewed-on: https://gerrit.libreoffice.org/18568 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin: defaultparamsNoel Grandin2015-08-141-2/+2
| | | | Change-Id: I65c0ed65b20f606cf1409a3158ff1ef1e2d6cd9f
* cppcheck: noExplicitConstructorCaolán McNamara2015-06-081-1/+1
| | | | Change-Id: I8b03c27188b02c3c4a9a9fbbe0df1fb1ae1c5caf
* convert ScopedVclPtr to ScopedVclPtrInstanceNoel Grandin2015-04-101-1/+1
| | | | Change-Id: I22a9d9c313a81ccee885b9c8785d4b008a6f2058
* Automated conversion of VclPtr construction to use Instance template.Michael Meeks2015-04-101-3/+3
| | | | Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e