summaryrefslogtreecommitdiffstats
path: root/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
Commit message (Collapse)AuthorAgeFilesLines
* tdf#135935 Ensure help page is opened in chart creation Wizard dialogRafael Lima2022-01-221-1/+2
| | | | | | | | | | | | | | | Prior to this patch, if the user opens the Chart Wizard dialog (Insert > Chart) and clicks the Help button without clicking anywhere in the dialog, the help ID was not being applied. This problem happens on kf5 and gen, but not on gtk3. With this patch, the expected behavior is achieved in gtk3, gen and kf5. Change-Id: Ief7852fce00de45f65c21ea0ddc8e4d6477612d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127783 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 67e88d173fb56a2628a5464d56276134bf6f65a2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128681 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#134386 set m_pTemplateProvider before creating any other pagesCaolán McNamara2020-06-291-4/+5
| | | | | | | Change-Id: Icc501b127f92cdbfbf0987af9b0b560f1efbc056 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97404 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* tdf#42949 tdf#119699 Fix IWYU warnings in chart2/Gabor Kelemen2019-11-211-1/+0
| | | | | | | | | | | | | | | | | * Recheck after recent refactorings and improvements in f-u-i * Drop now unused TabPageIds.h * The problem noticed in bug #119699 now seems to be gone too so drop those lines from the blacklist. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I44f26c7370f5328c8f67ac61cd8f0cdb29077f15 Reviewed-on: https://gerrit.libreoffice.org/83182 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* cid#1453998 Wrapper object use after freeCaolán McNamara2019-11-161-3/+4
| | | | | | | | Change-Id: I1dc733e72ba63db1eaa20113a7599ea7580eef31 Reviewed-on: https://gerrit.libreoffice.org/82988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* chart2: Move some headers to incMuhammet Kara2019-11-121-1/+1
| | | | | | | | | | | | So that they will be accessible from inside the sidebar dir. Change-Id: Iaf7b1a800a3b35a5c497d8122f68c97c8cdc9eff Reviewed-on: https://gerrit.libreoffice.org/80922 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82461 Tested-by: Jenkins
* Resolves: tdf#128134 page creation order affecting travelCaolán McNamara2019-10-141-4/+6
| | | | | | | | | | | the page is created before the page is moved to, so CanTravel gets locked. Only lock when the page is the current page Change-Id: Ic21fe3077a750e1279db8be0dd5c7f9112c999b1 Reviewed-on: https://gerrit.libreoffice.org/80779 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* now drop TabPageParent intermediateCaolán McNamara2019-09-261-6/+4
| | | | | | | | Change-Id: I47328f76342ac023628d9042bdfa8213a1c93d0c Reviewed-on: https://gerrit.libreoffice.org/79469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* disinherit OWizardPage and SfxTabPage from vcl TabPageCaolán McNamara2019-09-261-29/+28
| | | | | | | | | | | | | | | | | | Now that there's no need to support weld/unwelded mixes of pages in dialog any more. inherit from a BuilderPage which contains a Builder and Toplevel container BuilderPage Activate and Deactivate replace TabPage ActivatePage and DeactivatePage, allowing disambiguation wrt SfxTabPage ActivatePage and DeactivatePage. Change-Id: I5706e50fd92f712a25328ee9791e054bb9ad9812 Reviewed-on: https://gerrit.libreoffice.org/79317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* inherit from one classCaolán McNamara2019-09-141-0/+2
| | | | | | | | Change-Id: Ia3cb14429a42e445c14cecc20728d59d985f4b5d Reviewed-on: https://gerrit.libreoffice.org/78837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* weld SwMailMergeWizardCaolán McNamara2019-08-231-8/+0
| | | | | | | | Change-Id: I03a7fd1f7676792387155db986d710a001887c8d Reviewed-on: https://gerrit.libreoffice.org/77977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* weld chart CreationWizardCaolán McNamara2019-08-221-21/+30
| | | | | | | | Change-Id: I7ee88c1e1b0eca5c2510a4bbba8b60c0d8a4e3e8 Reviewed-on: https://gerrit.libreoffice.org/77954 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* move RoadmapWizard to vclCaolán McNamara2019-08-171-2/+2
| | | | | | | | Change-Id: Iae2f5e0ac52dcf862035508db3a22cfd86d02d8f Reviewed-on: https://gerrit.libreoffice.org/76903 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* move WizardMachine to vclCaolán McNamara2019-08-161-3/+3
| | | | | | | | Change-Id: I55cc4a6c1ad111a22a43fd66a3cd01b5b02fb7cb Reviewed-on: https://gerrit.libreoffice.org/76902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#42949 Fix IWYU warnings in chart2/source/controller/dialogs/*hxxGabor Kelemen2018-11-091-0/+1
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie6fb9f03f36d71e7b07ef70238d969db65121c8f Reviewed-on: https://gerrit.libreoffice.org/61506 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* loplugin:singlevalfieldsNoel Grandin2018-10-171-5/+4
| | | | | | | | | tighten up the handling of binary operators Change-Id: I262ec57bf7142fa094d240738150a94d83fd15ee Reviewed-on: https://gerrit.libreoffice.org/61777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Revert "loplugin:changetoolsgen in canvas..cui" and reapplyNoel Grandin2018-02-161-1/+1
| | | | | | | | | | | | | because I (a) forgot to insert parentheses which changes the meaning of some expressions and (b) I now use the AdjustFoo calls when changing unary operations, which reads much better This reverts commit f841dada1a5018897cce29ccf972da33ece4738c. Change-Id: Iff19e1fc99812c086b0a39b71a3f67b98e2f9c8f Reviewed-on: https://gerrit.libreoffice.org/49841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:changetoolsgen in canvas..cuiNoel Grandin2018-02-141-1/+1
| | | | | | | Change-Id: I4e320055a3dbe4159c2aa2714e1ee98182e1e80a Reviewed-on: https://gerrit.libreoffice.org/49642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* inline ASSERT_EXCEPTION macro in chart2Noel Grandin2017-11-031-1/+0
| | | | | | | Change-Id: I6bdcde5fd416531e2cdd3c9ec160833f1022247c Reviewed-on: https://gerrit.libreoffice.org/44246 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* vcl: make MapMode constructor explicitMichael Stahl2017-10-261-2/+2
| | | | | | | Insert constructor everywhere, except a couple places that apparently want to compare GetMapUnit(). Change-Id: I1910deb60562e5e949203435e827057f70a3f988
* loplugin:includeform: chart2Stephan Bergmann2017-10-231-5/+5
| | | | Change-Id: I5b455c684e7cd689d5160135246f3400363c7d40
* remove unnecessary use of 'this->'Noel Grandin2017-08-021-4/+4
| | | | | | | Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* de-hrc various thingsCaolán McNamara2017-07-211-1/+1
| | | | | | | | | | | | e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
* migrate to boost::gettextCaolán McNamara2017-07-211-7/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
* can drop SCH_RESSTR nowCaolán McNamara2017-05-181-2/+2
| | | | Change-Id: Ic9e82098101cb184faec6b3f7fe4c821f5df3278
* tdf#83257 [API-CHANGE] Pivot chart implementationTomaž Vajngerl2017-04-041-29/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a squashed commit of the pivot chart implementation. Some of the changes: - Add pivot chart specific (pivot table) data provider which provides the data from a pivot table to the associated chart. - When inserting a chart and the cursor is in a pivot table, in that case insert a pivot chart - Modify the pivot chart when the pivot table changes - Collect and set the number format for the values - isDataFromSpreadsheet check for the creation wizard - In ChartView (and VLegend) check if the data provider is a pivot chart data provider and get the pivot table field names to create the buttons on the UI. - Adds the functionallity to show a filter pop-up (from calc) when clicking on row / column / page field buttons. - Remove (X)PopupRequest as we won't need it. - Add ODF import/export for pivot charts: + Added loext:data-pilot-source attribute on chart:chart which is the internal name of the pivot table with which the pivot chart is associated with. If the element is present, then the it means the chart is a pivot chart, else it is a normal chart + Added service to create pivot chart data provider through UNO + Add new methods to XPivotChartDataProvider to create value and label data sequences separately from the data source, which is needed for pivot chart import + When importing defer setting the data provider until a later time when we know if we are creating a chart od a pivot chart - Pivot chart ODF round-trip test - Add table pivot chart supplier API: This adds the XTablePivotChartSupplier and related interfaces so we can access, create, delete pivot charts from UNO in a sheet document. With this we now distinguish between normal charts and pivot charts. This was mainly needed because we can't extend the "published" interfaces of TableChartSupplier. - Added an extensive test, which uses the API to create a new pivot chart when there was none, and checks that the pivot chart updates when the pivot table updates. Change-Id: Ia9ed96fd6b1d342e61c2f7f9fa33a5e03dda21af Reviewed-on: https://gerrit.libreoffice.org/36023 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
* m_bDoLiveUpdate is always trueTamás Zolnai2017-01-051-1/+1
| | | | Change-Id: I169027a02bd4e0e5c2e0011e6aca4d6063547ca0
* Remove useless explicit bool conversionTamás Zolnai2017-01-051-2/+2
| | | | Change-Id: I81caa89fe2ebfb88ce4eb36b8edb9460e9aca9c8
* convert MapUnit to scoped enumNoel Grandin2016-10-051-2/+2
| | | | | | | | | | | | I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constantparam in svtoolsNoel Grandin2016-09-091-3/+1
| | | | | | | Change-Id: I04caae0c9ae621c55e16d3bdc014a4729617feb3 Reviewed-on: https://gerrit.libreoffice.org/28757 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#95416 remove ../ style includeJochen Nitschke2016-08-261-0/+2
| | | | | | | | | move (default) dtors to source files, where members are complete Change-Id: I9f3273d322b62cb01e546ff30d9fb4d37747bb3b Reviewed-on: https://gerrit.libreoffice.org/28400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* loplugin:singlevalfields in chart2Noel Grandin2016-06-281-3/+1
| | | | | | | Change-Id: I8b8bf093736a191c90d765dce82b00e15bb398d6 Reviewed-on: https://gerrit.libreoffice.org/26708 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* -Werror,-WvarargsStephan Bergmann2016-04-271-3/+2
| | | | | | | | | "passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]" just drop the variadic overload and use the one taking a WizardPath (i.e., a vector) Change-Id: I6e389f60f8b7cb0633bf173bde69af1c5af86048
* loplugin:constantparamNoel Grandin2016-04-111-22/+4
| | | | Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
* loplugin:unusedfields in chart2Noel Grandin2015-12-231-1/+1
| | | | Change-Id: I8203f84ad8b138932c990032e17ea5d2daf384bb
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-101-1/+1
| | | | Change-Id: I71de514405bb9bcc746c1ab9633e7fe659888943
* convert WZB_ constants to scoped enumNoel Grandin2015-04-291-6/+6
| | | | Change-Id: If2f12ea54b57f32df23fc22fb8be0aa3c6f2e76e
* dbaccess: convert new to ::Create.Michael Meeks2015-04-201-2/+2
| | | | | | Also convert svtools' WizardShell::createPage. Change-Id: I09bd40ef4748aa2de7b49eeefc95be06b545ea05
* chart2: convert new to ::Create.Michael Meeks2015-04-171-4/+4
| | | | Change-Id: I14887bab5ced6e5915a8ecbc277017cec37a82ca
* vcl: VclPtr conversion in chart2Noel Grandin2015-04-091-4/+0
| | | | Change-Id: Iae82331e812836ff4c97617227d316bfe15b23df
* V668 no sense in testing the result of new against nullCaolán McNamara2015-03-111-1/+1
| | | | Change-Id: I7783d96e40de7a8df794f143d2c7830bf3314218
* fdo#82577: Handle WindowNoel Grandin2014-09-231-1/+1
| | | | | | | Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
* drop FixedLines from wizards to be consistent with the rest of the uiCaolán McNamara2014-08-151-1/+0
| | | | | | and two virtual methods don't need to exist after that Change-Id: I50ea8eaa99fddfed7e0c61e99e76631aa595f2dc
* drop DLG_CHART_WIZARD via .resCaolán McNamara2014-07-231-7/+8
| | | | Change-Id: I394a42bfb761e2f7cf8c3186f5ec412331b5950c
* remove whitespacesMarkus Mohrhard2014-07-021-1/+0
| | | | Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
* loplugin: inlinesimplememberfunctionsNoel Grandin2014-06-091-5/+0
| | | | Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
* Replace auto_ptr with boost::scoped_ptr.Kohei Yoshida2014-05-121-6/+5
| | | | Change-Id: Ibc6d532eff59146d8fbe7dcc7f9155ce6119f474
* svtools: sal_Bool->boolNoel Grandin2014-03-251-2/+2
| | | | Change-Id: I42a341b5805e0b2a7d619ba552700db35815afd5
* svtools: sal_Bool->boolNoel Grandin2014-03-251-1/+1
| | | | Change-Id: Ia0280d3d4f2d5b8a93a37a93847951391e928028
* convert remnants of String to CHART2 module to OUStringNoel Grandin2013-10-011-1/+1
| | | | Change-Id: I799d7ff1d9e8a72b1e68e53aa7d9ef21a2d299b1
* convert include/svtools/roadmapwizard.hxx from String to OUStringNoel Grandin2013-08-151-1/+1
| | | | Change-Id: I1b5a0c3f5946aac9d353550091616cf5a31e6f82