summaryrefslogtreecommitdiffstats
path: root/canvas
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:checkunusedparams variousNoel Grandin2017-05-161-1/+1
| | | | | | | Change-Id: I5d1cc807134230d86e0226a12fada204004312d3 Reviewed-on: https://gerrit.libreoffice.org/37675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* cleanup osl/diagnose.h includesJochen Nitschke2017-05-091-1/+0
| | | | | | | | | | | | | | with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* revert OSL_ASSERT changesChris Sherlock2017-05-072-2/+2
| | | | Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
* tdf#43157: convert most of canvas codebase away from OSL_ASSERT to assertChris Sherlock2017-05-072-2/+2
| | | | Change-Id: Ie6a5942dcac62a0bc3b589ff0b82922b313f88a8
* gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2017-04-218-8/+0
| | | | | | | | | Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
* loplugin:redundantinline (clang-cl)Stephan Bergmann2017-04-041-1/+1
| | | | | | | Change-Id: I03a19b599005f6ef25040889a1e1802445ebf430 Reviewed-on: https://gerrit.libreoffice.org/36063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna2017-03-313-13/+13
| | | | | | | | | | | | | | | Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* Fix typosAndrea Gelmini2017-03-252-2/+2
| | | | | | | Change-Id: If92860597a44ee79b513d255ce3f21112485a97e Reviewed-on: https://gerrit.libreoffice.org/35617 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Remove unused #include <ctype.h>Stephan Bergmann2017-03-233-6/+0
| | | | Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
* Remove unused #include <cctype>Stephan Bergmann2017-03-236-10/+0
| | | | Change-Id: I9c61e1b558104fa55d887a6c32e1ef2b03f1d1a0
* loplugins:redundantcast teach it about c-style typedef castsNoel Grandin2017-03-231-2/+1
| | | | | | | Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* ofz#887 support avoiding reading configCaolán McNamara2017-03-172-60/+65
| | | | Change-Id: Ic7e0e65b15c7b6a01a10d6004230ad71a2d439d2
* vcl: OutputDevice::GetGlyphBoundRects()'s nIndex and nBase is always the sameMiklos Vajna2017-03-171-1/+0
| | | | | | | | | So keeping just nIndex is enough. Change-Id: I5d3a0e6b4a6ce1305a56cf50e7ff181a098f6412 Reviewed-on: https://gerrit.libreoffice.org/35336 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* loplugin:unoany (clang-cl)Stephan Bergmann2017-03-141-4/+4
| | | | Change-Id: I14351561764811562a2c2904b6f7db6148e55c9b
* Fix typosAndrea Gelmini2017-03-031-1/+1
| | | | | | | Change-Id: I4f16ba5fc32cbfd6a5b01e495f3ad905da193524 Reviewed-on: https://gerrit.libreoffice.org/34808 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* new loplugin unoanyNoel Grandin2017-02-282-4/+4
| | | | | | | Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:loopvartoosmallStephan Bergmann2017-02-261-13/+13
| | | | Change-Id: I4dce711021557e6e0b1fb661285d32292b0478b6
* drop ModulationMode enumNoel Grandin2017-02-175-172/+35
| | | | | | since we only ever use the MODULE_NONE enumerator Change-Id: Icd075bb01b5938dbd75b901521d084ddd6469963
* drop cairocanvas::ColorType enumNoel Grandin2017-02-171-45/+13
| | | | | | since we only use the one enumerator value Change-Id: Ifec39f4845348c753a6207795c62b27a7af1bbcd
* Drop :: prefix from std in c*/Tor Lillqvist2017-02-1529-110/+110
| | | | | | | Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155 Reviewed-on: https://gerrit.libreoffice.org/34324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
* Fix typosAndrea Gelmini2017-02-131-1/+1
| | | | | | | Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c Reviewed-on: https://gerrit.libreoffice.org/34199 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
* loplugin:unusedenumconstants read-only constants in vclNoel Grandin2017-02-081-4/+0
| | | | | | | Change-Id: I8c81444cbecdc103cc47d9a4133b0b4d9010e0c2 Reviewed-on: https://gerrit.libreoffice.org/34018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* makeAny->Any in canvas..configmgrNoel Grandin2017-02-0310-18/+18
| | | | | | | Change-Id: Id06812595f373cd0da8b421dbac34a60a266ae6e Reviewed-on: https://gerrit.libreoffice.org/33869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#105620: Probably better to not ignore initial x0 and y0Tor Lillqvist2017-02-011-2/+2
| | | | | | | So add to them instead of just assigning. In the bugdoc the initial values were zero, but maybe in some other cases they aren't. Change-Id: I3d399fe4aab9260817f171d4e69388a19eb85d21
* tdf#105620: Fix placement of image embedded in graphicTor Lillqvist2017-02-011-0/+6
| | | | | | | Change-Id: I419e44d72f594fab0774152720f55c1d7d5366e6 Reviewed-on: https://gerrit.libreoffice.org/33723 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
* more SAL_WARN_UNUSEDNoel Grandin2017-01-312-9/+0
| | | | Change-Id: Idf44fe0302b4504c443f083e527b63b2461ada85
* teach lolugin:stringconstant about calling constructorsNoel Grandin2017-01-311-2/+2
| | | | | | | | | | | so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Drop meaningless forward declarationTor Lillqvist2017-01-301-2/+0
| | | | Change-Id: I29e09ad50e8adb2c5dd99014872be9c3f0fdcdbd
* loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin2017-01-281-3/+1
| | | | | | | | | ..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix comments to match realityTor Lillqvist2017-01-272-2/+2
| | | | Change-Id: I99b49a3c8472b063316baeebdaa89119832a2a1b
* Remove dynamic exception specificationsStephan Bergmann2017-01-2650-499/+452
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#100151: Dispose of window if DX device creation failedAron Budea2017-01-231-8/+11
| | | | | | | | | | | | | | | Before, if the device lacked Direct3D capabilities, VclPtr handling became compromised, and caused a crash. This was particularly a problem in virtualized/remote desktop connections in Windows. Now mpWindow instance is disposed of right away if DX device creation fails. Change-Id: I639340380affdb31a93ce6dccd8df33a0a466df6 Reviewed-on: https://gerrit.libreoffice.org/33413 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
* loplugin:externvar (clang-cl)Stephan Bergmann2017-01-112-3/+3
| | | | Change-Id: Ied0ee5f637e83fe7819c68e3f4ea4634f21ac3f6
* New loplugin:externvar: canvasStephan Bergmann2017-01-093-5/+5
| | | | Change-Id: If11977a086dd7bd7d76782577db619fd272e814c
* loplugin:salboolStephan Bergmann2017-01-061-1/+1
| | | | Change-Id: I7dfd48a04e2dff1391d10acb75180711b403af9b
* This fallback code makes no sense any moreKhaled Hosny2016-12-142-2/+0
| | | | | | | | | | | | Ito probably made sense only with bitmap fonts which we no longer support, and if we don’t need the fallback for printer devices then we don’t need it on screen either (that whole printer/screen distinction needs to die someday). Change-Id: Icf77cd70f0f1b2c186a3c856900295caba72e903 Reviewed-on: https://gerrit.libreoffice.org/31914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
* post glew->epoxy, we don't need to link to win openg32 and mac OpenGLCaolán McNamara2016-12-131-15/+0
| | | | | | | Change-Id: Iadc373961dcca788b1174ee71cb386979ce064ed Reviewed-on: https://gerrit.libreoffice.org/31954 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* change from glew to epoxyCaolán McNamara2016-12-137-13/+7
| | | | | | | | | | because that works under wayland out of the box and gtk3 uses it already Change-Id: Iefaac31e325534a81a5389f752804af917c1baef Reviewed-on: https://gerrit.libreoffice.org/31213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* OSL_TRACE->SAL in avmedia..canvasNoel Grandin2016-12-132-9/+0
| | | | Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9
* remove useless Mutex guardsNoel Grandin2016-12-122-12/+0
| | | | | | | Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51 Reviewed-on: https://gerrit.libreoffice.org/31875 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* canvas: remove useless MutexGuardsArnaud Versini2016-12-118-110/+0
| | | | | | | Change-Id: I7a6f55ad7f3a26a88263660b97dd8650858890f8 Reviewed-on: https://gerrit.libreoffice.org/31859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* canvas: try to fix Android buildMichael Stahl2016-12-071-1/+1
| | | | Change-Id: If90e026bb6f606ea448ff853d944c9bda7f1938a
* convert PolyFlags to scoped enumNoel Grandin2016-12-071-4/+4
| | | | | | | | | | and remove the XPolyFlags enum, which has the same values and was being converted to PolyFlags anyhow Change-Id: Iaead84933c79a7603698a4e50257dd944df89c41 Reviewed-on: https://gerrit.libreoffice.org/31627 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:vclwidgetsStephan Bergmann2016-11-111-1/+1
| | | | Change-Id: Iead7373a76b086dbd96d1d9d4643247762d0522f
* loplugin:expandablemethods in avmedia..canvasNoel Grandin2016-11-111-9/+4
| | | | | | | Change-Id: Ic230f1ef6b1dbe796ac7862a1a7e6a718f9e4e54 Reviewed-on: https://gerrit.libreoffice.org/30753 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* update vclwidget loplugin to find ref-dropping assigmentNoel Grandin2016-11-114-4/+4
| | | | | | | | | | Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* make comphelper::sequenceToContainer a little smarterNoel Grandin2016-11-101-1/+1
| | | | | | | | | so we don't have to specify the source type Change-Id: I4106705a39874a8043f0f294a11374404d6cfc3a Reviewed-on: https://gerrit.libreoffice.org/30713 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:expandablemethodds in include/basic..comphelperNoel Grandin2016-10-211-1/+1
| | | | | | | Change-Id: I1aa9c12e8839325a9fd98530abc89a3d586ff62e Reviewed-on: https://gerrit.libreoffice.org/30120 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-cl loplugin: canvasStephan Bergmann2016-10-1628-245/+217
| | | | | | | Change-Id: I3e4f9ccbe608a98759f2a9e312839eb909e6b575 Reviewed-on: https://gerrit.libreoffice.org/29878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Resolves: tdf#103026 invalid dash causes CAIRO_STATUS_INVALID_DASH stateCaolán McNamara2016-10-061-1/+4
| | | | Change-Id: I072635ff7c67022ebfd5bdb475e390f3aab7a51c