summaryrefslogtreecommitdiffstats
path: root/canvas
Commit message (Collapse)AuthorAgeFilesLines
* This fallback code makes no sense any moreKhaled Hosny2016-12-142-2/+0
| | | | | | | | | | | | Ito probably made sense only with bitmap fonts which we no longer support, and if we don’t need the fallback for printer devices then we don’t need it on screen either (that whole printer/screen distinction needs to die someday). Change-Id: Icf77cd70f0f1b2c186a3c856900295caba72e903 Reviewed-on: https://gerrit.libreoffice.org/31914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
* post glew->epoxy, we don't need to link to win openg32 and mac OpenGLCaolán McNamara2016-12-131-15/+0
| | | | | | | Change-Id: Iadc373961dcca788b1174ee71cb386979ce064ed Reviewed-on: https://gerrit.libreoffice.org/31954 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* change from glew to epoxyCaolán McNamara2016-12-137-13/+7
| | | | | | | | | | because that works under wayland out of the box and gtk3 uses it already Change-Id: Iefaac31e325534a81a5389f752804af917c1baef Reviewed-on: https://gerrit.libreoffice.org/31213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* OSL_TRACE->SAL in avmedia..canvasNoel Grandin2016-12-132-9/+0
| | | | Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9
* remove useless Mutex guardsNoel Grandin2016-12-122-12/+0
| | | | | | | Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51 Reviewed-on: https://gerrit.libreoffice.org/31875 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* canvas: remove useless MutexGuardsArnaud Versini2016-12-118-110/+0
| | | | | | | Change-Id: I7a6f55ad7f3a26a88263660b97dd8650858890f8 Reviewed-on: https://gerrit.libreoffice.org/31859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* canvas: try to fix Android buildMichael Stahl2016-12-071-1/+1
| | | | Change-Id: If90e026bb6f606ea448ff853d944c9bda7f1938a
* convert PolyFlags to scoped enumNoel Grandin2016-12-071-4/+4
| | | | | | | | | | and remove the XPolyFlags enum, which has the same values and was being converted to PolyFlags anyhow Change-Id: Iaead84933c79a7603698a4e50257dd944df89c41 Reviewed-on: https://gerrit.libreoffice.org/31627 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:vclwidgetsStephan Bergmann2016-11-111-1/+1
| | | | Change-Id: Iead7373a76b086dbd96d1d9d4643247762d0522f
* loplugin:expandablemethods in avmedia..canvasNoel Grandin2016-11-111-9/+4
| | | | | | | Change-Id: Ic230f1ef6b1dbe796ac7862a1a7e6a718f9e4e54 Reviewed-on: https://gerrit.libreoffice.org/30753 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* update vclwidget loplugin to find ref-dropping assigmentNoel Grandin2016-11-114-4/+4
| | | | | | | | | | Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* make comphelper::sequenceToContainer a little smarterNoel Grandin2016-11-101-1/+1
| | | | | | | | | so we don't have to specify the source type Change-Id: I4106705a39874a8043f0f294a11374404d6cfc3a Reviewed-on: https://gerrit.libreoffice.org/30713 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:expandablemethodds in include/basic..comphelperNoel Grandin2016-10-211-1/+1
| | | | | | | Change-Id: I1aa9c12e8839325a9fd98530abc89a3d586ff62e Reviewed-on: https://gerrit.libreoffice.org/30120 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-cl loplugin: canvasStephan Bergmann2016-10-1628-245/+217
| | | | | | | Change-Id: I3e4f9ccbe608a98759f2a9e312839eb909e6b575 Reviewed-on: https://gerrit.libreoffice.org/29878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Resolves: tdf#103026 invalid dash causes CAIRO_STATUS_INVALID_DASH stateCaolán McNamara2016-10-061-1/+4
| | | | Change-Id: I072635ff7c67022ebfd5bdb475e390f3aab7a51c
* use a vector here instead of manual mem managementCaolán McNamara2016-10-061-6/+5
| | | | Change-Id: Ic0944837bc49f4a0e86f67bcb5dccc8c1854a396
* convert MapUnit to scoped enumNoel Grandin2016-10-053-6/+6
| | | | | | | | | | | | I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedmethods unused returnsNoel Grandin2016-09-223-6/+0
| | | | | | | Change-Id: I4da3374e31d3c7407b401d66275da7f56ae83d30 Reviewed-on: https://gerrit.libreoffice.org/29178 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl2016-09-152-96/+96
| | | | | | | | ... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
* loplugin:constantparamNoel Grandin2016-09-142-6/+3
| | | | | | | | | | clean up the plugin a little, and try to catch params which are default constructed, which doesn't seem to be working yet Change-Id: Ife45f18502a45cd26306424b7432c55fcbb0fd12 Reviewed-on: https://gerrit.libreoffice.org/28861 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#88205 use list ctor for uno::Sequence a11y to canvasJochen Nitschke2016-09-141-6/+3
| | | | | | | Change-Id: Ib719c94c0488b8a48fdb013bc8fbd1a988595d18 Reviewed-on: https://gerrit.libreoffice.org/28866 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constantparam in chart2..connectivityNoel Grandin2016-09-143-8/+5
| | | | | | | Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d Reviewed-on: https://gerrit.libreoffice.org/28834 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-138-8/+8
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* put StreamMode masks in scope of enum classJochen Nitschke2016-08-273-3/+3
| | | | | | | | Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#96505 get rid of long integer literals 'L'Asela Dasanayaka2016-08-243-12/+12
| | | | | | | | | Remove L from integer literals in module canvas all 0L, 1L, 2L , 7L and 8L Change-Id: Idd41a31857b4bb58ed8e7b6f4e727a73806098b1 Reviewed-on: https://gerrit.libreoffice.org/27817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
* Related: tdf#86473 git rid of special pixel snapping for rectanglesCaolán McNamara2016-08-211-22/+1
| | | | Change-Id: Ia9ab5c58975df2de8c261d92a866cbe264d03205
* Resolves: tdf#86473 approx 1 pixel high rectangular polygon not drawnCaolán McNamara2016-08-201-1/+21
| | | | | | | | | The other implementations of basically this in vcl/headless/svpgdi.cxx:AddPolygonToPath and vcl/quartz/salgdicommon.cxx:AddPolygonToPath hook this rounding foo off getAntiAliasB2DDraw FWIW Change-Id: Ideec049ec6ca04105721bf8acda44c31b2a73215
* loplugin:countusersofdefaultparams in canvas,chart2Noel Grandin2016-08-0510-12/+12
| | | | | | | Change-Id: Id66a706171b73affeb508812744028d9f30133af Reviewed-on: https://gerrit.libreoffice.org/27868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMuhammet Kara2016-08-0415-44/+15
| | | | | | | | | in basctl, basegfx, canvas Change-Id: I59383d2599793b99b560333387e163a3d80eecec Reviewed-on: https://gerrit.libreoffice.org/27778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#100726: Improve readability of OUString concatenationnadith2016-08-011-3/+1
| | | | | | | | | this bug fixed in the modules between canvas - cppu Change-Id: I2022b022897dafde20251352376e3facdb9b8d75 Reviewed-on: https://gerrit.libreoffice.org/27663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#101026 Create more correct replacement control vectorArmin Le Grand2016-07-281-5/+7
| | | | | | | | Change-Id: I909adaab3dca3c1bac4331b164343cdbc1205df2 Reviewed-on: https://gerrit.libreoffice.org/27365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
* improve passstuffbyref return analysisNoel Grandin2016-07-272-4/+4
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin2016-07-048-16/+16
| | | | | | | | | convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* update other places that read data from cairo image surfaceDavid Tardon2016-06-281-0/+7
| | | | Change-Id: Icb8761e5ff89e1c0e0e034a751fe9a50ad5ab90a
* Simplify some PutProperties callsStephan Bergmann2016-06-281-5/+1
| | | | Change-Id: Idf91592e6cf34b5591f221c3c5bdc937bbe46014
* tdf#96099 Remove various smart pointer typedefs in canvasMark Page2016-06-0916-42/+42
| | | | | | | Change-Id: Ied6ec5f7830c53a339de985d173c1dec711ac8f7 Reviewed-on: https://gerrit.libreoffice.org/26092 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Convert ComplexTextLayoutMode to scoped enumNoel Grandin2016-06-034-22/+22
| | | | | | | Change-Id: I257f8e15fec92f0701235a6fe4b6a2272498c4f1 Reviewed-on: https://gerrit.libreoffice.org/25667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:constantparamsNoel Grandin2016-06-0310-20/+15
| | | | | | | Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361 Reviewed-on: https://gerrit.libreoffice.org/25769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* canvas: error C2397: conversion from 'size_t' to 'BYTE' requires ...Michael Stahl2016-05-261-1/+2
| | | | | | | a narrowing conversion (at least other people's MSVC says so, mine doesn't complain) Change-Id: Ic87da76567778884b81361067075fd9325e2d276
* canvas: replace BOOST_PP usageMichael Stahl2016-05-251-17/+11
| | | | Change-Id: I46bb4aba6c08fb753b22242069ef0b00d4c77f12
* Convert BMP_FORMAT to scoped enumNoel Grandin2016-05-254-69/+69
| | | | | | | Change-Id: I751ab762b6e6f961e9e73a8a2ca92a3f5a5eb1c8 Reviewed-on: https://gerrit.libreoffice.org/25189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Resolve: "TODO(Q1): Make GetSystemData method virtual"Caolán McNamara2016-05-193-3/+3
| | | | | | | | | and remove the casting silliness, allowing the removal of cairo_cairo.?xx If anything is to go wrong I'd guess it'll be the windows directx stuff. Change-Id: I3e22c07b9c26ade9b27a245fdd8408de540643f4
* rename to two GetSystemData methods to find all call-sitesCaolán McNamara2016-05-193-3/+3
| | | | | | | | | | | | | | | anyplace calling GetSystemChildSystemData on a SystemChildWindow is definitely right anyplace calling GetWindowSystemData on a Window *might* have intended to call GetSystemChildSystemData on a Window casted back to an underlying SystemChildWindow. Change-Id: I7dcf3a50d0b7ed29bc08cfdb15cc0dcb86be8fa7 Reviewed-on: https://gerrit.libreoffice.org/25158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* clang-tidy modernize-make-sharedNoel Grandin2016-05-181-3/+2
| | | | | | | Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove various crutches for boost::bind/boost::mem_fnMichael Stahl2016-05-131-5/+0
| | | | | | | | | | These aren't used any more, and the C++11 std equivalents don't use get_pointer() overloads. Change-Id: Ib97a6a595863e21a1621c63709ea2b28f6550fde Reviewed-on: https://gerrit.libreoffice.org/24982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* convert EXCEPTION_ to scoped enumNoel Grandin2016-05-131-5/+4
| | | | | | | | | | | | - simplify VCLExceptionSignal_impl - drop "minor" part of error code, nobody passes it in, and nobody checks it - rename Display to UserInterface, to prevent -Werror=shadow Change-Id: I503fd8a50ded30d59c30fb388796f6b1a0c058de Reviewed-on: https://gerrit.libreoffice.org/24892 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann2016-05-103-3/+3
| | | | | | | | | | | | | | | | ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
* teach stylepolice plugin about ref-counted-pointer namingNoel Grandin2016-04-282-6/+6
| | | | | | | Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#48066 render stroke-miterlimit correctly in SVG importRegina Henschel2016-04-262-6/+19
| | | | | | | | | | | | | | | | | | The property stroke-miterlimit is transported to the renderers via a new member mfMiterMinimumAngle in class LineAttribute Several drawPolyLine methods are adapted. This patch does not include changes in MetaAction. Presentation mode, printing, and PDF-export is still wrong. Corrected LineJoinMiter to LineJoinBevel in canvas, that s closer to NONE. Removed DrawPolyLine method without MiterMinimumAngle and adapted calls accordingly. Change-Id: I6bcd24add5d85c4d9a39e3788e0682091c5fc9c4 Reviewed-on: https://gerrit.libreoffice.org/23946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
* Fix typosAndrea Gelmini2016-04-221-1/+1
| | | | | | | Change-Id: Iea11112a1bf1ff934de0e355b9e81979aa1966a3 Reviewed-on: https://gerrit.libreoffice.org/24286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>