summaryrefslogtreecommitdiffstats
path: root/basic
Commit message (Collapse)AuthorAgeFilesLines
* Adapt to true wchar_t in clang-clStephan Bergmann2015-11-281-1/+5
| | | | Change-Id: I215b8215108a268f969106db6f01f876bd0dc0a0
* #i117960# Basic: Line Input doesn't work in single-line IfDamjan Jovanovic2015-11-251-1/+2
| | | | | | | | | | | | i92642 added the ability to use certain keywords as variable names (eg. name = 1, line = "hi"), but also caused a regression where "Line Input" is broken in single-line If statements. This patch fixes that by allowing Then and Else to also be the start-of-line tokens expected to immediately preceed the "Line" token in order for that "Line" token to be recognized a keyword instead of a variable name. Also added FVT spreadsheet tests for "Line" as both a variable name and as "Line Input". Patch by: me (cherry picked from commit f8a51d0f5a645704bc2bdc939474ac931d55559c)
* loplugin:unusedfields variousNoel Grandin2015-11-251-7/+0
| | | | Change-Id: I59d9f7f73677358b4ae57efda965d43718bdf0d5
* use comphelper::containerToSequenceNoel Grandin2015-11-191-4/+2
| | | | | | in chart2, we remove a local equivalent of the method Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
* remove unused typedefs and inline use-once typedefsNoel Grandin2015-11-181-4/+3
| | | | | | | | | and improve the script a little Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84 Reviewed-on: https://gerrit.libreoffice.org/20033 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:unnecessaryvirtualNoel Grandin2015-11-174-36/+3
| | | | | | | | | | update the plugin with lessons learned from the mergeclasses plugin and re-run it Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711 Reviewed-on: https://gerrit.libreoffice.org/20015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Fast PCH generator and optimized PCH filesAshod Nakashian2015-11-151-47/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* 5th step to remove tools/rtti.hxxOliver Specht2015-11-1117-56/+0
| | | | | | | | | | | tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
* new loplugin: memoryvarNoel Grandin2015-11-112-11/+11
| | | | | | | | | | detect when we can convert a new/delete sequence on a local variable to use std::unique_ptr Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc Reviewed-on: https://gerrit.libreoffice.org/19884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Resolves: #i61854# Basic: Default title of Msgboxes should be changedDamjan Jovanovic2015-11-101-1/+1
| | | | | | | | | | Found by: berend dot cornelius at germany dot sun dot com Patch by: Pathangi Janardhanan Jatinshravan <JATINSHR001 at e dot ntu dot edu dot sg> Review by: Damjan Jovanovic (cherry picked from commit 519770a2b47d4bb95a7616cedcc1582ae83ab205) Change-Id: I61c9eacd285c8335925f1569b64bb2d600caf545
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-1058-938/+938
| | | | Change-Id: I1ec9a671fe3ac838feb36297915e3cdf8749d944
* new loplugin: oncevarNoel Grandin2015-11-093-9/+4
| | | | | | | Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann2015-11-0615-82/+82
| | | | Change-Id: I9979100550a86ac3f42d74a5403fb3ffd9d5006b
* Resolves: #i61277# Basic open file with random access erases all data.Damjan Jovanovic2015-11-041-1/+1
| | | | | | | | | | | | | StarBasic tries to emulate truncation of files opened for writing by deleting them before opening them (if they exist). However there are exclusion to the truncation behaviour when the file is opened in append mode or is a binary file. Another exclusion - that was missing with disasterous consequences - is that the file should not be truncated when opened in random access mode. (cherry picked from commit 72b2f07ccac7578ef36fc2b92dcba49abe397ebc) Change-Id: Ic0053039ce5fd67ad42bf5332ae301d83f1a158d
* yyyyyNoel Grandin2015-11-046-13/+13
| | | | Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
* tdf#94269: Replace "n" prefix for bool variables with "b"Benjamin Ni2015-11-025-27/+27
| | | | | Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797 Signed-off-by: Michael Stahl <mstahl@redhat.com>
* UNO: no need to use OUString constructor when calling createInstanceNoel Grandin2015-10-302-7/+5
| | | | | | | Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* use uno::Reference::set method instead of assignmentNoel Grandin2015-10-304-14/+11
| | | | Change-Id: I58410209f32f988f258a588364e0b037c2790211
* basic: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl2015-10-262-19/+20
| | | | Change-Id: I98c4ac860fbdb55a61f9be0e9d2d5f29fb849e05
* basic: replace boot::ptr_vector with std::vectorMichael Stahl2015-10-262-5/+6
| | | | Change-Id: I4967ad8345cd74c39edbea1df513978b62996b90
* basic: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl2015-10-261-41/+41
| | | | Change-Id: I0bd3a5182d62432a8f0caf4bbae11bbce56a363c
* basic: replace boost::ptr_vector with std::vector<std::unqiue_ptr>Michael Stahl2015-10-262-15/+20
| | | | Change-Id: Ieba2fb34e0279871d36b4fe80d9de76e614b5cde
* loplugin:defaultparamsStephan Bergmann2015-10-202-2/+2
| | | | Change-Id: I5a3852f85f20543165e174da9cd9a36da9a3df8d
* loplugin:defaultparamsStephan Bergmann2015-10-191-1/+1
| | | | Change-Id: Ib0f01af2c7a7186d138369c177a563b322a87214
* calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin2015-10-151-1/+1
| | | | | | | | | | | | the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
* Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-1222-323/+323
| | | | Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
* Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-123-7/+7
| | | | Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
* cppcheck:variableScopeNoel Grandin2015-10-121-11/+9
| | | | | | | Change-Id: I037feb335499629300309851dcda3bb661f03d4f Reviewed-on: https://gerrit.libreoffice.org/19316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Reduce variable scopeStephan Bergmann2015-10-071-2/+1
| | | | Change-Id: I87850db982f413b328976e043d8386b7577ba17c
* Related: tdf#94814 some cleanup of static_cast following dynamic_castCaolán McNamara2015-10-064-58/+42
| | | | | | to the same type Change-Id: I197e88acbc30f8e8bb9e7f2d54803971df6062af
* clang-analyzer-deadcode.DeadStoresStephan Bergmann2015-10-061-2/+12
| | | | Change-Id: I03769bd4105e4e1d140b2885978ea9da9ef866de
* clang-analyzer-deadcode.DeadStoresStephan Bergmann2015-10-061-2/+1
| | | | Change-Id: Ib26cbbc839040c49288606f588cb7400d7e40b83
* clang-analyzer-deadcode.DeadStoresStephan Bergmann2015-10-061-1/+0
| | | | Change-Id: I2ef946572a61eb766454d2df0cb2ff523050ed7e
* tdf#94559: 4th step to remove rtti.hxxOliver Specht2015-10-067-22/+22
| | | | | | | | | | replaced use of PTR_CAST, IS_TYPE, ISA in idl, editeng, sc, sd, sw, sfx2, sot, starmath Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653 Reviewed-on: https://gerrit.libreoffice.org/19132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
* checkUnoObjectType etc always deref their ptr arg, convert to refCaolán McNamara2015-10-023-47/+44
| | | | Change-Id: Iabdb057fb2dc05cfb8c98864dc5109360b50633a
* Fix typosAndrea Gelmini2015-10-025-18/+18
| | | | | | | Change-Id: I776c517ba87838c0c3391f79010a30fa7fe2abd3 Reviewed-on: https://gerrit.libreoffice.org/18939 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* tdf#94617 allow to store nStart information greater than sal_Int16 limitLaurent Godard2015-10-012-6/+41
| | | | | | | | | | | | | | | | | | - preserve backward compatibility - nDebugFlag is stored but not used when loaded - Flag nDebugFlag set the top bit to 1 - stores the multiplier of sal_Int16 limit to reach nStart - in load, test this flag bit - rebuild correct nStart - new B_CURVERSION file format for binary storage macro - unit test for big modules Reviewed-on: https://gerrit.libreoffice.org/18926 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit db17079fcff6f9a068c499b17f2501cc4c82d10b) Change-Id: Iaa037982d828fef7195615e6eda546b7199a4fe8
* coverity#1325250 Unchecked dynamic_castCaolán McNamara2015-10-011-4/+3
| | | | Change-Id: Id52cad11d2ca4ef42a31c0905ee123ccd53e0677
* coverity#1325255 Unchecked dynamic_castCaolán McNamara2015-10-011-5/+4
| | | | Change-Id: Ie1a6b231e0313d1c00ffb9ab0137af2beeb05e02
* loplugin:unusedmethodsNoel Grandin2015-10-014-48/+12
| | | | | | | | | | | | - improvements to the plugin to find more method calls - improvements to python script to remove more false+ - fix the FORCE_COMPILE_ALL build flag to include code in the $WORKDIR Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836 Reviewed-on: https://gerrit.libreoffice.org/19064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Fix typosAndrea Gelmini2015-09-305-5/+5
| | | | | | | Change-Id: Ie0e941d48457d758525353d6c5cf858652f86fd3 Reviewed-on: https://gerrit.libreoffice.org/18938 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Renamed wrongly prefixed boolean variablesStefan Heinemann2015-09-291-6/+6
| | | | | | | | | Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* loplugin:removeunusedmethods, remove unused stuffNoel Grandin2015-09-292-10/+0
| | | | Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
* remove unused #include <sal/alloca.h>Michael Stahl2015-09-291-2/+0
| | | | Change-Id: I490841fd2c526e4ca6d6c94cc7b9dba318c932a1
* basic: more plausible build fix than e5a8eb9eMichael Stahl2015-09-291-1/+1
| | | | Change-Id: I26fd8a76a17386de73fa12058509ccee7e768512
* fix dbgutil buildCaolán McNamara2015-09-291-1/+1
| | | | Change-Id: If2a9d330bd7fde8db5e998e97c278fb19c90f24a
* tdf#94559: first step to remove rtti.hxxOliver Specht2015-09-2930-248/+252
| | | | | | | | | | replaced use of PTR_CAST, IS_TYPE, ISA in avmedia, basctl, basic, cui, dbaccess, vcl,xmloff Change-Id: If4496762e82e896b6fbc362e6626502703c245f5 Reviewed-on: https://gerrit.libreoffice.org/18905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
* pVar != null, so static_cast(pVar) != nullCaolán McNamara2015-09-261-18/+16
| | | | | | | | Change-Id: Id22808858b5884b2f87064b389eb411e0712bab4 Reviewed-on: https://gerrit.libreoffice.org/18881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* boost->stdCaolán McNamara2015-09-1812-39/+33
| | | | | | | | Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0 Reviewed-on: https://gerrit.libreoffice.org/18670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* boost->stdCaolán McNamara2015-09-141-2/+1
| | | | | | | | Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c Reviewed-on: https://gerrit.libreoffice.org/18564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>