summaryrefslogtreecommitdiffstats
path: root/basic
Commit message (Collapse)AuthorAgeFilesLines
* Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe2015-06-178-23/+23
| | | | | | | | | | | | | | | | | | | | | | This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Fix typosAndrea Gelmini2015-06-161-1/+1
| | | | | | | Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56 Reviewed-on: https://gerrit.libreoffice.org/16300 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* Fix typosAndrea Gelmini2015-06-161-1/+1
| | | | | | | Change-Id: I549635318f46718042e50c8f89ce3c620cade990 Reviewed-on: https://gerrit.libreoffice.org/16281 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* cppcheck:redundantAssignmentNoel Grandin2015-06-151-2/+2
| | | | Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
* cppcheck:redundantConditionNoel Grandin2015-06-151-1/+1
| | | | Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
* cppcheck: redundantCondition [part1]Julien Nabet2015-06-141-3/+3
| | | | Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
* BASIC: Don't use SbiStringPool to pass SbiParser.Arnaud Versini2015-06-133-19/+12
| | | | | | | Change-Id: I15949e604285d804de1554d36acf36e8a407ebd9 Reviewed-on: https://gerrit.libreoffice.org/16137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
* TyposJulien Nabet2015-06-131-2/+2
| | | | Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
* cppcheck: variableScopeCaolán McNamara2015-06-091-2/+1
| | | | Change-Id: If0c56c89e2722d47a401363f3854331229856490
* loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2015-06-0818-105/+105
| | | | Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
* Apply new VclPtr clang plugin to catch potential problems.Noel Grandin2015-06-062-2/+2
| | | | | | | | | | Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* convert PropertyMode to scoped enumNoel Grandin2015-06-043-15/+15
| | | | Change-Id: I9b0bbf6273aa18ae918d1d69af5dcc7652181f5c
* loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann2015-06-021-2/+2
| | | | Change-Id: I1788ad7d9f9dec892b31a0610d0f44ae1ccd2e64
* cppcheck: noExplicitConstructorCaolán McNamara2015-06-0210-16/+16
| | | | Change-Id: I8ae8623252546ca94f65fc04b331dd9cafa4fc92
* tdf#91702 - fix stack-based MessBox allocation.Michael Meeks2015-05-292-3/+4
| | | | | | | Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* loplugin:loopvartoosmallNoel Grandin2015-05-295-6/+6
| | | | Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
* Rewrite all calls like Dialog(params).Execute()Philippe Jung2015-05-281-2/+2
| | | | | | | | | | | | | Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* BASIC: Remove BasicCharClass::IsLetterTabArnaud Versini2015-05-264-87/+14
| | | | | | | Change-Id: Ib6a13cb7a5725d451c0f8d64c2c543a8a9ec2ad0 Reviewed-on: https://gerrit.libreoffice.org/15876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
* BASIC: User std::unique_ptr in basic runtimeArnaud Versini2015-05-264-41/+34
| | | | | | | | Change-Id: Iac7efdad78cf2f827cbddbc671dd0d1b5ae1d467 Reviewed-on: https://gerrit.libreoffice.org/15874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Wrong comment since 642cfe8ac206af4fe82bc695d38b5c7f0edf7dc7Julien Nabet2015-05-231-1/+1
| | | | | | nEndPos is in fact sal_uInt32 type Change-Id: I434564eebff2138709807676ae855a8f487f4c09
* tdf#90110: basic: fix Randomize statementMichael Stahl2015-05-192-8/+40
| | | | | | | | | | | | | | | | | - time() is used to seed the RNG but since it only has second resolution, the same values will be generated if it's called multiple times like in the bug report - BASIC using the global rng would be fine except that BASIC Randomize takes an optional parameter to set the seed, which should continue to be supported, but should not affect the RNG state for non-BASIC users of comphelper::random (regression from df466d79cb126667cc9d5c108367bfa4f5ce76c8, but the old implementation was even more delightfully absurd, where Randomize was essentially srand((sal_uInt16)rand()) ...) Change-Id: I0f30e509de08f933c02ac77c5d932b20e79586c5
* basic: used typed LINKsNoel Grandin2015-05-194-18/+18
| | | | Change-Id: I8770a782e7ff5529e30aee13558711bdd8a4070d
* missing semiCaolán McNamara2015-05-181-1/+1
| | | | Change-Id: I3253f09d10cbe733fdf6387d90ab04d65ba9328e
* cppunit: noExplicitConstructorCaolán McNamara2015-05-181-4/+5
| | | | Change-Id: Iaf1387ea236bf3a5db9b2165d5b827dbdcf95207
* Remove include stdio (part2)Julien Nabet2015-05-182-4/+0
| | | | | | | Change-Id: Iae58d107d8df1c543a165086fb2b7c288e7121dd Reviewed-on: https://gerrit.libreoffice.org/15775 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* remove unnecessary header fileNoel Grandin2015-05-1715-46/+18
| | | | Change-Id: I3b86a54a773341be7e7e69e88c59dc531ea49c5b
* tdf#62475: partial handmade fixesAndrea Gelmini2015-05-152-18/+0
| | | | | | | Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4 Reviewed-on: https://gerrit.libreoffice.org/15712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Missing disposeAndClear in MsgBox basic functionPhilippe Jung2015-05-121-0/+1
| | | | | | | Change-Id: Ida3d792a6f3797a6173b31b86a49b72ad7353340 Reviewed-on: https://gerrit.libreoffice.org/15717 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* tdf#90969: basic: add horrible hack to avoid crash due to ...Michael Stahl2015-05-121-3/+16
| | | | | | ... the stupid global variable GaDocBasicItems. Change-Id: Ib849e0e2b661e54005d00091f6d6fc474dc5549b
* Basic: Doesn't allow non ASCII characters in numeric literalsArnaud Versini2015-05-121-1/+1
| | | | | | | | Change-Id: I8b7755dbea56953a04cd7687181ec246fc680c43 Reviewed-on: https://gerrit.libreoffice.org/14691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann2015-05-118-28/+28
| | | | Change-Id: I1e4363f917a978434fb11368918435da12531dc6
* NOINSTANCE is implied now in IMPL_STATIC_LINK...Stephan Bergmann2015-05-101-1/+1
| | | | Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
* lopluign:staticmethods: Handle DECL_LINKStephan Bergmann2015-05-081-2/+2
| | | | Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
* Unwind SotStorageStreamRef typedefStephan Bergmann2015-05-071-5/+5
| | | | Change-Id: If7652a7c0251b741660365848a717c06954ca419
* Unwind SotStorageRef typedefStephan Bergmann2015-05-073-9/+9
| | | | Change-Id: I8d5363bb2ad813ef29b4078848914f4b0989b9f1
* tdf#84435: Mod operator does not deal with decimals as described in helpJulien Nabet2015-04-301-4/+4
| | | | | | | Change-Id: I8dbfdf4bb2eceac0b5afbddd3f35e1dcde2db68b Reviewed-on: https://gerrit.libreoffice.org/14611 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
* Gradually typed LinkStephan Bergmann2015-04-304-7/+7
| | | | | | | | | | | | | | | | | Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
* Remove unnecessary IMPL_LINK[_NOARG]_INLINE_START/ENDStephan Bergmann2015-04-292-9/+4
| | | | | | ...just use IMPL_LINK[_NOARG] and let the compiler decide what to inline Change-Id: I63ec5116df7e79093ebf31193f8c674f1351c0e6
* Remove unnecessary IMPL_LINK_INLINE macroStephan Bergmann2015-04-291-2/+1
| | | | Change-Id: I81cbec049b98d2d2619b0480e0cf54bd1d7b6718
* convert STR_EVENT constants to scoped enumNoel Grandin2015-04-291-1/+1
| | | | | | | | - also add needed infrastructure to o3tl::enumarray so we can use std::find on it - move the Impl inside the .cxx file, no need to expose it in the header Change-Id: I7758a6175849f46723d97b1e657f846524c3b7cd
* Merge remote-tracking branch 'origin/feature/vclptr'Michael Meeks2015-04-283-50/+71
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve several thousand lines of conflicts. Conflicts: accessibility/source/extended/accessiblelistbox.cxx accessibility/source/standard/vclxaccessiblecombobox.cxx accessibility/source/standard/vclxaccessibledropdowncombobox.cxx accessibility/source/standard/vclxaccessibledropdownlistbox.cxx accessibility/source/standard/vclxaccessiblelistbox.cxx accessibility/source/standard/vclxaccessibletextfield.cxx basctl/source/basicide/basidesh.cxx cui/source/inc/chardlg.hxx cui/source/tabpages/tpbitmap.cxx dbaccess/source/ui/dlg/UserAdmin.cxx dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx extensions/source/propctrlr/propertyeditor.hxx extensions/source/scanner/sanedlg.cxx filter/source/pdf/impdialog.cxx include/sfx2/mgetempl.hxx include/sfx2/sidebar/SidebarToolBox.hxx include/sfx2/viewsh.hxx include/svtools/brwbox.hxx include/svtools/filectrl.hxx include/svtools/scrwin.hxx include/svx/dlgctrl.hxx include/svx/sidebar/Popup.hxx include/svx/sidebar/PopupContainer.hxx include/svx/sidebar/PopupControl.hxx include/svx/sidebar/SidebarDialControl.hxx include/svx/sidebar/ValueSetWithTextControl.hxx sc/source/ui/condformat/condformatdlgentry.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/sidebar/CellBorderStyleControl.hxx sd/source/ui/animations/CustomAnimationDialog.cxx sd/source/ui/inc/DrawViewShell.hxx sd/source/ui/inc/Ruler.hxx sd/source/ui/inc/SlideSorter.hxx sd/source/ui/inc/ViewTabBar.hxx sd/source/ui/inc/Window.hxx sd/source/ui/inc/morphdlg.hxx sd/source/ui/inc/sdpreslt.hxx sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx sd/source/ui/sidebar/LayoutMenu.hxx sd/source/ui/sidebar/MasterPagesSelector.hxx sd/source/ui/sidebar/NavigatorWrapper.hxx sd/source/ui/sidebar/PanelBase.hxx sd/source/ui/sidebar/RecentMasterPagesSelector.cxx sd/source/ui/sidebar/RecentMasterPagesSelector.hxx sd/source/ui/slideshow/showwindow.hxx sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviewsa.cxx sfx2/source/appl/fileobj.hxx sfx2/source/appl/opengrf.cxx sfx2/source/control/thumbnailviewacc.hxx sfx2/source/dialog/securitypage.cxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/docinsert.cxx sfx2/source/doc/guisaveas.cxx sfx2/source/inc/alienwarn.hxx sfx2/source/sidebar/Deck.cxx sfx2/source/sidebar/Deck.hxx sfx2/source/sidebar/DeckTitleBar.cxx sfx2/source/sidebar/DeckTitleBar.hxx sfx2/source/sidebar/MenuButton.cxx sfx2/source/sidebar/MenuButton.hxx sfx2/source/sidebar/Panel.cxx sfx2/source/sidebar/Panel.hxx sfx2/source/sidebar/PanelTitleBar.hxx sfx2/source/sidebar/SidebarDockingWindow.hxx sfx2/source/sidebar/SidebarToolBox.cxx sfx2/source/sidebar/TabBar.hxx sfx2/source/sidebar/TabItem.cxx sfx2/source/sidebar/TabItem.hxx sfx2/source/sidebar/TitleBar.hxx sfx2/source/toolbox/imgmgr.cxx starmath/inc/edit.hxx starmath/inc/smmod.hxx starmath/qa/cppunit/test_starmath.cxx starmath/source/edit.cxx starmath/source/smmod.cxx svtools/source/brwbox/brwbox1.cxx svtools/source/brwbox/datwin.hxx svtools/source/contnr/fileview.cxx svtools/source/contnr/simptabl.cxx svtools/source/control/filectrl.cxx svtools/source/control/valueimp.hxx svx/inc/GalleryControl.hxx svx/source/dialog/dlgctrl.cxx svx/source/dialog/swframeexample.cxx svx/source/fmcomp/fmgridif.cxx svx/source/gallery2/GalleryControl.cxx svx/source/sidebar/EmptyPanel.hxx svx/source/sidebar/area/AreaPropertyPanel.hxx svx/source/sidebar/area/AreaTransparencyGradientControl.hxx svx/source/sidebar/graphic/GraphicPropertyPanel.hxx svx/source/sidebar/insert/InsertPropertyPanel.cxx svx/source/sidebar/insert/InsertPropertyPanel.hxx svx/source/sidebar/line/LinePropertyPanel.hxx svx/source/sidebar/line/LineWidthControl.cxx svx/source/sidebar/line/LineWidthControl.hxx svx/source/sidebar/line/LineWidthValueSet.hxx svx/source/sidebar/paragraph/ParaPropertyPanel.hxx svx/source/sidebar/possize/SidebarDialControl.cxx svx/source/sidebar/text/TextCharacterSpacingPopup.hxx svx/source/sidebar/text/TextPropertyPanel.hxx svx/source/sidebar/tools/PopupContainer.cxx svx/source/sidebar/tools/PopupControl.cxx svx/source/sidebar/tools/ValueSetWithTextControl.cxx svx/source/svdraw/svdfmtf.hxx svx/source/svdraw/svdibrow.cxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx sw/source/ui/dbui/mmaddressblockpage.cxx sw/source/ui/dialog/uiregionsw.cxx sw/source/ui/index/cnttab.cxx sw/source/uibase/inc/drpcps.hxx sw/source/uibase/sidebar/PageColumnControl.hxx sw/source/uibase/sidebar/PageMarginControl.hxx sw/source/uibase/sidebar/PageOrientationControl.hxx sw/source/uibase/sidebar/PagePropertyPanel.hxx sw/source/uibase/sidebar/PageSizeControl.hxx sw/source/uibase/uiview/view2.cxx sw/source/uibase/utlui/navipi.cxx vcl/inc/svdata.hxx vcl/source/control/combobox.cxx vcl/source/control/lstbox.cxx vcl/source/window/dockwin.cxx vcl/source/window/winproc.cxx Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
| * basctl, basic: convert new to ::Create.Michael Meeks2015-04-173-9/+9
| | | | | | | | Change-Id: I1fc2c69640ed625425a679380d6f25178bc5aeb1
| * Automated conversion of VclPtr construction to use Instance template.Michael Meeks2015-04-101-1/+1
| | | | | | | | Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
| * first half of non-scriptable, Instance constructor conversion.Michael Meeks2015-04-101-2/+2
| | | | | | | | Change-Id: If73bb41bfa805e22609748f25971724b4778edb3
| * vclwidget: fixup locally allocated vcl::Window objectsNoel Grandin2015-04-101-1/+1
| | | | | | | | | | | | They need to be wrapped in ScopedVclPtr in order to be disposed properly. Change-Id: Ib64dba353774f54711e4de7f5d15d859c6a4dc7e
| * vclwidget: fix more places that should be wrapping in VclPtrNoel Grandin2015-04-102-2/+2
| | | | | | | | Change-Id: I31c9115662da2f81e1b22be91ee58e2862076b8e
| * vclwidget: only call dispose() onceNoel Grandin2015-04-102-2/+2
| | | | | | | | | | | | | | | | by using a new utility method in vcl::Window This means that we don't have to make all our dispose methods safe to call more than once. Change-Id: I2110c7de4a86c70fdc97dd8fd318c86b56865374
| * vclwidgets: wrap all vcl::Window subclasses allocated on stack in VclPtrNoel Grandin2015-04-091-3/+3
| | | | | | | | | | | | | | Change-Id: Ia8b0d84bbf69f9d8f85505d019acdded14e25133 Conflicts: sw/qa/tiledrendering/tiledrendering.cxx
| * vcl: VclPtr conversion in basicNoel Grandin2015-04-092-39/+60
| | | | | | | | Change-Id: Ia0330d596b696f914a8ee2f81f0399e9456ff87c
* | Rephrase comparisons between bool and sal_BoolStephan Bergmann2015-04-281-2/+2
| | | | | | | | | | | | ...to cater for forthcoming loplugin:implicitboolconversion improvements Change-Id: I801b6b73648715448198d582a087cc834f6e20c8