summaryrefslogtreecommitdiffstats
path: root/basic/source
Commit message (Collapse)AuthorAgeFilesLines
* Further clean-upStephan Bergmann2014-12-032-26/+1
| | | | Change-Id: I20049b482c831e4ac2221fddfe80deb9847e72c3
* Code clean-up/consolidation task.Vishv Brahmbhatt2014-12-031-7/+3
| | | | | | | | | | | | Removing the duplicate code,and consolidating changes by using method "getExpandedFilePath" of comphelper. Signed-off-by: Stephan Bergmann <sbergman@redhat.com>: adapted to recent change from comphelper::getExpandedFilePath to comphelper::getExpandedUri; fixed the two changes in framework to actually modify the by--non-const--ref argument; fixed a loplugin:unreffun. More clean-up to follow. Change-Id: Ie8875bcb61b616385bd64151f0a915bf7cce04e5
* fdo#84938 replace BASERR_REASON_ constants -> enumTobias Madl2014-12-031-10/+10
| | | | | | | Change-Id: I80fe0108c2d27b72d2fadc23032cf2b52c3193a6 Reviewed-on: https://gerrit.libreoffice.org/13268 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Add missing include headerDavid Ostrovsky2014-12-031-0/+1
| | | | | | | Change-Id: I59d6f1401cdfc37c0949cc9d439cb7ff52857079 Reviewed-on: https://gerrit.libreoffice.org/13286 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* busted loop conditionCaolán McNamara2014-11-211-2/+1
| | | | | | | | | | regression from commit 119873328acd70ca3569c21a0b1fe36277e8bf4c Date: Thu Oct 21 15:34:02 2010 -0500 convert vos/process.hxx and related API Change-Id: I36527a4f0109105b9853a79773b4c92f9bc4e902
* coverity#1255390 Resource leakCaolán McNamara2014-11-211-0/+2
| | | | Change-Id: I3631d6bbcf45986deb1e911fcdb0e6606a0c6d91
* cppuhelper: clean up public headers with include-what-you-useMichael Stahl2014-11-181-0/+2
| | | | Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
* coverity#735399 Logically dead codeCaolán McNamara2014-11-171-4/+0
| | | | | | | | | | | | | we can only enter the bAssumeExprLParenMode controlled block once because the block sets bAssumeExprLParenMode to false bAssumeExprLParenMode is only true if the first token read in the method is LPAREN so we can only enter this block if the current token is LPAREN and its the first token processed, so the token can't be BYVAL Change-Id: I6e668fca4d127d7dbfe447e2d9f2231e05278a7d
* sal: clean up public headers with include-what-you-useMichael Stahl2014-11-175-0/+7
| | | | | | | | | Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
* this is for detecting the type of a variable based on its nameCaolán McNamara2014-11-141-8/+5
| | | | | | | which means legal input is any character which a variable can start with Change-Id: I0c2d13a92ba374f8020e86e90e8e5f18ce8a9c90
* coverity#1242865 Untrusted value as argumentCaolán McNamara2014-11-141-0/+11
| | | | Change-Id: Ie7a7a2e7894a204dd55833416b7cbc5b01826e64
* fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava2014-11-143-5/+5
| | | | | | | Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl2014-11-141-0/+1
| | | | | | | | | | | | | | And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
* Fix common typos. No automatic tools. Handmade…Andrea Gelmini2014-11-127-9/+9
| | | | | | | Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* coverity#1242689 Untrusted loop boundCaolán McNamara2014-11-051-1/+9
| | | | Change-Id: Ie226805ef8d430eb3f7b3abaa54ac3af31f72f7b
* coverity#1242865 Untrusted loop boundCaolán McNamara2014-11-051-1/+10
| | | | Change-Id: I9dc9cd98d0a02a2867d4c40c7afb7bf873513143
* coverity#1242794 Untrusted loop boundCaolán McNamara2014-11-051-2/+10
| | | | Change-Id: I902a5bf989a8f385994a2f927cce4975b18f06d2
* markup with event type not checker typeCaolán McNamara2014-11-054-6/+6
| | | | Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
* fdo#38835 strip out OUString globalsNoel Grandin2014-11-053-22/+11
| | | | | | | they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
* document array_vs_singleton dismissalsCaolán McNamara2014-10-304-1/+7
| | | | Change-Id: I8d7eb4c01197e885abca717c7814c61a7641ac9d
* coverity#704558 Dereference after null checkCaolán McNamara2014-10-241-3/+2
| | | | Change-Id: I6fe44d8926acd185bb6bc671fb7df8ae935998c1
* fdo#84935: basic: avoid silly SolarMutex asserts on exit on MacMichael Stahl2014-10-231-0/+4
| | | | Change-Id: If22b8ff962d2b68130176de3b7b9eccacfc850dc
* basic: move SbxAppData to a BasicDLL memberMichael Stahl2014-10-232-7/+12
| | | | | | ... so it is deleted by ~SfxApplication. Change-Id: I161bd92eb9b5082d1fdeea603921d0372a4d97e6
* basic: pimplify thatMichael Stahl2014-10-231-7/+21
| | | | Change-Id: I0abe66ded0fd69a2720ad64e1a1426aafc7dfffb
* Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky2014-10-231-2/+2
| | | | | | | | | | | | | | This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
* Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky2014-10-231-2/+2
| | | | | | | | | | | | This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
* fdo#60689: replace SUPD variableMarcos Paulo de Souza2014-10-231-1/+2
| | | | | | | | Change-Id: Iad63330f8762b595ba5ee94fc20bc2c64ac92f6b Reviewed-on: https://gerrit.libreoffice.org/11937 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* fdo#84935: basic: DocBasicItem is a UNO service, lock SolarMutex in dtorMichael Stahl2014-10-231-0/+3
| | | | Change-Id: Ia31d735ba54d18f406653debce04a07c077d09eb
* Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist2014-10-228-23/+38
| | | | | | | | Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
* fdo#84854 it seems long is not enough on 32 bitDavid Tardon2014-10-161-2/+2
| | | | | | | Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
* Typo: compatability->compatibilityJulien Nabet2014-10-121-1/+1
| | | | Change-Id: If0b98a30452a9d1fcc340173deb6856755926471
* fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca2014-10-091-2/+2
| | | | | | | | | | | | | | | | | | | | | * Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
* basic: use SolarMutex to lock SfxLibraryContainerMichael Stahl2014-10-081-2/+2
| | | | | | | | | | | | | | Originally this used both SolarMutex and an own mutex, then a deadlock was resolved in 2fe6a4a34b38c05e252c71f4d2f18e4a90e61b29 by not locking SolarMutex. Since the class will call event listeners without dropping the mutex e.g. in insertNoCheck(), using the SolarMutex appears better anyway. With this, installing a BASIC extension no longer triggers SolarMutex asserts in SfxBroadcaster. Change-Id: Ib9a2ee491ef53b1a53855af0fc22e863c5e7cb91
* basic::ImplRepository: use SolarMutex instead of own mutexMichael Stahl2014-10-081-8/+10
| | | | | | | | | The locking strategy in the basic module is totally unclear to me, there does not appear to be a dedicated mutex for the core stuff callable via StarBASIC, just a bunch of SolarMutexGuards at random locations; let's try to use SolarMutex at the UNO entry points... Change-Id: Ia9c45fdcfb5ffd0a4acc77ef5d2fabfb8743ad38
* back out even more wrong tools::Time changes, geez..Eike Rathke2014-10-081-1/+1
| | | | Change-Id: I52eb3400769999d7f554c3bdb8746f65b7990388
* back out more wrong and confusing tools::Time comment changesEike Rathke2014-10-082-3/+3
| | | | | | | Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script to change all ... Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
* spelling: instanciated -> instantiatedNoel Grandin2014-10-081-1/+1
| | | | Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
* use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara2014-10-061-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
* coverity#1242481 Dereference null return valueCaolán McNamara2014-10-031-2/+2
| | | | Change-Id: I21e6bdd643d898a3515a96e4c9c17c2d6f98b0e4
* rename SvRef::AddRef to AddFirstRefNoel Grandin2014-10-034-14/+14
| | | | | | | | | to make it's intended purpose clearly distinguishable from AddNextRef Change-Id: I5da780b48b19fd873667b648031bc394113f953b Reviewed-on: https://gerrit.libreoffice.org/11763 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin: cstylecastNoel Grandin2014-10-0216-78/+78
| | | | Change-Id: Ic7c9c978baf5602a508aff5976220a02ed03a680
* loplugin: cstylecastNoel Grandin2014-10-013-39/+39
| | | | Change-Id: Ie3d13eccdf444d569cbe40befb45eb86941160b6
* avoid calling OUString::copy() with length being -1Luboš Luňák2014-10-011-17/+20
| | | | | | Which asserts in dbgutil build. Change-Id: I0f8205ae98c5a57c430b7d8a574e4c0019855841
* fdo#82577: Handle TimeNoel Grandin2014-10-014-14/+14
| | | | | | | | | | Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* remove unnecessary casts in misc calls to SvStream.Write*Noel Grandin2014-09-261-1/+1
| | | | | | | left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ib80032e8626f5476a89b958f590441994594f4e4
* remove unnecessary casts in calls to SvStream.WriteUInt32Noel Grandin2014-09-265-10/+10
| | | | | | | left over from our conversion of the SvStream output operators to more specific methods Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
* remove unnecessary casts in calls to SvStream.WriteInt32Noel Grandin2014-09-262-9/+9
| | | | | | | left over from our conversion of the SvStream output operators to more specific methods Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
* remove unnecessary casts in calls to SvStream.WriteUInt16Noel Grandin2014-09-264-15/+15
| | | | | | | left over from our conversion of the SvStream output operators to more specific methods Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
* remove unnecessary casts in calls to SvStream.WriteInt16Noel Grandin2014-09-263-7/+7
| | | | | | | left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
* remove unnecessary casts in calls to SvStream.WriteUCharNoel Grandin2014-09-263-10/+10
| | | | | | | left over from our conversion of the SvStream output operators to more specific methods Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
generated by cgit (git 2.34.1) at 2024-08-22 03:17:55 +0000