summaryrefslogtreecommitdiffstats
path: root/basegfx
Commit message (Collapse)AuthorAgeFilesLines
* Rename the basegfx::tools namespace to basegfx::utilsTor Lillqvist2017-09-2631-275/+275
| | | | | | | | | | | | | | Reduce potential confusion with the global tools namespace. Will hopefully make it possible to remove the annoying initial :: when referring to the global tools namespace. Unless we have even more tools subnamespaces somewhere. Thorsten said it was OK. Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996 Reviewed-on: https://gerrit.libreoffice.org/42644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
* Fresh run of bin/update_pch.shMike Kaganski2017-09-221-3/+7
| | | | | | | Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: https://gerrit.libreoffice.org/42565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* borderline: Preparing further to use CellCoordinateSystemArmin Le Grand2017-09-151-0/+14
| | | | | | | | | | Multiple cleanups, made svx::frame::Style a std::shared_ptr class, preparing basing all border stuff on transformations, so it will need a CellCoordinateSystem. Added stuff to get this Coordinate System from the svx::frame::Cell using the Frame and knowledge about ownerships Change-Id: Ic2cb59cc92e648ac2fef72f22f8913479769d3e2
* clang-tidy modernize-use-emplace in b*Noel Grandin2017-09-088-89/+70
| | | | | | | Change-Id: I51e0369ba2e1fe0b7c934531f71d3bda95ba09ec Reviewed-on: https://gerrit.libreoffice.org/42109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* basegfx: remove global ImplB2DPolyPolygonMichael Stahl2017-08-251-6/+3
| | | | Change-Id: I6035aaf8aabf71062bb63a4d416c253378fb4756
* basegfx: remove global ImplB2DPolygonMichael Stahl2017-08-251-10/+21
| | | | Change-Id: Ibd97ba1d7cc4e04203142057c47a74034cc4f70f
* basegfx: remove global 3D IdentityMatrix thread safety hazardMichael Stahl2017-08-251-10/+3
| | | | | | | | | | | On a tinderbox, CppunitTest_chart2_export crashed in basegfx::B3DHomMatrix::isEqual(), with other threads in other basegfx code. The UnsafeRefCountingPolicy on the global IdentityMatrix is likely the problem. Change-Id: Ib142c6f286453d61bd948fb0c184cd68fd313b0f
* loplugin:unnecessaryparenJan-Marek Glogowski2017-08-221-1/+1
| | | | Change-Id: I4f8b76a9f924a476d04aa745837e732b10348ffa
* remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin2017-08-171-1/+1
| | | | | | | Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparams in basegfx,sax,shellNoel Grandin2017-07-174-21/+21
| | | | | | | Change-Id: I90a9d105a6db146ae64cff56983def94b9472a95 Reviewed-on: https://gerrit.libreoffice.org/40043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* teach unnecessaryparen loplugin about identifiersNoel Grandin2017-07-103-10/+10
| | | | | | | Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* C++11 remove std::binary_function bases from functorsJochen Nitschke2017-07-071-2/+1
| | | | | | | | | | | | | | | | | | | std::binary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::binary_function base class was used by deprecated std::bind2nd, this was solved in individual commits. The members first_argument_type and second_argument_type were used in chart2/source/controller/dialogs/DataBrowserModel.cxx: DataBrowserModel::implColumnLess and are inlined in this commit. Change-Id: I60ded60a8d4afd59e15ac15a58e18d2498c9be5a Reviewed-on: https://gerrit.libreoffice.org/39659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:casttovoid: basegfxStephan Bergmann2017-07-023-15/+2
| | | | Change-Id: I5a7723a9b0ce64969a96a3bccb47b380a138b69c
* basegfx: remove trivial copy ctorsJochen Nitschke2017-06-272-28/+0
| | | | | | | Change-Id: If6668552ec56d1b6439ead56fb2d77491a84ea13 Reviewed-on: https://gerrit.libreoffice.org/39295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* cppcheck: knownConditionTrueFalseJochen Nitschke2017-06-061-2/+2
| | | | | | | Change-Id: I231113eaf3117e13ed18de906e3787643abe9335 Reviewed-on: https://gerrit.libreoffice.org/38423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* basegfx: remove global IdentityMatrix thread safety hazardMichael Stahl2017-05-311-11/+4
| | | | | | | | | | | | | | | | | | | | ASAN reports this about JunitTest_chart2_unoapi ==27381==ERROR: AddressSanitizer: heap-use-after-free on address 0x6060005bd218 at pc 0x7ff229755271 bp 0x7fffb52c6c30 sp 0x7fffb52c6c28 READ of size 8 at 0x6060005bd218 thread T0 #0 0x7ff229755270 in o3tl::UnsafeRefCountingPolicy::decrementCount(unsigned long&) include/o3tl/cow_wrapper.hxx:41:68 #1 0x7ff2297551bf in o3tl::cow_wrapper<basegfx::Impl2DHomMatrix, o3tl::UnsafeRefCountingPolicy>::release() include/o3tl/cow_wrapper.hxx:203:29 #2 0x7ff2297515f0 in o3tl::cow_wrapper<basegfx::Impl2DHomMatrix, o3tl::UnsafeRefCountingPolicy>::~cow_wrapper() include/o3tl/cow_wrapper.hxx:248:13 #3 0x7ff242ef440f in __run_exit_handlers (/lib64/libc.so.6+0x3a40f) #4 0x7ff242ef4469 in __GI_exit (/lib64/libc.so.6+0x3a469) The reason appears to be the UnsafeRefCountingPolicy on the global IdentityMatrix, so every B2DHomMatrix that is created on any thread will manipulate the refcount of that global without synchronisation. Let's just remove the global and hope the extra allocations don't matter. Change-Id: I4962ab2e622286f29b912a57448f3f1a53eeb592
* loplugin:comparisonwithconstant in accessibility..basegfxNoel Grandin2017-05-199-23/+23
| | | | | | | | | | re-running this plugin on these modules now that sberg has improved the plugin. Change-Id: I1818b1fa540cf62b81219a4f3ed2dcae8ff0e838 Reviewed-on: https://gerrit.libreoffice.org/37805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:comparisonwithconstant in basegfxNoel Grandin2017-05-1818-84/+84
| | | | | | | Change-Id: I6953640a1aa2e58fe2ea6555291c4f4a5271770f Reviewed-on: https://gerrit.libreoffice.org/37680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* cleanup osl/diagnose.h includesJochen Nitschke2017-05-097-7/+0
| | | | | | | | | | | | | | with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* cppcheck: knownConditionTrueFalseJochen Nitschke2017-05-081-41/+34
| | | | | | | | | remove bDone and simply 'break' the loop when done. Change-Id: Idf4170083cbda3a783cb52bba9e94d3be512f167 Reviewed-on: https://gerrit.libreoffice.org/37355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* revert OSL_ASSERT changesChris Sherlock2017-05-071-1/+1
| | | | Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
* tdf#43157: convert basegfx from OSL_ASSERT to assertChris Sherlock2017-05-071-1/+1
| | | | Change-Id: Ieabb52d9d0aa3b9c81e1642cd64bddea897ed53a
* remove empty namespacesJochen Nitschke2017-05-033-19/+0
| | | | | | | Change-Id: I3eae0ecc1ffc5500d3c55abc6554822f5432a50a Reviewed-on: https://gerrit.libreoffice.org/37173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:salunicodeliteral: basegfxStephan Bergmann2017-04-281-4/+4
| | | | Change-Id: Ice43bae52ac244815ee62ee843108fd36b9918d7
* loplugin:cppunitassertequals: basegfxStephan Bergmann2017-04-285-203/+209
| | | | Change-Id: I942634a688d7728bb21c3ce9bd530e07467cb7c5
* gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2017-04-212-2/+0
| | | | | | | | | Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
* clang-tidy readability-simplify-boolean-expr in accessibility..cuiNoel Grandin2017-04-192-14/+2
| | | | | | | Change-Id: Iae27da322c6ede592e6b268fb2210d3525ed22cc Reviewed-on: https://gerrit.libreoffice.org/36677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr extend to catch more localvar casesNoel Grandin2017-04-062-12/+8
| | | | | | | | | | | | | | | i.e. where the code looks like { foo * p = new foo; ... delete p; return ...; } Change-Id: Id5f2e55d0363fc62c72535a23faeaaf1f0ac6aee Reviewed-on: https://gerrit.libreoffice.org/36190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:redundantcast find c-style bool castsNoel Grandin2017-04-051-1/+1
| | | | | | | Change-Id: I3237b93babc67de12c3771aa84766c2141ca93b2 Reviewed-on: https://gerrit.libreoffice.org/36137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typosAndrea Gelmini2017-03-261-1/+1
| | | | | | | | Change-Id: Idbf0aa261b829e83d4c08a2e989a4ced871dc6de Reviewed-on: https://gerrit.libreoffice.org/35616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Only need an OStringBuffer in number2PolyPolygonStephan Bergmann2017-03-211-3/+3
| | | | | | | | | | | ...so that later passing the OStringBuffer's aNum[i] to createSevenSegmentPolyPolygon (taking a first parameter of type char) doesn't need to implicitly convert from sal_Unicode to char. Requires addition of some missing OStringBuffer-related function variants in rtl/math.hxx and rtl/strbuf.hxx. Change-Id: I79e6b2a791abc62b6556a6668e4411cced490c11
* Fix typosAndrea Gelmini2017-03-191-1/+1
| | | | | | | Change-Id: I5c89a47e658ae4ad2b0cdfcdb4988c4b79353085 Reviewed-on: https://gerrit.libreoffice.org/35413 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove redundant 'inline' keywordStephan Bergmann2017-03-031-3/+3
| | | | | | | | | | ...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* ofz: timeout loading emf with move clip recordCaolán McNamara2017-03-012-0/+25
| | | | | | | | Change-Id: Id5d60f0037873598e1447b063e66e9c29840587c Reviewed-on: https://gerrit.libreoffice.org/34740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:loopvartoosmallStephan Bergmann2017-02-261-3/+4
| | | | Change-Id: I085d409f3271c5a4d8237fa3e3c4a74bed296acb
* vector::data seems more natural than &vector::frontCaolán McNamara2017-02-242-16/+16
| | | | Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1
* change intervall -> intervalDavid Tardon2017-02-231-2/+2
| | | | Change-Id: Ib211619428f16304603d9c0a9fce0b22dde2a617
* Drop :: prefix from std in [a-b]*/Tor Lillqvist2017-02-1524-113/+113
| | | | | | | Change-Id: I0422aaf39bbce889c95ed9a81a0784cb03a1badd Reviewed-on: https://gerrit.libreoffice.org/34320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
* Add missing #includesStephan Bergmann2017-02-063-0/+3
| | | | | | | | | ...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
* loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin2017-01-281-3/+2
| | | | | | | | | ..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove dynamic exception specificationsStephan Bergmann2017-01-262-22/+18
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin: unnecessary destructor: basctl..codemakerNoel Grandin2017-01-242-20/+0
| | | | | | | Change-Id: Iadcfa9bc4fe9efb8d24d6d6afaf2b9b3def0bc3c Reviewed-on: https://gerrit.libreoffice.org/33452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* New loplugin:conststringvar: basegfxStephan Bergmann2017-01-104-44/+41
| | | | Change-Id: Ia298e6a3515de9bde212dfd6159032859a965df1
* coverity#1398371 Useless callCaolán McNamara2017-01-072-24/+0
| | | | Change-Id: I3614bb162cec889ee102e0284b6a3a33a98df470
* cppcheck unreadVariable: curr_OffsetTibor Móger2016-12-061-1/+0
| | | | | | | Change-Id: Iffc1d36a0e1921f55f24f5e3f9fc1b063b7c0f16 Reviewed-on: https://gerrit.libreoffice.org/31672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
* convert some anonymous enums to scopedNoel Grandin2016-12-021-6/+2
| | | | | | | Change-Id: Ia989376c983ff475359e4964abeb1f5a2300ff5b Reviewed-on: https://gerrit.libreoffice.org/31486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* includes should be at the top of the fileNoel Grandin2016-11-182-2/+2
| | | | | | | | | | | | not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedmethodsNoel Grandin2016-10-182-99/+0
| | | | | | | Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constantfunctionNoel Grandin2016-10-111-5/+0
| | | | | | | | | | | | | update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: https://gerrit.libreoffice.org/29665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* rtl::math::approxEqual(value,0.0) never yields true for value!=0.0Eike Rathke2016-10-065-13/+13
| | | | | | | | | ... so replace with a simple value == 0.0 also in other modules than sc. Change-Id: Ie7316505a1cf9c15100114b45d300facceb03b7e Reviewed-on: https://gerrit.libreoffice.org/29575 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-08-06 02:43:22 +0000