summaryrefslogtreecommitdiffstats
path: root/basegfx
Commit message (Collapse)AuthorAgeFilesLines
* remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin2017-12-051-1/+1
| | | | | | | | | | | | | | Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2e8acde112e1c6754df26902e79a78346ba45a2d) Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/45452 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 2887aefa4d4f60ba8b0cd7efd5d3a73ffb209781)
* vector::data seems more natural than &vector::frontCaolán McNamara2017-12-052-16/+16
| | | | | | Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1 (cherry picked from commit 3a74745367a73ed9351379fc32bbe9253cdae697) (cherry picked from commit 3437713c11d60f99470fc1d0e2a8e5c56d5a6fe8)
* includes should be at the top of the fileNoel Grandin2016-11-182-2/+2
| | | | | | | | | | | | not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedmethodsNoel Grandin2016-10-182-99/+0
| | | | | | | Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constantfunctionNoel Grandin2016-10-111-5/+0
| | | | | | | | | | | | | update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: https://gerrit.libreoffice.org/29665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* rtl::math::approxEqual(value,0.0) never yields true for value!=0.0Eike Rathke2016-10-065-13/+13
| | | | | | | | | ... so replace with a simple value == 0.0 also in other modules than sc. Change-Id: Ie7316505a1cf9c15100114b45d300facceb03b7e Reviewed-on: https://gerrit.libreoffice.org/29575 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* CPPUNIT_ASSERT[_DOUBLES]_EQUALStephan Bergmann2016-10-062-31/+53
| | | | Change-Id: I417cea926abcc511e74a090ee90a851c138ac0c0
* Fix typosAndrea Gelmini2016-10-031-1/+1
| | | | | | | Change-Id: Ie44267e7c9f92eb1920f05235826abff761251f1 Reviewed-on: https://gerrit.libreoffice.org/29430 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* coverity#1371281 Missing move assignment operatorCaolán McNamara2016-09-231-0/+11
| | | | Change-Id: I7d0351931b0baa434bd24db05358e096cfa1b6e2
* Remove nonsense comments: // bitfieldTor Lillqvist2016-09-131-1/+0
| | | | | | | Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
* tdf#43157 - Clean up OSL_ASSERT, DBG_ASSERT, etc.Gökhan Gurbetoğlu2016-09-051-3/+4
| | | | | | | Change-Id: I8114e338451b5b2e79b2318f558cbd075f024f08 Reviewed-on: https://gerrit.libreoffice.org/28584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* tdf#43157 Clean up OSL_ASSERTdrazil2016-08-291-6/+6
| | | | | | | | | Clean up OSL_ASSERT in basegfx/source/tools/b2dclipstate.cxx Change-Id: I4107980aa079b0e0e8605de34ecfd01587647af6 Reviewed-on: https://gerrit.libreoffice.org/28417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* cid#1371223 Missing move assignment operatorNoel Grandin2016-08-293-0/+32
| | | | | | and cid#1371216, cid#1371179 Change-Id: I64faaada85cc92a8b47c2a665488f07050be6fc3
* cid#1371276 Missing move assignment operatorNoel Grandin2016-08-251-0/+10
| | | | | | | | also cid#1371234, cid#1371249, cid#1371208, cid#1371250, cid#1371258, cid#1371266, cid#1371257, cid#1371221 Change-Id: I18d952887b684e1999d003cec0f668789c851b52
* cid#1371281 Missing move assignment operatorNoel Grandin2016-08-251-0/+11
| | | | Change-Id: I29e1b042d2550bbe909ea432b161bdcb418d8976
* cid#1371285 Missing move assignment operatorNoel Grandin2016-08-251-0/+11
| | | | Change-Id: Ia822a01caec28f8137e30c05b6904c9fac367ce4
* loplugin:unusedenumconstants in basctl..editengNoel Grandin2016-08-171-10/+0
| | | | Change-Id: I49a23a197969d58a3a2d6b2be1fbe4a647c7fa08
* loplugin:countusersofdefaultparams in basctl..basicNoel Grandin2016-08-042-4/+4
| | | | | | | Change-Id: I16fac3317ebf55581cb9aaef676a9759de51d695 Reviewed-on: https://gerrit.libreoffice.org/27793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMuhammet Kara2016-08-041-3/+1
| | | | | | | | | in basctl, basegfx, canvas Change-Id: I59383d2599793b99b560333387e163a3d80eecec Reviewed-on: https://gerrit.libreoffice.org/27778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#96505 get rid of "long" integer literals 'L'Asela Dasanayaka2016-07-3013-117/+117
| | | | | | | | | Remove L from integer literals in module basegfx all 0L, 1L, and 2L Change-Id: Ia8a0d660033651f6d0a35392b74b67358b639fb3 Reviewed-on: https://gerrit.libreoffice.org/27717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* improve passstuffbyref return analysisNoel Grandin2016-07-271-1/+1
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* basegfx: use polygon initializer_list in some placesTomaž Vajngerl2016-07-252-59/+63
| | | | | | | Change-Id: Ibb83476376e1c46aedf67c9455292405219a45c1 Reviewed-on: https://gerrit.libreoffice.org/27476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* basegfx: initializer_list from polygonTomaž Vajngerl2016-07-251-0/+9
| | | | | | | Change-Id: I2d6cdb7189217e1fadb1ecf4e11cf4dd04043ec6 Reviewed-on: https://gerrit.libreoffice.org/27475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* simplify code nowCaolán McNamara2016-07-191-27/+8
| | | | Change-Id: Ic9fed523c9077f3e9efa2af00ac5f9e9071a0dc9
* Resolves: tdf#100909 artifacts in hole of polypolygon shapeCaolán McNamara2016-07-191-8/+0
| | | | | | | | | | | | | | | regression from... commit 1ca06ce59b7d3cea873d2dc109a2acaec0a80759 Date: Tue Aug 5 16:11:21 2014 +0000 Related: #i125349# moved clip enhancements to base clipping functionality The "reversed" clipPolyPolygonOnRange path is the problem apparently. The case in #i125349# uses the other clipPolyPolygonOnRange path. So for simplicity just remove the branch that's causing trouble here. Change-Id: Ia4c60ebc44a8c239c1a7d5c84e9b970c2885ff05
* tdf#82214 optimize performance for primitivesArmin Le Grand2016-07-071-0/+8
| | | | | | | | | | | | See svg bug doc, which is processed quite slowly. Beyond needing faster renderers, there is also demand to improve the handling of primitives created by SVG import. Conflicts: drawinglayer/source/primitive2d/patternfillprimitive2d.cxx vcl/win/gdi/gdiimpl.cxx Change-Id: I10992a5746b8b2d6b50e3ee3fe415a035685c9ba
* tdf#50613 speedup fat line drawing on linux using cairoArmin Le Grand2016-07-071-0/+61
| | | | | | | | | | | | | | Drawing fat lines is slow on linux due to X11 having no direct support for it. This leads to creating the PolyPolygon geometry for each fat line, then tesselate and draw as trapezoids. This is not buffered in any way and is done at each paint. As a side effect, fat lines composed of multiple anti-aliased lines also show errors since AA-ed edges do not add up graphically. Since we have cairo now available it makes sense to use it for fat line drawing, it is markedly faster despite being a software renderer. No such gains for PolyPolygons though. Change-Id: If4001556e2dd4c15ecf2587cad6ce1e864558f2d
* "it is working properly", not "it is working property"Christian Lohmaier2016-07-041-1/+1
| | | | Change-Id: Ief34f2e110060dc9d6200e8533c64b1e12bfb37b
* Fix some spelling errors in comments and stringsOtto Kekäläinen2016-07-042-4/+4
| | | | | | | Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e Reviewed-on: https://gerrit.libreoffice.org/26883 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko2016-06-091-4/+1
| | | | | | | | | | | | | | | | | | | | This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* loplugin:constantparamsNoel Grandin2016-06-032-3/+3
| | | | | | | Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361 Reviewed-on: https://gerrit.libreoffice.org/25769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#99130 use subdivision on B2DPolygon, angle based subdivisionTomaž Vajngerl2016-05-172-30/+1
| | | | | | | | | | | | | | Remove the subdivider we used until now as there is a better way to subdivide a polygon with getDefaultAdaptiveSubdivision, which in additiona also caches the result. The subdivider used in getDefaultAdaptiveSubdivision was a limited count based subdivider so this exchanges that with an angle based one which gives much better results. Change-Id: I95c009ccf3d54305df0d8eef177cab0df0a23bea Reviewed-on: https://gerrit.libreoffice.org/25033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann2016-05-102-10/+9
| | | | | | | | | | | | | | | | ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
* basegfx,oox,slideshow: replace boost::next/prior with std::next/prevMichael Stahl2016-05-062-3/+2
| | | | Change-Id: I38fde54d0fdbb9c61e3df004242a70e14429f52f
* Fix typosAndrea Gelmini2016-05-021-1/+1
| | | | | | | Change-Id: I38b5e720af67d0bfb1be72ff82a7f5c595a94c14 Reviewed-on: https://gerrit.libreoffice.org/24535 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
* update loplugin stylepolice to check local pointers varsNoel Grandin2016-04-261-2/+2
| | | | | | | | | | | | are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy modernize-loop-convert in b*Noel Grandin2016-04-215-10/+8
| | | | Change-Id: I8ac6eb59e213eafa78e3dc4578738b53e8adef5b
* clang-tidy performance-unnecessary-copy-initializationNoel Grandin2016-04-181-1/+1
| | | | | | | | | | | probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy performance-unnecessary-value-param in variousNoel Grandin2016-04-144-7/+7
| | | | | | | Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:passstuffbyref in basegfxNoel Grandin2016-04-131-1/+1
| | | | Change-Id: Ia7fc22152af2facf3134d9e0975cfb9608b2e931
* tdf#96505 Remove 0L occurences from avmedia and basegfx modulesslideon2016-03-3114-166/+166
| | | | | | | | | No compiler warnings on my machine Change-Id: Ibd303c64f04f6f52272ac19c3069da2f14cb4e9a Reviewed-on: https://gerrit.libreoffice.org/23558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* loplugin:nullptr: Find some more cases in templatesStephan Bergmann2016-03-301-1/+1
| | | | Change-Id: I1f127d56e40b04f2b4df85c0afbcfd424d68a8cc
* loplugin:nullptrStephan Bergmann2016-03-301-4/+4
| | | | Change-Id: I7f6d030317fc7910e69c742b3160b0156e9f9200
* Avoid reserved identifiersStephan Bergmann2016-03-101-4/+4
| | | | Change-Id: I036cb407c29ee375e1893b7418c7fa63bf1d592a
* tdf#97703 Removed empty setUp/tearDown methodsChirag Manwani2016-03-083-15/+0
| | | | | | | Change-Id: Ia62de30ae94bdae87cd5109c44eab40af4d020e5 Reviewed-on: https://gerrit.libreoffice.org/22985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:unuseddefaultparams variousNoel Grandin2016-03-031-3/+2
| | | | | | | Change-Id: Ibf8489c957b307156689de4c7cb8440ddd4e4546 Reviewed-on: https://gerrit.libreoffice.org/22852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* opengl: shader based polyline rendering - fixes tdf#97137 for OGLTomaž Vajngerl2016-02-251-0/+29
| | | | | | | | | Adds native opengl polyline rendering to draw polylines, line joins and line caps as triangle strips. The vertex shader allows for the dynamic line width by calculating the correct vertex posiitons, and the fragment shader is used for anti-aliasing. Change-Id: If7982c828cae1fae59c57194c8ac77e5ad7f1d26
* tdf#97703 Removed a few redundant calls to setUp and tearDownJaskaran2016-02-193-47/+0
| | | | | | | | | | Calls to CppUnit::TextFixture::setUp and CppUnit::TextFixture::tearDown have been removed. I hope that saves a few milliseconds of build time :) Change-Id: I611db2f5c5673ab86bf8f92beb4f6e8a70443b34 Reviewed-on: https://gerrit.libreoffice.org/22496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* crashtesting: crash on loading moz414782-1.svgCaolán McNamara2016-02-091-1/+1
| | | | Change-Id: I1324b902c0790350bc8c44e7d63ce45915e3b33f
* Fix typosAndrea Gelmini2016-02-055-7/+7
| | | | | | | Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>