summaryrefslogtreecommitdiffstats
path: root/basctl
Commit message (Collapse)AuthorAgeFilesLines
* fdo#46037: remove unused comphelper/configurationhelper.hxxAlexandre Vicenzi2014-07-291-1/+0
| | | | | | | Change-Id: I66f9d2912202ba1393d0c65189f8a945bca4fcaa Reviewed-on: https://gerrit.libreoffice.org/10603 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Drop unused #includesTakeshi Abe2014-07-242-2/+0
| | | | Change-Id: I77ca957204bacee95e32a7f2a54c9311002aeef9
* Resolves fdo#80906: Delete any control on Dialog editing window crashes LOJulien Nabet2014-07-211-1/+1
| | | | | | | | | | | | | | | | | | | | | Quick fix for this bt: 3 0x00002aaaab2935d2 in __GI___assert_fail (assertion=0x2aaae1f2806a "_pInterface != 0", file=0x2aaae1f28018 "/home/julien/compile-libreoffice/libreoffice/include/com/sun/star/uno/Reference.h", line=402, function=0x2aaae1f28480 <com::sun::star::uno::Reference<com::sun::star::resource::XStringResourceManager>::operator->() const::__PRETTY_FUNCTION__> "interface_type* com::sun::star::uno::Reference< <template-parameter-1-1> >::operator->() const [with interface_type = com::sun::star::resource::XStringResourceManager]") at assert.c:101 4 0x00002aaae1e2963b in com::sun::star::uno::Reference<com::sun::star::resource::XStringResourceManager>::operator-> (this=0x7fffffff2d00) at /home/julien/compile-libreoffice/libreoffice/include/com/sun/star/uno/Reference.h:402 5 0x00002aaae1eb5c87 in basctl::LocalizationMgr::implHandleControlResourceProperties (aControlAny= uno::Any {<com::sun::star::uno::XInterface> = {_vptr.XInterface = 0x8935ea8}, <No data fields>}, aDialogName="Dialog1", aCtrlName="TextField1", xStringResourceManager=empty uno::Reference, xSourceStringResolver=empty uno::Reference, eMode=basctl::LocalizationMgr::REMOVE_IDS_FROM_RESOURCE) at /home/julien/compile-libreoffice/libreoffice/basctl/source/basicide/localizationmgr.cxx:202 6 0x00002aaae1eb92a0 in basctl::LocalizationMgr::deleteControlResourceIDsForDeletedEditorObject (pEditor=0x919d820, aControlAny= uno::Any {<com::sun::star::uno::XInterface> = {_vptr.XInterface = 0x8935ea8}, <No data fields>}, aCtrlName="TextField1") at /home/julien/compile-libreoffice/libreoffice/basctl/source/basicide/localizationmgr.cxx:896 Indeed, LocalizationMgr::setControlResourceIDsForNewEditorObject just returns if !xStringResourceManager.is() So let's do the same when trying to delete ControlResources See http://opengrok.libreoffice.org/xref/core/basctl/source/basicide/localizationmgr.cxx#835 Change-Id: I4be49503cd2464f97a25840dfdc29877e5fb2b93
* Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert2014-07-172-2/+2
| | | | | | | | | | - Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: https://gerrit.libreoffice.org/10342 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
* new loplugin: externalandnotdefinedNoel Grandin2014-07-114-8/+5
| | | | | | | | Find "missing headers," where a function is declared directly in the .cxx (as extern) and not defined, and should arguably instead be declared in an include file. Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
* use assert when followed by derefCaolán McNamara2014-07-031-1/+1
| | | | Change-Id: I8405e4d8f9fa1de3ef6ee474321b4ac2b4ce1624
* clang scan-build: various warningsCaolán McNamara2014-07-011-1/+1
| | | | Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
* remove SFX_APP() macro that was a mer wrapper for SfxGetApp()Norbert Thiebaud2014-06-277-19/+19
| | | | Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
* loplugin:unreffun: also warn about redundant redeclarationsStephan Bergmann2014-06-271-2/+0
| | | | Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
* fdo#76203 - use consistent titlecase for UI title labelsJoren De Cuyper2014-06-231-4/+4
| | | | | | | Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9 Reviewed-on: https://gerrit.libreoffice.org/9858 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* improve the inlinesimplememberfunctions clang pluginNoel Grandin2014-06-174-10/+2
| | | | Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
* loplugin:staticcallStephan Bergmann2014-06-133-7/+7
| | | | Change-Id: Ida2e09b88c9df0d70c8298020d768e6386714edd
* coverity#1213488 Uncaught exceptionCaolán McNamara2014-06-131-8/+14
| | | | Change-Id: Iee4e5dd2936979a9bcb8bd5db781e51551270a7f
* loplugin: inlinesimplememberfunctionsNoel Grandin2014-06-096-15/+3
| | | | Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
* various: remove SAL_THROW macroNoel Grandin2014-06-052-6/+2
| | | | Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
* Avoid possible memory leaks in case of exceptionsTakeshi Abe2014-05-312-7/+8
| | | | Change-Id: I1988d2766d8bdeb5f8a22a5673dcff9b898dd637
* update_pchThomas Arnhold2014-05-281-0/+1
| | | | Change-Id: I5316693452427ed76a7738b090de023b110caa40
* css already means ::com::sun::starThomas Arnhold2014-05-271-3/+3
| | | | Change-Id: I48d7b746d7cc49246743c62480b0d225d2519342
* remove boilerplate in UNO Exception constructor callsNoel Grandin2014-05-231-1/+1
| | | | | | | Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
* Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19Julien Nabet2014-05-221-1/+1
| | | | Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
* bnc#467278: Introduce a warning that changes to VBA macros cannot be saved.Jan Holesovsky2014-05-223-1/+14
| | | | | | As an InfoBar, so hopefully not annoying... Change-Id: I5d4e79273edc03829fdab2d6d5a291576c954e4b
* hrc and src files: squeeze multiple newlinesThomas Arnhold2014-05-192-5/+0
| | | | | | for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
* Resolves: #i76558# jump by Enter key on the Object catalogTsutomu Uchino2014-05-192-22/+39
| | | | | | | | | | (cherry picked from commit 7bc75c1a7b05d81631ebccf05bf022636d1a3a14) Conflicts: basctl/source/basicide/objdlg.cxx basctl/source/basicide/objdlg.hxx Change-Id: Id3fa3686fd60df192c02cc8137c9bc59e68c1d49
* remove legacy svheader.hxxThomas Arnhold2014-05-159-68/+0
| | | | | | none of the corresponding headers is included... Change-Id: I85061dc159ace0fd727e3d32e52b14c123690584
* Find places where uno::Sequence is passed by value.Noel Grandin2014-05-143-7/+7
| | | | | | | | | | Implement a clang plugin to find them, and clean up existing code to pass them by reference. Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8 Reviewed-on: https://gerrit.libreoffice.org/9351 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* '!= false' is redundant, and confusing - kill it.Jan Holesovsky2014-05-091-3/+3
| | | | Change-Id: I1a52b9ce7b590e8cf274a2daaa1c55cfc1efe48b
* update_pch: add a bunch of pch filesThomas Arnhold2014-05-093-0/+250
| | | | | | | | | | | | | | | | | | | | | | | | I had to fix some source files because of macro redefinitions and such stuff. Small modules like basic have a great win, too: make basic.clean && time make basic: with w/o pch pch accessibility 23s 1m59s basctl 30s 1m42s basic 56s 1m35s comphelper 23s 51s editeng 48s 2m04s forms 40s 1m40s unotools 19s 38s sd 3m37s 4m33s Change-Id: Id24cdcddbe2ff64820b42266325c25af1355558f Reviewed-on: https://gerrit.libreoffice.org/9293 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
* coverity#1209811 Dereference before null checkCaolán McNamara2014-05-091-1/+1
| | | | Change-Id: I7e3778e5203438bc5db942c813a03896d7df895b
* coverity#1209554 Explicit null dereferencedCaolán McNamara2014-05-071-2/+1
| | | | Change-Id: Iacf4373221b93a97e030b09501cc91589f2fdff7
* simplify ternary conditions "xxx ? yyy : false"Noel Grandin2014-05-051-1/+1
| | | | | | | | | Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
* Improve TabBar return typesNoel Grandin2014-04-282-2/+2
| | | | | | | | | | | | DeactivatePage() goes from returning long to returning bool. StartRenaming goes from returning long to returning bool. AllowRenaming goes from returning long to returning a constant from a new enum. Change-Id: Ib87e8d7ceb4e23846547257b358ca4dfd41eb6ca Reviewed-on: https://gerrit.libreoffice.org/9161 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* coverity#736993 Uncaught exceptionCaolán McNamara2014-04-252-2/+2
| | | | Change-Id: Ib8e5d13da0e26f67da16edf0eb55341208ec2337
* coverity#736992 Uncaught exceptionCaolán McNamara2014-04-252-2/+2
| | | | Change-Id: Ia074dc867cc068fccb2d4eb613d04b945b8711e7
* coverity#736990 Uncaught exceptionCaolán McNamara2014-04-252-2/+2
| | | | Change-Id: I3b7f4c732a5a3369c05c75ede1580b32837be671
* basic macro dialog: let it expand vertically, tooThomas Arnhold2014-04-241-0/+6
| | | | | | it already expands horizontally, however hexpand is not set... Change-Id: I8e0bfb9dfc841c66eeb2d14f5f73a997b6862cb5
* fdo#77886: add language: expand list if dialog gets resizedThomas Arnhold2014-04-241-0/+2
| | | | | | Yes, I actually figured out how to do that ;) Change-Id: I9c62f57bbd07f44c9bf94a308a49df8c82eb2097
* manage breakpoints: expand list if dialog gets resizedThomas Arnhold2014-04-241-1/+8
| | | | Change-Id: I818a19a0a95991c97be539761d1f75e247880256
* huge hrc and src file cleanupThomas Arnhold2014-04-232-23/+0
| | | | | | | | | | | * mostly fallout from ui conversion * some completely unused defines from src files * lots of unused HID ids Change-Id: I976561205798db3d06ee139de6223f638e58f47a Reviewed-on: https://gerrit.libreoffice.org/9142 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
* fixincludeguards.sh: basctlThomas Arnhold2014-04-1946-138/+138
|
* sfx2: Move InitInterface_Impl() out of SFX_DECL_INTERFACE too.Jan Holesovsky2014-04-182-0/+11
| | | | Change-Id: Ib737e0d1b5888986b308aa60d4140f65e4e90243
* sfx2: Move InitInterface_Impl() method out of SFX_IMPL_INTERFACE.Jan Holesovsky2014-04-182-3/+5
| | | | | | | | | SFX_IMPL_INTERFACE previously looked like a function; where in fact it is several methods defined at once, and only the last one has a body. This is extremely confusing and hard to read; let's kill that nonsense. Change-Id: Ia4ae22eb58b1260c9c827c894f5345693bad49e7
* sfx2: Kill SFX_STATUSBAR_REGISTRATION macro.Jan Holesovsky2014-04-181-1/+1
| | | | Change-Id: Iff0ffdb955892117a767e1f31c1f854a93feb560
* sfx2: Kill SFX_FEATURED_CHILDWINDOW_REGISTRATION macro.Jan Holesovsky2014-04-181-1/+1
| | | | Change-Id: I9bf1c2404eeb6c59525061157e91b8777f2da540
* sfx2: Kill SFX_CHILDWINDOW_REGISTRATION macro.Jan Holesovsky2014-04-181-3/+2
| | | | Change-Id: Icd56e0cee1ce0283e8a1cbaafc81ecca25469185
* sfx2: Kill SFX_POPUPMENU_REGISTRATION macro.Jan Holesovsky2014-04-181-1/+2
| | | | Change-Id: Ie68ccbe5874ec7c7e1bb73cb2937e06bb4910cd0
* no temporary instance of SvtLanguageTable necessary hereEike Rathke2014-04-171-2/+1
| | | | Change-Id: I3172e4d174a7f632a4259bd7330b41d3f065daed
* no temporary instance of SvtLanguageTable necessary hereEike Rathke2014-04-171-2/+1
| | | | Change-Id: Iabb3aadf35eb6b3575d916f2400f606264572537
* basctl: sal_Bool->boolNoel Grandin2014-04-154-4/+4
| | | | Change-Id: I85e1e94557a238f629151d9ce46a502efed3696d
* use TriState instead of sal_Bool as there's three possibilitiesCaolán McNamara2014-04-082-13/+7
| | | | Change-Id: If24d4cec9ef4369f20419fe70de7392614a35316
* Explicitly mark overriding destructors as "virtual"Stephan Bergmann2014-04-0116-30/+30
| | | | | | | | It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
generated by cgit (git 2.34.1) at 2024-07-04 18:37:09 +0000