summaryrefslogtreecommitdiffstats
path: root/basctl
Commit message (Collapse)AuthorAgeFilesLines
* cppcheck:redundantAssignmentNoel Grandin2015-06-151-4/+1
| | | | Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
* cppcheck:redundantConditionNoel Grandin2015-06-151-1/+1
| | | | Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
* cppcheck: redundantCondition [part1]Julien Nabet2015-06-142-3/+3
| | | | Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
* convert expressions like 'size() == 0' to 'empty()'Noel Grandin2015-06-111-3/+3
| | | | Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
* coverity#1302618 deref of NULLCaolán McNamara2015-06-101-5/+5
| | | | | | | | | | | | | | | | | | | on examination this PreparePaint virtual is only called from SvTreeListBox::PaintEntry1 and PaintEntry1 is only called from SvImpLBox::Paint in a for(sal_uInt16 n=0; n< nCount && pEntry; n++) { /*long nMaxRight=*/ pView->PaintEntry1 loop so pEntry always exists given that test. Re-jig things so these families of method take a reference instead of a pointer so verifying it cannot be NULL and a whole pile of else paths fall away Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
* loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2015-06-085-8/+8
| | | | Change-Id: I6ea774c635335106a7a8ddc4214c20bdf3f021ba
* Apply new VclPtr clang plugin to catch potential problems.Noel Grandin2015-06-061-1/+1
| | | | | | | | | | Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* Resolves: tdf#90361 CellValueBinding/CellRangeListSource need WithArgumentsCaolán McNamara2015-06-051-2/+17
| | | | | | | | otherwise they are not initialized and every call on them throws. This at least results in the dialog editor not falling over immediately on inserting anything in calc. Change-Id: Ie1668ef440937c75dd08671c669c021c2efecd2a
* uno::Sequence provides now begin and endNoel Grandin2015-06-041-1/+1
| | | | | | | | | | | | use begin() and end() when calling std::copy on an uno::Sequence Inspired by commit b34b648fc3262c5d9aa295f621e8fe9c97d4c6b2 "uno::Sequence provides now begin and end" Change-Id: I08e8c3fd6144e77b95a26f85bc0daf6a9edeeb0b Reviewed-on: https://gerrit.libreoffice.org/16057 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann2015-06-021-1/+1
| | | | Change-Id: I625929f9cfa3a2d403d0a4652e57c2bb7a998fa6
* tdf#91702 - fix stack-based MessBox allocation.Michael Meeks2015-05-293-5/+5
| | | | | | | Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* tdf#91484 fix macro editor - Invalidate in paintTomaž Vajngerl2015-05-292-1/+25
| | | | Change-Id: I787da9a665e54caea229def185076b29c00fd11e
* loplugin:loopvartoosmallNoel Grandin2015-05-297-14/+14
| | | | Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
* Rewrite all calls like Dialog(params).Execute()Philippe Jung2015-05-287-27/+27
| | | | | | | | | | | | | Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* tdf#91575 - CRASH: when "My Macros & Dialogs Standard" window closeNoel Grandin2015-05-262-4/+6
| | | | Change-Id: Iad4f67e78a0aa4c67f0c450e17278f873944aa23
* convert SCROLL constants to scoped enumNoel Grandin2015-05-261-1/+1
| | | | Change-Id: I5696fa39b2d032735cea7abe039349d4f83cf68d
* convert POINTER constants to scoped enumNoel Grandin2015-05-221-1/+1
| | | | | | | Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* coverity#1298898 coverity seems a little confused hereCaolán McNamara2015-05-201-1/+1
| | | | Change-Id: Ibc80e242b8fda8fb304ed5cd1a52716d1b7fc33d
* convert DEFAULTCONSTANT constant to scoped enumNoel Grandin2015-05-201-1/+1
| | | | Change-Id: I5ebd77edfa29d6c6c7acea37e826ef1d625916c3
* convert TEXT_DRAW constants to scoped enumNoel Grandin2015-05-201-1/+1
| | | | Change-Id: Ic0f7f8fa236bb478b3598ae3fd3c1b30ebbf1a01
* basic: used typed LINKsNoel Grandin2015-05-192-3/+3
| | | | Change-Id: I8770a782e7ff5529e30aee13558711bdd8a4070d
* cppunit: noExplicitConstructorCaolán McNamara2015-05-189-21/+44
| | | | Change-Id: Iaf1387ea236bf3a5db9b2165d5b827dbdcf95207
* basctl: Use typed LinksNoel Grandin2015-05-185-15/+11
| | | | | Change-Id: I0e0b6086852c06df88e1b623d4631f364eb28b09 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* callcatcher: update unused codeCaolán McNamara2015-05-182-24/+0
| | | | Change-Id: I43dd399368953c629916dad8104a296f837a6344
* refactor how font, fg. and bg. are applied in widgets/controlsTomaž Vajngerl2015-05-182-2/+3
| | | | | | | | | | | | | - Move vcl::RenderContext to outdev. - Change some methods on vcl::Window to accept RenderContext as parameter. - Add ApplySettings to vcl::Window - This method is called before painting. Refactor existing classes that use InitSettings to have ApplySettings or mark the classes to be refactored later. - Add RenderSettings for adding defered settings to rendering. This is similar to ApplySettings but for more ad-hoc calls. Change-Id: I4ea58461f3b6b08ccfa3e0ddd1a4a3e04f8c4f45
* tdf#91239 - return VclPtr's from Create Fn.s and add missing dispose logic.Michael Meeks2015-05-158-24/+36
| | | | Change-Id: I802b841040f608b5586704745cc9817603fb1879
* tdf#91239 - add missing disposeAndClear logic for basctl.Julien Nabet2015-05-151-0/+6
| | | | Change-Id: If5c8fbf453e47921b472a987e9e6cff283464dcf
* tdf#62475: partial handmade fixesAndrea Gelmini2015-05-156-29/+0
| | | | | | | Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4 Reviewed-on: https://gerrit.libreoffice.org/15712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* cppcheck: noExplicitConstructorCaolán McNamara2015-05-143-10/+10
| | | | Change-Id: I42d135456c7f9ce8bbd77db553be96149e4e75af
* convert QUICKHELP constants to scoped enumNoel Grandin2015-05-141-1/+1
| | | | Change-Id: Ie7302c909feb2e83b8b5e62a5e6a1f901783fb49
* refactor "basctl" classes to use RenderContextTomaž Vajngerl2015-05-149-239/+155
| | | | Change-Id: I6eb54af9f793c614c823123c6f16a3dc4f3a0c0b
* Switch VclBuilder constructors to use VclPtr.Michael Meeks2015-05-123-5/+3
| | | | Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
* Revert "Switch VclBuilder constructors to use VclPtr."Michael Meeks2015-05-113-3/+5
| | | | | | | | Behaves oddly; not ready yet. This reverts commit 9f016bd69422bdfb4cf7c4f5e57356eb98db2d8c. Change-Id: I30d746eac29d1dbe78d3072b10d2e22c051e3f4e
* Switch VclBuilder constructors to use VclPtr.Michael Meeks2015-05-113-5/+3
| | | | Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
* convert COMMAND_ constants to scoped enumNoel Grandin2015-05-113-10/+10
| | | | | | | Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95 Reviewed-on: https://gerrit.libreoffice.org/15671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann2015-05-111-1/+1
| | | | Change-Id: I13f6c41a9918363d1b91d64ab2b8c331d007561a
* refactor TreeListBox to use RenderContextTomaž Vajngerl2015-05-111-16/+11
| | | | Change-Id: I901a1f1f9732fb66718dca34c698a851e5b0d87f
* NOINSTANCE is implied now in IMPL_STATIC_LINK...Stephan Bergmann2015-05-103-3/+3
| | | | Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
* Replace IMPL_STATIC_LINK[_TYPED] with more useful variantsStephan Bergmann2015-05-101-2/+1
| | | | Change-Id: Ic59c2c9079dce37ad76b6a1396a719d372253674
* tdf#91052 - more macros for 'make' constructors.Michael Meeks2015-05-093-3/+6
| | | | Change-Id: Id05266810760f73db2daba10d1efa14aa9f88dd9
* lopluign:staticmethods: Handle DECL_LINKStephan Bergmann2015-05-084-4/+5
| | | | Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
* convert BUTTONDIALOG constants to scoped enumNoel Grandin2015-05-071-7/+7
| | | | | | | Change-Id: Icbf73fe55ad604f762dd2b98fd39189bab82f061 Reviewed-on: https://gerrit.libreoffice.org/15648 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Remove unnecessary includes of sot/storage.hxx from include/Stephan Bergmann2015-05-071-0/+1
| | | | Change-Id: I242cd126814bbebdb99ea38d9e66513189c313d9
* refactor "TextEdit" & co. to use RenderContextTomaž Vajngerl2015-05-071-3/+3
| | | | Change-Id: Ib26ecb9640d23714acec73304f26e2fd6af90ed4
* convert DEFAULTFONT_ constants to scoped enumNoel Grandin2015-05-061-1/+1
| | | | Change-Id: Ia33e957f6cf530e2639b3c86d9482f642652cb46
* Use typed Idle::SetIdleHdl LinkStephan Bergmann2015-05-054-7/+4
| | | | Change-Id: I189937950325dc4ef663f7f49cb45f38f8537de9
* Use typed Timer::SetTimeoutHdl LinkStephan Bergmann2015-05-052-3/+2
| | | | Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
* Gradually typed LinkStephan Bergmann2015-04-303-9/+9
| | | | | | | | | | | | | | | | | Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
* coverity#1296211 pCurWin == pNewWin at this pointCaolán McNamara2015-04-291-1/+1
| | | | | | | | should silence coverity#1296211 Explicit null dereferenced Change-Id: I0798db1b88bfec94139995db552029b18a9562af
* Remove unnecessary IMPL_LINK[_NOARG]_INLINE_START/ENDStephan Bergmann2015-04-297-35/+12
| | | | | | ...just use IMPL_LINK[_NOARG] and let the compiler decide what to inline Change-Id: I63ec5116df7e79093ebf31193f8c674f1351c0e6
generated by cgit (git 2.34.1) at 2024-08-11 05:57:30 +0000